Re: [Django] #21051: Move cookie settings from standalone values to dictionaries

[Django]

#21051: Move cookie settings from standalone values to dictionaries
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Core (Other) |   Resolution:  wontfix
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  cookie cookis csrf   |  Needs documentation:  0
  sesssion language  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by ramiro):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 The described limitations seem unlikely fixable with urrent implementation
 of settings infrastructure. Closing for now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c95ba8b9b26b015bf62de5fb7dd92a5d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21051: Move cookie settings from standalone values to dictionaries

[Django]

#21051: Move cookie settings from standalone values to dictionaries
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Core (Other) |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  cookie cookis csrf   |  Needs documentation:  0
  sesssion language  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 After discussion with Ramiro on IRC, we're not sure if we should move
 forward with this. Using a dictionary has the problem that default
 settings from `django/conf/global_settings.py` would be lost if only
 overriding part of the `SESSION_COOKIE` dictionary. I proposed the
 possibility of adding a shim to the settings setter to merge the two
 dictionaries, but I'm not sure if this is feasible or worth it.

 Marking as "patch needs improvement", but leaving it up to Ramiro as to
 whether we should move forward or won't fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cf75cc9729df6ebc612313eb1b76a6f8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21051: Move cookie settings from standalone values to dictionaries

[Django]

#21051: Move cookie settings from standalone values to dictionaries
-+-
 Reporter:  ramiro   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Core (Other) |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  cookie cookis csrf   |  Needs documentation:  0
  sesssion language  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.87b1ca5a1e4e7ed3518e27b6a3db5494%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21051: Move cookie settings from standalone values to dictionaries

[Django]

#21051: Move cookie settings from standalone values to dictionaries
-+-
   Reporter:  ramiro |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |Version:  master
  Component:  Core   |   Keywords:  cookie cookis csrf
  (Other)|  sesssion language
   Severity:  Normal |  Has patch:  1
   Triage Stage: |Needs tests:  0
  Unreviewed |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
 This could help with #15318 and other efforts to expand configurability of
 existing cookie-related settings.

 See https://github.com/django/django/pull/1554 for the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.e7490f819dc4b22891b73c3c8bc4c33a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.