Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by mjtamlyn):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I can confirm that in python3.4 rc3 there are no test failures. There are
 still warnings from the deprecation of the `imp` module, but that is
 tracked in #21628.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a5c3b59de4c6be18951a0a990f4bf05b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by mkai):

 * cc: django@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3d78b3c47c49f782bbe18ec71b2e7ce8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by berkerpeksag):

 * cc: berker.peksag@… (added)


Comment:

 > django.utils.module_loading. module_has_submodule has some issues with
 eggs. sys.meta_path is giving us importlib as a finder.
 importlib.find_module is deferred to importlib.find_spec (new in py3.4),
 which throws an error (ImportError: spec missing loader).

 I didn't get any test failures with the current default branch of CPython
 3.4. Probably related to http://bugs.python.org/issue20763.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3c80a4e6e82052a2d71f298484440d5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Description changed by mjtamlyn:

Old description:

> Python 3.4 support should be added in master ready for 1.7, and probably
> also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
> bundled pip and venv, and is a prime target for new python developers and
> those running classes, it is very important for Django to support it.
>
> I've run the test suite (on sqlite) against 1.6.X and master. A test run
> on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542
>
> The current state of things is as follows:
>
> - ~~There are a couple of warnings printed at startup time. These relate
> to API changes in plistlib (which is OSX specific) and codecs (universal
> newlines reading of files has been deprecated).~~
> - ~~Our usage of `HTMLParser` should now always specify the value of
> `convert_charrefs` as it's default will change in Py3.5. This is slightly
> problematic as Py2.7 does not have this kwarg so we can't universally
> apply it. Perhaps the best option is a six-like wrapper.~~
> - `django.utils.module_loading. module_has_submodule` has some issues
> with eggs.  `sys.meta_path` is giving us `importlib` as a finder.
> `importlib.find_module` is deferred to `importlib.find_spec` (new in
> py3.4), which throws an error (`ImportError: spec missing loader`).
> - ~~There is a failing test in the mail library regarding encoding in the
> mail module. Florian seemed to know about this.~~
> - ~~There is a significant issue with signal deregistration. I've been
> able to ascertain that something is up in the `django.dispatch.saferef`
> module, but I don't have a sufficient understanding to work out what's
> wrong. There seems to be no test which tests this code directly and
> failures are thrown up at random during tests, test teardown and/or test
> suite teardown. They show up either as `NoneType is not callable` or as
> `catching classes that do not inherit from BaseException is not
> allowed`.~~
> - `U` mode has been deprecated for files. We use it in `makemessages` and
> in `sql`, both for management commands. It seems unnecessary in
> `makemessages`, in the `sql` we will have to be more careful as at
> present we split on `\n`, which may need to be `\r\n` on windows.
> However, it may well be fine anyway it probably doesn't matter if we have
> trailing `\r` characters on the sql statements.
> - There are quite a lot of `ResourceWarning`s thrown for unclosed files
> ~~(and sockets in the mail tests)~~

New description:

 Python 3.4 support should be added in master ready for 1.7, and probably
 also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
 bundled pip and venv, and is a prime target for new python developers and
 those running classes, it is very important for Django to support it.

 I've run the test suite (on sqlite) against 1.6.X and master. A test run
 on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542

 The current state of things is as follows:

 - ~~There are a couple of warnings printed at startup time. These relate
 to API changes in plistlib (which is OSX specific) and codecs (universal
 newlines reading of files has been deprecated).~~
 - ~~Our usage of `HTMLParser` should now always specify the value of
 `convert_charrefs` as it's default will change in Py3.5. This is slightly
 problematic as Py2.7 does not have this kwarg so we can't universally
 apply it. Perhaps the best option is a six-like wrapper.~~
 - `django.utils.module_loading. module_has_submodule` has some issues with
 eggs.  `sys.meta_path` is giving us `importlib` as a finder.
 `importlib.find_module` is deferred to `importlib.find_spec` (new in
 py3.4), which throws an error (`ImportError: spec missing loader`).
 - ~~There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.~~
 - ~~There is a significant issue with signal deregistration. I've been
 able to ascertain that something is up in the `django.dispatch.saferef`
 module, but I don't have a sufficient understanding to work out what's
 wrong. There seems to be no test which tests this code directly and
 failures are thrown up at random during tests, test teardown and/or test
 suite teardown. They show up either as `NoneType is not callable` or as
 `catching classes 

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by mjtamlyn):

 This approach turned out not be necessary. See comment 17. Python 3.4
 caught a bug for us!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.dde7cec677f62a7312eae9cbdebb40c1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 @mjtamlyn: You can't just close the connection in
 https://github.com/mjtamlyn/django/compare/mail-connection-wrappers#diff-
 e1d718400701d0b0adfafbdcf8163aa3R284 -- if `EmailMessage` was constructed
 with a valid connection it should stay open…

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.693ccc131bc10033eb0788bcdcd9f30a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Old description:

> Python 3.4 support should be added in master ready for 1.7, and probably
> also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
> bundled pip and venv, and is a prime target for new python developers and
> those running classes, it is very important for Django to support it.
>
> I've run the test suite (on sqlite) against 1.6.X and master. A test run
> on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542
>
> The current state of things is as follows:
>
> - There are a couple of warnings printed at startup time. These relate to
> API changes in plistlib (which is OSX specific) and codecs (universal
> newlines reading of files has been deprecated).
> - ~~Our usage of `HTMLParser` should now always specify the value of
> `convert_charrefs` as it's default will change in Py3.5. This is slightly
> problematic as Py2.7 does not have this kwarg so we can't universally
> apply it. Perhaps the best option is a six-like wrapper.~~
> - `django.utils.module_loading. module_has_submodule` has some issues
> with eggs.  `sys.meta_path` is giving us `importlib` as a finder.
> `importlib.find_module` is deferred to `importlib.find_spec` (new in
> py3.4), which throws an error (`ImportError: spec missing loader`).
> - ~~There is a failing test in the mail library regarding encoding in the
> mail module. Florian seemed to know about this.~~
> - ~~There is a significant issue with signal deregistration. I've been
> able to ascertain that something is up in the `django.dispatch.saferef`
> module, but I don't have a sufficient understanding to work out what's
> wrong. There seems to be no test which tests this code directly and
> failures are thrown up at random during tests, test teardown and/or test
> suite teardown. They show up either as `NoneType is not callable` or as
> `catching classes that do not inherit from BaseException is not
> allowed`.~~
> - `U` mode has been deprecated for files. We use it in `makemessages` and
> in `sql`, both for management commands. It seems unnecessary in
> `makemessages`, in the `sql` we will have to be more careful as at
> present we split on `\n`, which may need to be `\r\n` on windows.
> However, it may well be fine anyway it probably doesn't matter if we have
> trailing `\r` characters on the sql statements.
> - There are quite a lot of `ResourceWarning`s thrown for unclosed files
> ~~(and sockets in the mail tests)~~

New description:

 Python 3.4 support should be added in master ready for 1.7, and probably
 also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
 bundled pip and venv, and is a prime target for new python developers and
 those running classes, it is very important for Django to support it.

 I've run the test suite (on sqlite) against 1.6.X and master. A test run
 on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542

 The current state of things is as follows:

 - ~~There are a couple of warnings printed at startup time. These relate
 to API changes in plistlib (which is OSX specific) and codecs (universal
 newlines reading of files has been deprecated).~~
 - ~~Our usage of `HTMLParser` should now always specify the value of
 `convert_charrefs` as it's default will change in Py3.5. This is slightly
 problematic as Py2.7 does not have this kwarg so we can't universally
 apply it. Perhaps the best option is a six-like wrapper.~~
 - `django.utils.module_loading. module_has_submodule` has some issues with
 eggs.  `sys.meta_path` is giving us `importlib` as a finder.
 `importlib.find_module` is deferred to `importlib.find_spec` (new in
 py3.4), which throws an error (`ImportError: spec missing loader`).
 - ~~There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.~~
 - ~~There is a significant issue with signal deregistration. I've been
 able to ascertain that something is up in the `django.dispatch.saferef`
 module, but I don't have a sufficient understanding to work out what's
 wrong. There seems to be no test which tests this code directly and
 failures are thrown up at random during tests, test teardown and/or test
 suite teardown. They show up either as `NoneType is not callable` or as
 `catching classes that do not inherit from 

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Old description:

> Python 3.4 support should be added in master ready for 1.7, and probably
> also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
> bundled pip and venv, and is a prime target for new python developers and
> those running classes, it is very important for Django to support it.
>
> I've run the test suite (on sqlite) against 1.6.X and master. A test run
> on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542
>
> The current state of things is as follows:
>
> - There are a couple of warnings printed at startup time. These relate to
> API changes in plistlib (which is OSX specific) and codecs (universal
> newlines reading of files has been deprecated).
> - Our usage of `HTMLParser` should now always specify the value of
> `convert_charrefs` as it's default will change in Py3.5. This is slightly
> problematic as Py2.7 does not have this kwarg so we can't universally
> apply it. Perhaps the best option is a six-like wrapper.
> - `django.utils.module_loading. module_has_submodule` has some issues
> with eggs.  `sys.meta_path` is giving us `importlib` as a finder.
> `importlib.find_module` is deferred to `importlib.find_spec` (new in
> py3.4), which throws an error (`ImportError: spec missing loader`).
> - ~~There is a failing test in the mail library regarding encoding in the
> mail module. Florian seemed to know about this.~~
> - ~~There is a significant issue with signal deregistration. I've been
> able to ascertain that something is up in the `django.dispatch.saferef`
> module, but I don't have a sufficient understanding to work out what's
> wrong. There seems to be no test which tests this code directly and
> failures are thrown up at random during tests, test teardown and/or test
> suite teardown. They show up either as `NoneType is not callable` or as
> `catching classes that do not inherit from BaseException is not
> allowed`.~~
> - `U` mode has been deprecated for files. We use it in `makemessages` and
> in `sql`, both for management commands. It seems unnecessary in
> `makemessages`, in the `sql` we will have to be more careful as at
> present we split on `\n`, which may need to be `\r\n` on windows.
> However, it may well be fine anyway it probably doesn't matter if we have
> trailing `\r` characters on the sql statements.
> - There are quite a lot of `ResourceWarning`s thrown for unclosed files
> (and sockets in the mail tests)

New description:

 Python 3.4 support should be added in master ready for 1.7, and probably
 also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
 bundled pip and venv, and is a prime target for new python developers and
 those running classes, it is very important for Django to support it.

 I've run the test suite (on sqlite) against 1.6.X and master. A test run
 on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542

 The current state of things is as follows:

 - There are a couple of warnings printed at startup time. These relate to
 API changes in plistlib (which is OSX specific) and codecs (universal
 newlines reading of files has been deprecated).
 - ~~Our usage of `HTMLParser` should now always specify the value of
 `convert_charrefs` as it's default will change in Py3.5. This is slightly
 problematic as Py2.7 does not have this kwarg so we can't universally
 apply it. Perhaps the best option is a six-like wrapper.~~
 - `django.utils.module_loading. module_has_submodule` has some issues with
 eggs.  `sys.meta_path` is giving us `importlib` as a finder.
 `importlib.find_module` is deferred to `importlib.find_spec` (new in
 py3.4), which throws an error (`ImportError: spec missing loader`).
 - ~~There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.~~
 - ~~There is a significant issue with signal deregistration. I've been
 able to ascertain that something is up in the `django.dispatch.saferef`
 module, but I don't have a sufficient understanding to work out what's
 wrong. There seems to be no test which tests this code directly and
 failures are thrown up at random during tests, test teardown and/or test
 suite teardown. They show up either as `NoneType is not callable` or as
 `catching classes that do not inherit from BaseException is not
 

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by mjtamlyn):

 I've done a draft approach for suppressing the `ResourceWarning`s in
 `core.mail`. We can use `closing(get_connection())` in most cases in the
 tests and in `Message.send()`, but we use a custom context manager in the
 main utilities as we may already have a `connection` object. We do not
 want to close passed-in connections, that's the responsibility of whoever
 passed them in. Interestingly, the SMTP backend claims that just calling
 `send_messages` on it will close itself. It seems that on python 3.4 at
 least it does not.

 See diff at https://github.com/mjtamlyn/django/compare/mail-connection-
 wrappers. `auto_connection` is a rubbish name, but it is a utility only
 needed in this module.

 If we're happy with this approach, we should change the mail docs to
 recommend doing `with closing(get_connection())` where `get_connection()`
 is used, and add a note in the release notes that connections will now be
 closed. Ideally, I'd like to remove the implicit closing in
 `send_messages` in the SMTP backend. It seems weird, but also unreliable
 as the implementation does not close the connection should the message
 fail.

 In other news, I committed the `HTMLParser` fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.048dd9ad2ef7530ad497bdbcf9b7df0a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Old description:

> Python 3.4 support should be added in master ready for 1.7, and probably
> also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
> bundled pip and venv, and is a prime target for new python developers and
> those running classes, it is very important for Django to support it.
>
> I've run the test suite (on sqlite) against 1.6.X and master. A test run
> on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542
>
> The current state of things is as follows:
>
> - There are a couple of warnings printed at startup time. These relate to
> API changes in plistlib (which is OSX specific) and codecs (universal
> newlines reading of files has been deprecated).
> - Our usage of `HTMLParser` should now always specify the value of
> `convert_charrefs` as it's default will change in Py3.5. This is slightly
> problematic as Py2.7 does not have this kwarg so we can't universally
> apply it. Perhaps the best option is a six-like wrapper.
> - `django.utils.module_loading. module_has_submodule` has some issues
> with eggs.  `sys.meta_path` is giving us `importlib` as a finder.
> `importlib.find_module` is deferred to `importlib.find_spec` (new in
> py3.4), which throws an error (`ImportError: spec missing loader`).
> - There is a failing test in the mail library regarding encoding in the
> mail module. Florian seemed to know about this.
> - There is a significant issue with signal deregistration. I've been able
> to ascertain that something is up in the `django.dispatch.saferef`
> module, but I don't have a sufficient understanding to work out what's
> wrong. There seems to be no test which tests this code directly and
> failures are thrown up at random during tests, test teardown and/or test
> suite teardown. They show up either as `NoneType is not callable` or as
> `catching classes that do not inherit from BaseException is not allowed`.

New description:

 Python 3.4 support should be added in master ready for 1.7, and probably
 also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
 bundled pip and venv, and is a prime target for new python developers and
 those running classes, it is very important for Django to support it.

 I've run the test suite (on sqlite) against 1.6.X and master. A test run
 on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542

 The current state of things is as follows:

 - There are a couple of warnings printed at startup time. These relate to
 API changes in plistlib (which is OSX specific) and codecs (universal
 newlines reading of files has been deprecated).
 - Our usage of `HTMLParser` should now always specify the value of
 `convert_charrefs` as it's default will change in Py3.5. This is slightly
 problematic as Py2.7 does not have this kwarg so we can't universally
 apply it. Perhaps the best option is a six-like wrapper.
 - `django.utils.module_loading. module_has_submodule` has some issues with
 eggs.  `sys.meta_path` is giving us `importlib` as a finder.
 `importlib.find_module` is deferred to `importlib.find_spec` (new in
 py3.4), which throws an error (`ImportError: spec missing loader`).
 - ~~There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.~~
 - ~~There is a significant issue with signal deregistration. I've been
 able to ascertain that something is up in the `django.dispatch.saferef`
 module, but I don't have a sufficient understanding to work out what's
 wrong. There seems to be no test which tests this code directly and
 failures are thrown up at random during tests, test teardown and/or test
 suite teardown. They show up either as `NoneType is not callable` or as
 `catching classes that do not inherit from BaseException is not
 allowed`.~~
 - `U` mode has been deprecated for files. We use it in `makemessages` and
 in `sql`, both for management commands. It seems unnecessary in
 `makemessages`, in the `sql` we will have to be more careful as at present
 we split on `\n`, which may need to be `\r\n` on windows. However, it may
 well be fine anyway it probably doesn't matter if we have trailing `\r`
 characters on the sql statements.
 - There are quite a lot of `ResourceWarning`s thrown for unclosed files
 (and sockets in the mail tests)

--

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by akaariai):

 Any chance you can run djangobench for this? IIRC model_init_self_signals
 will benchmark signal sending.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e0b91951b279d5c5385d05dfbd3a65f0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 Latest version at https://github.com/apollo13/django/compare/signals

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cc2a7fc7f37e64402ed07049457dfb5d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 Ok, that failure was just an oversight; fixed in
 
https://github.com/apollo13/django/commit/8c43e774051494801be5ef576c6b0e5fb67ca60f

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d70d24824bfeb90b554b07ade6033d7f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anonymous):

 Oh, I just tested handlers+signals and had pyc files around :( Will rework
 my patch later on

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c0d7736c65a72c6e55c6ca3a65fd9773%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by mjtamlyn):

 I ran some tests with that commit. The good news is that python 3.4b2
 seems to be fine - the only failures now are the egg loading related
 failures and (obviously) the tests for saferef. There were no nasty
 warnings in interpreter shutdown. A number of other warnings have also
 disappeared, although not when you run with `-Wall`.

 The bad news is that python 2.7 doesn't work very well. Basically all the
 tests in `dispatch.tests` fail. https://gist.github.com/mjtamlyn/8304266.
 The same errors also happen on py3.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d4deeb1bb188ce0fb569a2049014943b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 And I got rid of saferef completely:
 
https://github.com/apollo13/django/commit/7a6c28977bf258b27c5bc2a19417f913c541e2dd
 -- Please test as much as possible :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.73e1766c2e6f6c5d3a70cc79ab494422%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 I've got it working:
 
https://github.com/apollo13/django/commit/b23ca8534534d2f1be029b567d9fe2e2bbcc85ef
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.04ca4748ca20ce5c6acb7a45c665f160%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 That patch is still pretty much unstable, there appear to be a few issues
 with `saferef` due to all the weakrefing :(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.803c1530fa5589a21ff5e877e75832ac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 The attached patch fixes the `None is not callable` issues, `TypeError:
 catching classes that do not inherit from BaseException is not allowed`
 still occurs with this variant.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c8c8840262bfe2bc1c324c65ac0ee0e6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by apollo13):

 Okay, my patch doesn't really work yet since it doesn't disconnect all
 receivers, gotta fix that *gg* http://bugs.python.org/issue19255 might
 allow us to use weakref's onDelete again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0c62c4bd986ff39cf0c1dfe63c07e730%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by apollo13):

 * cc: apollo13 (added)


Comment:

 Replying to [ticket:21721 mjtamlyn]:
 > - There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.
 Not an issue, just use an up2date 3.4 (beta 2 at least!).

 > - There is a significant issue with signal deregistration. I've been
 able to ascertain that something is up in the `django.dispatch.saferef`
 module, but I don't have a sufficient understanding to work out what's
 wrong. There seems to be no test which tests this code directly and
 failures are thrown up at random during tests, test teardown and/or test
 suite teardown. They show up either as `NoneType is not callable` or as
 `catching classes that do not inherit from BaseException is not allowed`.
 No, it has nothing to do with `saferef`, the main issue is that `weakref`
 und `onDelete` don't work properly on 3.4 during interpreter shutdown; to
 get this right you basically have to use `finalize`:
 https://dpaste.de/ZeyD (That patch needs a little bit of cleanup but is
 otherwise ready to go)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ca484de85bb5e6cd47810ebe5d1b7304%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c42c37011029e73cdc136ff2d3e1dc97%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+--
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by loic84):

 #21628 tracks the specific issue of the deprecation of the `imp` module.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e540fb67aa534814d9623dfb63f46875%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
-+--
 Reporter:  mjtamlyn |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by mjtamlyn):

 Loic pointed out on IRC a more significant issue with `module_loading` -
 which is that the code we use for acquiring a global import lock has also
 been deprecated. See
 http://docs.python.org/dev/library/imp.html#imp.acquire_lock

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ef7ed4e8552f6b3ced144de451a37eac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #21721: Python 3.4 support

[Django]

#21721: Python 3.4 support
---+
   Reporter:  mjtamlyn |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  Python 3 |Version:  master
   Severity:  Release blocker  |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Python 3.4 support should be added in master ready for 1.7, and probably
 also in 1.6.X as Py3.4 will be out before Django 1.7. As Py3.4 comes with
 bundled pip and venv, and is a prime target for new python developers and
 those running classes, it is very important for Django to support it.

 I've run the test suite (on sqlite) against 1.6.X and master. A test run
 on 1.6.X can be seen at https://gist.github.com/mjtamlyn/8195542

 The current state of things is as follows:

 - There are a couple of warnings printed at startup time. These relate to
 API changes in plistlib (which is OSX specific) and codecs (universal
 newlines reading of files has been deprecated).
 - Our usage of `HTMLParser` should now always specify the value of
 `convert_charrefs` as it's default will change in Py3.5. This is slightly
 problematic as Py2.7 does not have this kwarg so we can't universally
 apply it. Perhaps the best option is a six-like wrapper.
 - `django.utils.module_loading. module_has_submodule` has some issues with
 eggs.  `sys.meta_path` is giving us `importlib` as a finder.
 `importlib.find_module` is deferred to `importlib.find_spec` (new in
 py3.4), which throws an error (`ImportError: spec missing loader`).
 - There is a failing test in the mail library regarding encoding in the
 mail module. Florian seemed to know about this.
 - There is a significant issue with signal deregistration. I've been able
 to ascertain that something is up in the `django.dispatch.saferef` module,
 but I don't have a sufficient understanding to work out what's wrong.
 There seems to be no test which tests this code directly and failures are
 thrown up at random during tests, test teardown and/or test suite
 teardown. They show up either as `NoneType is not callable` or as
 `catching classes that do not inherit from BaseException is not allowed`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.7518ddaca7e2c6d8252a05d1104cee1c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.