Re: [Django] #25806: syndication.Feed uses name-mangling for __get_dynamic_attr

[Django]

#25806: syndication.Feed uses name-mangling for __get_dynamic_attr
--+
 Reporter:  kezabelle |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.syndication   |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2c0be9045bf883e20287ae04766098d7307b94ea" 2c0be90]:
 {{{
 #!CommitTicketReference repository=""
 revision="2c0be9045bf883e20287ae04766098d7307b94ea"
 Fixed #25806 -- Removed name mangling from syndication.Feed's
 _get_dynamic_attr().

 It doesn't seem to serve any purpose.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bc7f298d5204ff19f7cb6f3c07d5cc44%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25806: syndication.Feed uses name-mangling for __get_dynamic_attr

[Django]

#25806: syndication.Feed uses name-mangling for __get_dynamic_attr
--+
 Reporter:  kezabelle |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.syndication   |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Seems okay to me. [https://github.com/django/django/pull/5717 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.beee069d64d48196ffc97b6344f8ae6f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25806: syndication.Feed uses name-mangling for __get_dynamic_attr

[Django]

#25806: syndication.Feed uses name-mangling for __get_dynamic_attr
-+-
 Reporter:  kezabelle|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kezabelle):

 Hi Tim,
 Sorry, rather forgot the salient purpose of the ticket, didn't I? I'm
 proposing changing it to be a normal private method (`_get_dynamic_attr`)
 so that subclasses can easily modify what it does.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1ea68be0745d05e73d7d1f8102fd76ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25806: syndication.Feed uses name-mangling for __get_dynamic_attr

[Django]

#25806: syndication.Feed uses name-mangling for __get_dynamic_attr
-+-
 Reporter:  kezabelle|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  contrib.syndication  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 What change should be made?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.dbb5b258a21711797d44133ba7e1dbb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #25806: syndication.Feed uses name-mangling for __get_dynamic_attr

[Django]

#25806: syndication.Feed uses name-mangling for __get_dynamic_attr
--+
 Reporter:  kezabelle |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  contrib.syndication   |Version:  master
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 
[https://github.com/django/django/blob/aac2a2d2ae2486342058db0c72ed7ba2c7c8eb1e/django/contrib/syndication/views.py#L78
 This method being name-mangled] confused me a while back but I forgot
 about it, because it's really rare to actually use that aspect of Python's
 method naming, in my experience.

 I can't see the point of it, really.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.4a58c14cf9a8ba7b3230c205e1ac22f4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.