Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:  1.2  
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, character, 
restriction
 Stage:  Accepted| Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by jacob):

  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, character, 
restriction
 Stage:  Accepted| Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by bronger):

  * stage:  Design decision needed => Accepted

Comment:

 I restore the "Accepted" tag of Jacob as in
 .  I don't see why
 this was removed.  As far as I can see, we have patches and tests now that
 use newforms, so the issues mentioned in
 http://code.djangoproject.com/ticket/5786#comment:25 are addressed.

 Could some ticket triager come over and check
 [http://code.djangoproject.com/attachment/ticket/5786/django-auth-
 username-relax-character-restrictions.diff the latest patch] please?  So
 that it can be marked "Ready for checkin".  Thank you.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by bronger):

 Please change the character restrictions to the best common practice.  It
 is highly unusual to forbid dash or dot in login names.  Moreover, email
 addresses as logins are very common.

 It is not about satisfying all; that's never the case for default values.
 Instead, it's about satisfying ''almost'' all.  Given that almost all
 logins that I know allow more characters, I see no real use case for the
 very limited set being the default.  From this it also follows that only
 very few Django installation are expected to break due to relaxed
 restrictions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by leond):

 First I was convinced that this had to be changed. Later I discovered a
 good workaround because of the following: If you change this in the module
 code, there will be developers who may be dissatisfied with the relaxed
 restrictions. Or there may be developers who still are not satisfied. It
 may be that there are alway unsatisfied developers, no matter how you
 rewrite the module code. So the best solution (in my opinion) is to simply
 put a piece of code into your own admin.py and your own forms.py. You can
 find it in the attachments. I uploaded them several months ago and it
 works really fine.

 I am completely against changing the module code as that never satisfies
 every single developer! Please use the workaround I posted or take it as
 an idead to code a better one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by clayg):

 patch -p1 < django-auth-username-relax-character-restrictions.diff
 applies cleanly from the root directory

 ./tests/runtests.py --settings=settings auth
 --
 Ran 44 tests in 1.649s

 OK

 Will the documentation get updated from the doc strings?
 e.g.
 http://docs.djangoproject.com/en/1.1/topics/auth/#topics-auth

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by clayg):

 Triage Stage:   Design decision needed

 "we just need to relax the current restrictions"

 lbruno's patch looks good to me...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * milestone:  1.2 =>

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:  1.2  
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by lbruno):

 * cc: lbr...@ename.pt (added)
  * milestone:  => 1.2

Comment:

 This is what I'm using in my in-house Django fork. Can this find its way
 into the 1.2 series?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by leond):

 I did it this way! I just overwrote these classes and now it's working and
 it's really easy!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:  1.1  
   
Resolution:  |  Keywords:  username, 
character, restriction
 Stage:  Design decision needed  | Has_patch:  1
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by alextreme):

 * cc: alex-dja...@aperte.nl (added)
  * has_patch:  0 => 1
  * version:  => 1.1
  * stage:  Unreviewed => Design decision needed

Comment:

 I've included a very simple patch (django-auth-username-characters.patch,
 6 lines in 1 file) against Django 1.1 that eases the username
 restrictions. It allows the following characters (next to alphanumerics):
 @.+-_

 The auth system actually works perfectly fine with these characters, it's
 only the admin forms that restrict input. This probably was different in
 the past.

 I'm not sure if there was a rationale on restricting usernames (perhaps
 their use in URLs?) but this patch only allows a few more characters,
 those that probably cause the most annoyances.

 No major changes, no extra settings and good enough until #3011 sees some
 progress. Tests and a review are welcome however.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:   
   
Resolution:  |  Keywords:  username, character, 
restriction
 Stage:  Unreviewed  | Has_patch:  0
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Comment (by kmtracey):

 Replying to [comment:23 leond]:

 Understanding the ticket system does not have a lot to do with
 understanding why something may take a long time.  It isn't the ticket
 system or any process associated with it that holds things up. In this
 particular case the original patches apparently added yet another setting,
 which Jacob is opposed to (see
 http://code.djangoproject.com/ticket/5786#comment:10).  So calling for
 another setting to fix this is not likely to move things forward.  Nor is
 changing the ticket state from Accepted to Unreviewed -- why did you feel
 Accepted was "out of date"?  Jacob, in that same comment, indicated he
 agrees that the character restrictions need to be relaxed.  So near as I
 can see this ticket should still be Accepted. The triage states are
 described here:

 http://docs.djangoproject.com/en/dev/internals/contributing/#ticket-triage

 Another reason this ticket got slowed down is likely that the fixes
 proposed involved changing the validators for the field, and with newforms
 in progress validators were on their way out (to be replaced by model
 validation, which is still not yet in trunk).  Changing code that is about
 to be removed/replaced is generally not high priority.  I don't see that
 anyone has posted what changes are actually required now that newforms
 have replaced oldforms and validators are gone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  nobody   
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:   
   
Resolution:  |  Keywords:  username, character, 
restriction
 Stage:  Unreviewed  | Has_patch:  0
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by leond):

  * owner:  leond => nobody

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  leond
   
Status:  new | Milestone:   
   
 Component:  Authentication  |   Version:   
   
Resolution:  |  Keywords:  username, character, 
restriction
 Stage:  Unreviewed  | Has_patch:  0
   
Needs_docs:  0   |   Needs_tests:  0
   
Needs_better_patch:  0   |  
-+--
Changes (by leond):

  * status:  assigned => new
 * cc: leon.dig...@gmail.com (added)
  * needs_better_patch:  1 => 0
  * component:  Contrib apps => Authentication
  * owner:  luli => leond
  * version:  SVN =>
  * keywords:  auth => username, character, restriction
  * has_patch:  1 => 0
  * stage:  Accepted => Unreviewed

Comment:

 I really don't understand the ticket system very well. That's why I am
 always asking myself, after finding some tickets discussing a problem I
 have at the moment, why this takes so long? This ticket was opened two
 years ago and I see that this is a common problem which is demanded again
 and again. So for the sake of the principles of DRY this ticket should be
 considered of.

 There should be implemented something like a setting to customize the
 regex strings used in auth/forms.py.

 I will change some properties, because they are out-of-date.

 - lulin's last comment was in 2007, I will reassign this ticket to
 anonymous.
 - Further I change the triage stage to unreviewed.
 - The Component is clearly authentication.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Comment (by bronger):

 Actually, I think we should consider them separate issues.  #3011 is a
 large beast, and this one is pretty light-weight, so I'm afraid of waiting
 for a solution much longer than necessary.  Additionally, we discuss about
 changing Django's default behaviour here, whereas #3011 talks about
 extensibility.  I think that Django should support more usernames out-of-
 the-box.

 The demand that occurs again and again (on the mainglist and in the
 tickets) is that you have to include existing user databases.  In my case,
 we must authenticate against an external Windows Active Directory with
 pre-existing usernames.  I think that this is an important use case, and I
 think that characters like dot, dash, and plus are pretty common outside
 Django.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Comment (by bronger):

 So we should close this one, and post links to #6588 and this one to
 #3011?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Comment (by anonymous):

 The basic problem involves having a username/restrictive user model in
 general... see #3011

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Comment (by bronger):

 I think it's time to merge the ideas on this one.

 According to this issue, we want to have all alphanumeric characters from
 Unicode allowed in usernames.  According to #6588, also dots should be
 allowed, and according to
 , dashes
 might be highly sensible, too.

 So what about `re.compile(r'^...@.\w]+$', re.U)`?  Or do we need even more?
 (E.g. `:#*+~'$%&()[]{}!^`)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Changes (by bronger):

 * cc: bron...@physik.rwth-aachen.de (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #5786: Relax character restrictions on auth usernames

[Django]

#5786: Relax character restrictions on auth usernames
-+--
  Reporter:  Armin Ronacher  | Owner:  luli
Status:  assigned| Milestone:  
 Component:  Contrib apps|   Version:  SVN 
Resolution:  |  Keywords:  auth
 Stage:  Accepted| Has_patch:  1   
Needs_docs:  0   |   Needs_tests:  0   
Needs_better_patch:  1   |  
-+--
Comment (by dc):

 Also, see #6588 for a patches.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---