Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  jacob  
  
Status:  assigned  | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by mitsuhiko):

 * cc: mitsuhiko (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  jacob  
  
Status:  assigned  | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * owner:  mitsuhiko => jacob
  * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  mitsuhiko  
  
Status:  new   | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Comment (by mitsuhiko):

 The actual fix for this is in
 http://github.com/mitsuhiko/django/tree/ticket-10404

 It fixes it by using a descriptor in the image field, rather than pre
 saving multiple times.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  mitsuhiko  
  
Status:  new   | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

  * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  mitsuhiko  
  
Status:  new   | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Comment (by anonymous):

 The attach patch does fix it (test suite runs through fine). Don't ask me
 if that's the best way to do it :þ

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  mitsuhiko  
  
Status:  new   | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by mitsuhiko):

  * owner:  nobody => mitsuhiko
  * status:  reopened => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  nobody 
  
Status:  reopened  | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Comment (by kmtracey):

 The reason the patch to the file_storage tests doesn't trigger the error
 is because those tests call save() on the model image field directly.  The
 problem introduced by r9766 is that the under-the-covers save() for the
 file/image fields got moved to much later in the processing, so you need a
 test that doesn't call the field save() directly but rather just attempts
 to call save() on the model (or form).  That's when it becomes apparent
 that the save() on the image/file field is now happening too late in some
 cases.  I'll attach a patch to the model_forms test that do trigger the
 error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  nobody 
  
Status:  reopened  | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Comment (by kmtracey):

 Also, this looks to be another r9766 side-effect.  While the line of code
 identified in the description hasn't changed, r9766 effectively moved the
 setting of these fields from early on (when form data was saved) to much
 later in the processing.  Using r9765 I cannot recreate the error with
 admin even if the width and height fields are declared before the image
 field itself.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  nobody 
  
Status:  reopened  | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by kmtracey):

  * status:  closed => reopened
  * resolution:  worksforme =>

Comment:

 I haven't looked in detail but somehow that existing test with the order
 reversed doesn't trigger this bug. I, however, can recreate the described
 problem manually using admin, so I do believe there is a problem here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  nobody 
  
Status:  closed| Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:  worksforme|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by tclineks):

  * status:  new => closed
  * resolution:  => worksforme

Comment:

 The attached test patch would expose this problem, it doesn't. Marking
 worksforme.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
  Reporter:  Lehich| Owner:  nobody 
  
Status:  new   | Milestone:  1.1
  
 Component:  File uploads/storage  |   Version:  SVN
  
Resolution:|  Keywords:  ImageField, 
height_field, width_field
 Stage:  Accepted  | Has_patch:  0  
  
Needs_docs:  0 |   Needs_tests:  0  
  
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10404: ImageField: height_field and width_field option sometimes doesn't work

[Django]

#10404: ImageField: height_field and width_field option sometimes doesn't work
---+
 Reporter:  Lehich |   Owner:  nobody
   Status:  new|   Milestone:
Component:  File uploads/storage   | Version:  SVN   
 Keywords:  ImageField, height_field, width_field  |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 I had a problem: height_field and width_field always = 0 in some models,
 after uploading any image file.
 Problem was in fields order: if height_field and width_field goes before
 image field - this thing happends.

 I appears in models save method.
 /django/db/models/base.py : 378 (actual for revision: 9962)

 {{{
 values = [(f, None, f.get_db_prep_save(raw and getattr(self, f.attname) or
 f.pre_save(self, False))) for f in non_pks]
 }}}

 here all fields values are calculated (''get_db_prep_save'') and copy to
 ''values''. So, if in models description ImageField goes before height and
 width fields, everything is fine. But if ImageField goes after this
 fields, all pic size calculation still in fields but not in values list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---