Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-09-02 Thread Django 
#20998: Form GIS widgets render() lack of modularity
-+-
 Reporter:  leplatrem|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  GIS  |  1.6-beta-1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  refactor | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"0c5786890875f2adbcfddd0056dc2b87a768aa1e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0c5786890875f2adbcfddd0056dc2b87a768aa1e"
 [1.6.x] Fixed gis test to run on non gis-enabled settings

 Refs #20998.
 Backport of 973502c0 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.245d45b413c3b466110db4350851450c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-09-02 Thread Django 
#20998: Form GIS widgets render() lack of modularity
-+-
 Reporter:  leplatrem|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  GIS  |  1.6-beta-1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  refactor | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"973502c04704aac4742e2d996cb758acd5035d46"]:
 {{{
 #!CommitTicketReference repository=""
 revision="973502c04704aac4742e2d996cb758acd5035d46"
 Fixed gis test to run on non gis-enabled settings

 Refs #20998.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8ce67b0f9f4ca88d7265f8ef6d440266%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-09-02 Thread Django 
#20998: Form GIS widgets render() lack of modularity
-+-
 Reporter:  leplatrem|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  GIS  |  1.6-beta-1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  refactor | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"4e3794dd1fbc689dcbcc455f3458539d630a1ff3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4e3794dd1fbc689dcbcc455f3458539d630a1ff3"
 [1.6.x] Fixed #20998 -- Allow custom (de)serialization for GIS widgets

 Thanks Mathieu Leplatre for the report and the initial patch.
 Backport of 102f26c92 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.259bb23d30b294607a18ebb42d11ed9a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-09-02 Thread Django 
#20998: Form GIS widgets render() lack of modularity
-+-
 Reporter:  leplatrem|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  GIS  |  1.6-beta-1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  refactor | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"102f26c92923d0e5e80de9b473f2343f76b04aa8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="102f26c92923d0e5e80de9b473f2343f76b04aa8"
 Fixed #20998 -- Allow custom (de)serialization for GIS widgets

 Thanks Mathieu Leplatre for the report and the initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d98abd8b57ea0a9d29ee9779c9ddd7f7%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-08-30 Thread Django 
#20998: Form GIS widgets render() lack of modularity
-+-
 Reporter:  leplatrem|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  GIS  |  1.6-beta-1
 Severity:  Normal   |   Resolution:
 Keywords:  refactor | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * type:  Uncategorized => Cleanup/optimization
 * needs_tests:  1 => 0


Comment:

 https://github.com/django/django/pull/1532

 Please review!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.8ad26cc1d13eff14494fe54066996457%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-08-30 Thread Django 
#20998: Form GIS widgets render() lack of modularity
---+--
 Reporter:  leplatrem  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  GIS|  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:
 Keywords:  refactor   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by claudep):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Many thanks for suggesting those improvements.

 As discussed on IRC, my idea is to deprecate most of `gis/admin` as soon
 as the new form fields/widgets in `gis/forms.py` proved they can replace
 former functionality. So I wouldn't touch the `gis/admin` part, also for
 the fact that backwards compatibility is a concern for that code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0064288349a225992caa9f9fc0a36bbd%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20998: Form GIS widgets render() lack of modularity

2013-08-30 Thread Django 
#20998: Form GIS widgets render() lack of modularity
---+--
 Reporter:  leplatrem  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  GIS|  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:
 Keywords:  refactor   | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 If the goal is to make the widgets extensible by third-party code, we need
 a public API rather than a private one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.88716ef501869c9eb989080861d3409d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #20998: Form GIS widgets render() lack of modularity

2013-08-29 Thread Django 
#20998: Form GIS widgets render() lack of modularity
---+
 Reporter:  leplatrem  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  GIS|Version:  1.6-beta-1
 Severity:  Normal |   Keywords:  refactor
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 When subclassing GIS form widgets, there should be a way to override
 geometry serialization, without having to duplicate reprojection
 behaviour.

 
https://github.com/django/django/blob/1.6b2/django/contrib/gis/forms/widgets.py#L37-L74

 I propose to add some additional private methods:

 * _deserialize:  string (wkt) to geos (geos)
 * _transform: from map widget to model projection
 * _serialize: geometry to string (wkt)

 This would open doors to widgets that support other representation formats
 (geojson, topojson, ...)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.87fd1a62593e64804024df5f21b08e83%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.