Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
-+-
 Reporter:  claudep  |Owner:  timgraham
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"82e4f956e3faa4a48fe3c90e02673c1a916d6943"]:
 {{{
 #!CommitTicketReference repository=""
 revision="82e4f956e3faa4a48fe3c90e02673c1a916d6943"
 Fixed #23289 -- Added mock as a test dependency.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3310c6a0568cffc97333571e36f63398%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
-+-
 Reporter:  claudep  |Owner:  timgraham
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9342e2812bec5270a309d24923a211b3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+-
 Reporter:  claudep|Owner:  timgraham
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/3649 PR] is ready for review. I
 only updated one place to use mock, I'm sure there are others that could
 make use of it, but I'll create a separate ticket to audit for them after
 this goes in.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.669dbd619a747f389de57b4c21276c6c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+-
 Reporter:  claudep|Owner:  timgraham
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timgraham):

 * status:  new => assigned
 * owner:  nobody => timgraham


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d10a76ec703ba54d821a408b5a8fc20b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+
 Reporter:  claudep|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timgraham):

 * cc: timo (added)
 * stage:  Unreviewed => Accepted


Comment:

 Undecided on the approach, but definitely would like this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8b9a73b3d6bfe3d84b68ae3c8f3b2f86%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+--
 Reporter:  claudep|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by collinanderson):

 I think it's great that you can just download Django and `./runtests.py`
 works. I know pip and venv have made dependencies much easier, but I think
 there are still some really great benefits to making dependencies as
 optional as possible. I'm new to testing in general: is it too hard to
 manually patch things to make a mock by hand?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3cfa21f395a64f44a109e081fe6db5ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+--
 Reporter:  claudep|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by claudep):

 `mock`'s utility goes beyond its potential usage in the mentioned ticket.
 It might certainly be useful in several other cases in the current Django
 test suite.

 I've purposefully refrained from giving any personal preference in the
 ticket description, but experience has told us that vendoring should be a
 last-resort solution. My preference goes to 3., while 2. might be
 interesting in the sense that it might be useful for some external
 reusable Django apps.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e470220541cbe69274b8d52fe8b31a06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23289: Make mock library available for testing in Django

[Django]

#23289: Make mock library available for testing in Django
---+--
 Reporter:  claudep|Owner:  nobody
 Type:  New feature|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by collinanderson):

 I assume it's not possible or extremely complicated to write the test
 without mock? It seems to me #1 is the best option if we do use mock. It
 would be great if the tests just worked.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c812d759da7e241220b539601fcde57d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.