Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha 
   
Status:  new  | Milestone:  1.3 
 
 Component:  django.contrib.admin |   Version:  1.2 
 
Resolution:   |  Keywords:  
sprintSep2010
 Stage:  Ready for checkin| Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Changes (by jezdez):

  * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha 
   
Status:  new  | Milestone:  1.3 
 
 Component:  django.contrib.admin |   Version:  1.2 
 
Resolution:   |  Keywords:  
sprintSep2010
 Stage:  Accepted | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Changes (by acdha):

  * milestone:  => 1.3

Comment:

 Updated patch against current trunk:

 https://github.com/acdha/django/compare/django-master...django-6183-1.3
 https://github.com/acdha/django/compare/django-
 master...django-6183-1.3.patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha 
   
Status:  new  | Milestone:  
 
 Component:  django.contrib.admin |   Version:  1.2 
 
Resolution:   |  Keywords:  
sprintSep2010
 Stage:  Accepted | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Comment (by ramiro):

 See also #14402.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha 
   
Status:  new  | Milestone:  
 
 Component:  django.contrib.admin |   Version:  1.2 
 
Resolution:   |  Keywords:  
sprintSep2010
 Stage:  Accepted | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Changes (by andrewbadr):

 * cc: andrewbadr@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha 
   
Status:  new  | Milestone:  
 
 Component:  django.contrib.admin |   Version:  1.2 
 
Resolution:   |  Keywords:  
sprintSep2010
 Stage:  Accepted | Has_patch:  1   
 
Needs_docs:  0|   Needs_tests:  0   
 
Needs_better_patch:  0|  
--+-
Changes (by acdha):

  * keywords:  => sprintSep2010

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha
Status:  new  | Milestone:   
 Component:  django.contrib.admin |   Version:  1.2  
Resolution:   |  Keywords:   
 Stage:  Accepted | Has_patch:  1
Needs_docs:  0|   Needs_tests:  0
Needs_better_patch:  0|  
--+-
Comment (by acdha):

 Replying to [comment:10 acdha]:
 > I think the larger question of where the help text comes from is
 definitely worth some changes but it's beyond the scope of this ticket.
 >
 > Current patch here after testing:
 > http://github.com/acdha/django/compare/django-bug-6183

 Direct patch link: http://github.com/acdha/django/compare/django-
 bug-6183.patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha
Status:  new  | Milestone:   
 Component:  django.contrib.admin |   Version:  1.2  
Resolution:   |  Keywords:   
 Stage:  Accepted | Has_patch:  1
Needs_docs:  0|   Needs_tests:  0
Needs_better_patch:  0|  
--+-
Changes (by acdha):

  * needs_better_patch:  1 => 0
  * version:  1.1 => 1.2

Comment:

 I think the larger question of where the help text comes from is
 definitely worth some changes but it's beyond the scope of this ticket.

 Current patch here after testing:
 http://github.com/acdha/django/compare/django-bug-6183

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  acdha
Status:  new  | Milestone:   
 Component:  django.contrib.admin |   Version:  1.1  
Resolution:   |  Keywords:   
 Stage:  Accepted | Has_patch:  1
Needs_docs:  0|   Needs_tests:  0
Needs_better_patch:  1|  
--+-
Changes (by acdha):

  * owner:  nobody => acdha

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.admin |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Comment (by mattjmorrison):

 I'm not sure if this is really a separate issue, but it seems related to
 this one... First off, why is there default help text in the
 ManyToManyField specific to a widget that COULD be used for that type of
 field?  It seems like that "Hold down control..." wording really doesn't
 belong in a database level field class at all.  Secondly, I'm sure this
 was added for a reason, but why is the help_text of a ManyToManyField not
 over-writable?  Looking at the trunk, any specified help_text that I
 specify on my ManyToManyFields still has the "widget specific" wording
 appended to the end of it.  In my case, I'd like to specify some help_text
 for a ManyToManyField and I also happen to be using my own custom widget
 for that same field.  Since the "Hold down control..." wording doesn't
 make any sense for my custom widget, I should be able to override it with
 my own help_text.

 IMHO, I think the real patch should remove the default help_text from the
 ManyToManyField class all together, and have that help_text added to the
 SelectMultiple widget instead.

 Let me know if you think this should be a separate ticket/patch...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.admin |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Comment (by acdha):

 I've uploaded a much more concise version of this patch which behaves the
 same as django-6183.patch and doesn't require the change to related.py.
 Tested in Safari 4, Firefox 3.5, IE7 (don't have 6 or 8 handy) and Chrome
 4. Can someone review the patch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

--

You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=.

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.admin |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Changes (by acdha):

 * cc: ch...@improbable.org (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  nobody
Status:  new  | Milestone:
 Component:  django.contrib.admin |   Version:  1.1   
Resolution:   |  Keywords:
 Stage:  Accepted | Has_patch:  1 
Needs_docs:  0|   Needs_tests:  0 
Needs_better_patch:  1|  
--+-
Changes (by acdha):

  * version:  newforms-admin => 1.1

Comment:

 The attached patch is updated against 1.1 and changes the mechanics
 slightly: instead of appending the help_text to the bottom of the widget,
 it ensures that it will be the first element in the container, which
 doesn't interfere with the filter widgets.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  
nobody
Status:  new  | Milestone:  
  
 Component:  django.contrib.admin |   Version:  
newforms-admin
Resolution:   |  Keywords:  
  
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  1|  
--+-
Comment (by kmtracey):

 #11452 and #6459 were closed as dupes of this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  
nobody
Status:  new  | Milestone:  
  
 Component:  django.contrib.admin |   Version:  
newforms-admin
Resolution:   |  Keywords:  
  
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  1|  
--+-
Comment (by lakinwecker):

 Yeah I'd be interested in getting this added to trunk too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #6183: [patch] Support help_text with ManyToMany field widgets

[Django]

#6183: [patch] Support help_text with ManyToMany field widgets
--+-
  Reporter:  Steven Armstrong   | Owner:  
nobody
Status:  new  | Milestone:  
  
 Component:  django.contrib.admin |   Version:  
newforms-admin
Resolution:   |  Keywords:  
  
 Stage:  Accepted | Has_patch:  1   
  
Needs_docs:  0|   Needs_tests:  0   
  
Needs_better_patch:  1|  
--+-
Changes (by kit1980):

  * keywords:  nfa-someday =>

Comment:

 Newforms-admin merged to trunk long time ago.
 Maybe someday is now? :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---