Re: [Dovecot] over quota + antispam crash
Thanks for the patch, can you check whether it works with just the if (dest_mail)? johannes signature.asc Description: This is a digitally signed message part
Re: [Dovecot] over quota + antispam crash
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Johannes Berg a écrit : Thanks for the patch, can you check whether it works with just the if (dest_mail)? It doesn't work the return -1 is inspired from the end of quota_save_init function (in src/plugins/quota/quota-storage.c) the if(dest_mail) is not in quota_save_init. it may be unnecessary. Stéphane johannes -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkme5AcACgkQNgQUYqHIqqs7vACgjNp27Pf+Hc+9v2GK0NKRXyKC BjUAn0MApH6xBjw+FHCOCT693rhGYduT =kAgf -END PGP SIGNATURE- begin:vcard fn;quoted-printable:St=C3=A9phane Cottin n;quoted-printable:Cottin;St=C3=A9phane org:VIXNS adr:;;172 avenue de toulon;Marseille;;13010;France email;internet:stephane.cot...@vixns.com x-mozilla-html:FALSE url:http://www.vixns.com version:2.1 end:vcard
Re: [Dovecot] over quota + antispam crash
On Thu, Feb 19, 2009 at 8:57 AM, Stéphane Cottin stephane.cot...@vixns.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stéphane Cottin a écrit : Hi, I am using dovecot 1.1.11 , quota, imap_quota antispam plugins. Dovecot crashes when saving a message to the Sent maildir and the account is over quota. gdb trace attached. Stéphane Cottin All day long without segfaults!!! :D Many thanks!!
Re: [Dovecot] over quota + antispam crash
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stéphane Cottin a écrit : Hi, I am using dovecot 1.1.11 , quota, imap_quota antispam plugins. Dovecot crashes when saving a message to the Sent maildir and the account is over quota. gdb trace attached. Stéphane Cottin Hi, The attached patch seems to fix my bug. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmdSSUACgkQNgQUYqHIqqt+WgCeOfxt3CiMVs4cQLYVHFl932pM H1gAni6WIB3V+qUr/hwScxMSWVjAvq1s =2zbd -END PGP SIGNATURE- diff --git a/antispam-storage-1.1.c b/antispam-storage-1.1.c index 348ae9d..bc370ad 100644 --- a/antispam-storage-1.1.c +++ b/antispam-storage-1.1.c @@ -167,7 +167,11 @@ static int antispam_save_init(struct mailbox_transaction_context *t, timezone_offset, from_envelope, input, dest_mail, ctx_r); - (*ctx_r)-dest_mail = dest_mail; + if(ret 0) + return -1; + + if (dest_mail != NULL) + (*ctx_r)-dest_mail = dest_mail; return ret; } begin:vcard fn;quoted-printable:St=C3=A9phane Cottin n;quoted-printable:Cottin;St=C3=A9phane org:VIXNS adr:;;172 avenue de toulon;Marseille;;13010;France email;internet:stephane.cot...@vixns.com x-mozilla-html:FALSE url:http://www.vixns.com version:2.1 end:vcard
