Re: Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 05:34:46PM -0400, Alex Deucher wrote: > On Thu, Apr 14, 2011 at 5:09 PM, Joerg Roedel wrote: > > Actually, the nb gart is part of the cpu. It is part of the cpu north > > bridge and can translate io and cpu accesses. In fact, it is a remapper > > of physical memory addresses. > > I know what it's for. In the IGP graphics chip is also part of the > north bridge, but it may not be related at all. Okay, just wanted to make clear that it is part of the CPU and not of the chipset :) > > The problem seems to be related to specific gpu chips. On another > > notebook with an hd3000 card gtt and the nb gart aperture are both on > > 0xa000 too but the box works fine. I havn't tested with an hd5000 > > yet. The failing notebook has an hd4200 mobility. > > What exact model is the hd3000? Is it IGP GPU or a discrete GPU? It > it's an IGP, it's identical to the hd4200 programming-wise. It is an IGP card, an "ATI Technologies Inc RS780M/RS780MN [Radeon HD 3200 Graphics]" according to lspci. > > Btw. what happens if the gpu accesses an unmapped address in the gtt > > range? > > It's redirected to a dummy page. So there should be no issue too, this is a very weird bug. Joerg ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: 2.6.39-rc1 nouveau regression (bisected)
On Thu, Apr 14, 2011 at 09:02:01PM +0200, Marcin Slusarz wrote: > On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > > Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" > > to everyone, but then chose to CC Maciej instead: Would you be so kind and > > add this to your regression list? Thanks! > > > > Since commit 38f1cff > > > > From: Dave Airlie > > Date: Wed, 16 Mar 2011 11:34:41 +1000 > > Subject: [PATCH] Merge commit > > '5359533801e3dd3abca5b7d3d985b0b33fd9fe8b' into dr > > > > This commit changed an internal radeon structure, that meant a new > > driver > > in -next had to be fixed up, merge in the commit and fix up the driver. > > > > Also fixes a trivial nouveau merge. > > > > Conflicts: > > drivers/gpu/drm/nouveau/nouveau_mem.c > > > > booting my atom/NM10/ION2 system crashes hard during boot, right after > > blanking the screen, and before the initramfs gets loaded. I just > > re-checked: both parent commits ( 5359533 and 4819d2e ) do indeed work > > just fine, but the merge commit ( 38f1cff ) fails, same as tip ( 85f2e68 ). > > Can you activate netconsole and check whether kernel spits anything > interesting? > You might try to load nouveau module after boot - maybe something will be > saved > to /var/log or you could even ssh into the box and check dmesg... Compiling it as a module seems to work fine. When I do so, no regression is obvious from what gets reported in "dmesg". However, somehow I now do get some output: The last message I see is [drm] nouveau :01:00.0: allocated 1680x1050, fb 0x40 b0 Then, nothing more. However, it really is quite strange why this error only appears in the CONFIG_NOUVEAU=y case, not in the =m case... Best, Dominik ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 10:28:43AM -0400, Alex Deucher wrote: > On Thu, Apr 14, 2011 at 4:56 AM, Joerg Roedel wrote: > > And this makes a difference, with this change on-top of -rc3 the box boots > > fine. So there seems to be some dependency between the GART base and the GTT > > base even when they are in different address spaces. > > > > Alex, can you comment on this? > > As Dave said, they are completely different addresses spaces. You > could put the GPU aperture at 0 if you wanted (in fact we do on some > chips). Perhaps there's some strange interaction with the nb gart > since the nb gart on that chipset was designed to be used for graphics > and the rs780/880 can be configured to use an agp aperture. > Unfortunately, I'm not that familiar with the nb gart. Actually, the nb gart is part of the cpu. It is part of the cpu north bridge and can translate io and cpu accesses. In fact, it is a remapper of physical memory addresses. The problem seems to be related to specific gpu chips. On another notebook with an hd3000 card gtt and the nb gart aperture are both on 0xa000 too but the box works fine. I havn't tested with an hd5000 yet. The failing notebook has an hd4200 mobility. Btw. what happens if the gpu accesses an unmapped address in the gtt range? Regards, Joerg
[Bug 36255] New: [r128] Kernel panic after killing X since 2.6.37
https://bugs.freedesktop.org/show_bug.cgi?id=36255 Summary: [r128] Kernel panic after killing X since 2.6.37 Product: DRI Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: DRM/other AssignedTo: dri-devel@lists.freedesktop.org ReportedBy: connor.be...@gmail.com Created an attachment (id=45651) --> (https://bugs.freedesktop.org/attachment.cgi?id=45651) Dmesg output I have seen this bug in kernels 2.6.38, 2.6.37 and NOT 2.6.36. Every time I quit the Xserver using the Xfce session manager, the message printed on the console it returns to is: EIP: [] r128_driver_irq_handler +0x15/0x50 [r128] SS:ESP 0068:df007fac CR2: e08c8044 --- [ end trace 632129fdd65eae19 ] --- Kernel panic - not syncing: Fatal exception in interrupt Pid: 0, comm: swapper tainted: G D 2.6.38-ARCH #1 Call trace: *some calls including r128_driver_irq_handler and other IRQ functions* And I have to reboot with Alt+SysRq+REISUB. This only happens when I quit X using the functions in the Xfce session manager. The return to the console will be fine if I use Ctrl+Alt+Backspace, "sudo killall X", or Ctrl+Alt+F1 followed by Ctrl+C. I admit that this is vague information but I simply cannot get an answer our of the Xfce developers as to what function is being used. >From the look I had at the xfce4-session source code I would guess that the logout is being done with libICE. I know it is not being done with Hal, Consolekit or the XKillClient Xlib function. I will update this bug report as soon as I know which function causes this and have a testcase ready. If you think it will lead to a fix I would be willing to use a pencil and paper to write out the exact call trace in the kernel panic (which I have no way of copying or pasting). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36255] New: [r128] Kernel panic after killing X since 2.6.37
https://bugs.freedesktop.org/show_bug.cgi?id=36255 Summary: [r128] Kernel panic after killing X since 2.6.37 Product: DRI Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: major Priority: medium Component: DRM/other AssignedTo: dri-devel at lists.freedesktop.org ReportedBy: connor.behan at gmail.com Created an attachment (id=45651) --> (https://bugs.freedesktop.org/attachment.cgi?id=45651) Dmesg output I have seen this bug in kernels 2.6.38, 2.6.37 and NOT 2.6.36. Every time I quit the Xserver using the Xfce session manager, the message printed on the console it returns to is: EIP: [] r128_driver_irq_handler +0x15/0x50 [r128] SS:ESP 0068:df007fac CR2: e08c8044 --- [ end trace 632129fdd65eae19 ] --- Kernel panic - not syncing: Fatal exception in interrupt Pid: 0, comm: swapper tainted: G D 2.6.38-ARCH #1 Call trace: *some calls including r128_driver_irq_handler and other IRQ functions* And I have to reboot with Alt+SysRq+REISUB. This only happens when I quit X using the functions in the Xfce session manager. The return to the console will be fine if I use Ctrl+Alt+Backspace, "sudo killall X", or Ctrl+Alt+F1 followed by Ctrl+C. I admit that this is vague information but I simply cannot get an answer our of the Xfce developers as to what function is being used.
2.6.39-rc1 nouveau regression (bisected)
On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" > to everyone, but then chose to CC Maciej instead: Would you be so kind and > add this to your regression list? Thanks! > > Since commit 38f1cff > > From: Dave Airlie > Date: Wed, 16 Mar 2011 11:34:41 +1000 > Subject: [PATCH] Merge commit '5359533801e3dd3abca5b7d3d985b0b33fd9fe8b' > into dr > > This commit changed an internal radeon structure, that meant a new driver > in -next had to be fixed up, merge in the commit and fix up the driver. > > Also fixes a trivial nouveau merge. > > Conflicts: > drivers/gpu/drm/nouveau/nouveau_mem.c > > booting my atom/NM10/ION2 system crashes hard during boot, right after > blanking the screen, and before the initramfs gets loaded. I just > re-checked: both parent commits ( 5359533 and 4819d2e ) do indeed work > just fine, but the merge commit ( 38f1cff ) fails, same as tip ( 85f2e68 ). Can you activate netconsole and check whether kernel spits anything interesting? You might try to load nouveau module after boot - maybe something will be saved to /var/log or you could even ssh into the box and check dmesg... Marcin
[PATCH] i2c-algo-bit: make sure to call pre/post_xfer for bit_test
Apparently some distros set i2c-algo-bit.bit_test to 1 by
default. In some cases this causes i2c_bit_add_bus
to fail and prevents the i2c bus from being added. In the
radeon case, we fail to add the ddc i2c buses which prevents
the driver from being able to detect attached monitors.
The i2c bus works fine even if bit_test fails. This is likely
due to gpio switching that is required and handled in the
pre/post_xfer hooks, so call the pre/post_xfer hooks in the
bit test as well.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=36221
Cc: Jean Delvare
Signed-off-by: Alex Deucher
---
drivers/i2c/algos/i2c-algo-bit.c | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index 38319a6..e2740e6 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -232,9 +232,16 @@ static int i2c_inb(struct i2c_adapter *i2c_adap)
* Sanity check for the adapter hardware - check the reaction of
* the bus lines only if it seems to be idle.
*/
-static int test_bus(struct i2c_algo_bit_data *adap, char *name)
+static int test_bus(struct i2c_adapter *i2c_adap, char *name)
{
- int scl, sda;
+ struct i2c_algo_bit_data *adap = i2c_adap->algo_data;
+ int scl, sda, ret;
+
+ if (adap->pre_xfer) {
+ ret = adap->pre_xfer(i2c_adap);
+ if (ret < 0)
+ return -ENODEV;
+ }
if (adap->getscl == NULL)
pr_info("%s: Testing SDA only, SCL is not readable\n", name);
@@ -297,11 +304,19 @@ static int test_bus(struct i2c_algo_bit_data *adap, char
*name)
"while pulling SCL high!\n", name);
goto bailout;
}
+
+ if (adap->post_xfer)
+ adap->post_xfer(i2c_adap);
+
pr_info("%s: Test OK\n", name);
return 0;
bailout:
sdahi(adap);
sclhi(adap);
+
+ if (adap->post_xfer)
+ adap->post_xfer(i2c_adap);
+
return -ENODEV;
}
@@ -607,7 +622,7 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
int ret;
if (bit_test) {
- ret = test_bus(bit_adap, adap->name);
+ ret = test_bus(adap, adap->name);
if (ret < 0)
return -ENODEV;
}
--
1.7.1.1
[Bug 32982] Kernel locks up a few minutes after boot
https://bugzilla.kernel.org/show_bug.cgi?id=32982 --- Comment #8 from Bart Van Assche 2011-04-14 19:24:34 --- The result of the bisect process - not sure it's useful: # git bisect skip There are only 'skip'ped commits left to test. The first bad commit could be any of: 62e0ff1ef2d8ea0814487f73a7de431396a1e914 1fcf0069f4715f6f811466db68a547a348b4d5a9 94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9 53f358a81e10e798f44af896ffacaedd7ac0269b e9c5db0b8dce1bcdc99ad26e718230810d6b5cff b73a21fc66fee35b41db755abebfacba48b2fc76 We cannot bisect more! git bisect start # skip: [1fcf0069f4715f6f811466db68a547a348b4d5a9] Merge branch 'common/fbdev' of master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6 git bisect skip 1fcf0069f4715f6f811466db68a547a348b4d5a9 # skip: [e9c5db0b8dce1bcdc99ad26e718230810d6b5cff] efifb: support AMD Radeon HD 6490 git bisect skip e9c5db0b8dce1bcdc99ad26e718230810d6b5cff # skip: [21cd72e7cb424f1686855602ec0fdc6e5830f249] savagefb: Set up I2C based on chip family instead of card id git bisect skip 21cd72e7cb424f1686855602ec0fdc6e5830f249 # skip: [47c87d930f3db4fc3a30505075e07f5597e2e953] fb: Reduce priority of resource conflict message git bisect skip 47c87d930f3db4fc3a30505075e07f5597e2e953 # good: [899631c7916b231ba6509c90dbc33221e9194029] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input git bisect good 899631c7916b231ba6509c90dbc33221e9194029 # bad: [b73a21fc66fee35b41db755abebfacba48b2fc76] video: s3c-fb: fix checkpatch errors and warning git bisect bad b73a21fc66fee35b41db755abebfacba48b2fc76 # skip: [6c5103890057b1bb781b26b7aae38d33e4c517d8] Merge branch 'for-2.6.39/core' of git://git.kernel.dk/linux-2.6-block git bisect skip 6c5103890057b1bb781b26b7aae38d33e4c517d8 # good: [247f99386100d1d1c369ba98120d2edebf5426fc] fbdev: sh_mobile_lcdcfb: fix module lock acquisition git bisect good 247f99386100d1d1c369ba98120d2edebf5426fc # skip: [53f358a81e10e798f44af896ffacaedd7ac0269b] Merge branch 'viafb-next' of git://github.com/schandinat/linux-2.6 git bisect skip 53f358a81e10e798f44af896ffacaedd7ac0269b # good: [3f086fe93f734ba76f2e130777687f81e0cbb318] viafb: initialize margins correct git bisect good 3f086fe93f734ba76f2e130777687f81e0cbb318 # skip: [62e0ff1ef2d8ea0814487f73a7de431396a1e914] fbcon: Remove unused 'display *p' variable from fb_flashcursor() git bisect skip 62e0ff1ef2d8ea0814487f73a7de431396a1e914 # skip: [94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9] s3fb: fix Virge/GX2 git bisect skip 94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list Dri-devel at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 6:56 PM, Joerg Roedel wrote:
> On Wed, Apr 13, 2011 at 06:58:46PM -0700, H. Peter Anvin wrote:
>> On 04/13/2011 12:14 PM, Yinghai Lu wrote:
>> >
>> > so looks bios program wrong address to the radon card?
>> >
>>
>> Okay, staring at this, it definitely seems toxic to overlay the GART
>> over memory areas reserved by the BIOS. ?If I were to guess, I would say
>> that the problem here seems to be that the kernel thinks it is
>> overlaying 64 MiB of memory, but the actual GART is in fact 512 MiB in
>> size -- 131072 CPU pages -- which now overlaps the BIOS reserved areas.
>>
>> Alex D., could you comment on the "num cpu pages" bit?
>
> Okay, I tried the debug-patch from Yinghai (posted to the bugzilla):
>
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -325,6 +325,8 @@ void radeon_gtt_location(struct radeon_device *rdev,
> struct radeon_mc *mc)
> ? ? ? ? ? ? ? ? ? ? ? ?mc->gtt_size = size_bf;
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?mc->gtt_start = (mc->vram_start & ~mc->gtt_base_align) -
> mc->gtt_size;
> + ? ? ? ? ? ? ? if (mc->gtt_start == 0xa000)
> + ? ? ? ? ? ? ? ? ? ? ? mc->gtt_start = 0x8000;
> ? ? ? ?} else {
> ? ? ? ? ? ? ? ?if (mc->gtt_size > size_af) {
> ? ? ? ? ? ? ? ? ? ? ? ?dev_warn(rdev->dev, "limiting GTT\n");
>
> And this makes a difference, with this change on-top of -rc3 the box boots
> fine. So there seems to be some dependency between the GART base and the GTT
> base even when they are in different address spaces.
>
> Alex, can you comment on this?
Wierd either a hw bug or some access to the GTT is leaking out before,
things are setup properly,
I think the RS780/880 docs are on the website, but generally the
address spaces are completely separate so anything getting through is
very unusual.
Dave.
[PATCH] drm/radeon/kms: adjust evergreen display watermark setup
This patch fixes two issues:
- A disabled crtc does not use any lb, so return 0 for
lb size. This makes the display priority calculation
more exact.
- Only use 1/2 and whole lb partitions. Using smaller
partitions can cause underflow to one of the displays
if you have multiple large displays on the same lb.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=34534
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/evergreen.c | 89 ++--
1 files changed, 44 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreen.c
b/drivers/gpu/drm/radeon/evergreen.c
index 5f057b8..11d1578 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -371,7 +371,7 @@ static u32 evergreen_line_buffer_adjust(struct
radeon_device *rdev,
struct drm_display_mode *mode,
struct drm_display_mode *other_mode)
{
- u32 tmp = 0;
+ u32 tmp;
/*
* Line Buffer Setup
* There are 3 line buffers, each one shared by 2 display controllers.
@@ -381,64 +381,63 @@ static u32 evergreen_line_buffer_adjust(struct
radeon_device *rdev,
* first display controller
* 0 - first half of lb (3840 * 2)
* 1 - first 3/4 of lb (5760 * 2)
-* 2 - whole lb (7680 * 2)
+* 2 - whole lb (7680 * 2), other crtc must be disabled
* 3 - first 1/4 of lb (1920 * 2)
* second display controller
* 4 - second half of lb (3840 * 2)
* 5 - second 3/4 of lb (5760 * 2)
-* 6 - whole lb (7680 * 2)
+* 6 - whole lb (7680 * 2), other crtc must be disabled
* 7 - last 1/4 of lb (1920 * 2)
*/
- if (mode && other_mode) {
- if (mode->hdisplay > other_mode->hdisplay) {
- if (mode->hdisplay > 2560)
- tmp = 1; /* 3/4 */
- else
- tmp = 0; /* 1/2 */
- } else if (other_mode->hdisplay > mode->hdisplay) {
- if (other_mode->hdisplay > 2560)
- tmp = 3; /* 1/4 */
- else
- tmp = 0; /* 1/2 */
- } else
+ /* this can get tricky if we have two large displays on a paired group
+* of crtcs. Ideally for multiple large displays we'd assign them to
+* non-linked crtcs for maximum line buffer allocation.
+*/
+ if (radeon_crtc->base.enabled && mode) {
+ if (other_mode)
tmp = 0; /* 1/2 */
- } else if (mode)
- tmp = 2; /* whole */
- else if (other_mode)
- tmp = 3; /* 1/4 */
+ else
+ tmp = 2; /* whole */
+ } else
+ tmp = 0;
/* second controller of the pair uses second half of the lb */
if (radeon_crtc->crtc_id % 2)
tmp += 4;
WREG32(DC_LB_MEMORY_SPLIT + radeon_crtc->crtc_offset, tmp);
- switch (tmp) {
- case 0:
- case 4:
- default:
- if (ASIC_IS_DCE5(rdev))
- return 4096 * 2;
- else
- return 3840 * 2;
- case 1:
- case 5:
- if (ASIC_IS_DCE5(rdev))
- return 6144 * 2;
- else
- return 5760 * 2;
- case 2:
- case 6:
- if (ASIC_IS_DCE5(rdev))
- return 8192 * 2;
- else
- return 7680 * 2;
- case 3:
- case 7:
- if (ASIC_IS_DCE5(rdev))
- return 2048 * 2;
- else
- return 1920 * 2;
+ if (radeon_crtc->base.enabled && mode) {
+ switch (tmp) {
+ case 0:
+ case 4:
+ default:
+ if (ASIC_IS_DCE5(rdev))
+ return 4096 * 2;
+ else
+ return 3840 * 2;
+ case 1:
+ case 5:
+ if (ASIC_IS_DCE5(rdev))
+ return 6144 * 2;
+ else
+ return 5760 * 2;
+ case 2:
+ case 6:
+ if (ASIC_IS_DCE5(rdev))
+ return 8192 * 2;
+ else
+ return 7680 * 2;
+ case 3:
+ case 7:
+ if (ASIC_IS_DCE5(rdev))
+ return 2048 * 2;
+ else
+ return 1920 * 2;
+ }
}
+
+ /* controller not enabled, so no lb used */
+ return 0;
}
static u32 evergreen_get_number_of_dr
2.6.39-rc1 nouveau regression (bisected)
Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" to everyone, but then chose to CC Maciej instead: Would you be so kind and add this to your regression list? Thanks! Since commit 38f1cff From: Dave Airlie Date: Wed, 16 Mar 2011 11:34:41 +1000 Subject: [PATCH] Merge commit '5359533801e3dd3abca5b7d3d985b0b33fd9fe8b' into dr This commit changed an internal radeon structure, that meant a new driver in -next had to be fixed up, merge in the commit and fix up the driver. Also fixes a trivial nouveau merge. Conflicts: drivers/gpu/drm/nouveau/nouveau_mem.c booting my atom/NM10/ION2 system crashes hard during boot, right after blanking the screen, and before the initramfs gets loaded. I just re-checked: both parent commits ( 5359533 and 4819d2e ) do indeed work just fine, but the merge commit ( 38f1cff ) fails, same as tip ( 85f2e68 ). My previous reports (Apr 03, Apr 07) seem to have gotten lost (or ignored, or both). Best, Dominik
Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 5:09 PM, Joerg Roedel wrote: > On Thu, Apr 14, 2011 at 10:28:43AM -0400, Alex Deucher wrote: >> On Thu, Apr 14, 2011 at 4:56 AM, Joerg Roedel wrote: >> > And this makes a difference, with this change on-top of -rc3 the box boots >> > fine. So there seems to be some dependency between the GART base and the >> > GTT >> > base even when they are in different address spaces. >> > >> > Alex, can you comment on this? >> >> As Dave said, they are completely different addresses spaces. ?You >> could put the GPU aperture at 0 if you wanted (in fact we do on some >> chips). ?Perhaps there's some strange interaction with the nb gart >> since the nb gart on that chipset was designed to be used for graphics >> and the rs780/880 can be configured to use an agp aperture. >> Unfortunately, I'm not that familiar with the nb gart. > > Actually, the nb gart is part of the cpu. It is part of the cpu north > bridge and can translate io and cpu accesses. In fact, it is a remapper > of physical memory addresses. I know what it's for. In the IGP graphics chip is also part of the north bridge, but it may not be related at all. > > The problem seems to be related to specific gpu chips. On another > notebook with an hd3000 card gtt and the nb gart aperture are both on > 0xa000 too but the box works fine. I havn't tested with an hd5000 > yet. The failing notebook has an hd4200 mobility. What exact model is the hd3000? Is it IGP GPU or a discrete GPU? It it's an IGP, it's identical to the hd4200 programming-wise. > > Btw. what happens if the gpu accesses an unmapped address in the gtt > range? It's redirected to a dummy page. Alex
[PATCH] drm/radeon/kms: add connectors even if i2c fails
Sometimes the i2c test in i2c_bit_add_bus fails
if this happens we fail to register the i2c adapter and
eventually fail to add the connector. If i2c fails,
add the connector to the user can at least force
it on.
Note that some distros set i2c-algo-bit.bit_test to 1 by
default which sometimes fails preventing the ddc i2c adapter
from being added. The i2c adapter works even if the bit test
fails, probably due to pre/post_xfer not getting called in
the test_bit function. I have another patch to follow
up on that.
See:
https://bugs.freedesktop.org/show_bug.cgi?id=36221
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_connectors.c | 29 +++
drivers/gpu/drm/radeon/radeon_i2c.c|6 +
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
b/drivers/gpu/drm/radeon/radeon_connectors.c
index 2ef6d51..5f45fa1 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1199,7 +1199,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (router->ddc_valid || router->cd_valid) {
radeon_connector->router_bus = radeon_i2c_lookup(rdev,
&router->i2c_info);
if (!radeon_connector->router_bus)
- goto failed;
+ DRM_ERROR("Failed to assign router i2c bus! Check dmesg
for i2c errors.\n");
}
switch (connector_type) {
case DRM_MODE_CONNECTOR_VGA:
@@ -1208,7 +1208,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("VGA: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
radeon_connector->dac_load_detect = true;
drm_connector_attach_property(&radeon_connector->base,
@@ -1226,7 +1226,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DVIA: Failed to assign ddc bus!
Check dmesg for i2c errors.\n");
}
radeon_connector->dac_load_detect = true;
drm_connector_attach_property(&radeon_connector->base,
@@ -1249,7 +1249,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DVI: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
subpixel_order = SubPixelHorizontalRGB;
drm_connector_attach_property(&radeon_connector->base,
@@ -1290,7 +1290,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("HDMI: Failed to assign ddc bus!
Check dmesg for i2c errors.\n");
}
drm_connector_attach_property(&radeon_connector->base,
rdev->mode_info.coherent_mode_property,
@@ -1329,10 +1329,10 @@ radeon_add_atom_connector(struct drm_device *dev,
else
radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
if (!radeon_dig_connector->dp_i2c_bus)
- goto failed;
+ DRM_ERROR("DP: Failed to assign dp ddc bus!
Check dmesg for i2c errors.\n");
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DP: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
subpixel_order = SubPixelHorizontalRGB;
drm_connector_attach_property(&radeon_connector->base,
@@ -1381,7 +1381,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("LVDS: Failed to assign
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #40 from revealed 2011-04-14 16:58:21 PDT --- wow ok. Then i will keep the patch and cleanup the source. Many thanks for all your help. I will go to bed now. It is close to two o clock in the morning in my place. Thank you very much once more :D -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #40 from revealed 2011-04-14 16:58:21 PDT --- wow ok. Then i will keep the patch and cleanup the source. Many thanks for all your help. I will go to bed now. It is close to two o clock in the morning in my place. Thank you very much once more :D -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #39 from Alex Deucher 2011-04-14 16:53:01 PDT --- (In reply to comment #38) > (In reply to comment #37) > > Whats next for me? > > > > Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? > > I've sent the patch to the linux i2c list to be hopefully applied upstream. > It's up to the distros to pick up the patch in the meantime. Or they can set i2c-algo-bit.bit_test=0 in the interim. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #39 from Alex Deucher 2011-04-14 16:53:01 PDT --- (In reply to comment #38) > (In reply to comment #37) > > Whats next for me? > > > > Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? > > I've sent the patch to the linux i2c list to be hopefully applied upstream. > It's up to the distros to pick up the patch in the meantime. Or they can set i2c-algo-bit.bit_test=0 in the interim. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #38 from Alex Deucher 2011-04-14 16:52:11 PDT --- (In reply to comment #37) > Whats next for me? > > Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? I've sent the patch to the linux i2c list to be hopefully applied upstream. It's up to the distros to pick up the patch in the meantime. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #38 from Alex Deucher 2011-04-14 16:52:11 PDT --- (In reply to comment #37) > Whats next for me? > > Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? I've sent the patch to the linux i2c list to be hopefully applied upstream. It's up to the distros to pick up the patch in the meantime. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #37 from revealed 2011-04-14 16:48:54 PDT --- Whats next for me? Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #37 from revealed 2011-04-14 16:48:54 PDT --- Whats next for me? Can i run make clean all on /usr/src/linux-2x? And wait for an Update`? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] i2c-algo-bit: make sure to call pre/post_xfer for bit_test
Apparently some distros set i2c-algo-bit.bit_test to 1 by
default. In some cases this causes i2c_bit_add_bus
to fail and prevents the i2c bus from being added. In the
radeon case, we fail to add the ddc i2c buses which prevents
the driver from being able to detect attached monitors.
The i2c bus works fine even if bit_test fails. This is likely
due to gpio switching that is required and handled in the
pre/post_xfer hooks, so call the pre/post_xfer hooks in the
bit test as well.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=36221
Cc: Jean Delvare
Signed-off-by: Alex Deucher
---
drivers/i2c/algos/i2c-algo-bit.c | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index 38319a6..e2740e6 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -232,9 +232,16 @@ static int i2c_inb(struct i2c_adapter *i2c_adap)
* Sanity check for the adapter hardware - check the reaction of
* the bus lines only if it seems to be idle.
*/
-static int test_bus(struct i2c_algo_bit_data *adap, char *name)
+static int test_bus(struct i2c_adapter *i2c_adap, char *name)
{
- int scl, sda;
+ struct i2c_algo_bit_data *adap = i2c_adap->algo_data;
+ int scl, sda, ret;
+
+ if (adap->pre_xfer) {
+ ret = adap->pre_xfer(i2c_adap);
+ if (ret < 0)
+ return -ENODEV;
+ }
if (adap->getscl == NULL)
pr_info("%s: Testing SDA only, SCL is not readable\n", name);
@@ -297,11 +304,19 @@ static int test_bus(struct i2c_algo_bit_data *adap, char
*name)
"while pulling SCL high!\n", name);
goto bailout;
}
+
+ if (adap->post_xfer)
+ adap->post_xfer(i2c_adap);
+
pr_info("%s: Test OK\n", name);
return 0;
bailout:
sdahi(adap);
sclhi(adap);
+
+ if (adap->post_xfer)
+ adap->post_xfer(i2c_adap);
+
return -ENODEV;
}
@@ -607,7 +622,7 @@ static int __i2c_bit_add_bus(struct i2c_adapter *adap,
int ret;
if (bit_test) {
- ret = test_bus(bit_adap, adap->name);
+ ret = test_bus(adap, adap->name);
if (ret < 0)
return -ENODEV;
}
--
1.7.1.1
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #36 from Alex Deucher 2011-04-14 16:44:28 PDT --- (In reply to comment #35) > Seems to work fine! Great! thanks for testing. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #36 from Alex Deucher 2011-04-14 16:44:28 PDT --- (In reply to comment #35) > Seems to work fine! Great! thanks for testing. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #35 from revealed 2011-04-14 16:38:08 PDT --- Seems to work fine! disk@wild-thing:~> grep command /var/log/boot.msg <5>[0.00] Kernel command line: root=/dev/sdc6 resume=/dev/sdc5 splash=silent disk@wild-thing:~> dmesg | grep i2c [8.316773] ivtv0: Reopen i2c bus for IR-blaster support [8.522473] cx25840 5-0044: cx25843-23 found @ 0x88 (ivtv i2c driver #0) [8.656997] tuner 5-0061: chip found @ 0xc2 (ivtv i2c driver #0) [8.889160] wm8775 5-001b: chip found @ 0x36 (ivtv i2c driver #0) [ 29.856130] input: i2c IR (Hauppauge WinTV PVR-150 as /devices/virtual/rc/rc0/input6 [ 29.856207] rc0: i2c IR (Hauppauge WinTV PVR-150 as /devices/virtual/rc/rc0 [ 29.856210] ir-kbd-i2c: i2c IR (Hauppauge WinTV PVR-150 detected at i2c-5/5-0071/ir0 [ivtv i2c driver #0] disk@wild-thing:~> dmesg | grep drm [2.461044] [drm] Initialized drm 1.1.0 20060810 [2.513747] [drm] radeon defaulting to kernel modesetting. [2.513801] [drm] radeon kernel modesetting enabled. [2.515575] [drm] initializing kernel modesetting (R580 0x1002:0x7240). [2.515685] [drm] register mmio base: 0xFF7F [2.515733] [drm] register mmio size: 65536 [2.517031] [drm] Generation 2 PCI interface, using max accessible memory [2.517335] [drm] radeon: irq initialized. [2.517455] [drm] Detected VRAM RAM=512M, BAR=256M [2.517502] [drm] RAM width 256bits DDR [2.517739] [drm] radeon: 512M of VRAM memory ready [2.517786] [drm] radeon: 512M of GTT memory ready. [2.517845] [drm] GART: num cpu pages 131072, num gpu pages 131072 [2.519502] [drm] radeon: 4 quad pipes, 1 z pipes initialized. [2.520495] [drm] PCIE GART of 512M enabled (table at 0x0004). [2.520643] [drm] Loading R500 Microcode [2.522154] [drm] radeon: ring at 0x20001000 [2.55] [drm] ring test succeeded in 3 usecs [2.522411] [drm] radeon: ib pool ready. [2.522519] [drm] ib test succeeded in 0 usecs [2.523408] [drm] Radeon Display Connectors [2.523456] [drm] Connector 0: [2.523502] [drm] DVI-I [2.523568] [drm] HPD2 [2.523621] [drm] DDC: 0x7e40 0x7e40 0x7e44 0x7e44 0x7e48 0x7e48 0x7e4c 0x7e4c [2.523709] [drm] Encoders: [2.523762] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [2.523809] [drm] DFP3: INTERNAL_LVTM1 [2.523874] [drm] Connector 1: [2.523926] [drm] S-video [2.523972] [drm] Encoders: [2.524050] [drm] TV1: INTERNAL_KLDSCP_DAC2 [2.524104] [drm] Connector 2: [2.524150] [drm] DVI-I [2.524214] [drm] HPD1 [2.524267] [drm] DDC: 0x7e50 0x7e50 0x7e54 0x7e54 0x7e58 0x7e58 0x7e5c 0x7e5c [2.524354] [drm] Encoders: [2.524407] [drm] CRT2: INTERNAL_KLDSCP_DAC2 [2.524454] [drm] DFP1: INTERNAL_KLDSCP_TMDS1 [2.636077] [drm] Possible lm64 thermal controller at 0x18 [2.636172] [drm] radeon: power management initialized [2.762666] [drm] fb mappable at 0xC00C [2.762722] [drm] vram apper at 0xC000 [2.762775] [drm] size 9216000 [2.762827] [drm] fb depth is 24 [2.762879] [drm]pitch is 7680 [2.775905] fb0: radeondrmfb frame buffer device [2.775926] drm: registered panic notifier [2.775949] [drm] Initialized radeon 2.7.0 20080528 for :01:00.0 on minor 0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #35 from revealed 2011-04-14 16:38:08 PDT --- Seems to work fine! disk at wild-thing:~> grep command /var/log/boot.msg <5>[0.00] Kernel command line: root=/dev/sdc6 resume=/dev/sdc5 splash=silent disk at wild-thing:~> dmesg | grep i2c [8.316773] ivtv0: Reopen i2c bus for IR-blaster support [8.522473] cx25840 5-0044: cx25843-23 found @ 0x88 (ivtv i2c driver #0) [8.656997] tuner 5-0061: chip found @ 0xc2 (ivtv i2c driver #0) [8.889160] wm8775 5-001b: chip found @ 0x36 (ivtv i2c driver #0) [ 29.856130] input: i2c IR (Hauppauge WinTV PVR-150 as /devices/virtual/rc/rc0/input6 [ 29.856207] rc0: i2c IR (Hauppauge WinTV PVR-150 as /devices/virtual/rc/rc0 [ 29.856210] ir-kbd-i2c: i2c IR (Hauppauge WinTV PVR-150 detected at i2c-5/5-0071/ir0 [ivtv i2c driver #0] disk at wild-thing:~> dmesg | grep drm [2.461044] [drm] Initialized drm 1.1.0 20060810 [2.513747] [drm] radeon defaulting to kernel modesetting. [2.513801] [drm] radeon kernel modesetting enabled. [2.515575] [drm] initializing kernel modesetting (R580 0x1002:0x7240). [2.515685] [drm] register mmio base: 0xFF7F [2.515733] [drm] register mmio size: 65536 [2.517031] [drm] Generation 2 PCI interface, using max accessible memory [2.517335] [drm] radeon: irq initialized. [2.517455] [drm] Detected VRAM RAM=512M, BAR=256M [2.517502] [drm] RAM width 256bits DDR [2.517739] [drm] radeon: 512M of VRAM memory ready [2.517786] [drm] radeon: 512M of GTT memory ready. [2.517845] [drm] GART: num cpu pages 131072, num gpu pages 131072 [2.519502] [drm] radeon: 4 quad pipes, 1 z pipes initialized. [2.520495] [drm] PCIE GART of 512M enabled (table at 0x0004). [2.520643] [drm] Loading R500 Microcode [2.522154] [drm] radeon: ring at 0x20001000 [2.55] [drm] ring test succeeded in 3 usecs [2.522411] [drm] radeon: ib pool ready. [2.522519] [drm] ib test succeeded in 0 usecs [2.523408] [drm] Radeon Display Connectors [2.523456] [drm] Connector 0: [2.523502] [drm] DVI-I [2.523568] [drm] HPD2 [2.523621] [drm] DDC: 0x7e40 0x7e40 0x7e44 0x7e44 0x7e48 0x7e48 0x7e4c 0x7e4c [2.523709] [drm] Encoders: [2.523762] [drm] CRT1: INTERNAL_KLDSCP_DAC1 [2.523809] [drm] DFP3: INTERNAL_LVTM1 [2.523874] [drm] Connector 1: [2.523926] [drm] S-video [2.523972] [drm] Encoders: [2.524050] [drm] TV1: INTERNAL_KLDSCP_DAC2 [2.524104] [drm] Connector 2: [2.524150] [drm] DVI-I [2.524214] [drm] HPD1 [2.524267] [drm] DDC: 0x7e50 0x7e50 0x7e54 0x7e54 0x7e58 0x7e58 0x7e5c 0x7e5c [2.524354] [drm] Encoders: [2.524407] [drm] CRT2: INTERNAL_KLDSCP_DAC2 [2.524454] [drm] DFP1: INTERNAL_KLDSCP_TMDS1 [2.636077] [drm] Possible lm64 thermal controller at 0x18 [2.636172] [drm] radeon: power management initialized [2.762666] [drm] fb mappable at 0xC00C [2.762722] [drm] vram apper at 0xC000 [2.762775] [drm] size 9216000 [2.762827] [drm] fb depth is 24 [2.762879] [drm]pitch is 7680 [2.775905] fb0: radeondrmfb frame buffer device [2.775926] drm: registered panic notifier [2.775949] [drm] Initialized radeon 2.7.0 20080528 for :01:00.0 on minor 0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #34 from revealed 2011-04-14 16:33:22 PDT --- Will reboot and test now! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #34 from revealed 2011-04-14 16:33:22 PDT --- Will reboot and test now! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #33 from revealed 2011-04-14 16:11:04 PDT --- Yes i will... make is still processing at net/xy ... i guess this will take some time. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #33 from revealed 2011-04-14 16:11:04 PDT --- Yes i will... make is still processing at net/xy ... i guess this will take some time. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #32 from Alex Deucher 2011-04-14 16:09:29 PDT --- (In reply to comment #31) > So if i ignore this now, i can continue with: > > make modules > make modules_install > make install > and select the new kernel in grub. > > And it should work? yes. make sure you remove i2c-algo-bit.bit_test=0 from your grub config when testing it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #32 from Alex Deucher 2011-04-14 16:09:29 PDT --- (In reply to comment #31) > So if i ignore this now, i can continue with: > > make modules > make modules_install > make install > and select the new kernel in grub. > > And it should work? yes. make sure you remove i2c-algo-bit.bit_test=0 from your grub config when testing it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] drm/radeon/kms: adjust evergreen display watermark setup
This patch fixes two issues:
- A disabled crtc does not use any lb, so return 0 for
lb size. This makes the display priority calculation
more exact.
- Only use 1/2 and whole lb partitions. Using smaller
partitions can cause underflow to one of the displays
if you have multiple large displays on the same lb.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=34534
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/evergreen.c | 89 ++--
1 files changed, 44 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/radeon/evergreen.c
b/drivers/gpu/drm/radeon/evergreen.c
index 5f057b8..11d1578 100644
--- a/drivers/gpu/drm/radeon/evergreen.c
+++ b/drivers/gpu/drm/radeon/evergreen.c
@@ -371,7 +371,7 @@ static u32 evergreen_line_buffer_adjust(struct
radeon_device *rdev,
struct drm_display_mode *mode,
struct drm_display_mode *other_mode)
{
- u32 tmp = 0;
+ u32 tmp;
/*
* Line Buffer Setup
* There are 3 line buffers, each one shared by 2 display controllers.
@@ -381,64 +381,63 @@ static u32 evergreen_line_buffer_adjust(struct
radeon_device *rdev,
* first display controller
* 0 - first half of lb (3840 * 2)
* 1 - first 3/4 of lb (5760 * 2)
-* 2 - whole lb (7680 * 2)
+* 2 - whole lb (7680 * 2), other crtc must be disabled
* 3 - first 1/4 of lb (1920 * 2)
* second display controller
* 4 - second half of lb (3840 * 2)
* 5 - second 3/4 of lb (5760 * 2)
-* 6 - whole lb (7680 * 2)
+* 6 - whole lb (7680 * 2), other crtc must be disabled
* 7 - last 1/4 of lb (1920 * 2)
*/
- if (mode && other_mode) {
- if (mode->hdisplay > other_mode->hdisplay) {
- if (mode->hdisplay > 2560)
- tmp = 1; /* 3/4 */
- else
- tmp = 0; /* 1/2 */
- } else if (other_mode->hdisplay > mode->hdisplay) {
- if (other_mode->hdisplay > 2560)
- tmp = 3; /* 1/4 */
- else
- tmp = 0; /* 1/2 */
- } else
+ /* this can get tricky if we have two large displays on a paired group
+* of crtcs. Ideally for multiple large displays we'd assign them to
+* non-linked crtcs for maximum line buffer allocation.
+*/
+ if (radeon_crtc->base.enabled && mode) {
+ if (other_mode)
tmp = 0; /* 1/2 */
- } else if (mode)
- tmp = 2; /* whole */
- else if (other_mode)
- tmp = 3; /* 1/4 */
+ else
+ tmp = 2; /* whole */
+ } else
+ tmp = 0;
/* second controller of the pair uses second half of the lb */
if (radeon_crtc->crtc_id % 2)
tmp += 4;
WREG32(DC_LB_MEMORY_SPLIT + radeon_crtc->crtc_offset, tmp);
- switch (tmp) {
- case 0:
- case 4:
- default:
- if (ASIC_IS_DCE5(rdev))
- return 4096 * 2;
- else
- return 3840 * 2;
- case 1:
- case 5:
- if (ASIC_IS_DCE5(rdev))
- return 6144 * 2;
- else
- return 5760 * 2;
- case 2:
- case 6:
- if (ASIC_IS_DCE5(rdev))
- return 8192 * 2;
- else
- return 7680 * 2;
- case 3:
- case 7:
- if (ASIC_IS_DCE5(rdev))
- return 2048 * 2;
- else
- return 1920 * 2;
+ if (radeon_crtc->base.enabled && mode) {
+ switch (tmp) {
+ case 0:
+ case 4:
+ default:
+ if (ASIC_IS_DCE5(rdev))
+ return 4096 * 2;
+ else
+ return 3840 * 2;
+ case 1:
+ case 5:
+ if (ASIC_IS_DCE5(rdev))
+ return 6144 * 2;
+ else
+ return 5760 * 2;
+ case 2:
+ case 6:
+ if (ASIC_IS_DCE5(rdev))
+ return 8192 * 2;
+ else
+ return 7680 * 2;
+ case 3:
+ case 7:
+ if (ASIC_IS_DCE5(rdev))
+ return 2048 * 2;
+ else
+ return 1920 * 2;
+ }
}
+
+ /* controller not enabled, so no lb used */
+ return 0;
}
static u32 evergreen_get_number_of
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #31 from revealed 2011-04-14 16:06:56 PDT --- So if i ignore this now, i can continue with: make modules make modules_install make install and select the new kernel in grub. And it should work? greetings, R -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #31 from revealed 2011-04-14 16:06:56 PDT --- So if i ignore this now, i can continue with: make modules make modules_install make install and select the new kernel in grub. And it should work? greetings, R -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 34534] resolution 3840x1024 stopped to work on HD5850 after switch to 2.6.37 kernel
https://bugs.freedesktop.org/show_bug.cgi?id=34534 --- Comment #19 from Alex Deucher 2011-04-14 16:06:19 PDT --- (In reply to comment #18) > (In reply to comment #17) > > Does this patch help? > > Yes, this patch works. 0x770c is set to the right value now. > 0x7718 and 0x771c are different than before too but that is probably intended. Yes. > Here they are: > 0x0c000x00030002 (196610) > 0x0c040x2e985963 (781736291) > 0x77180x00100024 (1048612) > 0x771c0x00100024 (1048612) > 0x770c0x00020004 (131076) > > Thanks for fixing this. No problem. Sorry it took so long. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 34534] resolution 3840x1024 stopped to work on HD5850 after switch to 2.6.37 kernel
https://bugs.freedesktop.org/show_bug.cgi?id=34534 --- Comment #19 from Alex Deucher 2011-04-14 16:06:19 PDT --- (In reply to comment #18) > (In reply to comment #17) > > Does this patch help? > > Yes, this patch works. 0x770c is set to the right value now. > 0x7718 and 0x771c are different than before too but that is probably intended. Yes. > Here they are: > 0x0c000x00030002 (196610) > 0x0c040x2e985963 (781736291) > 0x77180x00100024 (1048612) > 0x771c0x00100024 (1048612) > 0x770c0x00020004 (131076) > > Thanks for fixing this. No problem. Sorry it took so long. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #30 from Alex Deucher 2011-04-14 16:05:09 PDT --- (In reply to comment #28) > With this patch i get: > > drivers/i2c/algos/i2c-algo-bit.c: In Funktion »i2c_bit_prepare_bus«: > drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable »bit_adap« wird > nicht verwendet > > --- Make continues??? you can ignore it or remove this line in i2c_bit_prepare_bus(): struct i2c_algo_bit_data *bit_adap = adap->algo_data; It's just saying the variable is unused. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #30 from Alex Deucher 2011-04-14 16:05:09 PDT --- (In reply to comment #28) > With this patch i get: > > drivers/i2c/algos/i2c-algo-bit.c: In Funktion ?i2c_bit_prepare_bus?: > drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable ?bit_adap? wird > nicht verwendet > > --- Make continues??? you can ignore it or remove this line in i2c_bit_prepare_bus(): struct i2c_algo_bit_data *bit_adap = adap->algo_data; It's just saying the variable is unused. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 32982] Kernel locks up a few minutes after boot
https://bugzilla.kernel.org/show_bug.cgi?id=32982 --- Comment #7 from Bart Van Assche 2011-04-14 15:57:40 --- Still occurs with 85f2e689a5c8fb6ed8fdbee00109e7f6e5fefcb6 (2.6.29-rc3+). Note: I'm still trying to find the offending commit via bisecting. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list Dri-devel at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #4 from Turo Lamminen 2011-04-14 15:47:42 PDT --- Something useful for you guys: 1. Back up the original executables and shaders (in data/shader/cg/) 2. Grab this: http://alternativegames.net/temp/trineUnofficialBeta.tar.bz2 This build is UNOFFICIAL and UNSUPPORTED. Don't get it unless you know you need it. 3. There's some better logging on shader errors. Post new logs, including log from the game ~/.frozenbyte/trine/logs/log.txt -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #4 from Turo Lamminen 2011-04-14 15:47:42 PDT --- Something useful for you guys: 1. Back up the original executables and shaders (in data/shader/cg/) 2. Grab this: http://alternativegames.net/temp/trineUnofficialBeta.tar.bz2 This build is UNOFFICIAL and UNSUPPORTED. Don't get it unless you know you need it. 3. There's some better logging on shader errors. Post new logs, including log from the game ~/.frozenbyte/trine/logs/log.txt -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 34534] resolution 3840x1024 stopped to work on HD5850 after switch to 2.6.37 kernel
https://bugs.freedesktop.org/show_bug.cgi?id=34534 --- Comment #18 from Peter Hercek 2011-04-14 15:44:43 PDT --- (In reply to comment #17) > Does this patch help? Yes, this patch works. 0x770c is set to the right value now. 0x7718 and 0x771c are different than before too but that is probably intended. Here they are: 0x0c000x00030002 (196610) 0x0c040x2e985963 (781736291) 0x77180x00100024 (1048612) 0x771c0x00100024 (1048612) 0x770c0x00020004 (131076) Thanks for fixing this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 34534] resolution 3840x1024 stopped to work on HD5850 after switch to 2.6.37 kernel
https://bugs.freedesktop.org/show_bug.cgi?id=34534 --- Comment #18 from Peter Hercek 2011-04-14 15:44:43 PDT --- (In reply to comment #17) > Does this patch help? Yes, this patch works. 0x770c is set to the right value now. 0x7718 and 0x771c are different than before too but that is probably intended. Here they are: 0x0c000x00030002 (196610) 0x0c040x2e985963 (781736291) 0x77180x00100024 (1048612) 0x771c0x00100024 (1048612) 0x770c0x00020004 (131076) Thanks for fixing this. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #29 from revealed 2011-04-14 15:39:05 PDT --- I am always patching a fresh copy of i2c-algo-bit.c from SuSE rpm; ?? Is this correct? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #28 from revealed 2011-04-14 15:37:54 PDT --- With this patch i get: drivers/i2c/algos/i2c-algo-bit.c: In Funktion »i2c_bit_prepare_bus«: drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable »bit_adap« wird nicht verwendet --- Make continues??? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #29 from revealed 2011-04-14 15:39:05 PDT --- I am always patching a fresh copy of i2c-algo-bit.c from SuSE rpm; ?? Is this correct? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #28 from revealed 2011-04-14 15:37:54 PDT --- With this patch i get: drivers/i2c/algos/i2c-algo-bit.c: In Funktion ?i2c_bit_prepare_bus?: drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable ?bit_adap? wird nicht verwendet --- Make continues??? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Attachment #45636|text/x-csrc |text/plain mime type|| Attachment #45636|0 |1 is patch|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #27 from Alex Deucher 2011-04-14 15:31:11 PDT --- Created an attachment (id=45637) View: https://bugs.freedesktop.org/attachment.cgi?id=45637 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45637 2.6.37 patch looks like the file changed slightly in newer kernels. Try this patch. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Attachment #45636|text/x-csrc |text/plain mime type|| Attachment #45636|0 |1 is patch|| -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #27 from Alex Deucher 2011-04-14 15:31:11 PDT --- Created an attachment (id=45637) View: https://bugs.freedesktop.org/attachment.cgi?id=45637 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45637 2.6.37 patch looks like the file changed slightly in newer kernels. Try this patch. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #26 from revealed 2011-04-14 15:27:06 PDT --- Created an attachment (id=45636) --> (https://bugs.freedesktop.org/attachment.cgi?id=45636) i2c-algo-bit.c from SuSE rpm; ?? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #26 from revealed 2011-04-14 15:27:06 PDT --- Created an attachment (id=45636) --> (https://bugs.freedesktop.org/attachment.cgi?id=45636) i2c-algo-bit.c from SuSE rpm; ?? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #25 from revealed 2011-04-14 15:21:32 PDT --- But if i run make with this file, i get: CC [M] drivers/i2c/algos/i2c-algo-bit.o drivers/i2c/algos/i2c-algo-bit.c: In Funktion »i2c_bit_prepare_bus«: drivers/i2c/algos/i2c-algo-bit.c:623:3: Warnung: Übergabe des Arguments 1 von »test_bus« von inkompatiblem Zeigertyp drivers/i2c/algos/i2c-algo-bit.c:235:12: Anmerkung: expected »struct i2c_adapter *« but argument is of type »struct i2c_algo_bit_data *« CC [M] drivers/i2c/algos/i2c-algo-pca.o LD drivers/i2c/busses/built-in.o And it continues. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #25 from revealed 2011-04-14 15:21:32 PDT --- But if i run make with this file, i get: CC [M] drivers/i2c/algos/i2c-algo-bit.o drivers/i2c/algos/i2c-algo-bit.c: In Funktion ?i2c_bit_prepare_bus?: drivers/i2c/algos/i2c-algo-bit.c:623:3: Warnung: ?bergabe des Arguments 1 von ?test_bus? von inkompatiblem Zeigertyp drivers/i2c/algos/i2c-algo-bit.c:235:12: Anmerkung: expected ?struct i2c_adapter *? but argument is of type ?struct i2c_algo_bit_data *? CC [M] drivers/i2c/algos/i2c-algo-pca.o LD drivers/i2c/busses/built-in.o And it continues. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #24 from revealed 2011-04-14 15:20:03 PDT
---
Starting new with the downloaded patch and the original file from SUSE rpm i
get the following output in the rej. file when issuing the:
Patch command: (forget my last both postings, please).
--- drivers/i2c/algos/i2c-algo-bit.c
+++ drivers/i2c/algos/i2c-algo-bit.c
@@ -622,7 +637,7 @@
int ret;
if (bit_test) {
- ret = test_bus(bit_adap, adap->name);
+ ret = test_bus(adap, adap->name);
if (ret < 0)
return -ENODEV;
}
drivers/i2c/algos/i2c-algo-bit.c.rej lines 1-11/11 (END)
I guess there is something wrong with the patch?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #24 from revealed 2011-04-14 15:20:03
PDT ---
Starting new with the downloaded patch and the original file from SUSE rpm i
get the following output in the rej. file when issuing the:
Patch command: (forget my last both postings, please).
--- drivers/i2c/algos/i2c-algo-bit.c
+++ drivers/i2c/algos/i2c-algo-bit.c
@@ -622,7 +637,7 @@
int ret;
if (bit_test) {
- ret = test_bus(bit_adap, adap->name);
+ ret = test_bus(adap, adap->name);
if (ret < 0)
return -ENODEV;
}
drivers/i2c/algos/i2c-algo-bit.c.rej lines 1-11/11 (END)
I guess there is something wrong with the patch?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #23 from revealed 2011-04-14 15:16:35 PDT --- patch -p1 -i 0001-i2c-algo-bit-make-sure-to-call-pre-post_xfer-for-bit.patch patching file drivers/i2c/algos/i2c-algo-bit.c Hunk #1 FAILED at 232. Hunk #2 FAILED at 297. Hunk #3 FAILED at 607. 3 out of 3 hunks FAILED -- saving rejects to file drivers/i2c/algos/i2c-algo-bit.c.rej -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #23 from revealed 2011-04-14 15:16:35 PDT --- patch -p1 -i 0001-i2c-algo-bit-make-sure-to-call-pre-post_xfer-for-bit.patch patching file drivers/i2c/algos/i2c-algo-bit.c Hunk #1 FAILED at 232. Hunk #2 FAILED at 297. Hunk #3 FAILED at 607. 3 out of 3 hunks FAILED -- saving rejects to file drivers/i2c/algos/i2c-algo-bit.c.rej -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #22 from revealed 2011-04-14 15:05:08 PDT --- drivers/i2c/algos/i2c-algo-bit.c: In Funktion »test_bus«: drivers/i2c/algos/i2c-algo-bit.c:237:28: Fehler: »adap« als andere Symbolart redeklariert drivers/i2c/algos/i2c-algo-bit.c:235:47: Anmerkung: Vorherige Definition von »adap« war hier drivers/i2c/algos/i2c-algo-bit.c:237:35: Fehler: »i2c_adap« undeclared (first use in this function) drivers/i2c/algos/i2c-algo-bit.c:237:35: Anmerkung: each undeclared identifier is reported only once for each function it appears in drivers/i2c/algos/i2c-algo-bit.c: In Funktion »i2c_bit_prepare_bus«: drivers/i2c/algos/i2c-algo-bit.c:623:3: Warnung: Übergabe des Arguments 1 von »test_bus« von inkompatiblem Zeigertyp drivers/i2c/algos/i2c-algo-bit.c:235:12: Anmerkung: expected »struct i2c_algo_bit_data *« but argument is of type »struct i2c_adapter *« drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable »bit_adap« wird nicht verwendet make[3]: *** [drivers/i2c/algos/i2c-algo-bit.o] Error 1 make[2]: *** [drivers/i2c/algos] Error 2 make[1]: *** [drivers/i2c] Error 2 make: *** [drivers] Fehler 2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #22 from revealed 2011-04-14 15:05:08 PDT --- drivers/i2c/algos/i2c-algo-bit.c: In Funktion ?test_bus?: drivers/i2c/algos/i2c-algo-bit.c:237:28: Fehler: ?adap? als andere Symbolart redeklariert drivers/i2c/algos/i2c-algo-bit.c:235:47: Anmerkung: Vorherige Definition von ?adap? war hier drivers/i2c/algos/i2c-algo-bit.c:237:35: Fehler: ?i2c_adap? undeclared (first use in this function) drivers/i2c/algos/i2c-algo-bit.c:237:35: Anmerkung: each undeclared identifier is reported only once for each function it appears in drivers/i2c/algos/i2c-algo-bit.c: In Funktion ?i2c_bit_prepare_bus?: drivers/i2c/algos/i2c-algo-bit.c:623:3: Warnung: ?bergabe des Arguments 1 von ?test_bus? von inkompatiblem Zeigertyp drivers/i2c/algos/i2c-algo-bit.c:235:12: Anmerkung: expected ?struct i2c_algo_bit_data *? but argument is of type ?struct i2c_adapter *? drivers/i2c/algos/i2c-algo-bit.c:620:28: Warnung: Variable ?bit_adap? wird nicht verwendet make[3]: *** [drivers/i2c/algos/i2c-algo-bit.o] Error 1 make[2]: *** [drivers/i2c/algos] Error 2 make[1]: *** [drivers/i2c] Error 2 make: *** [drivers] Fehler 2 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #21 from revealed 2011-04-14 14:44:09 PDT --- I did: make oldconfig now i am running make? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #21 from revealed 2011-04-14 14:44:09 PDT --- I did: make oldconfig now i am running make? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #20 from revealed 2011-04-14 14:41:15 PDT --- done! Will proceed with steps from comment 17. Greetings, -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #20 from revealed 2011-04-14 14:41:15 PDT --- done! Will proceed with steps from comment 17. Greetings, -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #19 from Alex Deucher 2011-04-14 14:39:07 PDT ---
(In reply to comment #18)
> Ok i will do but i have one question:
>
> The last line to add from the diff looks different in my version:
>
> My Version says:
>
> if (bit_test) {
> int ret = test_bus(bit_adap, adap->name);
> if (ret < 0)
> return -ENODEV;
> }
>
>
> Do i have to remove the 'int' too?
>
in your case keep it. Change it to:
int ret = test_bus(adap, adap->name);
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #19 from Alex Deucher 2011-04-14 14:39:07 PDT
---
(In reply to comment #18)
> Ok i will do but i have one question:
>
> The last line to add from the diff looks different in my version:
>
> My Version says:
>
> if (bit_test) {
> int ret = test_bus(bit_adap, adap->name);
> if (ret < 0)
> return -ENODEV;
> }
>
>
> Do i have to remove the 'int' too?
>
in your case keep it. Change it to:
int ret = test_bus(adap, adap->name);
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #18 from revealed 2011-04-14 14:34:47 PDT
---
Ok i will do but i have one question:
The last line to add from the diff looks different in my version:
My Version says:
if (bit_test) {
int ret = test_bus(bit_adap, adap->name);
if (ret < 0)
return -ENODEV;
}
Do i have to remove the 'int' too?
Many thanks!
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 5:09 PM, Joerg Roedel wrote: > On Thu, Apr 14, 2011 at 10:28:43AM -0400, Alex Deucher wrote: >> On Thu, Apr 14, 2011 at 4:56 AM, Joerg Roedel wrote: >> > And this makes a difference, with this change on-top of -rc3 the box boots >> > fine. So there seems to be some dependency between the GART base and the >> > GTT >> > base even when they are in different address spaces. >> > >> > Alex, can you comment on this? >> >> As Dave said, they are completely different addresses spaces. You >> could put the GPU aperture at 0 if you wanted (in fact we do on some >> chips). Perhaps there's some strange interaction with the nb gart >> since the nb gart on that chipset was designed to be used for graphics >> and the rs780/880 can be configured to use an agp aperture. >> Unfortunately, I'm not that familiar with the nb gart. > > Actually, the nb gart is part of the cpu. It is part of the cpu north > bridge and can translate io and cpu accesses. In fact, it is a remapper > of physical memory addresses. I know what it's for. In the IGP graphics chip is also part of the north bridge, but it may not be related at all. > > The problem seems to be related to specific gpu chips. On another > notebook with an hd3000 card gtt and the nb gart aperture are both on > 0xa000 too but the box works fine. I havn't tested with an hd5000 > yet. The failing notebook has an hd4200 mobility. What exact model is the hd3000? Is it IGP GPU or a discrete GPU? It it's an IGP, it's identical to the hd4200 programming-wise. > > Btw. what happens if the gpu accesses an unmapped address in the gtt > range? It's redirected to a dummy page. Alex ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221
--- Comment #18 from revealed 2011-04-14 14:34:47
PDT ---
Ok i will do but i have one question:
The last line to add from the diff looks different in my version:
My Version says:
if (bit_test) {
int ret = test_bus(bit_adap, adap->name);
if (ret < 0)
return -ENODEV;
}
Do i have to remove the 'int' too?
Many thanks!
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #17 from Alex Deucher 2011-04-14 14:28:40 PDT --- (In reply to comment #16) > I would! > > Do i have to edit the file in: > /usr/src/linux-2.6.37.1-1.2/drivers/i2c/algos/i2c-algo-bit.c yes, just download the patch into /usr/src/linux-2.6.37.1-1.2/ and run: patch -p1 -i 0001-i2c-algo-bit-make-sure-to-call-pre-post_xfer-for-bit.patch > > And make the i2c-algo-bit somehow? I cant remember properly if i can recompile > a single module? I dont need to translate the whole kernel? > from /usr/src/linux-2.6.37.1-1.2/ run: make make modules make modules_install make install and select the new kernel in grub. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #17 from Alex Deucher 2011-04-14 14:28:40 PDT --- (In reply to comment #16) > I would! > > Do i have to edit the file in: > /usr/src/linux-2.6.37.1-1.2/drivers/i2c/algos/i2c-algo-bit.c yes, just download the patch into /usr/src/linux-2.6.37.1-1.2/ and run: patch -p1 -i 0001-i2c-algo-bit-make-sure-to-call-pre-post_xfer-for-bit.patch > > And make the i2c-algo-bit somehow? I cant remember properly if i can recompile > a single module? I dont need to translate the whole kernel? > from /usr/src/linux-2.6.37.1-1.2/ run: make make modules make modules_install make install and select the new kernel in grub. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[PATCH] drm/radeon/kms: add connectors even if i2c fails
Sometimes the i2c test in i2c_bit_add_bus fails
if this happens we fail to register the i2c adapter and
eventually fail to add the connector. If i2c fails,
add the connector to the user can at least force
it on.
Note that some distros set i2c-algo-bit.bit_test to 1 by
default which sometimes fails preventing the ddc i2c adapter
from being added. The i2c adapter works even if the bit test
fails, probably due to pre/post_xfer not getting called in
the test_bit function. I have another patch to follow
up on that.
See:
https://bugs.freedesktop.org/show_bug.cgi?id=36221
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/radeon/radeon_connectors.c | 29 +++
drivers/gpu/drm/radeon/radeon_i2c.c|6 +
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c
b/drivers/gpu/drm/radeon/radeon_connectors.c
index 2ef6d51..5f45fa1 100644
--- a/drivers/gpu/drm/radeon/radeon_connectors.c
+++ b/drivers/gpu/drm/radeon/radeon_connectors.c
@@ -1199,7 +1199,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (router->ddc_valid || router->cd_valid) {
radeon_connector->router_bus = radeon_i2c_lookup(rdev,
&router->i2c_info);
if (!radeon_connector->router_bus)
- goto failed;
+ DRM_ERROR("Failed to assign router i2c bus! Check dmesg
for i2c errors.\n");
}
switch (connector_type) {
case DRM_MODE_CONNECTOR_VGA:
@@ -1208,7 +1208,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("VGA: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
radeon_connector->dac_load_detect = true;
drm_connector_attach_property(&radeon_connector->base,
@@ -1226,7 +1226,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DVIA: Failed to assign ddc bus!
Check dmesg for i2c errors.\n");
}
radeon_connector->dac_load_detect = true;
drm_connector_attach_property(&radeon_connector->base,
@@ -1249,7 +1249,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DVI: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
subpixel_order = SubPixelHorizontalRGB;
drm_connector_attach_property(&radeon_connector->base,
@@ -1290,7 +1290,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("HDMI: Failed to assign ddc bus!
Check dmesg for i2c errors.\n");
}
drm_connector_attach_property(&radeon_connector->base,
rdev->mode_info.coherent_mode_property,
@@ -1329,10 +1329,10 @@ radeon_add_atom_connector(struct drm_device *dev,
else
radeon_dig_connector->dp_i2c_bus =
radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
if (!radeon_dig_connector->dp_i2c_bus)
- goto failed;
+ DRM_ERROR("DP: Failed to assign dp ddc bus!
Check dmesg for i2c errors.\n");
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("DP: Failed to assign ddc bus! Check
dmesg for i2c errors.\n");
}
subpixel_order = SubPixelHorizontalRGB;
drm_connector_attach_property(&radeon_connector->base,
@@ -1381,7 +1381,7 @@ radeon_add_atom_connector(struct drm_device *dev,
if (i2c_bus->valid) {
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev,
i2c_bus);
if (!radeon_connector->ddc_bus)
- goto failed;
+ DRM_ERROR("LVDS: Failed to assign
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #16 from revealed 2011-04-14 14:22:20 PDT --- I would! Do i have to edit the file in: /usr/src/linux-2.6.37.1-1.2/drivers/i2c/algos/i2c-algo-bit.c And make the i2c-algo-bit somehow? I cant remember properly if i can recompile a single module? I dont need to translate the whole kernel? Can give me a hint? Greetings, R -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #16 from revealed 2011-04-14 14:22:20 PDT --- I would! Do i have to edit the file in: /usr/src/linux-2.6.37.1-1.2/drivers/i2c/algos/i2c-algo-bit.c And make the i2c-algo-bit somehow? I cant remember properly if i can recompile a single module? I dont need to translate the whole kernel? Can give me a hint? Greetings, R -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 32402] Oops associated with radeon_unpin_work_func
https://bugzilla.kernel.org/show_bug.cgi?id=32402 Adriano changed: What|Removed |Added CC||adriano.vilela at yahoo.com --- Comment #10 from Adriano 2011-04-14 14:11:32 --- I'm having this problem too with kernel 2.6.38 series. As soon as my screen saver kicks in, my entire desktop gets corrupted. If I wait long enough for my screen to stand by or suspend (just the screen, not the computer), then the computer completely freezes. I'm not sure if I can add attachments to bugs reported by others; if so, I would be happy to attach a picture with the error messages. Please, let me know how I can help with this issue. Thank you, Adriano -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list Dri-devel at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 10:28:43AM -0400, Alex Deucher wrote: > On Thu, Apr 14, 2011 at 4:56 AM, Joerg Roedel wrote: > > And this makes a difference, with this change on-top of -rc3 the box boots > > fine. So there seems to be some dependency between the GART base and the GTT > > base even when they are in different address spaces. > > > > Alex, can you comment on this? > > As Dave said, they are completely different addresses spaces. You > could put the GPU aperture at 0 if you wanted (in fact we do on some > chips). Perhaps there's some strange interaction with the nb gart > since the nb gart on that chipset was designed to be used for graphics > and the rs780/880 can be configured to use an agp aperture. > Unfortunately, I'm not that familiar with the nb gart. Actually, the nb gart is part of the cpu. It is part of the cpu north bridge and can translate io and cpu accesses. In fact, it is a remapper of physical memory addresses. The problem seems to be related to specific gpu chips. On another notebook with an hd3000 card gtt and the nb gart aperture are both on 0xa000 too but the box works fine. I havn't tested with an hd5000 yet. The failing notebook has an hd4200 mobility. Btw. what happens if the gpu accesses an unmapped address in the gtt range? Regards, Joerg ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Attachment #45619|0 |1 is obsolete|| --- Comment #15 from Alex Deucher 2011-04-14 14:03:58 PDT --- Created an attachment (id=45633) View: https://bugs.freedesktop.org/attachment.cgi?id=45633 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45633 better fix Is there any way you could test this patch? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Attachment #45619|0 |1 is obsolete|| --- Comment #15 from Alex Deucher 2011-04-14 14:03:58 PDT --- Created an attachment (id=45633) View: https://bugs.freedesktop.org/attachment.cgi?id=45633 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45633 better fix Is there any way you could test this patch? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #3 from dcela...@gmail.com 2011-04-14 13:28:46 PDT --- The quote the game developer's post over at Phoronix: The lights are missing. Which means that deferred phase is not working. Which means that most likely G-buffers are not filled correctly because multiple render targets do not work. This should probably be filed as a bug against the driver. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36236] Problems with lights in Trine game from www.humblebundle.com
https://bugs.freedesktop.org/show_bug.cgi?id=36236 --- Comment #3 from dcelasun at gmail.com 2011-04-14 13:28:46 PDT --- The quote the game developer's post over at Phoronix: The lights are missing. Which means that deferred phase is not working. Which means that most likely G-buffers are not filled correctly because multiple render targets do not work. This should probably be filed as a bug against the driver. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #14 from revealed 2011-04-14 13:13:47 PDT --- Ok. I am so happy at the moment having working desktop effects and such :D -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #14 from revealed 2011-04-14 13:13:47 PDT --- Ok. I am so happy at the moment having working desktop effects and such :D -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
Linux 2.6.39-rc3
Hello, On Wed, Apr 13, 2011 at 07:33:40PM -0700, Linus Torvalds wrote: > On Wednesday, April 13, 2011, Linus Torvalds > wrote: > > On Wednesday, April 13, 2011, H. Peter Anvin wrote: > >> > >> Yes. ?However, even if we *do* revert (and the time is running short on > >> not reverting) I would like to understand this particular one, simply > >> because I think it may very well be a problem that is manifesting itself > >> in other ways on other systems. > > sorry, fingerfart. Anyway, I agree 100%. > > we definitely want to also understand the reason for things not > working, even if we do revert.. There were (and still are) places where memblock callers implemented ad-hoc top-down allocation by stepping down start limit until allocation succeeds. Several of them have been removed since top-down became the default behavior, so simply reverting the commit is likely to cause subtle issues. Maybe the best approach is introducing @topdown parameter and use it selectively for pure memory allocations. Thanks. -- tejun
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #13 from Alex Deucher 2011-04-14 12:37:33 PDT --- (In reply to comment #12) > Oh yes :) > > Sorry! I have to also omit that i have an open bugreport at novell bugzilla > since februar. I was getting few response. Thats the reason i opened this > bugreport here. > > I set that one in novel bugzilla to resolved. > > https://bugzilla.novell.com/show_bug.cgi?id=669937 > > I know this is a very unkind multiposting from me. I want to apologize for > this. No worries :) > I guess the report in novell bugzilla is unnecessary now? Leave it open for now. They might have some ideas why i2c-algo-bit.bit_test=1 is set by default. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #13 from Alex Deucher 2011-04-14 12:37:33 PDT --- (In reply to comment #12) > Oh yes :) > > Sorry! I have to also omit that i have an open bugreport at novell bugzilla > since februar. I was getting few response. Thats the reason i opened this > bugreport here. > > I set that one in novel bugzilla to resolved. > > https://bugzilla.novell.com/show_bug.cgi?id=669937 > > I know this is a very unkind multiposting from me. I want to apologize for > this. No worries :) > I guess the report in novell bugzilla is unnecessary now? Leave it open for now. They might have some ideas why i2c-algo-bit.bit_test=1 is set by default. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[Bug 32982] Kernel locks up a few minutes after boot
https://bugzilla.kernel.org/show_bug.cgi?id=32982 --- Comment #8 from Bart Van Assche 2011-04-14 19:24:34 --- The result of the bisect process - not sure it's useful: # git bisect skip There are only 'skip'ped commits left to test. The first bad commit could be any of: 62e0ff1ef2d8ea0814487f73a7de431396a1e914 1fcf0069f4715f6f811466db68a547a348b4d5a9 94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9 53f358a81e10e798f44af896ffacaedd7ac0269b e9c5db0b8dce1bcdc99ad26e718230810d6b5cff b73a21fc66fee35b41db755abebfacba48b2fc76 We cannot bisect more! git bisect start # skip: [1fcf0069f4715f6f811466db68a547a348b4d5a9] Merge branch 'common/fbdev' of master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6 git bisect skip 1fcf0069f4715f6f811466db68a547a348b4d5a9 # skip: [e9c5db0b8dce1bcdc99ad26e718230810d6b5cff] efifb: support AMD Radeon HD 6490 git bisect skip e9c5db0b8dce1bcdc99ad26e718230810d6b5cff # skip: [21cd72e7cb424f1686855602ec0fdc6e5830f249] savagefb: Set up I2C based on chip family instead of card id git bisect skip 21cd72e7cb424f1686855602ec0fdc6e5830f249 # skip: [47c87d930f3db4fc3a30505075e07f5597e2e953] fb: Reduce priority of resource conflict message git bisect skip 47c87d930f3db4fc3a30505075e07f5597e2e953 # good: [899631c7916b231ba6509c90dbc33221e9194029] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input git bisect good 899631c7916b231ba6509c90dbc33221e9194029 # bad: [b73a21fc66fee35b41db755abebfacba48b2fc76] video: s3c-fb: fix checkpatch errors and warning git bisect bad b73a21fc66fee35b41db755abebfacba48b2fc76 # skip: [6c5103890057b1bb781b26b7aae38d33e4c517d8] Merge branch 'for-2.6.39/core' of git://git.kernel.dk/linux-2.6-block git bisect skip 6c5103890057b1bb781b26b7aae38d33e4c517d8 # good: [247f99386100d1d1c369ba98120d2edebf5426fc] fbdev: sh_mobile_lcdcfb: fix module lock acquisition git bisect good 247f99386100d1d1c369ba98120d2edebf5426fc # skip: [53f358a81e10e798f44af896ffacaedd7ac0269b] Merge branch 'viafb-next' of git://github.com/schandinat/linux-2.6 git bisect skip 53f358a81e10e798f44af896ffacaedd7ac0269b # good: [3f086fe93f734ba76f2e130777687f81e0cbb318] viafb: initialize margins correct git bisect good 3f086fe93f734ba76f2e130777687f81e0cbb318 # skip: [62e0ff1ef2d8ea0814487f73a7de431396a1e914] fbcon: Remove unused 'display *p' variable from fb_flashcursor() git bisect skip 62e0ff1ef2d8ea0814487f73a7de431396a1e914 # skip: [94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9] s3fb: fix Virge/GX2 git bisect skip 94e948e6e43cd34e0e2ca496d5e90e4ff0d884f9 -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev -- ___ Dri-devel mailing list dri-de...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Linux 2.6.39-rc3
On Wed, 2011-04-13 at 18:58 -0700, H. Peter Anvin wrote: > On 04/13/2011 12:14 PM, Yinghai Lu wrote: > > > > so those two patches uncover some problems. > > > > [0.00] Checking aperture... > > [0.00] No AGP bridge found > > [0.00] Node 0: aperture @ a000 size 32 MB > > [0.00] Aperture pointing to e820 RAM. Ignoring. > > [0.00] Your BIOS doesn't leave a aperture memory hole > > [0.00] Please enable the IOMMU option in the BIOS setup > > [0.00] This costs you 64 MB of RAM > > [0.00] memblock_x86_reserve_range: [0xa000-0xa3ff] > > aperture64 > > [0.00] Mapping aperture over 65536 KB of RAM @ a000 > > > > so kernel try to reallocate apperture. because BIOS allocated is pointed to > > RAM or size is too small. > > > > but your radeon does use [0xa000, 0xbfff) > > > > [4.281993] radeon :01:05.0: VRAM: 320M 0xC000 - > > 0xD3FF (320M used) > > [4.290672] radeon :01:05.0: GTT: 512M 0xA000 - > > 0xBFFF > > [4.298550] [drm] Detected VRAM RAM=320M, BAR=256M > > [4.309857] [drm] RAM width 32bits DDR > > [4.313748] [TTM] Zone kernel: Available graphics memory: 1896524 kiB. > > [4.320379] [TTM] Initializing pool allocator. > > [4.324948] [drm] radeon: 320M of VRAM memory ready > > [4.329832] [drm] radeon: 512M of GTT memory ready. > > > > and the one seems working: > > > > [0.00] Checking aperture... > > [0.00] No AGP bridge found > > [0.00] Node 0: aperture @ a000 size 32 MB > > [0.00] Aperture pointing to e820 RAM. Ignoring. > > [0.00] Your BIOS doesn't leave a aperture memory hole > > [0.00] Please enable the IOMMU option in the BIOS setup > > [0.00] This costs you 64 MB of RAM > > [0.00] memblock_x86_reserve_range: [0x8000-0x83ff] > > aperture64 > > [0.00] Mapping aperture over 65536 KB of RAM @ 8000 > > [0.00] memblock_x86_reserve_range: [0xacb6bdc0-0xacb6bddf] > > BOOTMEM > > > > will use different position... > > > > [4.250159] radeon :01:05.0: VRAM: 320M 0xC000 - > > 0xD3FF (320M used) > > [4.258830] radeon :01:05.0: GTT: 512M 0xA000 - > > 0xBFFF > > [4.266742] [drm] Detected VRAM RAM=320M, BAR=256M > > [4.271549] [drm] RAM width 32bits DDR > > [4.275435] [TTM] Zone kernel: Available graphics memory: 1896526 kiB. > > [4.282066] [TTM] Initializing pool allocator. > > [4.282085] usb 7-2: new full speed USB device number 2 using ohci_hcd > > [4.293076] [drm] radeon: 320M of VRAM memory ready > > [4.298277] [drm] radeon: 512M of GTT memory ready. > > [4.303218] [drm] Supports vblank timestamp caching Rev 1 (10.10.2010). > > [4.309854] [drm] Driver supports precise vblank timestamp query. > > [4.315970] [drm] radeon: irq initialized. > > [4.320094] [drm] GART: num cpu pages 131072, num gpu pages 131072 > > > > So question is why radeon is using the address [0xa000 - 0xc00], > > and in E820 it is RAM > > > > [0.00] BIOS-e820: 0010 - acb8d000 (usable) > > [0.00] BIOS-e820: acb8d000 - acb8f000 (reserved) > > [0.00] BIOS-e820: acb8f000 - afce9000 (usable) > > [0.00] BIOS-e820: afce9000 - afd21000 (reserved) > > [0.00] BIOS-e820: afd21000 - afd4f000 (usable) > > [0.00] BIOS-e820: afd4f000 - afdcf000 (reserved) > > [0.00] BIOS-e820: afdcf000 - afecf000 (ACPI NVS) > > [0.00] BIOS-e820: afecf000 - afeff000 (ACPI data) > > [0.00] BIOS-e820: afeff000 - aff0 (usable) > > > > so looks bios program wrong address to the radon card? > > > > Okay, staring at this, it definitely seems toxic to overlay the GART > over memory areas reserved by the BIOS. If I were to guess, I would say > that the problem here seems to be that the kernel thinks it is > overlaying 64 MiB of memory, but the actual GART is in fact 512 MiB in > size -- 131072 CPU pages -- which now overlaps the BIOS reserved areas. > > Alex D., could you comment on the "num cpu pages" bit? These are not CPU addresses. I think we've stated that already. Not the droids. the num cpu pages is how many CPU pages would be needed to fill the GPU GTT, for those crazy cases where CPU pagesize != GPU pagesize. Dave.
Re: 2.6.39-rc1 nouveau regression (bisected)
On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" > to everyone, but then chose to CC Maciej instead: Would you be so kind and > add this to your regression list? Thanks! > > Since commit 38f1cff > > From: Dave Airlie > Date: Wed, 16 Mar 2011 11:34:41 +1000 > Subject: [PATCH] Merge commit '5359533801e3dd3abca5b7d3d985b0b33fd9fe8b' > into dr > > This commit changed an internal radeon structure, that meant a new driver > in -next had to be fixed up, merge in the commit and fix up the driver. > > Also fixes a trivial nouveau merge. > > Conflicts: > drivers/gpu/drm/nouveau/nouveau_mem.c > > booting my atom/NM10/ION2 system crashes hard during boot, right after > blanking the screen, and before the initramfs gets loaded. I just > re-checked: both parent commits ( 5359533 and 4819d2e ) do indeed work > just fine, but the merge commit ( 38f1cff ) fails, same as tip ( 85f2e68 ). Can you activate netconsole and check whether kernel spits anything interesting? You might try to load nouveau module after boot - maybe something will be saved to /var/log or you could even ssh into the box and check dmesg... Marcin ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Linux 2.6.39-rc3
On Thu, Apr 14, 2011 at 01:03:37PM +0900, Tejun Heo wrote: > Hello, > > On Wed, Apr 13, 2011 at 07:33:40PM -0700, Linus Torvalds wrote: > > On Wednesday, April 13, 2011, Linus Torvalds > > wrote: > > > On Wednesday, April 13, 2011, H. Peter Anvin wrote: > > >> > > >> Yes. ?However, even if we *do* revert (and the time is running short on > > >> not reverting) I would like to understand this particular one, simply > > >> because I think it may very well be a problem that is manifesting itself > > >> in other ways on other systems. > > > > sorry, fingerfart. Anyway, I agree 100%. > > > > we definitely want to also understand the reason for things not > > working, even if we do revert.. > > There were (and still are) places where memblock callers implemented > ad-hoc top-down allocation by stepping down start limit until > allocation succeeds. Several of them have been removed since top-down > became the default behavior, so simply reverting the commit is likely > to cause subtle issues. Maybe the best approach is introducing > @topdown parameter and use it selectively for pure memory allocations. Wouldn't it be better to provide a seperate memblock allocation function which operates top-down and use this one in the places that need it? This way it wouldn't break code that relies on bottom-up. Joerg
[PATCH] drm/radeon/kms: fix bad shift in atom iio table parser
Noticed by Patrick Lowry. Signed-off-by: Alex Deucher Cc: stable at kernel.org --- drivers/gpu/drm/radeon/atom.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index d71d375..7bd7456 100644 --- a/drivers/gpu/drm/radeon/atom.c +++ b/drivers/gpu/drm/radeon/atom.c @@ -135,7 +135,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base, case ATOM_IIO_MOVE_INDEX: temp &= ~((0x >> (32 - CU8(base + 1))) << - CU8(base + 2)); + CU8(base + 3)); temp |= ((index >> CU8(base + 2)) & (0x >> (32 - CU8(base + 1 << CU8(base + @@ -145,7 +145,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base, case ATOM_IIO_MOVE_DATA: temp &= ~((0x >> (32 - CU8(base + 1))) << - CU8(base + 2)); + CU8(base + 3)); temp |= ((data >> CU8(base + 2)) & (0x >> (32 - CU8(base + 1 << CU8(base + @@ -155,7 +155,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base, case ATOM_IIO_MOVE_ATTR: temp &= ~((0x >> (32 - CU8(base + 1))) << - CU8(base + 2)); + CU8(base + 3)); temp |= ((ctx-> io_attr >> CU8(base + 2)) & (0x >> (32 - -- 1.7.1.1
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #12 from revealed 2011-04-14 11:14:14 PDT --- Oh yes :) Sorry! I have to also omit that i have an open bugreport at novell bugzilla since februar. I was getting few response. Thats the reason i opened this bugreport here. I set that one in novel bugzilla to resolved. https://bugzilla.novell.com/show_bug.cgi?id=669937 I know this is a very unkind multiposting from me. I want to apologize for this. I guess the report in novell bugzilla is unnecessary now? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #12 from revealed 2011-04-14 11:14:14 PDT --- Oh yes :) Sorry! I have to also omit that i have an open bugreport at novell bugzilla since februar. I was getting few response. Thats the reason i opened this bugreport here. I set that one in novel bugzilla to resolved. https://bugzilla.novell.com/show_bug.cgi?id=669937 I know this is a very unkind multiposting from me. I want to apologize for this. I guess the report in novell bugzilla is unnecessary now? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
Linux 2.6.39-rc3
* Joerg Roedel wrote:
> On Wed, Apr 13, 2011 at 06:58:46PM -0700, H. Peter Anvin wrote:
> > On 04/13/2011 12:14 PM, Yinghai Lu wrote:
> > >
> > > so looks bios program wrong address to the radon card?
> > >
> >
> > Okay, staring at this, it definitely seems toxic to overlay the GART
> > over memory areas reserved by the BIOS. If I were to guess, I would say
> > that the problem here seems to be that the kernel thinks it is
> > overlaying 64 MiB of memory, but the actual GART is in fact 512 MiB in
> > size -- 131072 CPU pages -- which now overlaps the BIOS reserved areas.
> >
> > Alex D., could you comment on the "num cpu pages" bit?
>
> Okay, I tried the debug-patch from Yinghai (posted to the bugzilla):
>
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -325,6 +325,8 @@ void radeon_gtt_location(struct radeon_device *rdev,
> struct radeon_mc *mc)
> mc->gtt_size = size_bf;
> }
> mc->gtt_start = (mc->vram_start & ~mc->gtt_base_align) -
> mc->gtt_size;
> + if (mc->gtt_start == 0xa000)
> + mc->gtt_start = 0x8000;
> } else {
> if (mc->gtt_size > size_af) {
> dev_warn(rdev->dev, "limiting GTT\n");
>
> And this makes a difference, with this change on-top of -rc3 the box boots
> fine. So there seems to be some dependency between the GART base and the GTT
> base even when they are in different address spaces.
>
> Alex, can you comment on this?
I'd strongly suggest we revert back to the old and proven allocation order, as
long as it results in valid layouts. Even if we figure out this particular
GART/GTT assumption there might be a dozen others in other types of hardware.
Thanks,
Ingo
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #11 from Alex Deucher 2011-04-14 11:10:36 PDT --- Leave this open until we get some feedback from Suse or the i2c people. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 Alex Deucher changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #11 from Alex Deucher 2011-04-14 11:10:36 PDT --- Leave this open until we get some feedback from Suse or the i2c people. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
[RFC] drm: emit change events when mode config changes
We've already seen that apps want to monitor the display config, and
some (like upowerd) poll for changes since we don't provide a
notification for general mode config changes, just hotplug events. So
add a new drm event, with CHANGE=1 set in the event, to allow for it.
Signed-off-by: Jesse Barnes
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 4c95b5f..174ee64 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1589,6 +1589,8 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,
set.fb = fb;
ret = crtc->funcs->set_config(&set);
+ drm_sysfs_change_event(dev);
+
out:
kfree(connector_set);
mutex_unlock(&dev->mode_config.mutex);
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 9507204..df946d4 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -822,6 +822,8 @@ int drm_fb_helper_set_par(struct fb_info *info)
return ret;
}
}
+
+ drm_sysfs_change_event(dev);
mutex_unlock(&dev->mode_config.mutex);
if (fb_helper->delayed_hotplug) {
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index 2eee8e0..fd3af31 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -467,9 +467,9 @@ EXPORT_SYMBOL(drm_sysfs_connector_remove);
* drm_sysfs_hotplug_event - generate a DRM uevent
* @dev: DRM device
*
- * Send a uevent for the DRM device specified by @dev. Currently we only
- * set HOTPLUG=1 in the uevent environment, but this could be expanded to
- * deal with other types of events.
+ * Send a uevent for the DRM device specified by @dev. Set HOTPLUG=1 in the
+ * event to indicate a display config change occurred, probably due to a
+ * display being added or removed.
*/
void drm_sysfs_hotplug_event(struct drm_device *dev)
{
@@ -483,6 +483,24 @@ void drm_sysfs_hotplug_event(struct drm_device *dev)
EXPORT_SYMBOL(drm_sysfs_hotplug_event);
/**
+ * drm_sysfs_change_event - generate a DRM uevent indicating a display config
change
+ * @dev: DRM device
+ *
+ * Send a uevent for the DRM device specified by @dev. Set CHANGE=1 to
+ * indicate that a userspace initiated display configuration change occurred.
+ */
+void drm_sysfs_change_event(struct drm_device *dev)
+{
+ char *event_string = "CHANGE=1";
+ char *envp[] = { event_string, NULL };
+
+ DRM_DEBUG("generating hotplug event\n");
+
+ kobject_uevent_env(&dev->primary->kdev.kobj, KOBJ_CHANGE, envp);
+}
+EXPORT_SYMBOL(drm_sysfs_change_event);
+
+/**
* drm_sysfs_device_add - adds a class device to sysfs for a character driver
* @dev: DRM device to be added
* @head: DRM head in question
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index ad5770f..3aff8fc 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1506,6 +1506,7 @@ extern struct class *drm_sysfs_create(struct module
*owner, char *name);
extern void drm_sysfs_destroy(void);
extern int drm_sysfs_device_add(struct drm_minor *minor);
extern void drm_sysfs_hotplug_event(struct drm_device *dev);
+extern void drm_sysfs_change_event(struct drm_device *dev);
extern void drm_sysfs_device_remove(struct drm_minor *minor);
extern char *drm_get_connector_status_name(enum drm_connector_status status);
extern int drm_sysfs_connector_add(struct drm_connector *connector);
--
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
--
___
Dri-devel mailing list
dri-de...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #10 from Alex Deucher 2011-04-14 11:06:31 PDT --- Created an attachment (id=45619) View: https://bugs.freedesktop.org/attachment.cgi?id=45619 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45619 possible fix This patch should fix the issue. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[Bug 36221] KMS with X1950 XT i2c error --> no ddc
https://bugs.freedesktop.org/show_bug.cgi?id=36221 --- Comment #10 from Alex Deucher 2011-04-14 11:06:31 PDT --- Created an attachment (id=45619) View: https://bugs.freedesktop.org/attachment.cgi?id=45619 Review: https://bugs.freedesktop.org/review?bug=36221&attachment=45619 possible fix This patch should fix the issue. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
