[PATCH] staging: fbtft: fix type assignment warning
Sparse spits out a warning that a __be16 was being assigned to a u16. Change the type of txbuf16 to __be16 b/c it's a restricted type and prevents mixing endianness. Signed-off-by: Alex Wilson <alex.david.wil...@gmail.com> --- drivers/staging/fbtft/fbtft-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c index 3475b1b8081f..a80b5d115ff8 100644 --- a/drivers/staging/fbtft/fbtft-bus.c +++ b/drivers/staging/fbtft/fbtft-bus.c @@ -114,7 +114,7 @@ EXPORT_SYMBOL(fbtft_write_reg8_bus9); int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len) { u16 *vmem16; - u16 *txbuf16 = par->txbuf.buf; + __be16 *txbuf16 = par->txbuf.buf; size_t remain; size_t to_copy; size_t tx_array_size; -- 2.12.1 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2] staging: panel: fix block comment usage
Fixed two coding style warnings concerning multiline comments. Signed-off-by: Alex Wilson alex.david.wil...@gmail.com --- drivers/staging/panel/panel.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index bda208d..3e9ee7e 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -781,14 +781,18 @@ static void long_sleep(int ms) schedule_timeout_interruptible(msecs_to_jiffies(ms)); } -/* send a serial byte to the LCD panel. The caller is responsible for locking - if needed. */ +/* + * send a serial byte to the LCD panel. The caller is responsible for locking + * if needed. + */ static void lcd_send_serial(int byte) { int bit; - /* the data bit is set on D0, and the clock on STROBE. -* LCD reads D0 on STROBE's rising edge. */ + /* +* the data bit is set on D0, and the clock on STROBE. +* LCD reads D0 on STROBE's rising edge. +*/ for (bit = 0; bit 8; bit++) { bits.cl = BIT_CLR; /* CLK low */ panel_set_bits(); -- 2.5.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: panel: fix block comment usage
Fixed two coding style warnings concerning multiline comments. Signed-off-by: Alex Wilson alex.david.wil...@gmail.com --- drivers/staging/panel/panel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index bda208d..16a7adc 100644 --- a/drivers/staging/panel/panel.c +++ b/drivers/staging/panel/panel.c @@ -782,13 +782,15 @@ static void long_sleep(int ms) } /* send a serial byte to the LCD panel. The caller is responsible for locking - if needed. */ + * if needed. + */ static void lcd_send_serial(int byte) { int bit; /* the data bit is set on D0, and the clock on STROBE. -* LCD reads D0 on STROBE's rising edge. */ +* LCD reads D0 on STROBE's rising edge. +*/ for (bit = 0; bit 8; bit++) { bits.cl = BIT_CLR; /* CLK low */ panel_set_bits(); -- 2.5.0 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel