Re: [PATCH 00/10] staging/irda/net: Adjustments for several function implementations
Did you read drivers/staging/irda/TODO ? There is no need to answer that. You already have. Thanks a lot for your ever lasting invaluable contributions to /dev/null. Please continue. Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: rtl8188eu: checkpatch fixes: removed not necessary braces {}
Greg KH writes: > Please take some time, and go read Documentation/SubmittingPatches. That's quickly done nowadays: bjorn@miraculix:/usr/local/src/git/linux$ cat Documentation/SubmittingPatches This file has moved to process/submitting-patches.rst I don't know why it was necessary to move that file, but it looks like you, and the gazillion links and references to this document, just have to adopt to a new location. Or submit a patch to fix it :) Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 00/10] MA USB drivers cover letter
[added linux-...@vger.kernel.org Cc] Stephanie Wallick writes: > Media Agnostic (MA) USB enables the USB protocol to be used over a wide > range of physical media. MA USB is a relatively new protocol and is > currently unsupported in the Linux kernel. This patch set adds the > following drivers with the following capabilities: > > 1) MA USB Host: > - provides functionality of a USB Host Controller. > - implements MA USB protocol for a MA USB host. > - provides MA USB packet transport over TCP > > 2) MA USB Device: > - provides functionality of a USB Device Controller. > - implements MA USB protocol for a MA USB device. > - provides MA USB packet transport over TCP Nice. But don't you think this deserves the attention of the linux-usb mailing list? Yes, Greg's attention is of course good to have too :-) But I believe this is of interest to more people, who might not read everything on linux-kernel. Has there been any thought/discussion about the relationship to the existing usbip drivers, which just moved out of staging? Is a usbip userspace compatibility layer feasible sometime in the future? Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH] staging: et131x: remove Module.symvers
Mark Einon writes:
> On Mon, Jun 02, 2014 at 10:26:42AM +0200, Bjørn Mork wrote:
>> Removing a build generated file.
>>
>> Cc: Mark Einon
>> Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock")
>> Signed-off-by: Bjørn Mork
>
> Hi Bjørn,
>
> Unfortunately this issue has already been fixed by someone else, see commit
> 788a829137 in staging-next.
Great! That's all I wanted :-)
Bjørn
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH] staging: et131x: remove Module.symvers
Removing a build generated file.
Cc: Mark Einon
Fixes: e0349d5bac22 ("staging: et131x: Remove unused rcv_pend_lock spinlock")
Signed-off-by: Bjørn Mork
---
drivers/staging/et131x/Module.symvers | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 drivers/staging/et131x/Module.symvers
diff --git a/drivers/staging/et131x/Module.symvers
b/drivers/staging/et131x/Module.symvers
deleted file mode 100644
index e69de29bb2d1..
--
2.0.0
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr
David Miller writes: > From: Bjørn Mork > Date: Fri, 30 Aug 2013 18:08:43 +0200 > >> Copying the dev_addr from a parent device is an operation >> common to a number of drivers. The addr_assign_type should >> be updated accordingly, either by reusing the value from >> the source device or explicitly indicating that the address >> is stolen by setting addr_assign_type to NET_ADDR_STOLEN. >> >> This patch set adds a helper copying both the dev_addr and >> the addr_assign_type, and use this helper in drivers which >> don't currently set the addr_assign_type. Using NET_ADDR_STOLEN >> might be more appropriate in some of these cases. Please >> let me know, and I'll update the patch accordingly. >> >> Changes in v2: >> - assuming addr_len == ETH_ALEN to allow optimized memcpy >> - dropped the vt6656 patch due to addr_len being unset in that driver > > Looks good, series applied, thanks. Thanks. But it doesn't look like it ended up in net-next? Or am I missing something (again)? Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 net-next 0/9] set addr_assign_type when inheriting a dev_addr
Copying the dev_addr from a parent device is an operation common to a number of drivers. The addr_assign_type should be updated accordingly, either by reusing the value from the source device or explicitly indicating that the address is stolen by setting addr_assign_type to NET_ADDR_STOLEN. This patch set adds a helper copying both the dev_addr and the addr_assign_type, and use this helper in drivers which don't currently set the addr_assign_type. Using NET_ADDR_STOLEN might be more appropriate in some of these cases. Please let me know, and I'll update the patch accordingly. Changes in v2: - assuming addr_len == ETH_ALEN to allow optimized memcpy - dropped the vt6656 patch due to addr_len being unset in that driver Bjørn Mork (9): net: etherdevice: add address inherit helper net: vlan: inherit addr_assign_type along with dev_addr net: dsa: inherit addr_assign_type along with dev_addr net: macvlan: inherit addr_assign_type along with dev_addr net: team: inherit addr_assign_type along with dev_addr net: airo: inherit addr_assign_type along with dev_addr net: hostap: inherit addr_assign_type along with dev_addr net: libertas: inherit addr_assign_type along with dev_addr staging: vt6655: inherit addr_assign_type along with dev_addr drivers/net/macvlan.c |2 +- drivers/net/team/team.c |2 +- drivers/net/wireless/airo.c |2 +- drivers/net/wireless/hostap/hostap_hw.c |2 +- drivers/net/wireless/hostap/hostap_main.c |2 +- drivers/net/wireless/libertas/mesh.c |2 +- drivers/staging/vt6655/hostap.c |2 +- drivers/staging/vt6655/ioctl.c|2 +- drivers/staging/vt6655/wpactl.c |2 +- include/linux/etherdevice.h | 15 +++ net/8021q/vlan_dev.c |2 +- net/dsa/slave.c |2 +- 12 files changed, 26 insertions(+), 11 deletions(-) -- 1.7.10.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 net-next 9/9] staging: vt6655: inherit addr_assign_type along with dev_addr
A device inheriting a random or set address should reflect this in
its addr_assign_type.
Cc: Forest Bond
Signed-off-by: Bjørn Mork
---
drivers/staging/vt6655/hostap.c |2 +-
drivers/staging/vt6655/ioctl.c |2 +-
drivers/staging/vt6655/wpactl.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
index 57a08c5..8acff44 100644
--- a/drivers/staging/vt6655/hostap.c
+++ b/drivers/staging/vt6655/hostap.c
@@ -86,7 +86,7 @@ static int hostap_enable_hostapd(PSDevice pDevice, int
rtnl_locked)
apdev_priv = netdev_priv(pDevice->apdev);
*apdev_priv = *pDevice;
- memcpy(pDevice->apdev->dev_addr, dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->apdev, dev);
pDevice->apdev->netdev_ops = &apdev_netdev_ops;
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 46e0e41..b5cd2e4 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -460,7 +460,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
}
if (sValue.dwValue == 1) {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "up wpadev\n");
- memcpy(pDevice->wpadev->dev_addr,
pDevice->dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->wpadev, pDevice->dev);
pDevice->bWPADEVUp = true;
} else {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "close wpadev\n");
diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c
index 869f62c..e8d9ecd 100644
--- a/drivers/staging/vt6655/wpactl.c
+++ b/drivers/staging/vt6655/wpactl.c
@@ -96,7 +96,7 @@ static int wpa_init_wpadev(PSDevice pDevice)
wpadev_priv = netdev_priv(pDevice->wpadev);
*wpadev_priv = *pDevice;
- memcpy(pDevice->wpadev->dev_addr, dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->wpadev, dev);
pDevice->wpadev->base_addr = dev->base_addr;
pDevice->wpadev->irq = dev->irq;
pDevice->wpadev->mem_start = dev->mem_start;
--
1.7.10.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH v2 net-next 1/9] net: etherdevice: add address inherit helper
Some etherdevices inherit their address from a parent or
master device. The addr_assign_type should be updated along
with the address in these cases. Adding a helper function
to simplify this.
Signed-off-by: Bjørn Mork
---
include/linux/etherdevice.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index c623861..d8b5124 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -199,6 +199,21 @@ static inline void eth_hw_addr_random(struct net_device
*dev)
}
/**
+ * eth_hw_addr_inherit - Copy dev_addr from another net_device
+ * @dst: pointer to net_device to copy dev_addr to
+ * @src: pointer to net_device to copy dev_addr from
+ *
+ * Copy the Ethernet address from one net_device to another along with
+ * the address attributes (addr_assign_type).
+ */
+static inline void eth_hw_addr_inherit(struct net_device *dst,
+ struct net_device *src)
+{
+ dst->addr_assign_type = src->addr_assign_type;
+ memcpy(dst->dev_addr, src->dev_addr, ETH_ALEN);
+}
+
+/**
* compare_ether_addr - Compare two Ethernet addresses
* @addr1: Pointer to a six-byte array containing the Ethernet address
* @addr2: Pointer other six-byte array containing the Ethernet address
--
1.7.10.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr
Dan Carpenter writes: > Ah... Here is the first patch which adds eth_hw_addr_inherit() > > http://patchwork.ozlabs.org/patch/269365/ > > I don't think we've actually set dst->addr_len yet at this point so > it doesn't do the memcpy(). This doesn't work. Ouch. Yes, I see. The net_device is allocated using kzalloc just a few lines earlier and there is no ether_setup or similar. Actually, it doesn't look like it ever sets addr_len. Is that right? Does it work even before this patch? Anyway, thanks for spotting this. I'll drop this patch for now as I clearly don't understand how this driver works. I do note that the otherwise very similar code in the vt6655 driver uses alloc_etherdev, and therefore has a fair chance of working both before and after my change. Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr
Dan Carpenter writes: > On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote: >> Cc: Forest Bond >> Signed-off-by: Bjørn Mork >> --- > > The changlog is missing. Yes, right. Sorry about that. > Why does this patch help? It ensures that addr_assign_type is set to the same value as the parent device the dev_addr is copied from. The initial reason was that I found it strange to see NET_ADDR_PERM on a vlan device which had inherited a random address from its parent. But I haven't verified whether that the parent device actually can have an addr_assign_type != NET_ADDR_PERM for every driver included. Bjørn ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH net-next 00/10] set addr_assign_type when inheriting a dev_addr
Copying the dev_addr from a parent device is an operation common to a number of drivers. The addr_assign_type should be updated accordingly, either by reusing the value from the source device or explicitly indicating that the address is stolen by setting addr_assign_type to NET_ADDR_STOLEN. This patch set adds a helper copying both the dev_addr and the addr_assign_type, and use this helper in drivers which don't currently set the addr_assign_type. Using NET_ADDR_STOLEN might be more appropriate in some of these cases. Please let me know, and I'll update the patch accordingly. Bjørn Mork (10): net: etherdevice: add address inherit helper net: vlan: inherit addr_assign_type along with dev_addr net: dsa: inherit addr_assign_type along with dev_addr net: macvlan: inherit addr_assign_type along with dev_addr net: team: inherit addr_assign_type along with dev_addr net: airo: inherit addr_assign_type along with dev_addr net: hostap: inherit addr_assign_type along with dev_addr net: libertas: inherit addr_assign_type along with dev_addr staging: vt6655: inherit addr_assign_type along with dev_addr staging: vt6656: inherit addr_assign_type along with dev_addr drivers/net/macvlan.c |2 +- drivers/net/team/team.c |2 +- drivers/net/wireless/airo.c |2 +- drivers/net/wireless/hostap/hostap_hw.c |2 +- drivers/net/wireless/hostap/hostap_main.c |2 +- drivers/net/wireless/libertas/mesh.c |2 +- drivers/staging/vt6655/hostap.c |2 +- drivers/staging/vt6655/ioctl.c|2 +- drivers/staging/vt6655/wpactl.c |2 +- drivers/staging/vt6656/hostap.c |2 +- include/linux/etherdevice.h | 19 +++ net/8021q/vlan_dev.c |2 +- net/dsa/slave.c |2 +- 13 files changed, 31 insertions(+), 12 deletions(-) -- 1.7.10.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH net-next 09/10] staging: vt6655: inherit addr_assign_type along with dev_addr
Cc: Forest Bond
Signed-off-by: Bjørn Mork
---
drivers/staging/vt6655/hostap.c |2 +-
drivers/staging/vt6655/ioctl.c |2 +-
drivers/staging/vt6655/wpactl.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/hostap.c b/drivers/staging/vt6655/hostap.c
index 57a08c5..8acff44 100644
--- a/drivers/staging/vt6655/hostap.c
+++ b/drivers/staging/vt6655/hostap.c
@@ -86,7 +86,7 @@ static int hostap_enable_hostapd(PSDevice pDevice, int
rtnl_locked)
apdev_priv = netdev_priv(pDevice->apdev);
*apdev_priv = *pDevice;
- memcpy(pDevice->apdev->dev_addr, dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->apdev, dev);
pDevice->apdev->netdev_ops = &apdev_netdev_ops;
diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
index 46e0e41..b5cd2e4 100644
--- a/drivers/staging/vt6655/ioctl.c
+++ b/drivers/staging/vt6655/ioctl.c
@@ -460,7 +460,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
}
if (sValue.dwValue == 1) {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "up wpadev\n");
- memcpy(pDevice->wpadev->dev_addr,
pDevice->dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->wpadev, pDevice->dev);
pDevice->bWPADEVUp = true;
} else {
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "close wpadev\n");
diff --git a/drivers/staging/vt6655/wpactl.c b/drivers/staging/vt6655/wpactl.c
index 869f62c..e8d9ecd 100644
--- a/drivers/staging/vt6655/wpactl.c
+++ b/drivers/staging/vt6655/wpactl.c
@@ -96,7 +96,7 @@ static int wpa_init_wpadev(PSDevice pDevice)
wpadev_priv = netdev_priv(pDevice->wpadev);
*wpadev_priv = *pDevice;
- memcpy(pDevice->wpadev->dev_addr, dev->dev_addr, ETH_ALEN);
+ eth_hw_addr_inherit(pDevice->wpadev, dev);
pDevice->wpadev->base_addr = dev->base_addr;
pDevice->wpadev->irq = dev->irq;
pDevice->wpadev->mem_start = dev->mem_start;
--
1.7.10.4
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
[PATCH net-next 10/10] staging: vt6656: inherit addr_assign_type along with dev_addr
Cc: Forest Bond Signed-off-by: Bjørn Mork --- drivers/staging/vt6656/hostap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c index c699a30..3ddef9d 100644 --- a/drivers/staging/vt6656/hostap.c +++ b/drivers/staging/vt6656/hostap.c @@ -77,7 +77,7 @@ static int hostap_enable_hostapd(struct vnt_private *pDevice, int rtnl_locked) apdev_priv = netdev_priv(pDevice->apdev); *apdev_priv = *pDevice; - memcpy(pDevice->apdev->dev_addr, dev->dev_addr, ETH_ALEN); + eth_hw_addr_inherit(pDevice->apdev, dev); pDevice->apdev->netdev_ops = &apdev_netdev_ops; -- 1.7.10.4 ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
