Re: [PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-28 Thread Dan Carpenter 
On Thu, Mar 13, 2014 at 12:30:48AM -0400, Gary Rookard wrote:
 I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
 should be immediately below its function warning fix.
 

Checkpatch.pl is wrong here and your patch breaks the build if LPROCFS
is defined.  (Probably it breaks the build.  I didn't test.  Lustre
build is already broken for me.)

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Gary Rookard 
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix.

Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
 drivers/staging/lustre/lustre/fld/fld_request.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c 
b/drivers/staging/lustre/lustre/fld/fld_request.c
index 896f9fe..4474537 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -325,9 +325,8 @@ void fld_client_proc_fini(struct lu_client_fld *fld)
 {
return;
 }
-#endif
-
 EXPORT_SYMBOL(fld_client_proc_fini);
+#endif
 
 static inline int hash_is_sane(int hash)
 {
-- 
1.9.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Greg KH 
On Thu, Mar 13, 2014 at 12:04:18AM -0400, Gary Rookard wrote:
 I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix.

What is the warning?

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Gary Rookard 
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL
should be immediately below its function warning fix.

Signed-off-by: Gary Alan Rookard garyrook...@gmail.com
---
On branch staging-next
 drivers/staging/lustre/lustre/fld/fld_request.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c 
b/drivers/staging/lustre/lustre/fld/fld_request.c
index 896f9fe..4474537 100644
--- a/drivers/staging/lustre/lustre/fld/fld_request.c
+++ b/drivers/staging/lustre/lustre/fld/fld_request.c
@@ -325,9 +325,8 @@ void fld_client_proc_fini(struct lu_client_fld *fld)
 {
return;
 }
-#endif
-
 EXPORT_SYMBOL(fld_client_proc_fini);
+#endif
 
 static inline int hash_is_sane(int hash)
 {
-- 
1.9.0

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel