Re: [PATCH] staging: dgnc: remove some unused code

2014-08-10 Thread Greg KH
On Sat, Aug 02, 2014 at 08:06:38PM +0900, Seunghun Lee wrote:
 Remove some unused code.
 
 CC: Lidza Louina lidza.lou...@gmail.com
 CC: Mark Hounschell ma...@compro.net
 Signed-off-by: Seunghun Lee way...@gmail.com
 ---
  drivers/staging/dgnc/dgnc_cls.c|   72 +-
  drivers/staging/dgnc/dgnc_driver.c |   39 +-
  drivers/staging/dgnc/dgnc_driver.h |   70 +-
  drivers/staging/dgnc/dgnc_mgmt.c   |   23 ---
  drivers/staging/dgnc/dgnc_neo.c|  117 ++--
  drivers/staging/dgnc/dgnc_tty.c|  271 
 
  6 files changed, 48 insertions(+), 544 deletions(-)

That's a big patch for such a small description.

Was all of this code really unused?  Please only remove one thing at a
time, so we can review it properly.  This should be split up into a
bunch of different patches, each only doing one thing.

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel


[PATCH] staging: dgnc: remove some unused code

2014-08-02 Thread Seunghun Lee
Remove some unused code.

CC: Lidza Louina lidza.lou...@gmail.com
CC: Mark Hounschell ma...@compro.net
Signed-off-by: Seunghun Lee way...@gmail.com
---
 drivers/staging/dgnc/dgnc_cls.c|   72 +-
 drivers/staging/dgnc/dgnc_driver.c |   39 +-
 drivers/staging/dgnc/dgnc_driver.h |   70 +-
 drivers/staging/dgnc/dgnc_mgmt.c   |   23 ---
 drivers/staging/dgnc/dgnc_neo.c|  117 ++--
 drivers/staging/dgnc/dgnc_tty.c|  271 
 6 files changed, 48 insertions(+), 544 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_cls.c b/drivers/staging/dgnc/dgnc_cls.c
index cfa8384..85dcfb9 100644
--- a/drivers/staging/dgnc/dgnc_cls.c
+++ b/drivers/staging/dgnc/dgnc_cls.c
@@ -99,8 +99,6 @@ static inline void cls_set_cts_flow_control(struct channel_t 
*ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Setting CTSFLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -144,8 +142,6 @@ static inline void cls_set_ixon_flow_control(struct 
channel_t *ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Setting IXON FLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -193,8 +189,6 @@ static inline void cls_set_no_output_flow_control(struct 
channel_t *ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Unsetting Output FLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -240,8 +234,6 @@ static inline void cls_set_rts_flow_control(struct 
channel_t *ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Setting RTSFLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -283,8 +275,6 @@ static inline void cls_set_ixoff_flow_control(struct 
channel_t *ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Setting IXOFF FLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -328,8 +318,6 @@ static inline void cls_set_no_input_flow_control(struct 
channel_t *ch)
uchar ier = readb(ch-ch_cls_uart-ier);
uchar isr_fcr = 0;
 
-   DPR_PARAM((Unsetting Input FLOW\n));
-
/*
 * The Enhanced Register Set may only be accessed when
 * the Line Control Register is set to 0xBFh.
@@ -393,8 +381,6 @@ static inline void cls_clear_break(struct channel_t *ch, 
int force)
writeb((temp  ~UART_LCR_SBC), ch-ch_cls_uart-lcr);
ch-ch_flags = ~(CH_BREAK_SENDING);
ch-ch_stop_sending_break = 0;
-   DPR_IOCTL((Finishing UART_LCR_SBC! finished: %lx\n,
-   jiffies));
}
}
DGNC_UNLOCK(ch-ch_lock, lock_flags);
@@ -429,8 +415,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
if (isr  UART_IIR_NO_INT)
break;
 
-   DPR_INTR((%s:%d port: %x isr: %x\n, __FILE__, __LINE__,
-port, isr));
 
/* Receive Interrupt pending */
if (isr  (UART_IIR_RDI | UART_IIR_RDI_TIMEOUT)) {
@@ -463,7 +447,6 @@ static inline void cls_parse_isr(struct dgnc_board *brd, 
uint port)
}
 
/* Parse any modem signal changes */
-   DPR_INTR((MOD_STAT: sending to parse_modem_sigs\n));
cls_parse_modem(ch, readb(ch-ch_cls_uart-msr));
}
 }
@@ -500,10 +483,6 @@ static void cls_param(struct tty_struct *tty)
if (!bd || bd-magic != DGNC_BOARD_MAGIC)
return;
 
-   DPR_PARAM((param start: tdev: %x cflags: %x oflags: %x iflags: %x\n,
-   ch-ch_tun.un_dev, ch-ch_c_cflag, ch-ch_c_oflag,
-ch-ch_c_iflag));
-
/*
 * If baud rate is zero, flush queues, and set mval to drop DTR.
 */
@@ -587,8 +566,6 @@ static void cls_param(struct tty_struct *tty)
(jindex  16)) {
baud = bauds[iindex][jindex];
} else {
-   DPR_IOCTL((baud indices were out of range (%d)(%d),
-   iindex, jindex));
baud = 0;
}
 
@@ -737,10 +714,8 @@ static void cls_tasklet(unsigned long data)
int state = 0;
int ports = 0;
 
-   if (!bd ||