Re: [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

[Dilger, Andreas]

On Jul 11, 2017, at 11:14, Greg Kroah-Hartman  
wrote:
> 
> On Fri, Jul 07, 2017 at 01:47:04AM +, Craig Inches wrote:
>> This fixes multiple block statements found not to match
>> style as per checkpatch
>> 
>> Signed-off-by: Craig Inches 
>> ---
>> drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 
>> +
>> 1 file changed, 81 insertions(+), 48 deletions(-)
>> 
>> diff --git a/drivers/staging/lustre/include/linux/lnet/lnetst.h 
>> b/drivers/staging/lustre/include/linux/lnet/lnetst.h
>> index ea736f8d5231..a4f9ff01d458 100644
>> --- a/drivers/staging/lustre/include/linux/lnet/lnetst.h
>> +++ b/drivers/staging/lustre/include/linux/lnet/lnetst.h
>> @@ -54,7 +54,8 @@
>> #define LSTIO_GROUP_ADD  0xC10   /* add group */
>> #define LSTIO_GROUP_LIST 0xC11   /* list all groups in session */
>> #define LSTIO_GROUP_INFO 0xC12   /* query default information of
>> - * specified group */
>> + * specified group
>> + */
>> #define LSTIO_GROUP_DEL  0xC13   /* delete group */
>> #define LSTIO_NODES_ADD  0xC14   /* add nodes to specified group 
>> */
>> #define LSTIO_GROUP_UPDATE  0xC15/* update group */
>> @@ -102,27 +103,32 @@ struct lstcon_test_ent {
>>  int tse_type;   /* test type */
>>  int tse_loop;   /* loop count */
>>  int tse_concur; /* concurrency of test */
>> -};  /*** test summary entry, for
>> - *** list_batch command */
>> +};  /* test summary entry, for
>> + * list_batch command
>> + */
> 
> That's odd, what was the *** stuff for?
> 
> I'd like to get a lustre maintainer's ack for all of these before I
> apply them...

It's nothing that I know about.  We used DOxygen to comment the code and 
generate docs,
but the "***" isn't any markup that I'm familiar with.

Reviewed-by: Andreas Dilger 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation







___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

[Greg Kroah-Hartman]

On Fri, Jul 07, 2017 at 01:47:04AM +, Craig Inches wrote:
> This fixes multiple block statements found not to match
> style as per checkpatch
> 
> Signed-off-by: Craig Inches 
> ---
>  drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 
> +
>  1 file changed, 81 insertions(+), 48 deletions(-)
> 
> diff --git a/drivers/staging/lustre/include/linux/lnet/lnetst.h 
> b/drivers/staging/lustre/include/linux/lnet/lnetst.h
> index ea736f8d5231..a4f9ff01d458 100644
> --- a/drivers/staging/lustre/include/linux/lnet/lnetst.h
> +++ b/drivers/staging/lustre/include/linux/lnet/lnetst.h
> @@ -54,7 +54,8 @@
>  #define LSTIO_GROUP_ADD  0xC10   /* add group */
>  #define LSTIO_GROUP_LIST 0xC11   /* list all groups in session */
>  #define LSTIO_GROUP_INFO 0xC12   /* query default information of
> -  * specified group */
> +  * specified group
> +  */
>  #define LSTIO_GROUP_DEL  0xC13   /* delete group */
>  #define LSTIO_NODES_ADD  0xC14   /* add nodes to specified group 
> */
>  #define LSTIO_GROUP_UPDATE  0xC15/* update group */
> @@ -102,27 +103,32 @@ struct lstcon_test_ent {
>   int tse_type;   /* test type */
>   int tse_loop;   /* loop count */
>   int tse_concur; /* concurrency of test */
> -};   /*** test summary entry, for
> -  *** list_batch command */
> +};   /* test summary entry, for
> +  * list_batch command
> +  */

That's odd, what was the *** stuff for?

I'd like to get a lustre maintainer's ack for all of these before I
apply them...

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 3/4] Staging: Lustre Fixing multiline block comments in lnetst.h

[Craig Inches]

This fixes multiple block statements found not to match
style as per checkpatch

Signed-off-by: Craig Inches 
---
 drivers/staging/lustre/include/linux/lnet/lnetst.h | 129 +
 1 file changed, 81 insertions(+), 48 deletions(-)

diff --git a/drivers/staging/lustre/include/linux/lnet/lnetst.h 
b/drivers/staging/lustre/include/linux/lnet/lnetst.h
index ea736f8d5231..a4f9ff01d458 100644
--- a/drivers/staging/lustre/include/linux/lnet/lnetst.h
+++ b/drivers/staging/lustre/include/linux/lnet/lnetst.h
@@ -54,7 +54,8 @@
 #define LSTIO_GROUP_ADD0xC10   /* add group */
 #define LSTIO_GROUP_LIST   0xC11   /* list all groups in session */
 #define LSTIO_GROUP_INFO   0xC12   /* query default information of
-* specified group */
+* specified group
+*/
 #define LSTIO_GROUP_DEL0xC13   /* delete group */
 #define LSTIO_NODES_ADD0xC14   /* add nodes to specified group 
*/
 #define LSTIO_GROUP_UPDATE  0xC15  /* update group */
@@ -102,27 +103,32 @@ struct lstcon_test_ent {
int tse_type;   /* test type */
int tse_loop;   /* loop count */
int tse_concur; /* concurrency of test */
-}; /*** test summary entry, for
-*** list_batch command */
+}; /* test summary entry, for
+* list_batch command
+*/
 
 struct lstcon_batch_ent {
int bae_state;  /* batch status */
int bae_timeout;/* batch timeout */
int bae_ntest;  /* # of tests in the batch */
-}; /*** batch summary entry, for
-*** list_batch command */
+}; /* batch summary entry, for
+* list_batch command
+*/
 
 struct lstcon_test_batch_ent {
struct lstcon_ndlist_ent   tbe_cli_nle; /* client (group) node_list
-* entry */
+* entry
+*/
struct lstcon_ndlist_ent   tbe_srv_nle; /* server (group) node_list
-* entry */
+* entry
+*/
union {
struct lstcon_test_ent  tbe_test; /* test entry */
struct lstcon_batch_ent tbe_batch;/* batch entry */
} u;
-}; /*** test/batch verbose information entry,
-*** for list_batch command */
+}; /* test/batch verbose information entry,
+* for list_batch command
+*/
 
 struct lstcon_rpc_ent {
struct list_headrpe_link;   /* link chain */
@@ -138,10 +144,10 @@ struct lstcon_rpc_ent {
 };
 
 struct lstcon_trans_stat {
-   int trs_rpc_stat[4];/* RPCs stat (0: total
- 1: failed
- 2: finished
- 4: reserved */
+   int trs_rpc_stat[4];/* RPCs stat (0: total 1: failed
+* 2: finished
+* 4: reserved
+*/
int trs_rpc_errno;  /* RPC errno */
int trs_fwk_stat[8];/* framework stat */
int trs_fwk_errno;  /* errno of the first remote error */
@@ -275,22 +281,28 @@ struct lstio_session_end_args {
 struct lstio_debug_args {
int  lstio_dbg_key; /* IN: session key */
int  lstio_dbg_type;/* IN: debug
-   session|batch|
-   group|nodes
-   list */
+* session|batch|
+* group|nodes list
+*/
int  lstio_dbg_flags;   /* IN: reserved debug
-  flags */
+* flags
+*/
int  lstio_dbg_timeout; /* IN: timeout of
-