Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Wed, Feb 05, 2014 at 12:02:49PM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: > > I'll apply these after the first round goes into Linus's tree to make > > the merging easier (i.e. after the next -rc). > > Now applied. Thanks. I'll see about sending the next set out for review - hopefully I can get all of them out for the next merge window. I do have one minor fix for the component stuff you merged which I'll send out in the next few days (it's just to ensure that devm resources for the master device are properly handled.) And thanks for merging that during the previous merge window, that has been a great help. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Tue, Dec 17, 2013 at 05:13:48PM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 07:09:56PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > > > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > > > > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > > > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux > > > > > wrote: > > > > > > Russell King (8): > > > > > > imx-drm: imx-drm-core: fix error cleanup path for > > > > > > imx_drm_add_crtc() > > > > > > imx-drm: imx-drm-core: fix DRM cleanup paths > > > > > > imx-drm: fix missing symbol exports > > > > > > > > > > Except the little doubt I replied on this one, for the whole series: > > > > > > > > > > Acked-by: Shawn Guo > > > > > Tested-by: Shawn Guo > > > > > > > > > > > imx-drm: ipu-v3: fix potential CRTC device registration race > > > > > > imx-drm: imx-tve: don't call sleeping functions beneath > > > > > > enable_lock spinlo > > > > > > imx-drm: imx-drm-core: use defined constant for number of > > > > > > CRTCs. > > > > > > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > > > > > > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() > > > > > > > > Greg, > > > > > > > > Do you want me to re-send them with these acks/tested-by's added, or are > > > > you happy to take them as-is? > > > > > > I can take these as-is. > > > > Thanks. > > > > > > I also have some further patches to send (I think three) which apply on > > > > top of these but are not fixes (so aren't -rc material), more cleanups. > > > > > > Ok, feel free to send them, I can take them. > > > > They'll be along shortly. Diffstat looks smaller - just one file: > > > > drivers/staging/imx-drm/imx-drm-core.c | 55 > > +++ > > 1 files changed, 20 insertions(+), 35 deletions(-) > > > > Russell King (3): > > imx-drm: imx-drm-core: use the crtc drm device for vblank > > imx-drm: imx-drm-core: avoid going the long route round for drm_device > > imx-drm: imx-drm-core: merge imx_drm_crtc_register() into > > imx_drm_add_crtc() > > I'll apply these after the first round goes into Linus's tree to make > the merging easier (i.e. after the next -rc). Now applied. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Tue, Dec 17, 2013 at 07:09:56PM +, Russell King - ARM Linux wrote: > On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > > > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux > > > > wrote: > > > > > Russell King (8): > > > > > imx-drm: imx-drm-core: fix error cleanup path for > > > > > imx_drm_add_crtc() > > > > > imx-drm: imx-drm-core: fix DRM cleanup paths > > > > > imx-drm: fix missing symbol exports > > > > > > > > Except the little doubt I replied on this one, for the whole series: > > > > > > > > Acked-by: Shawn Guo > > > > Tested-by: Shawn Guo > > > > > > > > > imx-drm: ipu-v3: fix potential CRTC device registration race > > > > > imx-drm: imx-tve: don't call sleeping functions beneath > > > > > enable_lock spinlo > > > > > imx-drm: imx-drm-core: use defined constant for number of CRTCs. > > > > > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > > > > > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() > > > > > > Greg, > > > > > > Do you want me to re-send them with these acks/tested-by's added, or are > > > you happy to take them as-is? > > > > I can take these as-is. > > Thanks. > > > > I also have some further patches to send (I think three) which apply on > > > top of these but are not fixes (so aren't -rc material), more cleanups. > > > > Ok, feel free to send them, I can take them. > > They'll be along shortly. Diffstat looks smaller - just one file: > > drivers/staging/imx-drm/imx-drm-core.c | 55 +++ > 1 files changed, 20 insertions(+), 35 deletions(-) > > Russell King (3): > imx-drm: imx-drm-core: use the crtc drm device for vblank > imx-drm: imx-drm-core: avoid going the long route round for drm_device > imx-drm: imx-drm-core: merge imx_drm_crtc_register() into > imx_drm_add_crtc() I'll apply these after the first round goes into Linus's tree to make the merging easier (i.e. after the next -rc). thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Tue, Dec 17, 2013 at 08:05:41AM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > > > Russell King (8): > > > > imx-drm: imx-drm-core: fix error cleanup path for > > > > imx_drm_add_crtc() > > > > imx-drm: imx-drm-core: fix DRM cleanup paths > > > > imx-drm: fix missing symbol exports > > > > > > Except the little doubt I replied on this one, for the whole series: > > > > > > Acked-by: Shawn Guo > > > Tested-by: Shawn Guo > > > > > > > imx-drm: ipu-v3: fix potential CRTC device registration race > > > > imx-drm: imx-tve: don't call sleeping functions beneath > > > > enable_lock spinlo > > > > imx-drm: imx-drm-core: use defined constant for number of CRTCs. > > > > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > > > > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() > > > > Greg, > > > > Do you want me to re-send them with these acks/tested-by's added, or are > > you happy to take them as-is? > > I can take these as-is. Thanks. > > I also have some further patches to send (I think three) which apply on > > top of these but are not fixes (so aren't -rc material), more cleanups. > > Ok, feel free to send them, I can take them. They'll be along shortly. Diffstat looks smaller - just one file: drivers/staging/imx-drm/imx-drm-core.c | 55 +++ 1 files changed, 20 insertions(+), 35 deletions(-) Russell King (3): imx-drm: imx-drm-core: use the crtc drm device for vblank imx-drm: imx-drm-core: avoid going the long route round for drm_device imx-drm: imx-drm-core: merge imx_drm_crtc_register() into imx_drm_add_crtc() ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Tue, Dec 17, 2013 at 03:17:02PM +, Russell King - ARM Linux wrote: > On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > > Russell King (8): > > > imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() > > > imx-drm: imx-drm-core: fix DRM cleanup paths > > > imx-drm: fix missing symbol exports > > > > Except the little doubt I replied on this one, for the whole series: > > > > Acked-by: Shawn Guo > > Tested-by: Shawn Guo > > > > > imx-drm: ipu-v3: fix potential CRTC device registration race > > > imx-drm: imx-tve: don't call sleeping functions beneath enable_lock > > > spinlo > > > imx-drm: imx-drm-core: use defined constant for number of CRTCs. > > > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > > > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() > > Greg, > > Do you want me to re-send them with these acks/tested-by's added, or are > you happy to take them as-is? I can take these as-is. > I also have some further patches to send (I think three) which apply on > top of these but are not fixes (so aren't -rc material), more cleanups. Ok, feel free to send them, I can take them. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Tue, Dec 17, 2013 at 01:04:20PM +0800, Shawn Guo wrote: > On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > > Russell King (8): > > imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() > > imx-drm: imx-drm-core: fix DRM cleanup paths > > imx-drm: fix missing symbol exports > > Except the little doubt I replied on this one, for the whole series: > > Acked-by: Shawn Guo > Tested-by: Shawn Guo > > > imx-drm: ipu-v3: fix potential CRTC device registration race > > imx-drm: imx-tve: don't call sleeping functions beneath enable_lock > > spinlo > > imx-drm: imx-drm-core: use defined constant for number of CRTCs. > > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() Greg, Do you want me to re-send them with these acks/tested-by's added, or are you happy to take them as-is? I also have some further patches to send (I think three) which apply on top of these but are not fixes (so aren't -rc material), more cleanups. Thanks. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Mon, Dec 16, 2013 at 12:38:23PM +, Russell King - ARM Linux wrote: > Russell King (8): > imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() > imx-drm: imx-drm-core: fix DRM cleanup paths > imx-drm: fix missing symbol exports Except the little doubt I replied on this one, for the whole series: Acked-by: Shawn Guo Tested-by: Shawn Guo > imx-drm: ipu-v3: fix potential CRTC device registration race > imx-drm: imx-tve: don't call sleeping functions beneath enable_lock > spinlo > imx-drm: imx-drm-core: use defined constant for number of CRTCs. > imx-drm: imx-drm-core: make imx_drm_crtc_register() safer > imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() > ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Re: [PATCH 0/8] Fix some bugs/races in imx-drm
On Mon, Dec 16, 2013 at 11:33:01AM +, Russell King - ARM Linux wrote: > The following patch series fixes some bugs and races in the imx-drm > code, which should probably be applied to an -rc kernel. > > drivers/staging/imx-drm/imx-drm-core.c | 21 - > drivers/staging/imx-drm/ipu-v3/ipu-common.c | 32 +- > drivers/staging/imx-drm/ipuv3-plane.c | 10 > 3 files changed, 41 insertions(+), 22 deletions(-) > > Russell King (4): > imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() > imx-drm: imx-drm-core: fix DRM cleanup paths > imx-drm: fix missing symbol exports > imx-drm: ipu-v3: fix potential CRTC device registration race I've decided to add four more patches to this set from my 50+ patch set for this driver. The new four come after the above four, so I'll just append them to the thread. New diffstat/shortlog: drivers/staging/imx-drm/imx-drm-core.c | 39 --- drivers/staging/imx-drm/imx-tve.c |9 -- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 32 +++--- drivers/staging/imx-drm/ipuv3-plane.c | 10 +++ 4 files changed, 55 insertions(+), 35 deletions(-) Russell King (8): imx-drm: imx-drm-core: fix error cleanup path for imx_drm_add_crtc() imx-drm: imx-drm-core: fix DRM cleanup paths imx-drm: fix missing symbol exports imx-drm: ipu-v3: fix potential CRTC device registration race imx-drm: imx-tve: don't call sleeping functions beneath enable_lock spinlo imx-drm: imx-drm-core: use defined constant for number of CRTCs. imx-drm: imx-drm-core: make imx_drm_crtc_register() safer imx-drm: imx-drm-core: improve safety of imx_drm_add_crtc() ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
