Re: [PATCH] staging: rtl8723au: Fix static symbol sparse warning

2014-08-02 Thread Jes Sorensen 
Larry Finger larry.fin...@lwfinger.net writes:
 On 08/01/2014 08:06 AM, Miguel Oliveira wrote:
 Fix sparse warning:
 drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol
 efuse_GetCurrentSize23a' was not declared. Should it be static?
 
 Signed-off-by: Miguel Oliveira cmro...@gmail.com
 ---
  drivers/staging/rtl8723au/include/rtw_efuse.h |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/rtl8723au/include/rtw_efuse.h
 b/drivers/staging/rtl8723au/include/rtw_efuse.h
 index 07bdc34..304cc71 100644
 --- a/drivers/staging/rtl8723au/include/rtw_efuse.h
 +++ b/drivers/staging/rtl8723au/include/rtw_efuse.h
 @@ -82,6 +82,7 @@ struct pg_pkt_struct {
  /*Export global
 variable*/
  
  u16 efuse_GetMaxSize23a(struct rtw_adapter *padapter);
 +int efuse_GetCurrentSize23a(struct rtw_adapter *padapter, u16 *size);
  int rtw_efuse_access23a(struct rtw_adapter *padapter, u8 bRead, u16
 start_addr, u16 cnts, u8 *data);
  int rtw_efuse_map_read23a(struct rtw_adapter *padapter, u16 addr,
 u16 cnts, u8 *data);
  u8 rtw_efuse_map_write(struct rtw_adapter *padapter, u16 addr, u16
 cnts, u8 *data);

 NACK. Whenever Sparse issues this warning, you should first check to see if it
 can be made static. Adding it to a header to make the Sparse warning go away 
 is
 not correct unless some other routine needs it to be globally known. In this
 case, no other routine needs it.

 Of course, making it static will lead to the compilation warning that the
 routine is not used. The correct patch is to delete the entire routine as it 
 is
 never called.

Yep, fix it correctly, or don't bother!

Cheers,
Jes
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723au: Fix static symbol sparse warning

2014-08-01 Thread Paul Bolle 
On Fri, 2014-08-01 at 14:06 +0100, Miguel Oliveira wrote:
 Fix sparse warning:
 drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol 
 'efuse_GetCurrentSize23a' was not declared. Should it be static?
 
 Signed-off-by: Miguel Oliveira cmro...@gmail.com
 ---
  drivers/staging/rtl8723au/include/rtw_efuse.h |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/rtl8723au/include/rtw_efuse.h 
 b/drivers/staging/rtl8723au/include/rtw_efuse.h
 index 07bdc34..304cc71 100644
 --- a/drivers/staging/rtl8723au/include/rtw_efuse.h
 +++ b/drivers/staging/rtl8723au/include/rtw_efuse.h
 @@ -82,6 +82,7 @@ struct pg_pkt_struct {
  /*Export global 
 variable*/
  
  u16  efuse_GetMaxSize23a(struct rtw_adapter *padapter);
 +int  efuse_GetCurrentSize23a(struct rtw_adapter *padapter, u16 *size);
  int  rtw_efuse_access23a(struct rtw_adapter *padapter, u8 bRead, u16 
 start_addr, u16 cnts, u8 *data);
  int  rtw_efuse_map_read23a(struct rtw_adapter *padapter, u16 addr, u16 cnts, 
 u8 *data);
  u8   rtw_efuse_map_write(struct rtw_adapter *padapter, u16 addr, u16 cnts, 
 u8 *data);

This function is never used in current linux-next. So I think it might
as well be dropped.

Note there's also Efuse_GetCurrentSize23a (with an uppercase 'E'). It's
used just once. You could probably submit another patch to remove that
from rtw_efuse.h and make it static in rtw_efuse.c The comment above
that function needs and update too, but maybe it's also OK to drop that
comment.


Paul Bolle

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: rtl8723au: Fix static symbol sparse warning

2014-08-01 Thread Larry Finger 
On 08/01/2014 08:06 AM, Miguel Oliveira wrote:
 Fix sparse warning:
 drivers/staging/rtl8723au/core/rtw_efuse.c:579:5: warning: symbol 
 'efuse_GetCurrentSize23a' was not declared. Should it be static?
 
 Signed-off-by: Miguel Oliveira cmro...@gmail.com
 ---
  drivers/staging/rtl8723au/include/rtw_efuse.h |1 +
  1 file changed, 1 insertion(+)
 
 diff --git a/drivers/staging/rtl8723au/include/rtw_efuse.h 
 b/drivers/staging/rtl8723au/include/rtw_efuse.h
 index 07bdc34..304cc71 100644
 --- a/drivers/staging/rtl8723au/include/rtw_efuse.h
 +++ b/drivers/staging/rtl8723au/include/rtw_efuse.h
 @@ -82,6 +82,7 @@ struct pg_pkt_struct {
  /*Export global 
 variable*/
  
  u16  efuse_GetMaxSize23a(struct rtw_adapter *padapter);
 +int  efuse_GetCurrentSize23a(struct rtw_adapter *padapter, u16 *size);
  int  rtw_efuse_access23a(struct rtw_adapter *padapter, u8 bRead, u16 
 start_addr, u16 cnts, u8 *data);
  int  rtw_efuse_map_read23a(struct rtw_adapter *padapter, u16 addr, u16 cnts, 
 u8 *data);
  u8   rtw_efuse_map_write(struct rtw_adapter *padapter, u16 addr, u16 cnts, 
 u8 *data);

NACK. Whenever Sparse issues this warning, you should first check to see if it
can be made static. Adding it to a header to make the Sparse warning go away is
not correct unless some other routine needs it to be globally known. In this
case, no other routine needs it.

Of course, making it static will lead to the compilation warning that the
routine is not used. The correct patch is to delete the entire routine as it is
never called.

Larry


___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel