Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

2019-01-07 Thread Dan Carpenter 
On Mon, Jan 07, 2019 at 11:40:08AM +, David Binderman wrote:
> 
> Hello there,
> 
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: 
> (style) Expression is always false because 'else if' condition matches 
> previous condition at line 410.
> 
> Source code is
> 
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
> 

That's true, but that's how to the code was originally when it was
committed 5 years ago so it's hard to tell what the fix should be...

regards,
dan carpenter

___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

2019-01-07 Thread gre...@linuxfoundation.org 
On Mon, Jan 07, 2019 at 11:40:08AM +, David Binderman wrote:
> 
> Hello there,
> 
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: 
> (style) Expression is always false because 'else if' condition matches 
> previous condition at line 410.
> 
> Source code is
> 
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 2;
> else if (pRaInfo->HighestRate > 0x0b)
> pRaInfo->PTModeSS = 1;
> 
> Suggest code rework.

Patches are always gladly accepted!

thanks,

greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel