Re: [Orgmode] org-infojs-handle-options fails when :infojs-opt is not in exp-list

2009-01-08 Thread Friedrich Delgado Friedrichs
Hi.

A while ago I had this problem:
org-infojs-handle-options: Wrong type argument: stringp, nil

I wonder if my patch ever reached the mailing list, or if it
was overlooked because it was too close to christmas:

Friedrich Delgado Friedrichs schrieb:
 From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00 2001
 From: Friedrich Delgado Friedrichs delg...@dfn-cert.de
 Date: Tue, 23 Dec 2008 12:10:42 +0100
 Subject: [PATCH] fix string-match against nil when no in-file options are set 
 for jsinfo
 
 ---
  lisp/org-jsinfo.el |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el
 index 8f2d7e8..19faa9e 100644
 --- a/lisp/org-jsinfo.el
 +++ b/lisp/org-jsinfo.el
 @@ -140,7 +140,8 @@ Option settings will replace the %MANAGER-OPTIONS cookie.
  default (cdr (assoc opt org-infojs-options)))
(and (symbolp default) (not (memq default '(t nil)))
 (setq default (plist-get exp-plist default)))
 -  (if (string-match (format  %s:\\(\\S-+\\) opt) v)
 +  (if (and v
 +   (string-match (format  %s:\\(\\S-+\\) opt) v))
(setq val (match-string 1 v))
  (setq val default))
(cond
 -- 
 1.6.0.2.526.g5c283.dirty
---Zitatende---

-- 
Friedrich Delgado Friedrichs frie...@nomaden.org
Laziness led to the invention of the most useful tools.


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] org-infojs-handle-options fails when :infojs-opt is not in exp-list

2009-01-08 Thread Carsten Dominik

Apparently, I had indeed overlooked this patch.

Fixed now, thanks for resending it.

- Carsten

On Jan 8, 2009, at 3:12 PM, Friedrich Delgado Friedrichs wrote:


Hi.

A while ago I had this problem:
org-infojs-handle-options: Wrong type argument: stringp, nil

I wonder if my patch ever reached the mailing list, or if it
was overlooked because it was too close to christmas:

Friedrich Delgado Friedrichs schrieb:
From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00  
2001

From: Friedrich Delgado Friedrichs delg...@dfn-cert.de
Date: Tue, 23 Dec 2008 12:10:42 +0100
Subject: [PATCH] fix string-match against nil when no in-file  
options are set for jsinfo


---
lisp/org-jsinfo.el |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el
index 8f2d7e8..19faa9e 100644
--- a/lisp/org-jsinfo.el
+++ b/lisp/org-jsinfo.el
@@ -140,7 +140,8 @@ Option settings will replace the %MANAGER- 
OPTIONS cookie.

default (cdr (assoc opt org-infojs-options)))
  (and (symbolp default) (not (memq default '(t nil)))
   (setq default (plist-get exp-plist default)))
-  (if (string-match (format  %s:\\(\\S-+\\) opt) v)
+  (if (and v
+   (string-match (format  %s:\\(\\S-+\\) opt) v))
  (setq val (match-string 1 v))
(setq val default))
  (cond
--
1.6.0.2.526.g5c283.dirty

---Zitatende---

--
   Friedrich Delgado Friedrichs frie...@nomaden.org
Laziness led to the invention of the most useful tools.


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode




___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


[Orgmode] org-infojs-handle-options fails when :infojs-opt is not in exp-list

2008-12-23 Thread Friedrich Delgado Friedrichs
Hi.

I got

 org-infojs-handle-options: Wrong type argument: stringp, nil

the first time I tried to do a html export with java script turned on.

I didn't change any options in 'Org Infojs Options' yet, so I guess
that's why (plist-get exp-plist :infojs-opt) returns nil and
string-match gives an error.

Workaround: set an option
Fix: Uhm, probably

(or (not (plist-get exp-plist :infojs-opt))
(not (plist-get exp-plist :infojs-opt))
(string-match \\view:nil\\
 (plist-get exp-plist :infojs-opt)))

Or something like that.

-- 
Friedrich Delgado Friedrichs frie...@nomaden.org


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] org-infojs-handle-options fails when :infojs-opt is not in exp-list

2008-12-23 Thread Friedrich Delgado Friedrichs
Doh!

Friedrich Delgado Friedrichs schrieb:
 Workaround: set an option

Doesn't work.

 Fix: 

Complete rubbish, as I just noticed... I think I got the wrong spot...

-- 
Friedrich Delgado Friedrichs frie...@nomaden.org
Vaßmerstraße 3 +49-4161/651844
21614 Buxtehude   TauPan on Ircnet and Freenode ;)


___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode


Re: [Orgmode] org-infojs-handle-options fails when :infojs-opt is not in exp-list

2008-12-23 Thread Friedrich Delgado Friedrichs
Found the culprit :)

org-jsinfo rocks :)

-- 
Friedrich Delgado Friedrichs frie...@nomaden.org
From 0fef25f56c837ae9f434449c6f30268e0474f7ab Mon Sep 17 00:00:00 2001
From: Friedrich Delgado Friedrichs delg...@dfn-cert.de
Date: Tue, 23 Dec 2008 12:10:42 +0100
Subject: [PATCH] fix string-match against nil when no in-file options are set for jsinfo

---
 lisp/org-jsinfo.el |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/org-jsinfo.el b/lisp/org-jsinfo.el
index 8f2d7e8..19faa9e 100644
--- a/lisp/org-jsinfo.el
+++ b/lisp/org-jsinfo.el
@@ -140,7 +140,8 @@ Option settings will replace the %MANAGER-OPTIONS cookie.
 default (cdr (assoc opt org-infojs-options)))
   (and (symbolp default) (not (memq default '(t nil)))
(setq default (plist-get exp-plist default)))
-  (if (string-match (format  %s:\\(\\S-+\\) opt) v)
+  (if (and v
+   (string-match (format  %s:\\(\\S-+\\) opt) v))
   (setq val (match-string 1 v))
 (setq val default))
   (cond
-- 
1.6.0.2.526.g5c283.dirty

___
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode