Re: [O] outorg issue
Kaushal writes: Hi all, Hi Bastien, > I don't know the outshine and outorg code in and out. But I wouldn't > mind keeping it maintained with the pull requests I get. > > That said, adding Thorsten Jolitz to this discussion. > @Thorsten Would you mind making me ( > https://github.com/tj64/outshine/pull/46 ) a temporary maintainer of > your outshine package on github. Or do you have anyone in mind you > would take this up? Thanks. sorry for being so late to the party, I didn't even notice the cc'd messages, probably because I used to read this mailing list only via gmane and filtered the posts from my mail inbox. I feel bad anyway for the issues on github not taken care of, and while I started to touch Emacs once in a while again, I'm afraid I won't be much of a maintainer for these libraries in the future due to lack of time and energy. I used to simply apply patches untested on github, but that wasn't a popular decision either. So I'm very happy if somebody would like to take over (permanent) maintainershisp. For me outshine.el, outorg.el and navi-mode.el always belonged together as the 'outshine suite', so to say, so I would prefer to give them away as a bundle to a new maintainer (whoever that might be, I'll leave that up to the Org Community and Maintainers). I still find them quite usefull, I used them almost all the time when programming or writing emails with emacs, and will do so in the future whenever I touch Emacs. So thanks in advance to the new maintainer, let me know (PM?) if I have to do something in the course of changing maintainership > I'd also like to second Bastien's suggestion, it would be > excellent to > see this useful extension maintained again. 1+ -- cheers, Thorsten
Re: [O] outorg issue
I don't know the outshine and outorg code in and out. But I wouldn't mind keeping it maintained with the pull requests I get. That said, adding Thorsten Jolitz to this discussion. @Thorsten Would you mind making me ( https://github.com/tj64/outshine/pull/46 ) a temporary maintainer of your outshine package on github. Or do you have anyone in mind you would take this up? Thanks. On Wed, Aug 19, 2015 at 2:26 PM Pip Cet wrote: > On 8/19/15, Andreas Leha wrote: > > Thank you for your patch! It seems as it breaks global visibility > > cycling, though. > > Sorry about that, I really messed up there. Kaushal's patch should > work better, as long as there is at least one valid heading in the > file (if I try running it on an entirely empty org file, I can still > produce the error message with M-x outline-hide-sublevels). > > I'd also like to second Bastien's suggestion, it would be excellent to > see this useful extension maintained again. > >
Re: [O] outorg issue
On 8/19/15, Andreas Leha wrote: > Thank you for your patch! It seems as it breaks global visibility > cycling, though. Sorry about that, I really messed up there. Kaushal's patch should work better, as long as there is at least one valid heading in the file (if I try running it on an entirely empty org file, I can still produce the error message with M-x outline-hide-sublevels). I'd also like to second Bastien's suggestion, it would be excellent to see this useful extension maintained again.
Re: [O] outorg issue
Hi Pip, Pip Cet writes: > Hi, > can you confirm the issue only appears when the first line of the > buffer isn't an outline heading? I think it's easy enough to fix then, > and if you like you might want to try the patch I've attached. > > It's bugged me for a while that `org-back-to-heading' et al throw > errors when they're used before the first heading, but I haven't > really come up with a better solution. Thank you for your patch! It seems as it breaks global visibility cycling, though. Regards, Andreas
Re: [O] outorg issue
Hi Kaushal, Kaushal writes: > I had submitted a pull request to solve this issue on that author's outshine > package page a couple of months back but as Andreas noted, the author hasn't > been able to maintain this stuff > due to personal reasons. > > You can fix this issue by manually making changes in your copy of outshine as > per this PR: https://github.com/tj64/outshine/pull/46/files > > I use outshine daily and I needed to fix only outshine.el. Probably outorg.el > needs a similar fix? > Thanks for your patch! In my first quick tests, this seems to work nicely! Nothing seems to be needed for outorg. Regards, Andreas
Re: [O] outorg issue
Hi Kaushal, thanks for sharing your solution. Kaushal writes: > You can fix this issue by manually making changes in your copy of > outshine as per this PR: https://github.com/tj64/outshine/pull/46/ > files > > I use outshine daily and I needed to fix only outshine.el. Probably > outorg.el needs a similar fix? Maybe Thorsten would be fine to have you as a maintainer for his libraries? Even temporarily? -- Bastien
Re: [O] outorg issue
Hi, can you confirm the issue only appears when the first line of the buffer isn't an outline heading? I think it's easy enough to fix then, and if you like you might want to try the patch I've attached. It's bugged me for a while that `org-back-to-heading' et al throw errors when they're used before the first heading, but I haven't really come up with a better solution. On 8/18/15, Andreas Leha wrote: > Hi Bastien, > > Bastien writes: >> Hi Andreas, >> >> Andreas Leha writes: >> >>> For quite some time now, I have to disable outshine/outorg [1] as it >>> does give me "Before first heading" (complete backtrace [2]) whenever I >>> open an org file followed by more issues actually using org mode. >> >> Copying Thorsten as the author of outshine.el, hopefully he's be able >> to dig deeper. > > Thanks, but my hopes are low. Quoting from the top of outshine's github > readme [1]: > > , > | events in my life forced me away from Emacs and [...] I won't have the > | time to fix issues or code new features (though I will apply patches) > ` > > Regards, > Andreas > > [1] https://github.com/tj64/outshine > > > From 753f4e2723c493274d9e55c195296fe5d0b5773e Mon Sep 17 00:00:00 2001 From: Philip Date: Tue, 18 Aug 2015 20:24:13 + Subject: [PATCH] Avoid error when first line of the buffer isn't a heading. * outshine.el (outline-hide-sublevels): Avoid error for files that don't begin with a heading. (outline-cycle): Avoid error for files that don't begin with a heading. --- outshine.el | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/outshine.el b/outshine.el index 9ccbd1f..aba5271 100644 --- a/outshine.el +++ b/outshine.el @@ -1826,8 +1826,9 @@ The old value is stored in (setq keep-levels (1- keep-levels)) (save-excursion (goto-char (point-min)) -(hide-subtree) -(show-children keep-levels) +(when (outline-on-heading-p) + (hide-subtree) + (show-children keep-levels)) (condition-case err (while (outline-get-next-sibling) (hide-subtree) @@ -2048,7 +2049,8 @@ may have changed." (message "SUBTREE"))) (t ;; Default action: hide the subtree. - (hide-subtree) + (when (outline-on-heading-p) +(hide-subtree)) (unless outshine-cycle-silently (message "FOLDED")) -- 2.5.0
Re: [O] outorg issue
I had submitted a pull request to solve this issue on that author's outshine package page a couple of months back but as Andreas noted, the author hasn't been able to maintain this stuff due to personal reasons. You can fix this issue by manually making changes in your copy of outshine as per this PR: https://github.com/tj64/outshine/pull/46/files I use outshine daily and I needed to fix only outshine.el. Probably outorg.el needs a similar fix? On Tue, Aug 18, 2015 at 3:54 PM Andreas Leha < andreas.l...@med.uni-goettingen.de> wrote: > Hi Bastien, > > Bastien writes: > > Hi Andreas, > > > > Andreas Leha writes: > > > >> For quite some time now, I have to disable outshine/outorg [1] as it > >> does give me "Before first heading" (complete backtrace [2]) whenever I > >> open an org file followed by more issues actually using org mode. > > > > Copying Thorsten as the author of outshine.el, hopefully he's be able > > to dig deeper. > > Thanks, but my hopes are low. Quoting from the top of outshine's github > readme [1]: > > , > | events in my life forced me away from Emacs and [...] I won't have the > | time to fix issues or code new features (though I will apply patches) > ` > > Regards, > Andreas > > [1] https://github.com/tj64/outshine > > >
Re: [O] outorg issue
Hi Bastien, Bastien writes: > Hi Andreas, > > Andreas Leha writes: > >> For quite some time now, I have to disable outshine/outorg [1] as it >> does give me "Before first heading" (complete backtrace [2]) whenever I >> open an org file followed by more issues actually using org mode. > > Copying Thorsten as the author of outshine.el, hopefully he's be able > to dig deeper. Thanks, but my hopes are low. Quoting from the top of outshine's github readme [1]: , | events in my life forced me away from Emacs and [...] I won't have the | time to fix issues or code new features (though I will apply patches) ` Regards, Andreas [1] https://github.com/tj64/outshine
Re: [O] outorg issue
Hi Andreas, Andreas Leha writes: > For quite some time now, I have to disable outshine/outorg [1] as it > does give me "Before first heading" (complete backtrace [2]) whenever I > open an org file followed by more issues actually using org mode. Copying Thorsten as the author of outshine.el, hopefully he's be able to dig deeper. Thanks, -- Bastien
Re: [O] outorg issue
Hi John, Thanks for the confirmation! Andreas John Kitchin writes: > I can only confirm I have had the same issue for a while. For me it is > mostly when I press shift-tab. regular tab works fine for cycling. > > The problem seems to arise from the point moving to the beginning of the > buffer when outline-back-to-heading is called, which raises that > error. I don't have time today to dig much further. I hope that helps > get a solution though! I miss outshine! > > > Andreas Leha writes: > >> Hi all, >> >> For quite some time now, I have to disable outshine/outorg [1] as it >> does give me "Before first heading" (complete backtrace [2]) whenever I >> open an org file followed by more issues actually using org mode. >> >> I can even reproduce this with emacs -Q and a minimal configuration [3]. >> >> My system is: >> : GNU Emacs 25.0.50.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version >> 10.9.5 (Build 13F1077)) >> : of 2015-06-17 >> : Org-mode version 8.3beta (release_8.3beta-1264-g365c19) >> >> >> Can anyone reproduce this and/or has a fix? Or am I missing anything >> obvious? >> >> Thanks in advance! >> >> >> Regards, >> Andreas >> >> >> >> >> [1] https://github.com/tj64/outshine >> https://github.com/tj64/outorg >> >> >> [2] complete backtrace when opening a random org file >> >> --8<---cut here---start->8--- >> Debugger entered--Lisp error: (error "Before first heading") >> signal(error ("Before first heading")) >> error("Before first heading") >> outline-back-to-heading() >> outline-flag-subtree(t) >> hide-subtree() >> (save-excursion (goto-char (point-min)) (hide-subtree) (show-children >> keep-levels) (condition-case err (while (outline-get-next-sibling) >> (hide-subtree) (show-children keep-levels)) (error nil))) >> hide-sublevels(1) >> org-overview() >> org-set-startup-visibility() >> org-mode() >> set-auto-mode-0(org-mode nil) >> set-auto-mode() >> normal-mode(t) >> after-find-file(nil t) >> find-file-noselect-1(# >> "~/hipsci/cellomics/cellomics.org" nil nil >> "~/hipsci/cellomics/cellomics.org" (25636441 16777218)) >> find-file-noselect("~/hipsci/cellomics/cellomics.org" nil nil t) >> find-file("~/hipsci/cellomics/cellomics.org" t) >> funcall-interactively(find-file "~/hipsci/cellomics/cellomics.org" t) >> call-interactively(find-file nil nil) >> command-execute(find-file) >> --8<---cut here---end--->8--- >> >> >> >> [3] minimal startup file >> >> --8<---cut here---start->8--- >> ;; outorg/outshine pre-requisite >> (defvar outline-minor-mode-prefix "\M-#") >> >> (add-to-list 'load-path (expand-file-name >> "~/local/emacs/org-mode-install/lisp")) >> (add-to-list 'auto-mode-alist '("\\.\\(org\\ |org_archive\\|txt\\)$" . >> org-mode)) >> >> ;; outorg/outshine >> (add-to-list 'load-path "~/local/emacs/org-mode-in-comments/outorg/") >> (add-to-list 'load-path "~/local/emacs/org-mode-in-comments/outshine") >> (require 'outshine) >> (add-hook 'outline-minor-mode-hook 'outshine-hook-function) >> (setq outshine-use-speed-commands t) >> --8<---cut here---end--->8--- > > -- > Professor John Kitchin > Doherty Hall A207F > Department of Chemical Engineering > Carnegie Mellon University > Pittsburgh, PA 15213 > 412-268-7803 > @johnkitchin > http://kitchingroup.cheme.cmu.edu
Re: [O] outorg issue
I can only confirm I have had the same issue for a while. For me it is mostly when I press shift-tab. regular tab works fine for cycling. The problem seems to arise from the point moving to the beginning of the buffer when outline-back-to-heading is called, which raises that error. I don't have time today to dig much further. I hope that helps get a solution though! I miss outshine! Andreas Leha writes: > Hi all, > > For quite some time now, I have to disable outshine/outorg [1] as it > does give me "Before first heading" (complete backtrace [2]) whenever I > open an org file followed by more issues actually using org mode. > > I can even reproduce this with emacs -Q and a minimal configuration [3]. > > My system is: > : GNU Emacs 25.0.50.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version > 10.9.5 (Build 13F1077)) > : of 2015-06-17 > : Org-mode version 8.3beta (release_8.3beta-1264-g365c19) > > > Can anyone reproduce this and/or has a fix? Or am I missing anything > obvious? > > Thanks in advance! > > > Regards, > Andreas > > > > > [1] https://github.com/tj64/outshine > https://github.com/tj64/outorg > > > [2] complete backtrace when opening a random org file > > --8<---cut here---start->8--- > Debugger entered--Lisp error: (error "Before first heading") > signal(error ("Before first heading")) > error("Before first heading") > outline-back-to-heading() > outline-flag-subtree(t) > hide-subtree() > (save-excursion (goto-char (point-min)) (hide-subtree) (show-children > keep-levels) (condition-case err (while (outline-get-next-sibling) > (hide-subtree) (show-children keep-levels)) (error nil))) > hide-sublevels(1) > org-overview() > org-set-startup-visibility() > org-mode() > set-auto-mode-0(org-mode nil) > set-auto-mode() > normal-mode(t) > after-find-file(nil t) > find-file-noselect-1(# > "~/hipsci/cellomics/cellomics.org" nil nil "~/hipsci/cellomics/cellomics.org" > (25636441 16777218)) > find-file-noselect("~/hipsci/cellomics/cellomics.org" nil nil t) > find-file("~/hipsci/cellomics/cellomics.org" t) > funcall-interactively(find-file "~/hipsci/cellomics/cellomics.org" t) > call-interactively(find-file nil nil) > command-execute(find-file) > --8<---cut here---end--->8--- > > > > [3] minimal startup file > > --8<---cut here---start->8--- > ;; outorg/outshine pre-requisite > (defvar outline-minor-mode-prefix "\M-#") > > (add-to-list 'load-path (expand-file-name > "~/local/emacs/org-mode-install/lisp")) > (add-to-list 'auto-mode-alist '("\\.\\(org\\ |org_archive\\|txt\\)$" . > org-mode)) > > ;; outorg/outshine > (add-to-list 'load-path "~/local/emacs/org-mode-in-comments/outorg/") > (add-to-list 'load-path "~/local/emacs/org-mode-in-comments/outshine") > (require 'outshine) > (add-hook 'outline-minor-mode-hook 'outshine-hook-function) > (setq outshine-use-speed-commands t) > --8<---cut here---end--->8--- -- Professor John Kitchin Doherty Hall A207F Department of Chemical Engineering Carnegie Mellon University Pittsburgh, PA 15213 412-268-7803 @johnkitchin http://kitchingroup.cheme.cmu.edu