Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Ihor Radchenko  writes:

> Ihor Radchenko  writes:
>
>> Part of the problem is some undocumented behaviour of isearch.
>> I will need to consult Emacs devs before fixing.
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399

There seems to be no easy way to fix isearch yet retaining the ability
to obey `org-fold-show-context-detail'.  I have disabled
`org-fold-show-context-detail' when revealing folds temporarily +
`org-fold-core-style' = 'overlays.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=df4a5d86d

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Samuel Wales]

more below.

On 12/29/22, Ihor Radchenko  wrote:
> Samuel Wales  writes:
>
>> possibly related: are links still not searchable with iserch without
>> being in reveal mode or similar?  [9.4 here.)
>
> Unrelated.
> The reported issue is related to the new org-fold implementation.

ok didn't men to lower s/n.

tanks for your patience.

>
> The old issue with searching links is known. It is simply because
> isearch does not support searching inside invisible text. And links are
> abbreviated by applying invisible text property to the hidden parts.

>
> You either upgrade or set isearch-invisible to t.


i look forward to it if it is fixed.  fwiw i vaguely thought the issue
was overlays or so, as the default value is 'open.  but it sounds like
you are saying this was fixed in emacs or org.  i do have a vague
inkling that it was fixed in future emacs or org.


>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Ihor Radchenko  writes:

> Part of the problem is some undocumented behaviour of isearch.
> I will need to consult Emacs devs before fixing.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60399

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Samuel Wales  writes:

> possibly related: are links still not searchable with iserch without
> being in reveal mode or similar?  [9.4 here.)

Unrelated.
The reported issue is related to the new org-fold implementation.

The old issue with searching links is known. It is simply because
isearch does not support searching inside invisible text. And links are
abbreviated by applying invisible text property to the hidden parts.

You either upgrade or set isearch-invisible to t.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Samuel Wales]

possibly related: are links still not searchable with iserch without
being in reveal mode or similar?  [9.4 here.)

On 12/28/22, Ihor Radchenko  wrote:
> Matt Lundin  writes:
>
>> Here is a minimal recipe for reproducing the bug:
>>
>> Use a minimal emacs startup file:
>>
>> --8<---cut here---start->8---
>> (add-to-list 'load-path "~/org-mode/lisp/")
>> (setq org-startup-folded t)
>> (setq org-fold-core-style 'overlays)
>> --8<---cut here---end--->8---
>>
>> Open the following file:
>>
>> --8<---cut here---start->8---
>> * One
>> word
>> * Two
>> word
>> --8<---cut here---end--->8---
>>
>> Issue #1:
>>
>> Go to the beginning of headline "Two" when the trees are folded.
>>
>> Type "M-x isearch word [RET]".
>
> Confirmed.
> Part of the problem is some undocumented behaviour of isearch.
> I will need to consult Emacs devs before fixing.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at .
> Support Org development at ,
> or support my work at 
>
>


-- 
The Kafka Pandemic

A blog about science, health, human rights, and misopathy:
https://thekafkapandemic.blogspot.com

Re: [Bug] isearch errors when org-fold-core-style is 'overlays

[Ihor Radchenko]

Matt Lundin  writes:

> Here is a minimal recipe for reproducing the bug:
>
> Use a minimal emacs startup file:
>
> --8<---cut here---start->8---
> (add-to-list 'load-path "~/org-mode/lisp/")
> (setq org-startup-folded t)
> (setq org-fold-core-style 'overlays)
> --8<---cut here---end--->8---
>
> Open the following file:
>
> --8<---cut here---start->8---
> * One
> word
> * Two
> word
> --8<---cut here---end--->8---
>
> Issue #1:
>
> Go to the beginning of headline "Two" when the trees are folded.
>
> Type "M-x isearch word [RET]".

Confirmed.
Part of the problem is some undocumented behaviour of isearch.
I will need to consult Emacs devs before fixing.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at