[Enigmail] [PATCH] explicitly place stderr on file descriptor 2
Earlier lines explicitly place stdin and stdout on file descriptors 0 and 1. It looks like that's what we're trying to do for stderr as well. Use dup2 instead of dup to avoid compile error: ipc/src/subprocess.c: In function ‘launchProcess’: ipc/src/subprocess.c:88:8: error: ignoring return value of ‘dup’, declared with attribute warn_unused_result [-Werror=unused-result] dup(mergeStderr ? fd_out[1] : fd_err[1]); ^ cc1: all warnings being treated as errors make: *** [ipc/src/subprocess.o] Error 1 --- ipc/src/subprocess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/src/subprocess.c b/ipc/src/subprocess.c index 5343120..7c67ccb 100644 --- a/ipc/src/subprocess.c +++ b/ipc/src/subprocess.c @@ -85,7 +85,7 @@ pid_t launchProcess(const char *path, dup2(fd_out[1], 1); close(2); -dup(mergeStderr ? fd_out[1] : fd_err[1]); +dup2(mergeStderr ? fd_out[1] : fd_err[1], 2); for (i=0; ihttps://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
Re: [Enigmail] behaviour of enigmail 1.6 in Thunderbird 24.2.0
On 20/12/2013 00:20, Olav Seyfarth wrote: >> With 1.6, I never found a usable option for 'view OpenPGP photoID' under >> > the 'Details' button - it was always grayed out. With 1.7a1pre, sometimes >> > it is there and it works. Other times it is grayed out but the photoID is >> > present and can be viewed through the key manager. I can't spot any >> > differences between the cases where the option is available and those where >> > it is grayed out. Any ideas ? > No. You did turn Enigmail debugging on and checkt the output files for hints? > > Olav I can see in the debug logfile where the ID picture is displayed - the log file turns 'binary' for a line or three. But I don't know enough about the program to understand what all the debug info is. In any case, I can't see anything which suggests why in one case, the option to view photo ID is available under the 'Details' button and in another case this option is greyed out but the photo info can still be seen by taking the 'View key properties' option and then selecting 'View Photo ID' from the lower left 'Select Action button' Philip 0x23543A63.asc Description: application/pgp-keys ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
Re: [Enigmail] behaviour of enigmail 1.6 in Thunderbird 24.2.0
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 20.12.13 16:15, Philip Jackson wrote: > > > On 20/12/2013 15:48, Patrick Brunschwig wrote: >> On 18.12.13 00:24, Philip Jackson wrote: >>> On 17/12/2013 14:38, Anne Wilson wrote: On 15/12/2013 17:43, Philip Jackson wrote: > 1. import public key : this seems to work and the imported > key is immediately displayed in Kleopatra but not in > Thunderbird key manager until Thunderbird is restarted This may not be entirely an Enigmail problem. I have seen exactly that behaviour in Linux over a long period, when KMail couldn't see newly imported signatures but Kgpg reported them. As with Thunderbird, it required a restart to see them, so I came to the conclusion that maybe the signature file is read once only, when starting up. Of course the reason could be something entirely different :-) Anne >>> Olav's suggestion to try the 'Reload key cache' works fine. >>> The newly imported 'sender key' is then displayed in the Key >>> Manager. >> >>> This also explains why in one of my cases, the option 'View >>> key properties' under the 'Details' button did not do anything. >>> Until the key cache is reloaded and the key info is present in >>> the key manager, 'View key properties' does nothing - not even >>> an error message. As soon as the key cache has been reloaded, >>> 'View key properties' works correctly. >> >> Is there any error message in the Thunderbird Error Console >> (menu Tools > Error console)? >> >> -Patrick > Nothing found in the Thunderbird error console. I'm trying to read > the enigmail debug file but it's quite difficult (in fact, quite a > bugger) with lines that don't wrap. Copy and paste to a text editor > needs returns and new lines put in manually. > > I'm still checking and I'll make a bug report over the weekend. Otherwise, just create a bug report and attach the debug log file. I'm used to reading it ... - -Patrick -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEVAwUBUrRft8k25cDiHiw+AQhAZQgAlcwH0xtKOCY6Cc52gL7pPe7UefMdYnr2 RVdrSITi9fGmCOchzHuYqV9bFRawjOZREWj2u5HJJ3OPobPx5da+UZk7ml6mrWvs lH/oJS5nevxVBqhCNAhMQ9PRDYPEjQb2irMAKjrZBZL0lDuCE2w3bXc8WiGZzkmF NZFUpaa9bzU6jFr0hHbZTcpa793Qb36kgVoNyXWYt0zw3gsSJfexJ8kyfjsD0WLx ssefA5p413DBsrd9asqJIMu/SMMJP8MhmwWyHBWGLHgAufdZCPtJfifhVmLBz0pn yEQaAEyN9RHfuuXgB0BFSGQSRhE4lIjOF4THJ96kTXsDgNljJ1Rlag== =GgMB -END PGP SIGNATURE- ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
Re: [Enigmail] behaviour of enigmail 1.6 in Thunderbird 24.2.0
On 20/12/2013 15:48, Patrick Brunschwig wrote: > On 18.12.13 00:24, Philip Jackson wrote: >> On 17/12/2013 14:38, Anne Wilson wrote: >>> On 15/12/2013 17:43, Philip Jackson wrote: 1. import public key : this seems to work and the imported key is immediately displayed in Kleopatra but not in Thunderbird key manager until Thunderbird is restarted >>> >>> This may not be entirely an Enigmail problem. I have seen >>> exactly that behaviour in Linux over a long period, when KMail >>> couldn't see newly imported signatures but Kgpg reported them. >>> As with Thunderbird, it required a restart to see them, so I came >>> to the conclusion that maybe the signature file is read once >>> only, when starting up. Of course the reason could be something >>> entirely different :-) >>> >>> Anne >> Olav's suggestion to try the 'Reload key cache' works fine. The >> newly imported 'sender key' is then displayed in the Key Manager. > >> This also explains why in one of my cases, the option 'View key >> properties' under the 'Details' button did not do anything. Until >> the key cache is reloaded and the key info is present in the key >> manager, 'View key properties' does nothing - not even an error >> message. As soon as the key cache has been reloaded, 'View key >> properties' works correctly. > > Is there any error message in the Thunderbird Error Console (menu > Tools > Error console)? > > -Patrick Nothing found in the Thunderbird error console. I'm trying to read the enigmail debug file but it's quite difficult (in fact, quite a bugger) with lines that don't wrap. Copy and paste to a text editor needs returns and new lines put in manually. I'm still checking and I'll make a bug report over the weekend. Philip 0x23543A63.asc Description: application/pgp-keys ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
Re: [Enigmail] behaviour of enigmail 1.6 in Thunderbird 24.2.0
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 15.12.13 18:43, Philip Jackson wrote: [...] > Second Case : after the 'import public key' option has been used > and the key is available in the key manager and appears to be valid > but I have not yet set a trust level nor signed the key. > Thunderbird displays a purple band with the message 'Error - > signature verification failed; click on 'Details' button for more > information.'The Details button provides 5 usable options : > > 1. 'OpenPGP security info': this gives a dialog box with 'Error - > signature verification failed' which we already knew so not very > helpful. 2. 'copy OpenPGP security info' - it doesn't do anything > - doesn't copy anything to windows clipboard - presumably because > nothing is known. 3. 'View key properties' : this doesn't do > anything despite multiple tries. (note that if the key manager is > opened from OpenPGP/Key management, the subject imported key is > visible provided that Thunderbird has been closed and restarted > after import.) But Details button option 3 does nothing - no > effect. 4. 'Sign sender's key' - this opens a dialog box which > appears that it would work BUT why would one wish to sign a key > where 'verification has failed' ? 5. 'Set owner trust of sender's > key' : this opens a dialog box where the 'Key to trust' field is > empty (you need to open key manager or Kleopatra to find the key > ID) - but again, on what basis would you set a trust level for an > unidentified key for which verification had failed ? This looks like a bug. Could I ask you to report a bug via https://sourceforge.net/p/enigmail/bugs/new/ Thanks, - -Patrick -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEVAwUBUrRZvsk25cDiHiw+AQgjxgf+IeNlerfo3MDPWA/YhO7dEwY0BL29t24B hyM2u7PDBJWmg/XjvD5Vo1wNk2Z1BDXf6X4B9pGaDfNt9n9D5cGghwd8gPSF5UUf HUH5QnBNIbLe6DdTSuADTtwUpDbuY6CgHF2iQCm4paFGHsah9H64Tjk85+iJaf1u +YO3m1oJHm97or+beWpWKa++DwtMTbBiyJaRno6ysE1mLvpe1xgFkSn++e/U3NbH zhDYu10e1DWfg4F7tOEjWD10BWNOabcsfdSUzOtFmsgQjreDRXZu6YKbnqpNS0Un wXSWtOJ49RdL2moCL3KA++pOwowjAoUrOObE2/fEAFYj67kID1zB8w== =CXxn -END PGP SIGNATURE- ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
Re: [Enigmail] behaviour of enigmail 1.6 in Thunderbird 24.2.0
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 18.12.13 00:24, Philip Jackson wrote: > On 17/12/2013 14:38, Anne Wilson wrote: >> On 15/12/2013 17:43, Philip Jackson wrote: >>> 1. import public key : this seems to work and the imported key >>> is immediately displayed in Kleopatra but not in Thunderbird >>> key manager until Thunderbird is restarted >> >> This may not be entirely an Enigmail problem. I have seen >> exactly that behaviour in Linux over a long period, when KMail >> couldn't see newly imported signatures but Kgpg reported them. >> As with Thunderbird, it required a restart to see them, so I came >> to the conclusion that maybe the signature file is read once >> only, when starting up. Of course the reason could be something >> entirely different :-) >> >> Anne > Olav's suggestion to try the 'Reload key cache' works fine. The > newly imported 'sender key' is then displayed in the Key Manager. > > This also explains why in one of my cases, the option 'View key > properties' under the 'Details' button did not do anything. Until > the key cache is reloaded and the key info is present in the key > manager, 'View key properties' does nothing - not even an error > message. As soon as the key cache has been reloaded, 'View key > properties' works correctly. Is there any error message in the Thunderbird Error Console (menu Tools > Error console)? - -Patrick -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEVAwUBUrRY1ck25cDiHiw+AQiVJQgAwN4XEiaXNWmDKYW3ejWQ9CS1qnFCfC9r Jb62LoNZXhlxIi4S5raakFXOkJwni8InZXuWu5KT+TKCYh5DwabXqIITZCNo80lA 5JhhaGVJEGFlLZs+Xg9T2mmvfeGbzMH+YBKllTNXJkWxwWdyNqC/UjqdFDIZtgZF yaqE8UiA8QLJszIH3ExSleADG2YP896VHUweKLezIEODrAwx/XJbJq0FGKmsBxzd yrq8ESZs15dmNdQY052q4gH8ZYQJwQnyGbuCpYfz+tXLJ1ZpqbIWGnIpsn+jKwWH FPMHdnl8f07XeD+vNsyjVU2snky051K7OuB8vod+342UlirVaG5MwQ== =J6z2 -END PGP SIGNATURE- ___ enigmail-users mailing list enigmail-users@enigmail.net https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
