Re: [E-devel] Add Null checking routine
I just added patch for trunk/efl/src/lib/eet/eet_lib.c 2012/10/5 Vincent Torri > provide the patch for et in efl/ too, please > > Vincent > > On Fri, Oct 5, 2012 at 6:46 AM, 곽성호 wrote: > > Hi, > > > > I add NULL chekcing routine in eet_identity_signature, > eet_identity_x509, eet_identity_sha1 to avoid crash. > > > > I just use if - return, cause I couldn't find any EINA_SAFETY inline > function in eet_lib.c > > Please show me that do I have to use EINA_SAFETY. > > > > Sincerely, > > Sungho Kwak > > > > > -- > > Don't let slow site performance ruin your business. Deploy New Relic APM > > Deploy New Relic app performance management and know exactly > > what is happening inside your Ruby, Python, PHP, Java, and .NET app > > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > > http://p.sf.net/sfu/newrelic-dev2dev > > ___ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > eet_et_1005.diff Description: Binary data eet_lib_1005.diff Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/eet/src/lib
oops I just had local commit. Now in svn! Daniel Juyung Seo (SeoZ) On Fri, Oct 5, 2012 at 3:05 PM, Vincent Torri wrote: > On Fri, Oct 5, 2012 at 2:04 AM, Daniel Juyung Seo > wrote: >> Thanks :) >> Done! > > not in efl/ > > Vincent > >> >> Daniel Juyung Seo (SeoZ) >> >> On Fri, Oct 5, 2012 at 8:43 AM, Vincent Torri >> wrote: >>> backport in efl/ >>> >>> Vincent >>> >>> On Fri, Oct 5, 2012 at 1:40 AM, Enlightenment SVN >>> wrote: Log: eet eet_connection.c: Added missing NULL check. Patch by Zbigniew Kosinski On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski wrote: > Hello, > > Please consider to add another NULL checks in eet lib: > > 1. eet_data_descriptor_element_add - NULL check for data descriptor > handle parameter. Author: seoz Date: 2012-10-04 16:40:13 -0700 (Thu, 04 Oct 2012) New Revision: 77494 Trac: http://trac.enlightenment.org/e/changeset/77494 Modified: trunk/eet/src/lib/eet_connection.c Modified: trunk/eet/src/lib/eet_connection.c === --- trunk/eet/src/lib/eet_connection.c 2012-10-04 23:30:35 UTC (rev 77493) +++ trunk/eet/src/lib/eet_connection.c 2012-10-04 23:40:13 UTC (rev 77494) @@ -185,6 +185,8 @@ int data_size; Eina_Bool ret = EINA_FALSE; + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); + flat_data = eet_data_descriptor_encode_cipher(edd, data_in, cipher_key, @@ -204,6 +206,8 @@ int data_size; Eina_Bool ret = EINA_FALSE; + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); + data = eet_data_node_encode_cipher(node, cipher_key, &data_size); if (!data) return EINA_FALSE; if (_eet_connection_raw_send(conn, data, data_size)) -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >>> >>> -- >>> Don't let slow site performance ruin your business. Deploy New Relic APM >>> Deploy New Relic app performance management and know exactly >>> what is happening inside your Ruby, Python, PHP, Java, and .NET app >>> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >>> http://p.sf.net/sfu/newrelic-dev2dev >>> ___ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> >> -- >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.so
Re: [E-devel] E SVN: seoz trunk/eet/src/lib
On Fri, Oct 5, 2012 at 2:04 AM, Daniel Juyung Seo wrote: > Thanks :) > Done! not in efl/ Vincent > > Daniel Juyung Seo (SeoZ) > > On Fri, Oct 5, 2012 at 8:43 AM, Vincent Torri wrote: >> backport in efl/ >> >> Vincent >> >> On Fri, Oct 5, 2012 at 1:40 AM, Enlightenment SVN >> wrote: >>> Log: >>> eet eet_connection.c: Added missing NULL check. Patch by Zbigniew Kosinski >>> >>> >>> On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski >>> wrote: >>> > Hello, >>> > >>> > Please consider to add another NULL checks in eet lib: >>> > >>> > 1. eet_data_descriptor_element_add - NULL check for data descriptor >>> > handle parameter. >>> >>> Author: seoz >>> Date: 2012-10-04 16:40:13 -0700 (Thu, 04 Oct 2012) >>> New Revision: 77494 >>> Trac: http://trac.enlightenment.org/e/changeset/77494 >>> >>> Modified: >>> trunk/eet/src/lib/eet_connection.c >>> >>> Modified: trunk/eet/src/lib/eet_connection.c >>> === >>> --- trunk/eet/src/lib/eet_connection.c 2012-10-04 23:30:35 UTC (rev 77493) >>> +++ trunk/eet/src/lib/eet_connection.c 2012-10-04 23:40:13 UTC (rev 77494) >>> @@ -185,6 +185,8 @@ >>> int data_size; >>> Eina_Bool ret = EINA_FALSE; >>> >>> + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); >>> + >>> flat_data = eet_data_descriptor_encode_cipher(edd, >>> data_in, >>> cipher_key, >>> @@ -204,6 +206,8 @@ >>> int data_size; >>> Eina_Bool ret = EINA_FALSE; >>> >>> + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); >>> + >>> data = eet_data_node_encode_cipher(node, cipher_key, &data_size); >>> if (!data) return EINA_FALSE; >>> if (_eet_connection_raw_send(conn, data, data_size)) >>> >>> >>> -- >>> Don't let slow site performance ruin your business. Deploy New Relic APM >>> Deploy New Relic app performance management and know exactly >>> what is happening inside your Ruby, Python, PHP, Java, and .NET app >>> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >>> http://p.sf.net/sfu/newrelic-dev2dev >>> ___ >>> enlightenment-svn mailing list >>> enlightenment-...@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >> >> -- >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> ___ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Add Null checking routine
provide the patch for et in efl/ too, please Vincent On Fri, Oct 5, 2012 at 6:46 AM, 곽성호 wrote: > Hi, > > I add NULL chekcing routine in eet_identity_signature, eet_identity_x509, > eet_identity_sha1 to avoid crash. > > I just use if - return, cause I couldn't find any EINA_SAFETY inline function > in eet_lib.c > Please show me that do I have to use EINA_SAFETY. > > Sincerely, > Sungho Kwak > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Another French^WKorean E diner
wow two guests.. that sounds great! but i'm afraid i cannot join.. T,.T 2012/10/5 Jérôme Pinot > On 10/04/12 18:17, Cedric BAIL wrote: > > Hello every body, > > > > Long time no see ! For all of you that are in Korea or may be around > > Seoul on Friday 12th of October, aka Friday next week, I propose we > > met in Itaewon for a diner at around 8pm. So who is joining ? And we > > will have two special guests ! > > It's OK for me too! > > BTW if you like to start earlier, I may be able to change my schedule. > > -- > Jérôme Pinot > http://ngc891.blogdns.net/ > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [e] evas bad typedef
I'll look into it and fix it. thanks. Sung On Fri, Oct 5, 2012 at 5:02 AM, rustyBSD wrote: > Le 01/10/2012 19:08, rustyBSD a écrit : > > Hi, > > == evas_gl_api_ext.h l.4 == > > The GLchar type is already defined on openbsd > > (/usr/X11R6/include/GL/glext.h), so it has to > > be renamed. > > You should really use another name.GLchar > already comes with gl/opengl. > > OpenBSD and NetBSD don't like that. > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Add Null checking routine
Hi, I add NULL chekcing routine in eet_identity_signature, eet_identity_x509, eet_identity_sha1 to avoid crash. I just use if - return, cause I couldn't find any EINA_SAFETY inline function in eet_lib.c Please show me that do I have to use EINA_SAFETY. Sincerely, Sungho Kwak eet_lib_1005.diff Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item Cache Refactoring
OK I will review your patch. Thanks. Daniel Juyung Seo (SeoZ) On Fri, Oct 5, 2012 at 11:09 AM, Bluezery wrote: > I resolved conflicts with recent svn. > > 2012/10/2 Bluezery : >> Dear EFL developers, >> >> This is patch for reconstructing genlist's item cache. >> Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item * >> now. >> Before, cache is disabled by comments. But I enabled item cache again >> (even for the case which tree_effect_enabled is on). >> >> I changed some functions: >> _item_cache_find() --> _item_cache_pop() >> _item_cache_add() --> _item_cache_push() >> _item_cache_zero() -->_item_cache_all_free() >> >> And I removed _item_cache_clean() function because I made >> _item_cache_push() to don't exceed the item_cache_max. So clean-up of >> cache is not needed anymore. >> >> I will do more re-factoring jobs for genlist. >> Please review this patch. >> >> -- >> BRs, >> Kim. > > > > -- > BRs, > Kim. > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Another French^WKorean E diner
On 10/04/12 18:17, Cedric BAIL wrote: > Hello every body, > > Long time no see ! For all of you that are in Korea or may be around > Seoul on Friday 12th of October, aka Friday next week, I propose we > met in Itaewon for a diner at around 8pm. So who is joining ? And we > will have two special guests ! It's OK for me too! BTW if you like to start earlier, I may be able to change my schedule. -- Jérôme Pinot http://ngc891.blogdns.net/ signature.asc Description: Digital signature -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [E-Devel][Patch][Elementary]Genlist - Edje Item Cache Refactoring
I resolved conflicts with recent svn. 2012/10/2 Bluezery : > Dear EFL developers, > > This is patch for reconstructing genlist's item cache. > Each item cache functions do harsh jobs so just push,pop by Elm_Gen_Item * > now. > Before, cache is disabled by comments. But I enabled item cache again > (even for the case which tree_effect_enabled is on). > > I changed some functions: > _item_cache_find() --> _item_cache_pop() > _item_cache_add() --> _item_cache_push() > _item_cache_zero() -->_item_cache_all_free() > > And I removed _item_cache_clean() function because I made > _item_cache_push() to don't exceed the item_cache_max. So clean-up of > cache is not needed anymore. > > I will do more re-factoring jobs for genlist. > Please review this patch. > > -- > BRs, > Kim. -- BRs, Kim. genlist@cache_refactoring.patch Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: stefan trunk/e/src/modules/connman
On Fri, Oct 5, 2012 at 4:09 AM, Lucas De Marchi wrote: > On Thu, Oct 4, 2012 at 11:56 AM, Enlightenment SVN > wrote: >> Log: >> e/connman: Check for the correct messages. >> >> Checking two times the same message does not make any sense. The only >> logical >> thing seems to be checking for the properties message here. Leaving the >> wifi >> properties message out as not every setup has wifi. At least on my desktop >> here I don't have /net/connman/technology/wifi so we should not fail >> without >> it. > > You could put wifi props there. We are just checking if the message > was actually created. > > HOWEVER, handling technologies in this function is totally misplaced. > I blame raster for adding this code :). The intention of this function > was to deal with Manager interface. Right approach would be to create > some infra similar to deal with technologies, calling > GetTechnologies() on Manager, monitoring signals etc. > > That said... as it is right now it works, so I'm not changing it. > Soon it will start using edbus, too. You can't use edbus until e17 is released. Just to be sure you don't miss that :-) -- Cedric BAIL -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/eet/src/lib
Thanks :) Done! Daniel Juyung Seo (SeoZ) On Fri, Oct 5, 2012 at 8:43 AM, Vincent Torri wrote: > backport in efl/ > > Vincent > > On Fri, Oct 5, 2012 at 1:40 AM, Enlightenment SVN > wrote: >> Log: >> eet eet_connection.c: Added missing NULL check. Patch by Zbigniew Kosinski >> >> >> On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski >> wrote: >> > Hello, >> > >> > Please consider to add another NULL checks in eet lib: >> > >> > 1. eet_data_descriptor_element_add - NULL check for data descriptor >> > handle parameter. >> >> Author: seoz >> Date: 2012-10-04 16:40:13 -0700 (Thu, 04 Oct 2012) >> New Revision: 77494 >> Trac: http://trac.enlightenment.org/e/changeset/77494 >> >> Modified: >> trunk/eet/src/lib/eet_connection.c >> >> Modified: trunk/eet/src/lib/eet_connection.c >> === >> --- trunk/eet/src/lib/eet_connection.c 2012-10-04 23:30:35 UTC (rev 77493) >> +++ trunk/eet/src/lib/eet_connection.c 2012-10-04 23:40:13 UTC (rev 77494) >> @@ -185,6 +185,8 @@ >> int data_size; >> Eina_Bool ret = EINA_FALSE; >> >> + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); >> + >> flat_data = eet_data_descriptor_encode_cipher(edd, >> data_in, >> cipher_key, >> @@ -204,6 +206,8 @@ >> int data_size; >> Eina_Bool ret = EINA_FALSE; >> >> + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); >> + >> data = eet_data_node_encode_cipher(node, cipher_key, &data_size); >> if (!data) return EINA_FALSE; >> if (_eet_connection_raw_send(conn, data, data_size)) >> >> >> -- >> Don't let slow site performance ruin your business. Deploy New Relic APM >> Deploy New Relic app performance management and know exactly >> what is happening inside your Ruby, Python, PHP, Java, and .NET app >> Try New Relic at no cost today and get our sweet Data Nerd shirt too! >> http://p.sf.net/sfu/newrelic-dev2dev >> ___ >> enlightenment-svn mailing list >> enlightenment-...@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/eet/src/lib
Doesn't edd need NULL-checking routine? 2012/10/5 Vincent Torri > backport in efl/ > > Vincent > > On Fri, Oct 5, 2012 at 1:40 AM, Enlightenment SVN > wrote: > > Log: > > eet eet_connection.c: Added missing NULL check. Patch by Zbigniew > Kosinski > > > > On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski < > z.kosin...@samsung.com> wrote: > > > Hello, > > > > > > Please consider to add another NULL checks in eet lib: > > > > > > 1. eet_data_descriptor_element_add - NULL check for data > descriptor > > > handle parameter. > > > > Author: seoz > > Date: 2012-10-04 16:40:13 -0700 (Thu, 04 Oct 2012) > > New Revision: 77494 > > Trac: http://trac.enlightenment.org/e/changeset/77494 > > > > Modified: > > trunk/eet/src/lib/eet_connection.c > > > > Modified: trunk/eet/src/lib/eet_connection.c > > === > > --- trunk/eet/src/lib/eet_connection.c 2012-10-04 23:30:35 UTC (rev > 77493) > > +++ trunk/eet/src/lib/eet_connection.c 2012-10-04 23:40:13 UTC (rev > 77494) > > @@ -185,6 +185,8 @@ > > int data_size; > > Eina_Bool ret = EINA_FALSE; > > > > + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); > > + > > flat_data = eet_data_descriptor_encode_cipher(edd, > > data_in, > > cipher_key, > > @@ -204,6 +206,8 @@ > > int data_size; > > Eina_Bool ret = EINA_FALSE; > > > > + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); > > + > > data = eet_data_node_encode_cipher(node, cipher_key, &data_size); > > if (!data) return EINA_FALSE; > > if (_eet_connection_raw_send(conn, data, data_size)) > > > > > > > -- > > Don't let slow site performance ruin your business. Deploy New Relic APM > > Deploy New Relic app performance management and know exactly > > what is happening inside your Ruby, Python, PHP, Java, and .NET app > > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > > http://p.sf.net/sfu/newrelic-dev2dev > > ___ > > enlightenment-svn mailing list > > enlightenment-...@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: seoz trunk/eet/src/lib
backport in efl/ Vincent On Fri, Oct 5, 2012 at 1:40 AM, Enlightenment SVN wrote: > Log: > eet eet_connection.c: Added missing NULL check. Patch by Zbigniew Kosinski > > > On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski > wrote: > > Hello, > > > > Please consider to add another NULL checks in eet lib: > > > > 1. eet_data_descriptor_element_add - NULL check for data descriptor > > handle parameter. > > Author: seoz > Date: 2012-10-04 16:40:13 -0700 (Thu, 04 Oct 2012) > New Revision: 77494 > Trac: http://trac.enlightenment.org/e/changeset/77494 > > Modified: > trunk/eet/src/lib/eet_connection.c > > Modified: trunk/eet/src/lib/eet_connection.c > === > --- trunk/eet/src/lib/eet_connection.c 2012-10-04 23:30:35 UTC (rev 77493) > +++ trunk/eet/src/lib/eet_connection.c 2012-10-04 23:40:13 UTC (rev 77494) > @@ -185,6 +185,8 @@ > int data_size; > Eina_Bool ret = EINA_FALSE; > > + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); > + > flat_data = eet_data_descriptor_encode_cipher(edd, > data_in, > cipher_key, > @@ -204,6 +206,8 @@ > int data_size; > Eina_Bool ret = EINA_FALSE; > > + EINA_SAFETY_ON_NULL_RETURN_VAL(conn, EINA_FALSE); > + > data = eet_data_node_encode_cipher(node, cipher_key, &data_size); > if (!data) return EINA_FALSE; > if (_eet_connection_raw_send(conn, data, data_size)) > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [EET][PATCH] NULL checks again
This one looks ok. Thanks in SVN! Daniel Juyung Seo (SeoZ) On Thu, Oct 4, 2012 at 9:12 PM, Zbigniew Kosinski wrote: > Hello, > > Please consider to add another NULL checks in eet lib: > > 1. eet_data_descriptor_element_add - NULL check for data descriptor > handle parameter. > > 2. eet_connection_send and eet_connection_node_send - NULL check for > connection parameter. > > Please take a look at attached patches. > > BR, > > Zbigniew > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Enlightement] Fix issues discovered by cppcheck
On 10/04/2012 09:14 PM, Igor Murzov wrote: > Here are three patches for Enlightenment: > > 01 Removes unused variables, drops duplicate return or break > statements and drops unnecessary checks. > 02 Fixes potential invalid memory reads. > 03 Fixes a typo. All in. S. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Enlightement] Fix issues discovered by cppcheck
On 10/04/2012 09:14 PM, Igor Murzov wrote: > Fixes a typo. In. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH][Emap] Unbreak parsing data from gpx files
Ooppps you found out my easter egg :) Thanks! In SVN! Daniel Juyung Seo (SeoZ) On Thu, Oct 4, 2012 at 9:42 PM, Igor Murzov wrote: > One more patch. It restores fread() call dropped by SeoZ in r62592 > while he was fixing compiler warnings. No code, no warning. That is > smart, isn't it? > > > -- Igor > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric IN trunk/elementary: . data/themes/widgets src/lib
This breaks Wayland bad! Please take a look on
http://trac.enlightenment.org/e/ticket/1598 for more information
On Thu, Oct 4, 2012 at 5:27 AM, Enlightenment SVN
wrote:
> Log:
> elementary: add color picker to elm_colorselector.
>
>
> Author: cedric
> Date: 2012-10-04 01:27:07 -0700 (Thu, 04 Oct 2012)
> New Revision: 77409
> Trac: http://trac.enlightenment.org/e/changeset/77409
>
> Modified:
> trunk/elementary/ChangeLog trunk/elementary/NEWS
> trunk/elementary/data/themes/widgets/colorselector.edc
> trunk/elementary/src/lib/elm_colorselector.c
> trunk/elementary/src/lib/elm_colorselector.h
> trunk/elementary/src/lib/elm_widget_colorselector.h
>
> Modified: trunk/elementary/ChangeLog
> ===
> --- trunk/elementary/ChangeLog 2012-10-04 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/ChangeLog 2012-10-04 08:27:07 UTC (rev 77409)
> @@ -560,3 +560,7 @@
>
> * fix copy&paste error in elm_flip.
> * fix possible invalid memory access in elm_access.
> +
> +2012-10-04 Cedric Bail
> +
> + * Add a color picker to elm_colorselector.
>
> Modified: trunk/elementary/NEWS
> ===
> --- trunk/elementary/NEWS 2012-10-04 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/NEWS 2012-10-04 08:27:07 UTC (rev 77409)
> @@ -9,6 +9,7 @@
> * Add reorder mode set/get API in Toolbar.
> * Add the toolbar API which expand the transverse length.
> * Add a way to know which month is displayed in elm_calendar
> + * Add color picker to elm_colorselector.
>
> Improvements:
>
>
> Modified: trunk/elementary/data/themes/widgets/colorselector.edc
> ===
> --- trunk/elementary/data/themes/widgets/colorselector.edc 2012-10-04
> 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/data/themes/widgets/colorselector.edc 2012-10-04
> 08:27:07 UTC (rev 77409)
> @@ -4,6 +4,31 @@
> data.item: "horizontal_pad" "10";
> data.item: "vertical_pad" "10";
> parts {
> + part { name: "picker";
> + type: SWALLOW;
> + scale: 1;
> + description { state: "default" 0.0;
> +align: 0.0 0.0;
> +rel1.relative: 0.0 0.0;
> +rel2.relative: 1.0 0.0;
> + }
> + }
> + part { name: "top_padding";
> + type: SPACER;
> + scale: 1;
> + description { state: "default" 0.0;
> +min: 0 20;
> +fixed: 0 1;
> +rel1.relative: 0.0 1.0;
> +rel1.to: "picker";
> +rel2.to: "picker";
> +align: 0.0 0.0;
> + }
> + description { state: "disabled" 0.0;
> +inherit: "default" 0.0;
> +min: 0 0;
> + }
> + }
>part { name: "palette";
> type: SWALLOW;
> scale: 1;
> @@ -11,18 +36,19 @@
> align: 0.0 0.0;
> fixed: 0 1;
> rel1 {
> - relative: 0.0 0.0;
> + relative: 0.0 1.0;
> + to: "top_padding";
> }
> rel2 {
> - relative: 1.0 0.0;
> + relative: 1.0 1.0;
> + to: "top_padding";
> }
> }
>}
>part{ name: "bottom_padding";
> - type: RECT;
> + type: SPACER;
> scale: 1;
> description { state: "default" 0.0;
> -visible: 0;
> min: 0 20;
> fixed: 0 1;
> rel1.relative: 0.0 1.0;
> @@ -49,27 +75,79 @@
>}
> }
> programs {
> + program { name: "init";
> + source: "";
> + signal: "load";
> + action: STATE_SET "disabled" 0.0;
> + target: "top_padding";
> + }
>program { name: "palette";
> source: "elm";
> signal: "elm,state,palette";
> action: STATE_SET "disabled" 0.0;
> target: "bottom_padding";
> + target: "top_padding";
>}
>program { name: "components";
> source: "elm";
> signal: "elm,state,components";
> action: STATE_SET "disabled" 0.0;
> target: "bottom_padding";
> + target: "top_padding";
>}
>program { name: "both";
> source: "elm";
> signal: "elm,state,both";
> action: STATE_SET "default" 0.0;
> target: "bottom_padding";
> + after: "notop";
>}
> + program { name: "notop";
> + action: STATE_SET "disabled" 0.0;
> + target: "top_padding";
> + }
> + program { name: "picker";
> + source: "elm";
> + signal: "elm,state,picker";
> + action: STATE_SET "disabled" 0.0;
> + target: "bottom_padding";
> + target: "top_padding";
> + }
> + program { name: "all";
> + source: "elm";
> + signal: "elm,
Re: [E-devel] [e] evas bad typedef
Le 01/10/2012 19:08, rustyBSD a écrit : > Hi, > == evas_gl_api_ext.h l.4 == > The GLchar type is already defined on openbsd > (/usr/X11R6/include/GL/glext.h), so it has to > be renamed. You should really use another name.GLchar already comes with gl/opengl. OpenBSD and NetBSD don't like that. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][Enlightement] Fix issues discovered by cppcheck
Here are three patches for Enlightenment:
01 Removes unused variables, drops duplicate return or break
statements and drops unnecessary checks.
02 Fixes potential invalid memory reads.
03 Fixes a typo.
In addition, I'm not sure if this ok or not, but Enlightenment
can not be compiled with EFL-1.7 anymore:
--
CC e_mod_comp_cfdata.lo
../../../src/modules/comp/e_mod_comp_cfdata.c: In function
'e_mod_comp_cfdata_config_new':
../../../src/modules/comp/e_mod_comp_cfdata.c:83:21: error:
'ECORE_EVAS_GL_X11_SWAP_MODE_AUTO' undeclared (first use in this function)
../../../src/modules/comp/e_mod_comp_cfdata.c:83:21: note: each undeclared
identifier is reported only once for each function it appears in
--
-- Igor
Index: src/bin/e_zone.c
===
--- src/bin/e_zone.c (revision 77434)
+++ src/bin/e_zone.c (working copy)
@@ -1296,7 +1296,6 @@
if (yy1 > zone->h - shelf->h)
yy1 = zone->h - shelf->h;
break;
- break;
case E_GADCON_ORIENT_LEFT:
case E_GADCON_ORIENT_CORNER_LT:
Index: src/modules/battery/batget.c
===
--- src/modules/battery/batget.c (revision 77434)
+++ src/modules/battery/batget.c (working copy)
@@ -272,8 +272,6 @@
bsd_apm_check(void)
{
int ac_stat, bat_stat, bat_val, time_val;
- char buf[4096];
- int hours, minutes;
int apm_fd = -1;
struct apm_info info;
@@ -357,7 +355,6 @@
const void *values;
int device_num, device_count;
int currentval = 0, maxval = 0;
- char buf[4096];
CFTypeRef blob;
CFArrayRef sources;
CFDictionaryRef device_dict;
Index: src/modules/conf_theme/e_int_config_scale.c
===
--- src/modules/conf_theme/e_int_config_scale.c (revision 77434)
+++ src/modules/conf_theme/e_int_config_scale.c (working copy)
@@ -386,7 +386,6 @@
(cfdata->max != e_config->scale.max) ||
(cfdata->factor != e_config->scale.factor) ||
(cfdata->base_dpi != e_config->scale.base_dpi);
- return 1;
}
static void
Index: src/modules/cpufreq/e_mod_main.c
===
--- src/modules/cpufreq/e_mod_main.c (revision 77434)
+++ src/modules/cpufreq/e_mod_main.c (working copy)
@@ -597,7 +597,7 @@
#elif defined (__FreeBSD__)
int freq;
size_t len = sizeof(buf);
- char *freqs, *pos, *q;
+ char *pos, *q;
/* read freq_levels sysctl and store it in freq */
if (sysctlbyname("dev.cpu.0.freq_levels", buf, &len, NULL, 0) == 0)
Index: src/modules/fileman/e_mod_menu.c
===
--- src/modules/fileman/e_mod_menu.c (revision 77434)
+++ src/modules/fileman/e_mod_menu.c (working copy)
@@ -274,7 +274,7 @@
e_menu_item_callback_set(mi, _e_mod_menu_gtk_cb,
(void *)eina_stringshare_add(uri->path));
e_menu_item_submenu_pre_callback_set(mi, _e_mod_menu_populate, eina_stringshare_add("/"));
- if (uri) efreet_uri_free(uri);
+ efreet_uri_free(uri);
}
fclose(fp);
}
Index: src/modules/illume-keyboard/e_kbd_dict.c
===
--- src/modules/illume-keyboard/e_kbd_dict.c (revision 77434)
+++ src/modules/illume-keyboard/e_kbd_dict.c (working copy)
@@ -153,7 +153,6 @@
kw1 = d1;
kw2 = d2;
return _e_kbd_dict_normalized_strcmp(kw1->word, kw2->word);
- return 0;
}
static const char *
Index: src/modules/xkbswitch/e_mod_main.c
===
--- src/modules/xkbswitch/e_mod_main.c (revision 77434)
+++ src/modules/xkbswitch/e_mod_main.c (working copy)
@@ -496,7 +496,6 @@
if (!inst) return;
e_gadcon_locked_set(inst->gcc->gadcon, 0);
- if (!(inst) || !inst->lmenu) return;
inst->lmenu = NULL;
}
Index: src/bin/e_exec.c
===
--- src/bin/e_exec.c (revision 77434)
+++ src/bin/e_exec.c (working copy)
@@ -158,15 +158,13 @@
EINA_LIST_FOREACH(e_border_client_list(), l, bd)
{
- if (bd->desktop == desktop)
+ if (bd && bd->desktop == desktop)
{
-if (bd)
- {
- if (!bd->focused)
- e_border_activate(bd, EINA_TRUE);
- else e_border_raise(bd);
- return NULL;
- }
+if (!bd->focused)
+ e_border_activate
Re: [E-devel] E SVN: stefan trunk/e/src/modules/connman
On Thu, Oct 4, 2012 at 11:56 AM, Enlightenment SVN wrote: > Log: > e/connman: Check for the correct messages. > > Checking two times the same message does not make any sense. The only > logical > thing seems to be checking for the properties message here. Leaving the wifi > properties message out as not every setup has wifi. At least on my desktop > here I don't have /net/connman/technology/wifi so we should not fail without > it. You could put wifi props there. We are just checking if the message was actually created. HOWEVER, handling technologies in this function is totally misplaced. I blame raster for adding this code :). The intention of this function was to deal with Manager interface. Right approach would be to create some infra similar to deal with technologies, calling GetTechnologies() on Manager, monitoring signals etc. That said... as it is right now it works, so I'm not changing it. Soon it will start using edbus, too. > > Dermarchi or Bdilly please cry or fix if this is not as intended. > (Brought to you by double_condition_check.cocci) nice someone is using these scripts... it's a long time since I wrote them > > Author: stefan > Date: 2012-10-04 07:56:17 -0700 (Thu, 04 Oct 2012) > New Revision: 77440 > Trac: http://trac.enlightenment.org/e/changeset/77440 > > Modified: > trunk/e/src/modules/connman/e_connman.c > > Modified: trunk/e/src/modules/connman/e_connman.c > === > --- trunk/e/src/modules/connman/e_connman.c 2012-10-04 14:30:55 UTC (rev > 77439) > +++ trunk/e/src/modules/connman/e_connman.c 2012-10-04 14:56:17 UTC (rev > 77440) > @@ -910,7 +910,7 @@ > > "/net/connman/technology/wifi", > CONNMAN_TECHNOLOGY_IFACE, > "GetProperties"); > - if (!msg_services || !msg_services) > + if (!msg_services || !msg_props) good catch. Lucas De Marchi -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: stefan trunk/PROTO/elocation/src/lib
On Thu, Oct 4, 2012 at 7:25 AM, Enlightenment SVN <
no-re...@enlightenment.org> wrote:
> Log:
> PROTO/elocation: Use one address unmarshall function for calls and signals
>
> Author: stefan
> Date: 2012-10-04 03:25:47 -0700 (Thu, 04 Oct 2012)
> New Revision: 77421
> Trac: http://trac.enlightenment.org/e/changeset/77421
>
> Modified:
> trunk/PROTO/elocation/src/lib/elocation.c
>
> Modified: trunk/PROTO/elocation/src/lib/elocation.c
> ===
> --- trunk/PROTO/elocation/src/lib/elocation.c 2012-10-04 10:25:43 UTC
> (rev 77420)
> +++ trunk/PROTO/elocation/src/lib/elocation.c 2012-10-04 10:25:47 UTC
> (rev 77421)
> @@ -45,9 +45,8 @@
> }
>
> static void
> -address_cb(void *data , const EDBus_Message *reply, EDBus_Pending
> *pending)
> +unmarshall_address(Elocation_Address *address, const EDBus_Message *reply)
> {
> - Elocation_Address address;
> int32_t level, timestamp;
> EDBus_Message_Iter *iter, *sub, *dict, *entry;
> double horizontal;
> @@ -71,32 +70,32 @@
>
> if (!strcmp(key, "country"))
> {
> -address.country = value;
> +address->country = value;
> printf("Key: %s, value: %s\n", key, value);
>
REALLY asking for trouble... value is a pointer to the wire-message and
will be freed afterwards, so you may end pointing at some point with
invalid access..
> }
> else if (!strcmp(key, "countrycode"))
> {
> -address.countrycode = value;
> +address->countrycode = value;
> printf("Key: %s, value: %s\n", key, value);
> }
> else if (!strcmp(key, "locality"))
> {
> -address.locality = value;
> +address->locality = value;
> printf("Key: %s, value: %s\n", key, value);
> }
> else if (!strcmp(key, "postalcode"))
> {
> -address.postalcode = value;
> +address->postalcode = value;
> printf("Key: %s, value: %s\n", key, value);
> }
> else if (!strcmp(key, "region"))
> {
> -address.region = value;
> +address->region = value;
> printf("Key: %s, value: %s\n", key, value);
> }
> else if (!strcmp(key, "timezone"))
> {
> -address.timezone = value;
> +address->timezone = value;
> printf("Key: %s, value: %s\n", key, value);
> }
> }
> @@ -107,10 +106,23 @@
> accur.horizontal = horizontal;
> accur.vertical = vertical;
> }
> +
> static void
> +address_cb(void *data , const EDBus_Message *reply, EDBus_Pending
> *pending)
> +{
> + Elocation_Address *address;
> +
> + address = malloc(sizeof(Elocation_Address));
> + unmarshall_address(address, reply);
> +}
> +static void
> address_signal_cb(void *data , const EDBus_Message *reply)
> {
> - address_cb(data, reply, NULL);
> + Elocation_Address *address;
> +
> + address = malloc(sizeof(Elocation_Address));
> + unmarshall_address(address, reply);
> + ecore_event_add(ELOCATION_EVENT_ADDRESS, address, NULL, NULL);
> }
>
> static void
>
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] icons in menu and everything
It seems that efreet_test can give me more information/failures: http://sprunge.us/GRNR $ efreet_test Data Home: PASSED in 0.029 seconds Config Home:PASSED in 0.025 seconds Cache Home: PASSED in 0.027 seconds Data Directories: efreet_data_dirs_get() nodes is differnet from expected default efreet_data_dirs_get() returned incorrect value (/usr/local/share) when XDG_DATA_DIRS= is set /usr/share FAILED in 0.020 seconds Config Directories: PASSED in 0.008 seconds Icon Theme Basic: PASSED in 0.014 seconds Icon Theme List:ERR<20025>: efreet_ini.c:325 efreet_ini_section_set() safety check failed: ini->data == NULL ERR<20025>: efreet_ini.c:465 efreet_ini_localestring_get() safety check failed: ini->section == NULL efreet_icon_theme_list_get() missed: DMZ hicolor DMZ-AA gnome oxygen HighContrast default.kde4 HighContrastInverse LowContrast FAILED in 0.005 seconds Icon Matching: Time: 0.000222 Time: 0.000193 PASSED in 0.000 seconds INI Parsing:ERR<20025>: efreet_ini.c:325 efreet_ini_section_set() safety check failed: ini->data == NULL efreet_ini_section_set() Failed to set 'contact' section FAILED in 0.000 seconds INI Long Line Parsing: ERR<20025>: efreet_ini.c:325 efreet_ini_section_set() safety check failed: ini->data == NULL Section missing: 'section'.FAILED in 0.000 seconds INI Garbage Parsing:PASSED in 0.000 seconds Desktop Parsing:No desktop found. FAILED in 0.000 seconds Desktop Type Parsing: No desktop found. FAILED in 0.000 seconds Desktop Save: Failed to get Desktop file FAILED in 0.000 seconds Desktop Command: EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app '/tmp/absolute_path' '/relative_path' '/tmp/absolute_uri' '/relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' EXE: 'app 'file:///tmp/absolute_path' 'file:///relative_path' 'file:///tmp/absolute_uri' 'file:///relative_uri'' PASSED in 0.001 seconds Menu Parsing: PASSED in 0.095 seconds Menu Incorrect Names: PASSED in 0.000 seconds Menu Save: efreet_menu_get() returned NULL FAILED in 0.000 seconds Utils: this-tmp-test.desktop kde-kresources.desktop: (nil) mplayer.desktop: (nil) nautilus-computer.desktop: (nil) PASSED in 0.000 seconds Mime: mime icon: application/x-desktop (null) 0.59 mime icon: image/png (null) 0.16 Got /usr/share/efreet/test/entry as null instead of image/png mime icon: image/png (null) 0.16 Got /usr/share/efreet/test/sub as null instead of inode/directory mime icon: inode/directory (null) 0.15 FAILED in 0.005 seconds - Passed 11 of 20 tests. This is from openSUSE 12.2, openSUSE 12.1 is one test better. Could you help me interpret these errors, please? TIA Tomas Cech Sleep_Walker pgpHZIj4mz2RJ.pgp Description: PGP signature -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica
> > * eio - Problem using sizeof(type *) instead of sizeof(type) for allocation > > > > * elmdentica - Same problem as with eio, but implemented less cunningly > > In svn for both of them. I think the one for eio should be backported to the stable branch. -- Igor -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] icons in menu and everything
Thank you for quick response. Unfortunately this did not help. Any other ideas? Can I make efreet more verbose to the log somehow? Tomas Cech Sleep_Walker On Thu, Oct 04, 2012 at 09:06:58AM -0400, Rbt. Y-Lee wrote: This usually means your icon cache is corrupt. Simply delete it and restart e. http://forums.bodhilinux.com/index.php?/topic/1651-solved-most-icons-missing/page__view__findpost__p__14275 good luck. On Thu, Oct 4, 2012 at 9:02 AM, Tomas Cech wrote: Hi, I have problem with showing icons for applications in menu and in everything. It shows icons for very small amount of applications. Desktop file has record Icon= inside but where is the path where the icon file is searched? Thanks. Best regards, Tomas Cech Sleep_Walker -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel pgpKoYCXvDAdv.pgp Description: PGP signature -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] icons in menu and everything
This usually means your icon cache is corrupt. Simply delete it and restart e. http://forums.bodhilinux.com/index.php?/topic/1651-solved-most-icons-missing/page__view__findpost__p__14275 good luck. On Thu, Oct 4, 2012 at 9:02 AM, Tomas Cech wrote: > Hi, > > I have problem with showing icons for applications in menu and in > everything. It shows icons for very small amount of applications. > > Desktop file has record Icon= inside but where is the path where the > icon file is searched? > > Thanks. > > Best regards, > > Tomas Cech > Sleep_Walker > > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] icons in menu and everything
Hi, I have problem with showing icons for applications in menu and in everything. It shows icons for very small amount of applications. Desktop file has record Icon= inside but where is the path where the icon file is searched? Thanks. Best regards, Tomas Cech Sleep_Walker pgp0Nj32Cs2Wb.pgp Description: PGP signature -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH][Emap] Unbreak parsing data from gpx files
One more patch. It restores fread() call dropped by SeoZ in r62592
while he was fixing compiler warnings. No code, no warning. That is
smart, isn't it?
-- Igor
Index: src/lib/route_gpx.c
===
--- src/lib/route_gpx.c (revision 77392)
+++ src/lib/route_gpx.c (working copy)
@@ -53,7 +53,8 @@
buf = malloc(sz);
if (buf)
{
-eina_simple_xml_parse(buf, sz, EINA_TRUE, _parser_cb, route);
+size_t n = fread(buf, 1, sz, f);
+eina_simple_xml_parse(buf, n, EINA_TRUE, _parser_cb, route);
free(buf);
}
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [EET][PATCH] NULL checks again
Hello, Please consider to add another NULL checks in eet lib: 1. eet_data_descriptor_element_add - NULL check for data descriptor handle parameter. 2. eet_connection_send and eet_connection_node_send - NULL check for connection parameter. Please take a look at attached patches. BR, Zbigniew 0001-add-NULL-check-for-conn-parameter.patch Description: Binary data 0001-eet_data_descriptor_element_add-add-NULL-check-for-e.patch Description: Binary data -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [e-users] Another French^WKorean E diner
I will join :) Daniel Juyung Seo (SeoZ) On Thu, Oct 4, 2012 at 6:17 PM, Cedric BAIL wrote: > Hello every body, > > Long time no see ! For all of you that are in Korea or may be around > Seoul on Friday 12th of October, aka Friday next week, I propose we > met in Itaewon for a diner at around 8pm. So who is joining ? And we > will have two special guests ! > > See you, > -- > Cedric BAIL > > -- > Don't let slow site performance ruin your business. Deploy New Relic APM > Deploy New Relic app performance management and know exactly > what is happening inside your Ruby, Python, PHP, Java, and .NET app > Try New Relic at no cost today and get our sweet Data Nerd shirt too! > http://p.sf.net/sfu/newrelic-dev2dev > ___ > enlightenment-users mailing list > enlightenment-us...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-users -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Entry widget, memory corrupted
I have found the roots of my problem: it's the COMPAT_SMART_DATA(sd)->text_get(obj, part); instruction in the elm_widget.c When I arrive in this instruction, I have a memory corrupted - Mail original - De: "Cedric BAIL" À: "Enlightenment developer list" Envoyé: Jeudi 4 Octobre 2012 10:57:52 Objet: Re: [E-devel] Entry widget, memory corrupted On Thu, Oct 4, 2012 at 5:18 PM, wrote: >I write a simple text editor with the Entry widget (elementary 1.7). >But when I use that in a "big" file (for example 300 lines), >I have an memory corrupted error (it works for small file). >The Entry widget has a maximal number of character? Not really and ecrire seems to be fine with big file. Look at http://trac.enlightenment.org/e/browser/trunk/ecrire for a sample code that use elm entry. -- Cedric BAIL -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: mike_m trunk/e/src/modules/conf_randr
On 04/10/12 12:47, Enlightenment SVN wrote: > Log: > e: Fix warning > >e_smart_monitor.c:1036:29: warning: ?\226?\128?\152mode?\226?\128?\153 may > be used uninitialized in this function > >Signed-off-by: Mike McCormack > > Author: mike_m > Date: 2012-10-04 04:47:43 -0700 (Thu, 04 Oct 2012) > New Revision: 77427 > Trac: http://trac.enlightenment.org/e/changeset/77427 > > Modified: >trunk/e/src/modules/conf_randr/e_smart_monitor.c > > Modified: trunk/e/src/modules/conf_randr/e_smart_monitor.c > === > --- trunk/e/src/modules/conf_randr/e_smart_monitor.c 2012-10-04 11:00:26 UTC > (rev 77426) > +++ trunk/e/src/modules/conf_randr/e_smart_monitor.c 2012-10-04 11:47:43 UTC > (rev 77427) > @@ -1033,7 +1033,7 @@ > Evas_Coord w, h, cw, ch; > Evas_Coord mx, my; > Evas_Coord nrw, nrh; > - Ecore_X_Randr_Mode_Info *mode; > + Ecore_X_Randr_Mode_Info *mode = NULL; > > ev = event; > > > Thanks Mike :) dh -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
whoops
On Thu, Oct 4, 2012 at 12:45 PM, Sebastian Dransfeld
wrote:
> On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> > Log:
> > show desktop filename in icon selection dialog
> >ticket #1237
>
> You are joking? Static text as argument for %s?
>
> S.
>
> >
> >
> > Author: discomfitor
> > Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> > New Revision: 77411
> > Trac: http://trac.enlightenment.org/e/changeset/77411
> >
> > Modified:
> >trunk/e/src/bin/e_eap_editor.c
> >
> > Modified: trunk/e/src/bin/e_eap_editor.c
> > ===
> > --- trunk/e/src/bin/e_eap_editor.c2012-10-04 08:31:35 UTC (rev 77410)
> > +++ trunk/e/src/bin/e_eap_editor.c2012-10-04 08:43:50 UTC (rev 77411)
> > @@ -808,6 +808,7 @@
> > E_Desktop_Edit *editor;
> > char *path = NULL;
> > const char *icon_path = NULL;
> > + char buf[PATH_MAX + 32];
> >
> > editor = data2;
> > cfdata = data1;
> > @@ -818,7 +819,8 @@
> > if (!dia) return;
> > e_object_del_attach_func_set(E_OBJECT(dia),
> >
> _e_desktop_edit_cb_icon_select_destroy);
> > - e_dialog_title_set(dia, _("Select an Icon"));
> > + snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for",
> ecore_file_file_get(cfdata->orig_path));
> > + e_dialog_title_set(dia, buf);
> > dia->data = cfdata;
> >
> > /* absolute path to icon */
> >
> >
> >
> --
> > Don't let slow site performance ruin your business. Deploy New Relic APM
> > Deploy New Relic app performance management and know exactly
> > what is happening inside your Ruby, Python, PHP, Java, and .NET app
> > Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
>
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
Am Donnerstag, 4. Oktober 2012 um 13:45 schrieb Sebastian Dransfeld:
> On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> > Log:
> > show desktop filename in icon selection dialog
> > ticket #1237
> >
>
>
> You are joking? Static text as argument for %s?
More probably forgot the _() around for gettext :)
>
> S.
>
> >
> >
> > Author: discomfitor
> > Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> > New Revision: 77411
> > Trac: http://trac.enlightenment.org/e/changeset/77411
> >
> > Modified:
> > trunk/e/src/bin/e_eap_editor.c
> >
> > Modified: trunk/e/src/bin/e_eap_editor.c
> > ===
> > --- trunk/e/src/bin/e_eap_editor.c 2012-10-04 08:31:35 UTC (rev 77410)
> > +++ trunk/e/src/bin/e_eap_editor.c 2012-10-04 08:43:50 UTC (rev 77411)
> > @@ -808,6 +808,7 @@
> > E_Desktop_Edit *editor;
> > char *path = NULL;
> > const char *icon_path = NULL;
> > + char buf[PATH_MAX + 32];
> >
> > editor = data2;
> > cfdata = data1;
> > @@ -818,7 +819,8 @@
> > if (!dia) return;
> > e_object_del_attach_func_set(E_OBJECT(dia),
> > _e_desktop_edit_cb_icon_select_destroy);
> > - e_dialog_title_set(dia, _("Select an Icon"));
> > + snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for",
> > ecore_file_file_get(cfdata->orig_path));
> > + e_dialog_title_set(dia, buf);
> > dia->data = cfdata;
> >
> > /* absolute path to icon */
> >
> >
> > --
> > Don't let slow site performance ruin your business. Deploy New Relic APM
> > Deploy New Relic app performance management and know exactly
> > what is happening inside your Ruby, Python, PHP, Java, and .NET app
> > Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> > http://p.sf.net/sfu/newrelic-dev2dev
> > ___
> > enlightenment-svn mailing list
> > enlightenment-...@lists.sourceforge.net
> > (mailto:enlightenment-...@lists.sourceforge.net)
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
>
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> (mailto:enlightenment-devel@lists.sourceforge.net)
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: discomfitor trunk/e/src/bin
On 10/04/2012 10:43 AM, Enlightenment SVN wrote:
> Log:
> show desktop filename in icon selection dialog
>ticket #1237
You are joking? Static text as argument for %s?
S.
>
>
> Author: discomfitor
> Date: 2012-10-04 01:43:50 -0700 (Thu, 04 Oct 2012)
> New Revision: 77411
> Trac: http://trac.enlightenment.org/e/changeset/77411
>
> Modified:
>trunk/e/src/bin/e_eap_editor.c
>
> Modified: trunk/e/src/bin/e_eap_editor.c
> ===
> --- trunk/e/src/bin/e_eap_editor.c2012-10-04 08:31:35 UTC (rev 77410)
> +++ trunk/e/src/bin/e_eap_editor.c2012-10-04 08:43:50 UTC (rev 77411)
> @@ -808,6 +808,7 @@
> E_Desktop_Edit *editor;
> char *path = NULL;
> const char *icon_path = NULL;
> + char buf[PATH_MAX + 32];
>
> editor = data2;
> cfdata = data1;
> @@ -818,7 +819,8 @@
> if (!dia) return;
> e_object_del_attach_func_set(E_OBJECT(dia),
> _e_desktop_edit_cb_icon_select_destroy);
> - e_dialog_title_set(dia, _("Select an Icon"));
> + snprintf(buf, sizeof(buf), "%s '%s'", "Select an Icon for",
> ecore_file_file_get(cfdata->orig_path));
> + e_dialog_title_set(dia, buf);
> dia->data = cfdata;
>
> /* absolute path to icon */
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: cedric IN trunk/elementary: . data/themes/widgets src/lib
AWESOME!!!
I just added this to elementary_test.
Thanks.
Daniel Juyung Seo (SeoZ)
On Thu, Oct 4, 2012 at 5:27 PM, Enlightenment SVN
wrote:
> Log:
> elementary: add color picker to elm_colorselector.
>
>
> Author: cedric
> Date: 2012-10-04 01:27:07 -0700 (Thu, 04 Oct 2012)
> New Revision: 77409
> Trac: http://trac.enlightenment.org/e/changeset/77409
>
> Modified:
> trunk/elementary/ChangeLog trunk/elementary/NEWS
> trunk/elementary/data/themes/widgets/colorselector.edc
> trunk/elementary/src/lib/elm_colorselector.c
> trunk/elementary/src/lib/elm_colorselector.h
> trunk/elementary/src/lib/elm_widget_colorselector.h
>
> Modified: trunk/elementary/ChangeLog
> ===
> --- trunk/elementary/ChangeLog 2012-10-04 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/ChangeLog 2012-10-04 08:27:07 UTC (rev 77409)
> @@ -560,3 +560,7 @@
>
> * fix copy&paste error in elm_flip.
> * fix possible invalid memory access in elm_access.
> +
> +2012-10-04 Cedric Bail
> +
> + * Add a color picker to elm_colorselector.
>
> Modified: trunk/elementary/NEWS
> ===
> --- trunk/elementary/NEWS 2012-10-04 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/NEWS 2012-10-04 08:27:07 UTC (rev 77409)
> @@ -9,6 +9,7 @@
> * Add reorder mode set/get API in Toolbar.
> * Add the toolbar API which expand the transverse length.
> * Add a way to know which month is displayed in elm_calendar
> + * Add color picker to elm_colorselector.
>
> Improvements:
>
>
> Modified: trunk/elementary/data/themes/widgets/colorselector.edc
> ===
> --- trunk/elementary/data/themes/widgets/colorselector.edc 2012-10-04
> 08:22:44 UTC (rev 77408)
> +++ trunk/elementary/data/themes/widgets/colorselector.edc 2012-10-04
> 08:27:07 UTC (rev 77409)
> @@ -4,6 +4,31 @@
> data.item: "horizontal_pad" "10";
> data.item: "vertical_pad" "10";
> parts {
> + part { name: "picker";
> + type: SWALLOW;
> + scale: 1;
> + description { state: "default" 0.0;
> +align: 0.0 0.0;
> +rel1.relative: 0.0 0.0;
> +rel2.relative: 1.0 0.0;
> + }
> + }
> + part { name: "top_padding";
> + type: SPACER;
> + scale: 1;
> + description { state: "default" 0.0;
> +min: 0 20;
> +fixed: 0 1;
> +rel1.relative: 0.0 1.0;
> +rel1.to: "picker";
> +rel2.to: "picker";
> +align: 0.0 0.0;
> + }
> + description { state: "disabled" 0.0;
> +inherit: "default" 0.0;
> +min: 0 0;
> + }
> + }
>part { name: "palette";
> type: SWALLOW;
> scale: 1;
> @@ -11,18 +36,19 @@
> align: 0.0 0.0;
> fixed: 0 1;
> rel1 {
> - relative: 0.0 0.0;
> + relative: 0.0 1.0;
> + to: "top_padding";
> }
> rel2 {
> - relative: 1.0 0.0;
> + relative: 1.0 1.0;
> + to: "top_padding";
> }
> }
>}
>part{ name: "bottom_padding";
> - type: RECT;
> + type: SPACER;
> scale: 1;
> description { state: "default" 0.0;
> -visible: 0;
> min: 0 20;
> fixed: 0 1;
> rel1.relative: 0.0 1.0;
> @@ -49,27 +75,79 @@
>}
> }
> programs {
> + program { name: "init";
> + source: "";
> + signal: "load";
> + action: STATE_SET "disabled" 0.0;
> + target: "top_padding";
> + }
>program { name: "palette";
> source: "elm";
> signal: "elm,state,palette";
> action: STATE_SET "disabled" 0.0;
> target: "bottom_padding";
> + target: "top_padding";
>}
>program { name: "components";
> source: "elm";
> signal: "elm,state,components";
> action: STATE_SET "disabled" 0.0;
> target: "bottom_padding";
> + target: "top_padding";
>}
>program { name: "both";
> source: "elm";
> signal: "elm,state,both";
> action: STATE_SET "default" 0.0;
> target: "bottom_padding";
> + after: "notop";
>}
> + program { name: "notop";
> + action: STATE_SET "disabled" 0.0;
> + target: "top_padding";
> + }
> + program { name: "picker";
> + source: "elm";
> + signal: "elm,state,picker";
> + action: STATE_SET "disabled" 0.0;
> + target: "bottom_padding";
> + target: "top_padding";
> + }
> + program { name: "all";
> + source: "elm";
> + signal: "elm,state,all";
> + actio
[E-devel] Another French^WKorean E diner
Hello every body, Long time no see ! For all of you that are in Korea or may be around Seoul on Friday 12th of October, aka Friday next week, I propose we met in Itaewon for a diner at around 8pm. So who is joining ? And we will have two special guests ! See you, -- Cedric BAIL -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Entry widget, memory corrupted
On Thu, Oct 4, 2012 at 5:18 PM, wrote: >I write a simple text editor with the Entry widget (elementary 1.7). >But when I use that in a "big" file (for example 300 lines), >I have an memory corrupted error (it works for small file). >The Entry widget has a maximal number of character? Not really and ecrire seems to be fine with big file. Look at http://trac.enlightenment.org/e/browser/trunk/ecrire for a sample code that use elm entry. -- Cedric BAIL -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCHES] Allocation bugs in ecore, eio, elmdentica
On 10/03/2012 05:28 PM, Igor Murzov wrote: > All patches are > Reviewed-by: Igor Murzov > > I have just prepared the very same patch for Eio, but you were > faster submitting it :) Hehe, it happens. But I see you had enough patches that no-one beat you to.:-) Regards, Daniel Willmann -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Entry widget, memory corrupted
hey On Thu, Oct 4, 2012 at 10:18 AM, wrote: > Hello, > >I write a simple text editor with the Entry widget (elementary 1.7). >But when I use that in a "big" file (for example 300 lines), >I have an memory corrupted error (it works for small file). >The Entry widget has a maximal number of character? i have no idea about your problem, but maybe you can help with another text editor (in very early stage) : http://trac.enlightenment.org/e/browser/trunk/PROTO/edi/src/bin Vincent -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Entry widget, memory corrupted
Hello,
I write a simple text editor with the Entry widget (elementary 1.7).
But when I use that in a "big" file (for example 300 lines),
I have an memory corrupted error (it works for small file).
The Entry widget has a maximal number of character?
Kind regards
Oboeuf David#include
#include
#include
char *keyword[] = {
"#define ", "#elif ", "#endif ", "#if ", "#ifdef ", "#ifndef ", "#include ",
"/*", "*/", "//", "NULL", "auto ", "break ", "case ", "char ", "const ",
"continue ", "default ", "do " ,"double ", "else ", "enum ", "extern ",
"float ", "for ", "goto ", "if ", "int ", "long ", "register ", "return ",
"short ", "signed ", "sizeof ", "static ","struct ", "switch ", "typedef ",
"union ", "unsigned ", "void ", "volatile ", "while"
};
typedef struct donnee{
Evas_Object *win;
Evas_Object *inwin;
Evas_Object *fileselect;
Evas_Object *entry;
char* txt;
char save_as;
}donnee;
static void
on_color(void *data, Evas_Object *obj, void *event_info)
{
donnee *dat = (donnee*)data;
char *name;
char buf[28];
int i = 0, j = 0;
int pos = elm_entry_cursor_pos_get(dat->entry);
int pos_init, pos_rel;
elm_entry_cursor_line_begin_set(dat->entry);
pos_init = elm_entry_cursor_pos_get(dat->entry);
elm_entry_cursor_selection_begin(dat->entry);
elm_entry_cursor_line_end_set(dat->entry);
elm_entry_cursor_selection_end(dat->entry);
dat->txt = elm_entry_markup_to_utf8(elm_entry_selection_get(dat->entry));
char *mark = strdup(elm_entry_selection_get(dat->entry));
elm_entry_select_none(dat->entry);
// if(mark) printf("mark %s",mark);
for(i = 0; i < 43; i++)
{
name = dat->txt;
do{
name = strstr(name, keyword[i]);
snprintf(buf, sizeof(buf), "%s", keyword[i]);
if(name){
pos_rel = name - dat->txt + pos_init;
switch(i) {
case 8:
if( !strstr(mark, "*/") ){
elm_entry_cursor_pos_set(dat->entry, pos_rel + strlen(keyword[i]) );
elm_entry_entry_insert(dat->entry, "");
}
break;
case 7:
if( !strstr(mark, "/*") ){
elm_entry_cursor_pos_set(dat->entry, pos_rel);
elm_entry_entry_insert(dat->entry, "");
}
break;
case 9:
if( !strstr(mark, "//") ){
elm_entry_cursor_pos_set(dat->entry, pos_rel);
elm_entry_entry_insert(dat->entry, "");
elm_entry_cursor_line_end_set(dat->entry);
elm_entry_entry_insert(dat->entry, " ");
}
break;
default:
if( !strstr(mark, buf) ){
elm_entry_cursor_pos_set(dat->entry, pos_rel);
elm_entry_entry_insert(dat->entry, "");
elm_entry_cursor_pos_set(dat->entry, pos_rel + strlen(keyword[i]) );
elm_entry_entry_insert(dat->entry, "");
}
break;
}
name += strlen(keyword[i]);
}
memset(buf,'\n',sizeof(buf));
}while(name != NULL);
}
free(dat->txt);
free(mark);
// printf("text : %s\n", elm_entry_entry_get(dat->entry));
elm_entry_cursor_pos_set(dat->entry,pos);
}
static void
fileselector_done(void *data, Evas_Object *obj, void *event_info)
{
const char *selected = event_info;
donnee *dat = (donnee*)data;
if (selected)
{
elm_entry_file_set(dat->entry, selected, ELM_TEXT_FORMAT_PLAIN_UTF8);
elm_win_title_set(dat->win, selected);
evas_object_del(dat->fileselect);
evas_object_del(dat->inwin);
if(dat->save_as)
elm_entry_entry_set(dat->entry, dat->txt);
}
else
{
evas_object_del(dat->fileselect);
evas_object_del(dat->inwin);
}
elm_entry_file_save(dat->entry);
dat->save_as = 0;
elm_entry_cursor_begin_set(dat->entry);
do{
on_color(dat,obj,event_info);
}while(elm_entry_cursor_down(dat->entry));
elm_entry_cursor_begin_set(dat->entry);
}
static void
on_done(void *data, Evas_Object *obj, void *event_info)
{
/* quit the mainloop (elm_run) */
elm_exit();
}
static void
new_file(void *data, Evas_Object *obj, void *event_info)
{
donnee *dat = (donnee*)data;
elm_win_title_set(dat->win, "New File");
elm_entry_entry_set(dat->entry,NULL);
elm_object_focus_set(dat->entry, EINA_TRUE);
}
static void
open(void *data, Evas_Object *obj, void *event_info)
{
donnee *dat = (donnee*)data;
dat->inwin = elm_win_inwin_add(dat->win);
dat->fileselect = elm_fileselector_add(dat->inwin);
elm_fileselector_path_set(dat->fileselect, getenv("HOME"));
elm_fileselector_
Re: [E-devel] E SVN: stefan trunk/PROTO/elocation/src/lib
Hello. On 03/10/12 17:54, Jose Souza wrote: > In your case its unnecessary this line: if (strcmp(bus, > GEOCLUE_DBUS_NAME) != 0) > Only do that if you use the same callback to multiple bus names. Good point. As it is only used for this one callback it must be this bus name anyway. Fixed. Will be in my next commit batch. regards Stefan Schmidt -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
