[Change Request] Don't try to restart iscsi{,d}

2009-08-11 Thread Ricky Zhou 
In light of what I just did to xen15, I'd like to make this change so
that puppet never makes the same mistake :-)

---
 modules/iscsi-initiator-utils/manifests/init.pp |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/modules/iscsi-initiator-utils/manifests/init.pp 
b/modules/iscsi-initiator-utils/manifests/init.pp
index 4fbd54c..193b377 100644
--- a/modules/iscsi-initiator-utils/manifests/init.pp
+++ b/modules/iscsi-initiator-utils/manifests/init.pp
@@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
 file { '/etc/iscsi/initiatorname.iscsi':
 content => template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
 require => Package['iscsi-initiator-utils'],
-notify => [Service['iscsi'], Service['iscsid']],
+# Never, ever notify this service - do any restarts manually
+# after making sure that nothing is using a disk on iscsi.
+#notify => [Service['iscsi'], Service['iscsid']],
 }
 }
 
-- 
1.5.5.6



pgplvSUTHPxj4.pgp
Description: PGP signature
___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list

Re: [Change Request] Don't try to restart iscsi{,d}

2009-08-11 Thread Stephen John Smoogen 
+1 to make this change. Things are screwey enought right now wihtout
it accidently doing it .

On Tue, Aug 11, 2009 at 9:56 PM, Ricky Zhou wrote:
> In light of what I just did to xen15, I'd like to make this change so
> that puppet never makes the same mistake :-)
>
> ---
>  modules/iscsi-initiator-utils/manifests/init.pp |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/modules/iscsi-initiator-utils/manifests/init.pp 
> b/modules/iscsi-initiator-utils/manifests/init.pp
> index 4fbd54c..193b377 100644
> --- a/modules/iscsi-initiator-utils/manifests/init.pp
> +++ b/modules/iscsi-initiator-utils/manifests/init.pp
> @@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
>     file { '/etc/iscsi/initiatorname.iscsi':
>         content => template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
>         require => Package['iscsi-initiator-utils'],
> -        notify => [Service['iscsi'], Service['iscsid']],
> +        # Never, ever notify this service - do any restarts manually
> +        # after making sure that nothing is using a disk on iscsi.
> +        #notify => [Service['iscsi'], Service['iscsid']],
>     }
>  }
>
> --
> 1.5.5.6
>
>
> ___
> Fedora-infrastructure-list mailing list
> Fedora-infrastructure-list@redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>
>



-- 
Stephen J Smoogen.

Ah, but a man's reach should exceed his grasp. Or what's a heaven for?
-- Robert Browning

___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list

Re: [Change Request] Don't try to restart iscsi{,d}

2009-08-12 Thread Toshio Kuratomi 
On 08/11/2009 09:09 PM, Stephen John Smoogen wrote:
> +1 to make this change. Things are screwey enought right now wihtout
> it accidently doing it .
> 
+1

-Toshio

> On Tue, Aug 11, 2009 at 9:56 PM, Ricky Zhou wrote:
>> In light of what I just did to xen15, I'd like to make this change so
>> that puppet never makes the same mistake :-)
>>
>> ---
>>  modules/iscsi-initiator-utils/manifests/init.pp |4 +++-
>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/modules/iscsi-initiator-utils/manifests/init.pp 
>> b/modules/iscsi-initiator-utils/manifests/init.pp
>> index 4fbd54c..193b377 100644
>> --- a/modules/iscsi-initiator-utils/manifests/init.pp
>> +++ b/modules/iscsi-initiator-utils/manifests/init.pp
>> @@ -33,7 +33,9 @@ class iscsi-initiator-utils::initiator {
>> file { '/etc/iscsi/initiatorname.iscsi':
>> content => template("iscsi-initiator-utils/initiatorname.iscsi.erb"),
>> require => Package['iscsi-initiator-utils'],
>> -notify => [Service['iscsi'], Service['iscsid']],
>> +# Never, ever notify this service - do any restarts manually
>> +# after making sure that nothing is using a disk on iscsi.
>> +#notify => [Service['iscsi'], Service['iscsid']],
>> }
>>  }
>>
>> --
>> 1.5.5.6
>>
>>
>> ___
>> Fedora-infrastructure-list mailing list
>> Fedora-infrastructure-list@redhat.com
>> https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
>>
>>
> 
> 
> 




signature.asc
Description: OpenPGP digital signature
___
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list