[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226542 Karel Zak changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Flag|needinfo?(k...@redhat.com) | --- Comment #6 from Karel Zak 2009-01-12 07:41:38 EDT --- (In reply to comment #4) > Some suggestions, I really would like to see, but no must: > - Remove "BuildRequires: coreutils", something else anyway pulls that in Fixed. > - Replace "Source: mwords.tar.Z" by "Source: > http://web.archive.org/web/20060527013227/http://www.dcs.shef.ac.uk/research/ilash/Moby/mwords.tar.Z"; > as it is a valid source URL and everybody can verify it OK, good idea. Fixed. > Karel, olease close the bug report once you've applied the changes or let me > know why you won't do this and close this bug report therewith. Closing... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226542 --- Comment #5 from Robert Scheck 2009-01-10 18:02:26 EDT --- Karel, ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226542 Robert Scheck changed: What|Removed |Added AssignedTo|red...@linuxnetz.de |redhat-bugzi...@linuxnetz.d ||e -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226542 Robert Scheck changed: What|Removed |Added AssignedTo|k...@redhat.com |red...@linuxnetz.de Flag|fedora-review- |fedora-review+, ||needinfo?(k...@redhat.com) --- Comment #4 from Robert Scheck 2008-12-20 09:36:00 EDT --- As Roozbeh did not continue the review for more than 1.5 years now, I'm now and hereby just silently overtaking the review. Re-assinging the bug report to me first, as it is usual for a Package Review. So rpmlint is completely silent, good job until now. Rest of the package is sane according to my knowledge of being a packager. Some suggestions, I really would like to see, but no must: - Remove "BuildRequires: coreutils", something else anyway pulls that in - Replace "Source: mwords.tar.Z" by "Source: http://web.archive.org/web/20060527013227/http://www.dcs.shef.ac.uk/research/ilash/Moby/mwords.tar.Z"; as it is a valid source URL and everybody can verify it Karel, olease close the bug report once you've applied the changes or let me know why you won't do this and close this bug report therewith. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: words https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226542 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium --- Additional Comments From [EMAIL PROTECTED] 2007-04-02 04:49 EST --- > * Version field is quite arbitrary (3.0) instead of matching upstream. The upstream doesn't use any versioning. > * Separate license file into a different "Source" file. Also explain in the > file that the license info in the file readme.txt is deprecated. Good point. Thanks. Fixed. Please, review the package (words-3.0-12.fc7). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: words
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226542
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
Flag|fedora-review? |fedora-review-
--- Additional Comments From [EMAIL PROTECTED] 2007-02-03 21:00 EST ---
Partial review:
GOOD
MUST: source matches upstream (md5sum checked)
BAD
===
MUST: rpmlint output
SRPM:
W: words summary-ended-with-dot A dictionary of English words for the
/usr/share/dict directory.
E: words tag-not-utf8 %changelog
W: words invalid-license public domain
E: words non-utf8-spec-file words.spec
E: words no-cleaning-of-buildroot %install
All should be fixed:
- Change License to "Public Domain"
- Remove dot at the end of summart
- change SPEC file to UTF-8
- clean the buildroot in %install using rm -rf $RPM_BUILD_ROOT
For the RPM, the errors are a subset of above.
* Version field is quite arbitrary (3.0) instead of matching upstream.
* Separate license file into a different "Source" file. Also explain in the
file that the license info in the file readme.txt is deprecated.
* Change /usr/share in %files section to %{_datadir}
* Change %defattr(-,root,root) to %defattr(-,root,root,-)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226542] Merge Review: words
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: words https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226542 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-02-03 20:36 EST --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
