[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #10 from Lubomir Rintel lkund...@v3.sk 2009-02-09 09:45:04 EDT --- Petr: ping. Alive? :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #11 from Petr Sklenar pskle...@redhat.com 2009-02-09 11:32:26 EDT --- hi, yes I live :) I made changes up your comments, and latest version is here: Spec URL: http://people.redhat.com/psklenar/stardict-dic-cs_CZ.spec SRPM URL: http://people.redhat.com/psklenar/stardict-dic-cs_CZ- 20081201-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #8 from Petr Sklenar pskle...@redhat.com 2009-01-29 09:56:18 EDT --- Hi, I made informal review at https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=481732
--- Comment #9 from Lubomir Rintel lkund...@v3.sk 2009-01-29 12:58:28 EDT ---
(In reply to comment #8)
Hi,
I made informal review at
https://bugzilla.redhat.com/show_bug.cgi?id=480860#c4
I like it. I'd still like to se at least a couple more, this one was pretty
easy :)
A review of this package:
1.) Package name.
To be consistent with other existing practice applied to other stardict
dictionary packages I suggest you rename the package to stardict-dic-cs or
stardict-dic-cs_CZ.
You may still want to add a Provides: for the upstream name.
2.) Package version.
%define dicdate 20081201
Version: 1.0.0
Source0:
ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz
Is 1.0.0 made up? Why not use 20081201 as version?
3.) URL tag.
URL: ftp://dl.cihar.com/slovnik/stable/stardict-english-czech-%{dicdate}.tar.gz
Purpose of the URL tag is to address the package's home page, with general
information about it -- it definitely should not be the same as Source tag.
4.) BuildArchitectures tag.
This is fairly minor, but: it is commonly spelled BuildArch:
5.) Setup
%setup -c -T -n %{name}-%{version}
%setup -q -n %{name}-%{version} -D -T -a 0
This could be written as:
%setup -q -c -n %{name}-%{version}
6.) No need to rename the README file
install -p -m 0644 %{name}-%{dicdate}/README LICENSE
Especially when it does not contain the license text.
7.) Your %description is not informative
Description is not meant to contain information about history of the package or
its build process, but rather contents of the package. The latter URL belongs
to the Url: tag and rest should be replaced with something like:
Czech-English and English-Czech translation dictionaries for StarDict, a
GUI-based dictionary software.
8.) Group.
I guess Applications/Text would be a far better pick than Applications/System.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? --- Comment #3 from Lubomir Rintel lkund...@v3.sk 2009-01-28 08:29:02 EDT --- Taking this. (In reply to comment #1) Hello, this is my second package, I am seeking sponsor like at bug 481272 I could sponsor you, but I can't find any reviews you've participated in. Would you mind pointing me to some, so I can be sure about your packaging abilities? In case you haven't done so, I recommend picking up a couple of review requests and doing preliminary reviews. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #4 from Petr Sklenar pskle...@redhat.com 2009-01-28 08:44:51 EDT --- I started with fedora packaging these time so I haven't done any pre-review, but I would like. Please can you recommend me some review to do preliminary review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #5 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-28 08:51:05 EDT --- Petr, you could start for instance with https://bugzilla.redhat.com/show_bug.cgi?id=480860 which is an easy one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #6 from Petr Sklenar pskle...@redhat.com 2009-01-28 09:01:48 EDT --- re Comment #5: OK, thanks much -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #7 from Lubomir Rintel lkund...@v3.sk 2009-01-28 09:11:01 EDT --- Here's the review queue: http://fedoraproject.org/PackageReviewStatus/REVIEW.html You are probably looking for bugs in NEW state, assigned to (Nobody). By skimming through the list I've managed to find one package for which the review did not start at all yet: python-argparse (bug #462505) You may want to help your colleagues with Merge reviews as well ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 Petr Sklenar pskle...@redhat.com changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #1 from Petr Sklenar pskle...@redhat.com 2009-01-27 08:06:16 EDT --- Hello, this is my second package, I am seeking sponsor like at bug 481272 There is GNU/FDL licence in separate file /usr/share/doc/stardict-english-czech-20081201/README Should I rename it to 'LICENSE' or is it OK? Original author has this name of file for licence. I made mistake for URL in first comment, this is right URL: Spec URL: http://people.redhat.com/psklenar/stardict-english-czech.spec SRPM URL: http://people.redhat.com/psklenar/stardict-english-czech-1.0.0-1.fc10.src.rpm Czech dictionaries for StarDict. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481732 --- Comment #2 from manuel wolfshant wo...@nobugconsulting.ro 2009-01-27 08:13:36 EDT --- No, it is not necessary to rename the files from the source (unless there is a very good reason, for instance in order to avoid a conflict with another package) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
