Re: [foreman-dev] Be sure to import your product content data for Katello 3.6

[Jonathon Turel]

On Thursday, December 7, 2017 at 6:04:45 AM UTC-5, Ewoud Kohl van 
Wijngaarden wrote:
>
> On Wed, Dec 06, 2017 at 07:07:05AM -0800, Jonathon Turel wrote: 
> >A change 
> ><
> https://github.com/Katello/katello/commit/946b2990c9a054babc9ad563e1b14c4161207b3e>
>  
>
> >landed in Katello yesterday which introduced a new pattern of importing 
> >product content information from Candlepin into the Katello DB. This is 
> in 
> >support of some new feature work and means that Candlepin will no longer 
> be 
> >consulted for that information until it's time to be refreshed. All areas 
> >of Katello which use product content data are affected such as the Red 
> Hat 
> >Repositories page and several APIs. 
> > 
> >In order to populate your local cache, please run `rake 
> >katello:upgrades:3.6:import_product_content`. From that point on the 
> cache 
> >should be updated through ordinary use of Katello - importing manifests, 
> >etc. This step is not necessary unless you have a manifest imported 
> and/or 
> >custom products created. 
> > 
> >I'm working on a change for the installer to do the same import and I'll 
> >update this thread once it's ready for review & test. 
> > 
> >Let me know if you have problems, questions, or concerns. 
>
> Perhaps this is unrelated and not even possible, but I'd like to know if 
> we could change database provisioning/seeding to not require candlepin. 
> Currently for the organization a matching org in candlepin is created. 
> That's a dependency that ideally shouldn't be there. Do you see this as 
> an option? 
>

I'd have to look into that, but I think I see the merit. Maybe opening an 
issue is appropriate here?
 

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Custom hiera in Katello 3.4 deployment

[Ewoud Kohl van Wijngaarden]

On Thu, Dec 07, 2017 at 04:16:14PM +0100, Lukas Zapletal wrote:

I have Katello 3.4 and I created this file:

/etc/foreman-installer/custom-hiera.yaml

---
dns::zones:
 home.lan:
   soa: winter.home.lan
   soaip: 192.168.99.1
   contact: hostmaster.home.lan.

After re-running the installer (in dry mode) nothing really happens.
This is already configured system, is there anything I need to do in
order to add this zone?


That depends on 88d31627716da45696a0628a892c83dc10ebfc86[1] which was 
included in theforeman-dns 5.0.1. Foreman 1.15 only includes 3.0.1 so it 
needs a backport. I don't think we'll be doing more of those for 
upstream but I can do it downstream.


[1]: 
https://github.com/theforeman/puppet-dns/commit/88d31627716da45696a0628a892c83dc10ebfc86

--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Be sure to import your product content data for Katello 3.6

[Jonathon Turel]

On Thursday, December 7, 2017 at 5:31:44 AM UTC-5, Eric Helms wrote:
>
> This sounds great! How long on average are you seeing the import take?
>


In my environment I have two orgs each with a manifest, totaling 270 
products. It's been taking about a minute to run the rake task (including 
the startup time) which results in the creation of 4027 Content records, 
and 4934 ProductContent records (which maps a Product to a Content as you 
might guess). The numbers are different because a single Content can be 
shared among products. I think the performance is pretty good 
.

 

>
> On Dec 6, 2017 10:07 AM, "Jonathon Turel" > 
> wrote:
>
>> Hi all,
>>
>> A change 
>> 
>>  
>> landed in Katello yesterday which introduced a new pattern of importing 
>> product content information from Candlepin into the Katello DB. This is in 
>> support of some new feature work and means that Candlepin will no longer be 
>> consulted for that information until it's time to be refreshed. All areas 
>> of Katello which use product content data are affected such as the Red Hat 
>> Repositories page and several APIs.
>>
>> In order to populate your local cache, please run `rake 
>> katello:upgrades:3.6:import_product_content`. From that point on the cache 
>> should be updated through ordinary use of Katello - importing manifests, 
>> etc. This step is not necessary unless you have a manifest imported and/or 
>> custom products created.
>>
>> I'm working on a change for the installer to do the same import and I'll 
>> update this thread once it's ready for review & test.
>>
>> Let me know if you have problems, questions, or concerns.
>>
>> Thanks,
>>
>> Jonathon
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to foreman-dev...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Custom hiera in Katello 3.4 deployment

[Lukas Zapletal]

Hey,

I have Katello 3.4 and I created this file:

/etc/foreman-installer/custom-hiera.yaml

---
dns::zones:
  home.lan:
soa: winter.home.lan
soaip: 192.168.99.1
contact: hostmaster.home.lan.

After re-running the installer (in dry mode) nothing really happens.
This is already configured system, is there anything I need to do in
order to add this zone?

Thanks

-- 
Later,
  Lukas @lzap Zapletal

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

[Andrew Kofink]

>
> notification updates (they're cached) are only a hassle because they're
> logged


Agreed. In development, the extra logs make debugging more difficult;
performance is not the motivation.

On Thu, Dec 7, 2017 at 10:08 AM, Daniel Lobato Garcia 
wrote:

> On 12/06, Ohad Levy wrote:
> > On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines 
> wrote:
> >
> > > > Oh yeah, especially notifications. Why can't they just update when
> the
> > > page updates?
> > >
> > > I think it would be good to move the notifications to a websocket
> approach
> > > instead of polling.  I know, I know, PRs welcome :)
> > >
> >
> > We can consider using SSE for sending notifications too, but I'm
> uncertain
> > how it would play with passenger. a more reliable approach would probably
> > be to start using redis + websockets additional service proxied by apache
> > (and webpack in development)
>
> I tried to make the Job Invocations donut chart work with ActionCable
> (so yeah, WebSockets):
>
> https://github.com/dlobatog/foreman/tree/actioncable , needs
> foreman_remote_execution to work
>
> Unfortunately..
> https://www.phusionpassenger.com/library/config/apache/
> action_cable_integration/
>
> If anyone wants to spend time changing our stack to be Passenger
> standalone behind an Apache proxy, I'd welcome the change but I am not
> sure whether that's worth the effort/possible bugs/etc..
>
> Having said that, notification updates (they're cached) are only a
> hassle because they're logged. At least I don't notice any slowness or
> anything, especially since they're cached.
>
> >
> > Ohad
> >
> > >
> > > On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy  wrote:
> > >
> > >>
> > >>
> > >> On Dec 6, 2017 12:19 PM, "Ivan Necas"  wrote:
> > >>
> > >> The only concern, as the users are used to the auto-refresh, once we
> turn
> > >> that off, they can start thinking the thing got stuck.
> > >>
> > >>
> > >> In that case let's keep updating the talk progress without replacing
> the
> > >> entire tab?
> > >>
> > >>
> > >> -- Ivan
> > >>
> > >> On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:
> > >>
> > >>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink 
> > >>> wrote:
> > >>>
> >  As part of this I would love to see *all* auto reloads default to
> off
> > >
> > 
> > >>> +1 - PR are welcomes ;)
> > >>>
> > >>>
> >  Oh yeah, especially notifications. Why can't they just update when
> the
> >  page updates?
> > 
> >  On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
> >  wrote:
> > 
> > > > I think the refresh should still be off by default.
> > >
> > > As part of this I would love to see *all* auto reloads default to
> > > off.  The dashboard, for example, constantly reloading by default
> is
> > > annoying to me.
> > >
> > > Cheers,
> > > Walden
> > >
> > > On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink  >
> > > wrote:
> > >
> > >> Hello,
> > >>
> > >> We have the option of toggling auto-refresh on individual tasks,
> but
> > >> I often find myself at the foreman_tasks#tasks page
> intermittently clicking
> > >> the search button to monitor the state of automated tasks (in my
> case,
> > >> usually bats content/proxy tests). I'm proposing a button or an
> option
> > >> under the search drop down button to enable/disable auto refresh.
> I think
> > >> the refresh should still be off by default.
> > >>
> > >> Any comments?
> > >>
> > >> - Andrew
> > >>
> > >> --
> > >> Andrew Kofink
> > >> akof...@redhat.com
> > >> IRC: akofink
> > >> Software Engineer
> > >> Red Hat Satellite
> > >>
> > >> --
> > >> You received this message because you are subscribed to the Google
> > >> Groups "foreman-dev" group.
> > >> To unsubscribe from this group and stop receiving emails from it,
> > >> send an email to foreman-dev+unsubscr...@googlegroups.com.
> > >> For more options, visit https://groups.google.com/d/optout.
> > >>
> > >
> > > --
> > > You received this message because you are subscribed to the Google
> > > Groups "foreman-dev" group.
> > > To unsubscribe from this group and stop receiving emails from it,
> send
> > > an email to foreman-dev+unsubscr...@googlegroups.com.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
> > 
> > 
> > 
> >  --
> >  Andrew Kofink
> >  akof...@redhat.com
> >  IRC: akofink
> >  Software Engineer
> >  Red Hat Satellite
> > 
> >  --
> >  You received this message because you are subscribed to the Google
> >  Groups "foreman-dev" group.
> >  To unsubscribe from this group and stop receiving emails from it,
> send
> >  an email to foreman-dev+unsubscr...@googlegroups.com.
> >  For more options, visit https://groups.google.com/d/optout.
> > 
> > >>> --
> > >>> You received this message because you are subscribed to the Google
> > 

Re: [foreman-dev] 1.17 branching - status update 3

[Ondrej Prazak]

I would rather go with option 1 to avoid a large amount of cherry-picks.
Thanks for pointing out the fog update.

On Thu, Dec 7, 2017 at 3:52 PM, Eric D Helms  wrote:

> Thanks for the weekly updates!
>
> Do you forsee 1.17 working as:
>
>  1) Wait till the core codebase is updated to Rails 5.1 then branch and
> notify plugins
>  2) Branch soon at some stable point and backport the Rails 5.1 code
> changes
>
>
> I believe also on the list of items is the update to fog 1.42 that has a
> pending PR given the current version of Fog requires JSON < 2 and Ruby 2.4
> comes with JSON 2+.
>
> On Dec 7, 2017 7:02 AM, "Ondrej Prazak"  wrote:
>
>> Hi,
>> this is a quick summary of current 1.17 branching status. As before, feel
>> free to correct/complete the information below.
>>
>> The new version of turbolinks-classic (2.5.4) was released about 12 hours
>> ago, and we work on adding it to tfm-ror51 [1].
>>
>> Dynflowd deployment on Debian is almost ready to be merged [2].
>>
>> OAuth fix for Rails 5 [3] did not receive much attention from OAuth
>> maintainers. We plan to package a forked version with included fix until
>> new gem version compatible with Rails 5 is released.
>>
>> The plan is to move slowly forward with Rails 5.0 [4], then introduce
>> incompatible changes to Rails 4.2 and move to 5.1
>>
>> O.
>>
>> [1] https://github.com/theforeman/tfm-ror51-packaging/pulls
>> [2] https://github.com/theforeman/foreman-packaging/pull/1959
>> [3] https://github.com/oauth-xx/oauth-ruby/pull/150
>> [4] https://github.com/theforeman/foreman/pull/4867
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Re: [foreman-dev] RFC Auto Refresh on ForemanTasks#Tasks Page

[Daniel Lobato Garcia]

On 12/06, Ohad Levy wrote:
> On Wed, Dec 6, 2017 at 9:10 PM, Walden Raines  wrote:
>
> > > Oh yeah, especially notifications. Why can't they just update when the
> > page updates?
> >
> > I think it would be good to move the notifications to a websocket approach
> > instead of polling.  I know, I know, PRs welcome :)
> >
>
> We can consider using SSE for sending notifications too, but I'm uncertain
> how it would play with passenger. a more reliable approach would probably
> be to start using redis + websockets additional service proxied by apache
> (and webpack in development)

I tried to make the Job Invocations donut chart work with ActionCable
(so yeah, WebSockets):

https://github.com/dlobatog/foreman/tree/actioncable , needs
foreman_remote_execution to work

Unfortunately..
https://www.phusionpassenger.com/library/config/apache/action_cable_integration/

If anyone wants to spend time changing our stack to be Passenger
standalone behind an Apache proxy, I'd welcome the change but I am not
sure whether that's worth the effort/possible bugs/etc..

Having said that, notification updates (they're cached) are only a
hassle because they're logged. At least I don't notice any slowness or
anything, especially since they're cached.

>
> Ohad
>
> >
> > On Wed, Dec 6, 2017 at 1:23 PM, Ohad Levy  wrote:
> >
> >>
> >>
> >> On Dec 6, 2017 12:19 PM, "Ivan Necas"  wrote:
> >>
> >> The only concern, as the users are used to the auto-refresh, once we turn
> >> that off, they can start thinking the thing got stuck.
> >>
> >>
> >> In that case let's keep updating the talk progress without replacing the
> >> entire tab?
> >>
> >>
> >> -- Ivan
> >>
> >> On Wed, 6 Dec 2017 at 17:50, Ohad Levy  wrote:
> >>
> >>> On Wed, Dec 6, 2017 at 6:48 PM, Andrew Kofink 
> >>> wrote:
> >>>
>  As part of this I would love to see *all* auto reloads default to off
> >
> 
> >>> +1 - PR are welcomes ;)
> >>>
> >>>
>  Oh yeah, especially notifications. Why can't they just update when the
>  page updates?
> 
>  On Wed, Dec 6, 2017 at 11:27 AM, Walden Raines 
>  wrote:
> 
> > > I think the refresh should still be off by default.
> >
> > As part of this I would love to see *all* auto reloads default to
> > off.  The dashboard, for example, constantly reloading by default is
> > annoying to me.
> >
> > Cheers,
> > Walden
> >
> > On Wed, Dec 6, 2017 at 11:16 AM, Andrew Kofink 
> > wrote:
> >
> >> Hello,
> >>
> >> We have the option of toggling auto-refresh on individual tasks, but
> >> I often find myself at the foreman_tasks#tasks page intermittently 
> >> clicking
> >> the search button to monitor the state of automated tasks (in my case,
> >> usually bats content/proxy tests). I'm proposing a button or an option
> >> under the search drop down button to enable/disable auto refresh. I 
> >> think
> >> the refresh should still be off by default.
> >>
> >> Any comments?
> >>
> >> - Andrew
> >>
> >> --
> >> Andrew Kofink
> >> akof...@redhat.com
> >> IRC: akofink
> >> Software Engineer
> >> Red Hat Satellite
> >>
> >> --
> >> You received this message because you are subscribed to the Google
> >> Groups "foreman-dev" group.
> >> To unsubscribe from this group and stop receiving emails from it,
> >> send an email to foreman-dev+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> > an email to foreman-dev+unsubscr...@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> 
> 
> 
>  --
>  Andrew Kofink
>  akof...@redhat.com
>  IRC: akofink
>  Software Engineer
>  Red Hat Satellite
> 
>  --
>  You received this message because you are subscribed to the Google
>  Groups "foreman-dev" group.
>  To unsubscribe from this group and stop receiving emails from it, send
>  an email to foreman-dev+unsubscr...@googlegroups.com.
>  For more options, visit https://groups.google.com/d/optout.
> 
> >>> --
> >>> You received this message because you are subscribed to the Google
> >>> Groups "foreman-dev" group.
> >>> To unsubscribe from this group and stop receiving emails from it, send
> >>> an email to foreman-dev+unsubscr...@googlegroups.com.
> >>> For more options, visit https://groups.google.com/d/optout.
> >>>
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "foreman-dev" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an
> >> email to foreman-dev+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google

Re: Re: [foreman-dev] Nominating additional maintainers in foreman-core

[Daniel Lobato Garcia]

On 12/06, Ewoud Kohl van Wijngaarden wrote:
> On Wed, Dec 06, 2017 at 02:40:36PM +0200, Tomer Brisker wrote:
> > Shimon Shtein - has 75 merged commits [1] and has taken part in the reviews
> > of 64 merged commits[2].
>
> +1
+1
>
> > Michael Moll - has 71 merged commits [3] and has taken part in the reviews
> > of 130 merged commits[4]. He is also already a long time maintainer of
> > several of our other repos and has proven to be a responsible maintainer.
>
> +1
+1
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: [foreman-dev] Is it time to remove turbolinks?

[Daniel Lobato Garcia]

On 12/06, Walden Raines wrote:
> I am seeing more and more issues [1][2] around turbolinks and I'm wondering
> if it's time to remove it from foreman.  I have seen it recommended that
> one shouldn't use the back button in foreman; I thought that request was
> reserved for poorly written php sites that resubmit forms when the back
> button is pressed, we're better than that! :)

If someone suggests the back button shouldn't be used within foreman
because that breaks something - it's our fault. I recall some problems
in some pages like Products/Errata etc.. but haven't seen any in a whlie

The request is used by Basecamp, GitHub, and modern Ruby applications,
but honestly that's just an ad-hominem. (notice the blue bar when you click
on a link in GitHub)

>
> Are the benefits of turbolinks worth the cost?  Does anyone have any
> metrics on the difference in page load times with and without
> "turbo"links?

Do the test, it's considerably faster to use it, I'm happy to provide metrics.
In fact for cached pages it can easily be 100ms (/subnets, /settings, etc)

https://www.speedshop.co/2015/05/27/100-ms-to-glass-with-rails-and-turbolinks.html

In fact, there's room to make it faster (data-turbolinks-permanent)

>
> Any additional thoughts on its removal?

Unless there are serious blockers or anything that cannot be done with
Turbolinks that we need to do, I really oppose this. If you have another
alternative that's not pushState that makes Foreman faster and is as easy to
use, I'd be glad to hear it

>
> Cheers,
> Walden
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1522740
> [2] http://projects.theforeman.org/issues/21480
>
> --
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

--
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: [foreman-dev] 1.17 branching - status update 3

[Eric D Helms]

Thanks for the weekly updates!

Do you forsee 1.17 working as:

 1) Wait till the core codebase is updated to Rails 5.1 then branch and
notify plugins
 2) Branch soon at some stable point and backport the Rails 5.1 code changes


I believe also on the list of items is the update to fog 1.42 that has a
pending PR given the current version of Fog requires JSON < 2 and Ruby 2.4
comes with JSON 2+.

On Dec 7, 2017 7:02 AM, "Ondrej Prazak"  wrote:

> Hi,
> this is a quick summary of current 1.17 branching status. As before, feel
> free to correct/complete the information below.
>
> The new version of turbolinks-classic (2.5.4) was released about 12 hours
> ago, and we work on adding it to tfm-ror51 [1].
>
> Dynflowd deployment on Debian is almost ready to be merged [2].
>
> OAuth fix for Rails 5 [3] did not receive much attention from OAuth
> maintainers. We plan to package a forked version with included fix until
> new gem version compatible with Rails 5 is released.
>
> The plan is to move slowly forward with Rails 5.0 [4], then introduce
> incompatible changes to Rails 4.2 and move to 5.1
>
> O.
>
> [1] https://github.com/theforeman/tfm-ror51-packaging/pulls
> [2] https://github.com/theforeman/foreman-packaging/pull/1959
> [3] https://github.com/oauth-xx/oauth-ruby/pull/150
> [4] https://github.com/theforeman/foreman/pull/4867
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] Milestones added on GH for upcoming core releases

[Tomer Brisker]

Hello,

I've added milestones on GH for 1.16.1 and 1.17.0 releases to make it easy
to see which issues are blocking a certain release.
Maintainers - please update PRs if they need to be included in a certain
release.
​Perhaps we can also look​ into automating this to align release field on
redmine with milestone on github?

-- 
Have a nice day,
Tomer Brisker
Red Hat Engineering

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[foreman-dev] 1.17 branching - status update 3

[Ondrej Prazak]

Hi,
this is a quick summary of current 1.17 branching status. As before, feel
free to correct/complete the information below.

The new version of turbolinks-classic (2.5.4) was released about 12 hours
ago, and we work on adding it to tfm-ror51 [1].

Dynflowd deployment on Debian is almost ready to be merged [2].

OAuth fix for Rails 5 [3] did not receive much attention from OAuth
maintainers. We plan to package a forked version with included fix until
new gem version compatible with Rails 5 is released.

The plan is to move slowly forward with Rails 5.0 [4], then introduce
incompatible changes to Rails 4.2 and move to 5.1

O.

[1] https://github.com/theforeman/tfm-ror51-packaging/pulls
[2] https://github.com/theforeman/foreman-packaging/pull/1959
[3] https://github.com/oauth-xx/oauth-ruby/pull/150
[4] https://github.com/theforeman/foreman/pull/4867

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] The road to Rails 5.1

[Michael Moll]

Hi,

On Thu, Nov 30, 2017 at 11:52:24PM +0100, Michael Moll wrote:
> > Would someone with more knowledge on the code side of the Rails 5 mind
> > sending along an update of the path we see for getting to 5.1?
> 
> We're currently blocked by two external dependencies:
> - https://github.com/turbolinks/turbolinks-classic/pull/679 (already
>   merged, we're only waiting for the gem release)

The gem got released and pulled into Foreman, this is all good now.

> - https://github.com/oauth-xx/oauth-ruby/pull/150

Nothing happened here, yet. So I propose to go forward now as outlined
below and if we're on 5.1 and oauth still didn't move, we fork that gem.

> Once there are gem releases out, I'd open PRs to raise the lower version
> boundary of these in core and after these got in, I'd ask
> https://github.com/theforeman/foreman/pull/4867
> to get merged (BTW, Eric, please see the comment at the bottom).
> 
> At that state, core would be using Rails 5.0 only and I'd open one PR
> including the 5.0 only parts of
> https://github.com/theforeman/foreman/pull/4836
> 
> After that one got merged, core would be using Rails 5.0 and be
> incompatible with Rails 4.2.
> 
> Plugin authors should start updating their plugins to Rails 5.0
> standards at that point.
> 
> Then I'd open a PR with the switch from Rails 5.0 to 5.1 and
> https://github.com/theforeman/foreman/pull/5026
> 
> After that one got merged, core is using Rails 5.1 (and probably not
> even Rails 5.0 compatible) and the RPM work can start. DEBs should just
> work fine without modifications.
> 
> Plugin authors should check if anything is missing for Rails 5.1 and
> update, if needed.
> 
> After that, the remaining deprecation notices with Rails 5.1 should get
> fixed and once this is done, Rails 5.2 is probably already released.

Regards
-- 
Michael Moll

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Is it time to remove turbolinks?

[Ondrej Prazak]

+1 to the comments above, moving forward with React will allow us to drop
turbolinks at some point without a noticeable decrease in UI performance -
at least that is my hope.

On Wed, Dec 6, 2017 at 5:46 PM, Ohad Levy  wrote:

>
>
> On Wed, Dec 6, 2017 at 5:10 PM, Walden Raines  wrote:
>
>> I am seeing more and more issues [1][2] around turbolinks and I'm
>> wondering if it's time to remove it from foreman.  I have seen it
>> recommended that one shouldn't use the back button in foreman; I thought
>> that request was reserved for poorly written php sites that resubmit forms
>> when the back button is pressed, we're better than that! :)
>>
>> Are the benefits of turbolinks worth the cost?  Does anyone have any
>> metrics on the difference in page load times with and without
>> "turbo"links?
>>
>> Any additional thoughts on its removal?
>>
>>
> I welcome the proposal to remove turbolinks,  having said that, there are
> a few things that we must take into account.
>
> 1. we should not just remove turbo links and loose all functionaitly -
> this will greatly impact current ui performance.
> 2. we should come up with an alternative plan - which is a roadmap to a
> SPA or semi SPA which will render the usage cases of tubolinks today not
> required.
>
> IMHO - I would suggest we look into converting the vertical nav into a
> react component (some work already done at [1]), than using that as a base
> for a SPA, we should default to fetching content, either via api and using
> react to render it, or (which is the very common case) to let the server
> render html and replace a content div, this will mimic the current way
> turbolinks more or less works and will surely speed up the page load times.
>
> We would need to move things like session / login / permissions etc into
> the browser if we go that path
>
> Ohad
>
>
>
> [1] https://github.com/patternfly/patternfly-react/pull/88
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Be sure to import your product content data for Katello 3.6

[Eric D Helms]

On Dec 7, 2017 6:04 AM, "Ewoud Kohl van Wijngaarden" <
ew...@kohlvanwijngaarden.nl> wrote:

On Wed, Dec 06, 2017 at 07:07:05AM -0800, Jonathon Turel wrote:

> A change
>  c9ad563e1b14c4161207b3e>
>
> landed in Katello yesterday which introduced a new pattern of importing
> product content information from Candlepin into the Katello DB. This is in
> support of some new feature work and means that Candlepin will no longer be
> consulted for that information until it's time to be refreshed. All areas
> of Katello which use product content data are affected such as the Red Hat
> Repositories page and several APIs.
>
> In order to populate your local cache, please run `rake
> katello:upgrades:3.6:import_product_content`. From that point on the cache
> should be updated through ordinary use of Katello - importing manifests,
> etc. This step is not necessary unless you have a manifest imported and/or
> custom products created.
>
> I'm working on a change for the installer to do the same import and I'll
> update this thread once it's ready for review & test.
>
> Let me know if you have problems, questions, or concerns.
>

Perhaps this is unrelated and not even possible, but I'd like to know if we
could change database provisioning/seeding to not require candlepin.
Currently for the organization a matching org in candlepin is created.
That's a dependency that ideally shouldn't be there. Do you see this as an
option?


I think this is a separate discussion that should be split off.



-- 
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Be sure to import your product content data for Katello 3.6

[Ewoud Kohl van Wijngaarden]

On Wed, Dec 06, 2017 at 07:07:05AM -0800, Jonathon Turel wrote:

A change

landed in Katello yesterday which introduced a new pattern of importing
product content information from Candlepin into the Katello DB. This is in
support of some new feature work and means that Candlepin will no longer be
consulted for that information until it's time to be refreshed. All areas
of Katello which use product content data are affected such as the Red Hat
Repositories page and several APIs.

In order to populate your local cache, please run `rake
katello:upgrades:3.6:import_product_content`. From that point on the cache
should be updated through ordinary use of Katello - importing manifests,
etc. This step is not necessary unless you have a manifest imported and/or
custom products created.

I'm working on a change for the installer to do the same import and I'll
update this thread once it's ready for review & test.

Let me know if you have problems, questions, or concerns.


Perhaps this is unrelated and not even possible, but I'd like to know if 
we could change database provisioning/seeding to not require candlepin. 
Currently for the organization a matching org in candlepin is created. 
That's a dependency that ideally shouldn't be there. Do you see this as 
an option?


--
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Be sure to import your product content data for Katello 3.6

[Eric D Helms]

This sounds great! How long on average are you seeing the import take?

On Dec 6, 2017 10:07 AM, "Jonathon Turel"  wrote:

> Hi all,
>
> A change
> 
> landed in Katello yesterday which introduced a new pattern of importing
> product content information from Candlepin into the Katello DB. This is in
> support of some new feature work and means that Candlepin will no longer be
> consulted for that information until it's time to be refreshed. All areas
> of Katello which use product content data are affected such as the Red Hat
> Repositories page and several APIs.
>
> In order to populate your local cache, please run `rake
> katello:upgrades:3.6:import_product_content`. From that point on the
> cache should be updated through ordinary use of Katello - importing
> manifests, etc. This step is not necessary unless you have a manifest
> imported and/or custom products created.
>
> I'm working on a change for the installer to do the same import and I'll
> update this thread once it's ready for review & test.
>
> Let me know if you have problems, questions, or concerns.
>
> Thanks,
>
> Jonathon
>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

[Timo Goebel]

Yes, please. We can use all the help we can get and both Shimon and Michael are 
doing great work.
Thanks Tomer for bringing this up.

> On 7. Dec 2017, at 09:23, Ondrej Prazak  wrote:
> 
> +1 to both
> 
>> On Wed, Dec 6, 2017 at 5:19 PM, Ivan Necas  wrote:
>> +2
>> 
>> -- Ivan
>> 
>>> On Wed, 6 Dec 2017 at 16:51, Lukas Zapletal  wrote:
>>> +1 +1 beer time!
>>> 
>>> LZ
>>> 
>>> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker  wrote:
>>> > Hello,
>>> > As many of you may have noticed, foreman-core open PR count has been in 
>>> > the
>>> > area of 100-110 for most of the last few months. There are only a few 
>>> > people
>>> > with merge access that actively review PRs, so that the time it takes for
>>> > changes to be accepted can take long. I would like to propose granting 
>>> > merge
>>> > access to two more members of the community:
>>> >
>>> > Shimon Shtein - has 75 merged commits [1] and has taken part in the 
>>> > reviews
>>> > of 64 merged commits[2].
>>> > Michael Moll - has 71 merged commits [3] and has taken part in the reviews
>>> > of 130 merged commits[4]. He is also already a long time maintainer of
>>> > several of our other repos and has proven to be a responsible maintainer.
>>> >
>>> > Please send +1/-1 either to the list or to me in private if you prefer.
>>> > Per our process, unless I receive any objections within a week, I will
>>> > request one of the organization owners to grant them access.
>>> >
>>> > [1]
>>> > https://github.com/theforeman/foreman/pulls?q=is%3Apr+author%3Ashimshtein+is%3Aclosed
>>> > [2]
>>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
>>> > [3]
>>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Ammoll+is%3Aclosed+
>>> > [4]
>>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>>> >
>>> > --
>>> > Have a nice day,
>>> > Tomer Brisker
>>> > Red Hat Engineering
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google Groups
>>> > "foreman-dev" group.
>>> > To unsubscribe from this group and stop receiving emails from it, send an
>>> > email to foreman-dev+unsubscr...@googlegroups.com.
>>> > For more options, visit https://groups.google.com/d/optout.
>>> 
>>> 
>>> 
>>> --
>>> Later,
>>>   Lukas @lzap Zapletal
>>> 
>>> --
>>> You received this message because you are subscribed to the Google Groups 
>>> "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to foreman-dev+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [foreman-dev] Nominating additional maintainers in foreman-core

[Ondrej Prazak]

+1 to both

On Wed, Dec 6, 2017 at 5:19 PM, Ivan Necas  wrote:

> +2
>
> -- Ivan
>
> On Wed, 6 Dec 2017 at 16:51, Lukas Zapletal  wrote:
>
>> +1 +1 beer time!
>>
>> LZ
>>
>> On Wed, Dec 6, 2017 at 1:40 PM, Tomer Brisker 
>> wrote:
>> > Hello,
>> > As many of you may have noticed, foreman-core open PR count has been in
>> the
>> > area of 100-110 for most of the last few months. There are only a few
>> people
>> > with merge access that actively review PRs, so that the time it takes
>> for
>> > changes to be accepted can take long. I would like to propose granting
>> merge
>> > access to two more members of the community:
>> >
>> > Shimon Shtein - has 75 merged commits [1] and has taken part in the
>> reviews
>> > of 64 merged commits[2].
>> > Michael Moll - has 71 merged commits [3] and has taken part in the
>> reviews
>> > of 130 merged commits[4]. He is also already a long time maintainer of
>> > several of our other repos and has proven to be a responsible
>> maintainer.
>> >
>> > Please send +1/-1 either to the list or to me in private if you prefer.
>> > Per our process, unless I receive any objections within a week, I will
>> > request one of the organization owners to grant them access.
>> >
>> > [1]
>> > https://github.com/theforeman/foreman/pulls?q=is%3Apr+
>> author%3Ashimshtein+is%3Aclosed
>> > [2]
>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
>> q=is%3Apr+-author%3Ashimshtein+commenter%3Ashimshtein+is%3Aclosed+
>> > [3]
>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
>> q=is%3Apr+author%3Ammoll+is%3Aclosed+
>> > [4]
>> > https://github.com/theforeman/foreman/pulls?utf8=%E2%9C%93&;
>> q=is%3Apr+-author%3Ammoll+commenter%3Ammoll+is%3Aclosed+
>> >
>> > --
>> > Have a nice day,
>> > Tomer Brisker
>> > Red Hat Engineering
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> Groups
>> > "foreman-dev" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> an
>> > email to foreman-dev+unsubscr...@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>>
>>
>> --
>> Later,
>>   Lukas @lzap Zapletal
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> You received this message because you are subscribed to the Google Groups
> "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to foreman-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to foreman-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.