[Differential] D12457: Complete INADDR_HASH lock protection
mav added inline comments. INLINE COMMENTS > if_stf.c:383 > break; > + IN_IFADDR_RUNLOCK(_ifa_tracker); > if (ia4 == NULL) Wouldn't it be better to use in_localip() here instead of code duplication? Or I miss something? > in_mcast.c:1383 > + IN_IFADDR_RUNLOCK(_ifa_tracker); > + } > if (sopt->sopt_name == IP_BLOCK_SOURCE) Do I miss some other protection means or this and few below places just scream about possible races due to missing interface pointer pulled out of the lock without taking reference? I suspect INADDR_TO_IFP KPI is not safe now in general. > ip_input.c:697 > } > - /* IN_IFADDR_RUNLOCK(); */ > + IN_IFADDR_RUNLOCK(_ifa_tracker); > Looking on r194951 commit message and later r286001 commit this should be uncommented now, but comments from active networking people are welcome. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D12457 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: eugen_grosbein.net, ae, avg, mav, rwatson Cc: imp, freebsd-net-list ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE
mav accepted this revision. mav added a reviewer: mav. mav added a comment. This revision has a positive review. It's been years since I worked on this, but I see no problems from this. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, adrian, #network, julian, mav Cc: mav, poolroom_gmail.com, mandree, imp, freebsd-net-list ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
Re: kern/182212: [patch] [ng_mppc] ng_mppc(4) blocks on network errors unconditionaly
Synopsis: [patch] [ng_mppc] ng_mppc(4) blocks on network errors unconditionaly State-Changed-From-To: open-patched State-Changed-By: mav State-Changed-When: Thu May 22 07:27:24 UTC 2014 State-Changed-Why: Patch committed to HEAD. http://www.freebsd.org/cgi/query-pr.cgi?pr=182212 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: sparc64/118932: [panic] 7.0-BETA4/sparc-64 kernel panic in rip_output
Synopsis: [panic] 7.0-BETA4/sparc-64 kernel panic in rip_output State-Changed-From-To: open-patched State-Changed-By: mav State-Changed-When: Thu Apr 1 15:13:56 UTC 2010 State-Changed-Why: Set of patches committed to HEAD. Responsible-Changed-From-To: freebsd-net-mav Responsible-Changed-By: mav Responsible-Changed-When: Thu Apr 1 15:13:56 UTC 2010 Responsible-Changed-Why: I'll track it. http://www.freebsd.org/cgi/query-pr.cgi?pr=118932 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/132984: [netgraph] swi1: net 100% cpu usage
Synopsis: [netgraph] swi1: net 100% cpu usage State-Changed-From-To: open-closed State-Changed-By: mav State-Changed-When: Tue Jul 14 07:23:12 UTC 2009 State-Changed-Why: This is probably duplicate of solved kern/134557. Fix committed to 8-CURRENT and merged to 7-STABLE on 2009-07-04. http://www.freebsd.org/cgi/query-pr.cgi?pr=132984 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134557: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem
Synopsis: [netgraph] [hang] 7.2 with mpd5.3 hanging up - ng_pptp problem State-Changed-From-To: open-closed State-Changed-By: mav State-Changed-When: Sat Jul 4 06:01:31 UTC 2009 State-Changed-Why: Patch committed and merged to 7-SATBLE. http://www.freebsd.org/cgi/query-pr.cgi?pr=134557 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134220: [ng_netflow] [patch]: incorrect comparison in ng_netflow_rcvmsg()
Synopsis: [ng_netflow] [patch]: incorrect comparison in ng_netflow_rcvmsg() State-Changed-From-To: patched-closed State-Changed-By: mav State-Changed-When: Wed May 20 02:56:31 UTC 2009 State-Changed-Why: Patch merged to 7-STABLE. http://www.freebsd.org/cgi/query-pr.cgi?pr=134220 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/134220: [ng_netflow] [patch]: incorrect comparison in ng_netflow_rcvmsg()
Synopsis: [ng_netflow] [patch]: incorrect comparison in ng_netflow_rcvmsg() State-Changed-From-To: open-patched State-Changed-By: mav State-Changed-When: Wed May 13 02:27:03 UTC 2009 State-Changed-Why: Patch committed to 8-CURRENT. http://www.freebsd.org/cgi/query-pr.cgi?pr=134220 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/123200: [netgraph] Server failure due to netgraph mpd and dhcpclient
Synopsis: [netgraph] Server failure due to netgraph mpd and dhcpclient State-Changed-From-To: feedback-closed State-Changed-By: mav State-Changed-When: Sat Jan 31 13:52:36 UTC 2009 State-Changed-Why: Patches fixing crashes/freezes on VPN routing loop were merged to 7-STABLE. http://www.freebsd.org/cgi/query-pr.cgi?pr=123200 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
Re: kern/123741: [netgraph] [panic] kernel panic due to netgraph mpd
Synopsis: [netgraph] [panic] kernel panic due to netgraph mpd State-Changed-From-To: patched-closed State-Changed-By: mav State-Changed-When: Sun Jun 22 22:26:06 UTC 2008 State-Changed-Why: Patches merged, no more feedback received. http://www.freebsd.org/cgi/query-pr.cgi?pr=123741 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: kern/123741: [netgraph] [panic] kernel panic due to netgraph mpd
Synopsis: [netgraph] [panic] kernel panic due to netgraph mpd State-Changed-From-To: open-patched State-Changed-By: mav State-Changed-When: Sat May 17 09:44:34 UTC 2008 State-Changed-Why: Problem should be fixed with recent commits. http://www.freebsd.org/cgi/query-pr.cgi?pr=123741 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: kern/119839: [ng_netflow] ng_netflow can consume large sums of memory if export hook isn't connected
Synopsis: [ng_netflow] ng_netflow can consume large sums of memory if export hook isn't connected State-Changed-From-To: open-closed State-Changed-By: mav State-Changed-When: Sun Jan 27 15:02:12 UTC 2008 State-Changed-Why: Fixed in HEAD. Expire does not depends on export hook any more. It allows node to be used with flowctl, but without export. http://www.freebsd.org/cgi/query-pr.cgi?pr=119839 ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to [EMAIL PROTECTED]
