Re: Remove ftime() interceptor defs from compiler-rt/FreeBSD

2020-11-21 Thread Warner Losh
On Sat, Nov 21, 2020, 9:26 PM Kyle Evans  wrote:

> Hi,
>
> Can we remove the ftime() interceptor definitions that are FreeBSD
> specific in compiler-rt? See:
> https://people.freebsd.org/~kevans/intercept.diff -- the very act of
> including sys/timeb.h adds build noise from the warning about it being
> deprecated, when ftime() is apparently not even intercepted on
> FreeBSD:
>
> #define SANITIZER_INTERCEPT_FTIME \
>   (!SI_FREEBSD && !SI_NETBSD && !SI_OPENBSD && SI_POSIX)
>

Seems legit. Time is marked legacy in xopen. It was only a thing on V7.
BSD4 added the replacement gettimeofday(). I'm not seeing any reason to not
do this, but I've not looked into this in depth... This hasn't been an
important function in a long time.

Warner

Thanks,
>
> Kyle Evans
> ___
> freebsd-toolchain@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
> To unsubscribe, send any mail to "
> freebsd-toolchain-unsubscr...@freebsd.org"
>
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"


Remove ftime() interceptor defs from compiler-rt/FreeBSD

2020-11-21 Thread Kyle Evans
Hi,

Can we remove the ftime() interceptor definitions that are FreeBSD
specific in compiler-rt? See:
https://people.freebsd.org/~kevans/intercept.diff -- the very act of
including sys/timeb.h adds build noise from the warning about it being
deprecated, when ftime() is apparently not even intercepted on
FreeBSD:

#define SANITIZER_INTERCEPT_FTIME \
  (!SI_FREEBSD && !SI_NETBSD && !SI_OPENBSD && SI_POSIX)

Thanks,

Kyle Evans
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"