[Freeciv-Dev] [bug #20462] Illegal requirement types considered None and not an error

2013-02-01 Thread Marko Lindqvist
Update of bug #20462 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20462

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3633] check_native_area()

2013-02-01 Thread Marko Lindqvist
Update of patch #3633 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3633

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3623] Nationality requirement

2013-02-01 Thread Marko Lindqvist
Update of patch #3623 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3623

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19160] in player_load_units_transporter() [savegame.c::2285]: assertion 'id_trans == -1 || ptrans != ((void *)0)' failed

2013-02-01 Thread pepeto
Follow-up Comment #4, bug #19160 (project freeciv):

The problem is with allied players, as jacob said. But, units are really all
loaded before loading the transported_by field. The problem is that in
savegame.c, the code assume the cargo is transported by a unit of the same
player. savegame2.c is ok. Patch attached.


(file #17090)
___

Additional Item Attachment:

File name: load_savegame_transporter.diff Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?19160

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20460] One cannot upgrade unit (s)he is not able to build him/herself

2013-02-01 Thread Marko Lindqvist
Update of bug #20460 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20460

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3646] Free specialist helptext

2013-02-01 Thread pepeto
URL:
  http://gna.org/patch/?3646

 Summary: Free specialist helptext
 Project: Freeciv
Submitted by: pepeto
Submitted on: ven. 01 févr. 2013 16:19:56 CET
Category: general
Priority: 3 - Low
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

From valgrind server output :

==25386== 281 bytes in 3 blocks are still reachable in loss record 1,452 of
1,525
==25386==at 0x402BE68: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==25386==by 0x825B2C0: fc_real_malloc (mem.c:84)
==25386==by 0x825B429: real_fc_strdup (mem.c:141)
==25386==by 0x826827A: string_duplicate (string_vector.c:50)
==25386==by 0x82687B5: strvec_set (string_vector.c:309)
==25386==by 0x8268815: strvec_store (string_vector.c:122)
==25386==by 0x80E4887: lookup_strvec (ruleset.c:738)
==25386==by 0x80EE47C: load_ruleset_cities (ruleset.c:3059)
==25386==by 0x80EF594: load_rulesets (ruleset.c:4228)
==25386==by 0x8076654: srv_prepare (srv_main.c:2424)
==25386==by 0x411E4D2: (below main) (libc-start.c:226)


From valgrind client output :

==25427== 281 bytes in 3 blocks are still reachable in loss record 8,302 of
10,308
==25427==at 0x402BE68: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==25427==by 0x82331C0: fc_real_malloc (mem.c:84)
==25427==by 0x823FF32: strvec_from_str (string_vector.c:143)
==25427==by 0x80E0054: handle_ruleset_specialist (packhand.c:3270)
==25427==by 0x80E134F: client_handle_packet (packhand_gen.c:272)
==25427==by 0x80AE834: client_packet_input (client_main.c:654)
==25427==by 0x80B593F: input_from_server (clinet.c:421)
==25427==by 0x807FC96: get_net_input (gui_main.c:1882)
==25427==by 0x46EB17D: g_io_unix_dispatch (giounix.c:166)
==25427==by 0x46AAD85: g_main_context_dispatch (gmain.c:2539)
==25427==by 0x46AB124: g_main_context_iterate.isra.21 (gmain.c:3146)
==25427==by 0x46AB56A: g_main_loop_run (gmain.c:3340)


Fix attached...




___

File Attachments:


---
Date: ven. 01 févr. 2013 16:19:56 CET  Name: specialist_helptext_free.diff 
Size: 518 o   By: pepeto

http://gna.org/patch/download.php?file_id=17091

___

Reply to this item at:

  http://gna.org/patch/?3646

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3632] Minimum readline version 4.3

2013-02-01 Thread Marko Lindqvist
Update of patch #3632 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3632

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3645] Modpack notes

2013-02-01 Thread Marko Lindqvist
Follow-up Comment #1, patch #3645 (project freeciv):

- As we are changing modlist capstr, let's make its form similar to other
capstrs

(file #17092)
___

Additional Item Attachment:

File name: ModpackNotes-2.patch   Size:5 KB


___

Reply to this item at:

  http://gna.org/patch/?3645

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20472] [River|Road] move_mode Relaxed assumes river/road on adjacent tile

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20472

 Summary: [River|Road] move_mode Relaxed assumes river/road
on adjacent tile
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 01 Feb 2013 06:12:04 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Noticed while porting river_move_mode as road.move_mode in patch #3637:

Relaxed mode let's one to easily move diagonally from river tile to river
tile, but with double move cost as if two cardinal moves were made. This
checks river from original and target tiles only. It's possible that there's
no connection between the two but they are two separate rivers, either their
starting points or turning away from each other. If the tile through which
unit is considered to move has no river, applying cost based on river cost
does not make sense.

patch #3637 makes road move_mode implementation identical to river_move_mode,
so similar bug makes it to road.move_mode too.




___

Reply to this item at:

  http://gna.org/bugs/?20472

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20003] Security advisory

2013-02-01 Thread pepeto
Follow-up Comment #21, bug #20003 (project freeciv):

 Well, third one is what I've planned to do for a long time*:
 give dio_get_xxx() functions return values telling if they
 succeeded or failed. Patch attached.

 *) According to very old TODO I had actually foreseen
 possibility of infinite loop somewhere when I first came across
 the dio_get_xxx() functions and noticed their lack of return
 value.

 Any volunteers to do throughout checking of all dio_get_xxx()
 callers in case there's other places where return values (added
 by this patch) should be checked.

When working on porting this patch to warclient, numerous questions came to
me. I had also noticed something wrong in those functions, including the case
of infinite loops and wrong data for a very long time.

What value returns the dio_get_xxx() ? According to your comment, I understand
that these functions returns TRUE if the value is read and valid. However, the
code doesn't match this (for example can dio_get_uint8() returns TRUE even if
there was no more byte, functions like dio_get_bit_string() look strange).

I guess that all receive_packet_xxx() functions should also test the results
of the dio_get_xxx() ones.

Also, shouldn't the server of the client cut the connection of a such packet ?
It clearly doesn't match the protocol, so it is not a compatible connection.

___

Reply to this item at:

  http://gna.org/bugs/?20003

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1574] add a player to a running game

2013-02-01 Thread Helen
Follow-up Comment #20, patch #1574 (project freeciv):

Yes; At the moment I get the list of tried tiles and from time to time the
message 'unit / city to close'. Perhaps the reason why another try is needed
should also be printed for the other tiles.

Should the number of tries limited to some maximal value? Late in the game
cities could be nearly everythere.
http://dsfasdfdsf.com


___

Reply to this item at:

  http://gna.org/patch/?1574

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3620] Governor (cma) branch pruning heuristic fix

2013-02-01 Thread Marko Lindqvist
Update of patch #3620 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = cazfi  
 Planned Release: = 2.4.0, 2.5.0   


___

Reply to this item at:

  http://gna.org/patch/?3620

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3636] Unit nationality mentioned in unit descriptions

2013-02-01 Thread Marko Lindqvist
Update of patch #3636 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3636

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] Culture

2013-02-01 Thread Marko Lindqvist
On 29 January 2013 03:01, Marko Lindqvist cazf...@gmail.com wrote:
 On 29 January 2013 02:50, Jacob Nevins
 0jacobnk.fc...@chiark.greenend.org.uk wrote:

 Back to culture: we've got the nationality feature that doesn't do a
 lot at the moment. I found this idea somewhat reminiscent of CivIV
 culture.

  I consider the two concepts separate, though in real life a lot of
 culture (or all, for certain meaning of the word) is specific to
 nationality. For the interaction of the two concepts, I've considered
 making multicultural cities to produce more culture than those with
 only one nationality.
  Anyway, for the schedule question, I have now decided to work on some
 nationality patches first so we get it a bit improved to 2.5.

 Patch #3628 adds new happiness step for nationality related happiness
modifications. Now i wonder if culture related happiness modifications
should be included in this same step, or should they apply like
current luxury or temple/cathedral effects. This should be decided
more on game balance point of view than realism view, I think. If they
go to same step as nationality modifications I wonder what to call
that nationality+culture step? Not that our step names would be
completely accurate otherwise (named like Buildings when there's no
telling if the effects are provided by buildings, tech, government, or
terrain city is on)


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3634] README.ruleset_experimental cleanup

2013-02-01 Thread Marko Lindqvist
Update of patch #3634 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3634

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3637] Road move mode

2013-02-01 Thread Marko Lindqvist
Update of patch #3637 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?3637

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3647] Generate river as road type

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3647

 Summary: Generate river as road type
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 02:34:15 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add road type flag GeneratedRiver. Currently at max one road type can have
this flag. If there is road type with that flag in the ruleset, mapgenerator
creates that road type instead of rivers as specials.

As some necessary functionality is still missing from such road type rivers,
this flag is left undocumented for now.



___

File Attachments:


---
Date: Sat 02 Feb 2013 02:34:15 AM EET  Name: GenRoadRiver.patch  Size: 15kB  
By: cazfi

http://gna.org/patch/download.php?file_id=17093

___

Reply to this item at:

  http://gna.org/patch/?3647

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3648] Roadstyle as specenum

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3648

 Summary: Roadstyle as specenum
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 03:19:15 AM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Make roadstyle specenum. This avoids magic '0', '1', and '2' values in code,
and more importantly in tileset format.

I've not included tilespec capstr bump to this patch to avoid noise, but it
should take place when this is committed.



___

File Attachments:


---
Date: Sat 02 Feb 2013 03:19:15 AM EET  Name: RoadstyleSpecenum.patch  Size:
13kB   By: cazfi

http://gna.org/patch/download.php?file_id=17094

___

Reply to this item at:

  http://gna.org/patch/?3648

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3649] Add latest links to tileset update HowTos

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3649

 Summary: Add latest links to tileset update HowTos
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 03:38:48 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0, 2.5.0

___

Details:

README.tilesets has links to tileset update HowTos. Latest link there is one
for updating from 2.2 to 2.3. Add new links.



___

File Attachments:


---
Date: Sat 02 Feb 2013 03:38:49 AM EET  Name: TilesetDocLink.patch  Size: 624B 
 By: cazfi

http://gna.org/patch/download.php?file_id=17095
---
Date: Sat 02 Feb 2013 03:38:49 AM EET  Name: TilesetDocLink-S2_4.patch  Size:
552B   By: cazfi

http://gna.org/patch/download.php?file_id=17096

___

Reply to this item at:

  http://gna.org/patch/?3649

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3650] Ruleset update HowTo links

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3650

 Summary: Ruleset update HowTo links
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 03:44:09 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.0, 2.5.0

___

Details:

README.rulesets claim to have links to all ruleset update links from 2.2 to
current version. S2_4 has only the 2.2 to 2.3 link, TRUNK only 2.4 to 2.5
link. Add the missing links.



___

File Attachments:


---
Date: Sat 02 Feb 2013 03:44:09 AM EET  Name: RulesetDocLink.patch  Size: 476B 
 By: cazfi

http://gna.org/patch/download.php?file_id=17097
---
Date: Sat 02 Feb 2013 03:44:09 AM EET  Name: RulesetDocLink-S2_4.patch  Size:
482B   By: cazfi

http://gna.org/patch/download.php?file_id=17098

___

Reply to this item at:

  http://gna.org/patch/?3650

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3651] Setting TRUNK for 2.6 development

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3651

 Summary: Setting TRUNK for 2.6 development
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 03:56:40 AM EET
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This patch is meant to be committed to TRUNK immediately after S2_5 has been
branched.
This is based on equivalent patch committed when 2.5 development started. I've
found a couple of places needing updating that we missed in the original 2.5
commit, so I've created first version of this patch already so those are not
forgotten. Branching of S2_5 is still months away.



___

File Attachments:


---
Date: Sat 02 Feb 2013 03:56:40 AM EET  Name: 2.6Trunk.patch  Size: 8kB   By:
cazfi

http://gna.org/patch/download.php?file_id=17099

___

Reply to this item at:

  http://gna.org/patch/?3651

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3652] First commit to S2_5

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3652

 Summary: First commit to S2_5
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 04:06:30 AM EET
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

This patch is meant to be committed as first commit to S2_5 once it's
branched.

It sets datasubdir from dev (used in TRUNK) to test (used in stable branch
until datafile format freeze), so that datafiles for both S2_5 and TRUNK do
not end to same directory when they may have different format.
Also change version label to alpha



___

File Attachments:


---
Date: Sat 02 Feb 2013 04:06:30 AM EET  Name: S2_5Alpha.patch  Size: 584B   By:
cazfi

http://gna.org/patch/download.php?file_id=17100

___

Reply to this item at:

  http://gna.org/patch/?3652

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3653] README.ruleset_alien list of changes since cazfi.net doc version

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3653

 Summary: README.ruleset_alien list of changes since cazfi.net
doc version
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 04:59:31 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

List all changes made to alien ruleset since it was added to freeciv version
control (since last version documented in cazfi.net) in README.ruleset_alien.

This patch applies on top of patch #36338 which provides first entry to the
changes list. Otherwise the list reflects freeciv revision 22260.



___

File Attachments:


---
Date: Sat 02 Feb 2013 04:59:31 AM EET  Name: RMAlienChanges.patch  Size: 1kB  
By: cazfi

http://gna.org/patch/download.php?file_id=17101

___

Reply to this item at:

  http://gna.org/patch/?3653

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3654] Alien KillCitizen adjustments

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3654

 Summary: Alien KillCitizen adjustments
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 05:06:25 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

Add KillCitizen flag for Amphibious and Antigravity units, remove it from
Burrowing units in alien ruleset.



___

File Attachments:


---
Date: Sat 02 Feb 2013 05:06:25 AM EET  Name: AlienKillCitizen.patch  Size: 1kB
  By: cazfi

http://gna.org/patch/download.php?file_id=17102

___

Reply to this item at:

  http://gna.org/patch/?3654

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20474] Help shows build time 0 for bases/roads with terrain dependant build time

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20474

 Summary: Help shows build time 0 for bases/roads with terrain
dependant build time
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 05:21:31 AM EET
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

Road/Base help shows build time as 0 MP if extras in question has not fixed
build time but terrain specific one.

Attached patch makes it to say Terrain specific instead.



___

File Attachments:


---
Date: Sat 02 Feb 2013 05:21:31 AM EET  Name: TerrainExtrasBuiltTimeHelp.patch 
Size: 2kB   By: cazfi

http://gna.org/bugs/download.php?file_id=17103

___

Reply to this item at:

  http://gna.org/bugs/?20474

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20475] User terrain flag names not known client side

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?20475

 Summary: User terrain flag names not known client side
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 05:34:44 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

Alien ruleset help for Tunnel says:
Requires TER_USER_1 terrain flag on the tile.

User (ruleset author) defined terrain flags are not sent to client side.




___

Reply to this item at:

  http://gna.org/bugs/?20475

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20475] User terrain flag names not known client side

2013-02-01 Thread Marko Lindqvist
Update of bug #20475 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Attached patch makes user terrain flags similar to user unit type flags.

- user_flag structure common to both types of user flags introduced along with
initialization and deinitialization functions
- User terrain flags are defined in ruleset in similar structure as user unit
type flags. This includes the fact that there's now helptext associated with
flags
- User terrain flags are sent to client side
- Terrain help displays user flag helptext when terrain has the flag

(file #17104)
___

Additional Item Attachment:

File name: UserFlags.patchSize:16 KB


___

Reply to this item at:

  http://gna.org/bugs/?20475

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3655] No max rates for Cheating AI in experimental ruleset

2013-02-01 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?3655

 Summary: No max rates for Cheating AI in experimental ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 02 Feb 2013 07:18:42 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

When hardcoded property of Cheating AI that it has no Max rates was replaced
by effect in default/ai_effects.ruleset experimental ruleset's version was
forgotten. This patch adds effect there too.



___

File Attachments:


---
Date: Sat 02 Feb 2013 07:18:42 AM EET  Name: ExperimentalCheatingRates.patch 
Size: 595B   By: cazfi

http://gna.org/patch/download.php?file_id=17105

___

Reply to this item at:

  http://gna.org/patch/?3655

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3401] Update README.ruleset_experimental for S2_5 changes

2013-02-01 Thread Marko Lindqvist
Follow-up Comment #3, patch #3401 (project freeciv):

 patch #3295: maglev, road/railroad movement cost change

I checked all the changes to experimental ruleset up to current revision
22260, and there was only one minor difference to classic ruleset introduced
in addition to that. There's more disaster types defined to classic ruleset
than to experimental.

Patch attached

(file #17106)
___

Additional Item Attachment:

File name: ExpRMUp.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?3401

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev