[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Matthias Pfafferodt]

URL:
  

 Summary: [1/4] Setting to disable border info in fog of war.
 Project: Freeciv
Submitted by: syntron
Submitted on: Mittwoch 26.08.2009 um 18:00
Category: general
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: None

___

Details:

Setting to disable border info in fog of war.

- Server setting 'foggedborders' controls whether
  changes in tile ownership (i.e. borders) are
  sent to clients who only know a tile but do not
  see it.
- Default value 0 preserves existing behavior.

Patch by: Madeline Book  for longturn
Adapted to mainline by: Matthias Pfafferodt 



___

File Attachments:


---
Date: Mittwoch 26.08.2009 um 18:00  Name:
0001-Setting-to-disable-border-info-in-fog-of-war.patch  Size: 7kB   By:
syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Matthias Pfafferodt]

Follow-up Comment #1, patch #1258 (project freeciv):

this patch series includes changes to the network packets ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Marko Lindqvist]

Update of patch #1258 (project freeciv):

 Planned Release:None => 2.3.0  

___

Follow-up Comment #2:

We had fogged borders (by me) for short time in the past. It was reverted as
unacceptable behavior.

But in that implementation it was not optional feature. Maybe this patch
series is acceptable as it adds fogged borders only as option?


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Marko Lindqvist]

Follow-up Comment #3, patch #1258 (project freeciv):

Why is this divided into 4 patches? It seems to me that patches 2 & 3 fix
serious bugs in patch 1, so patch 1 cannot be committed without them. Patch 4
is even more curious. Why does patch 1 set foggedborders setting SSET_RULES if
you already know that correct value is SSET_RULES_FLEXIBLE?

I do prefer small patches that do just one logical step. However, this is not
meant to introduce bugs. One logical step contains everything that is required
to make that step itself bugfree.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Matthias Pfafferodt]

Follow-up Comment #4, patch #1258 (project freeciv):

updated patch; changes

* all 4 patches within one patch
* bugfix within map_fog_tile() (saved the owner, if a unit move revales
ownership and it is fogged again within the same turn)

(file #6602)
___

Additional Item Attachment:

File name: 0001-Setting-to-disable-border-info-in-fog-of-war.diff Size:11 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Marko Lindqvist]

Follow-up Comment #5, patch #1258 (project freeciv):

I want to have final 2.2 borders system fully implemented before going
forward with this patch series. I don't want to implement 2.2 borders on top
of two different versions; trunk with fogged borders and S2_2 without.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Matthias Pfafferodt]

Follow-up Comment #6, patch #1258 (project freeciv):

no problem; working to find the reason for the bug mentioned in comment #4 I
did look into the border code - I would need some time to understand it ...

for fogged borders only one patch is left; the others can be closed

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[pepeto]

Update of patch #1258 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[pepeto]

Follow-up Comment #7, patch #1258 (project freeciv):

Fix that patch.  Notably:
* Setting class is SSET_RULES to be sure it won't be modified after the game
starts (could have random issues).
* Removed the setting from the packet_game_info because it is not used at all
by the client.
* Set default behaviour as setting default.


(file #6907)
___

Additional Item Attachment:

File name: trunk_S2_2_foggedborders.diff  Size:9 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[pepeto]

Update of patch #1258 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #8:

> I want to have final 2.2 borders system fully implemented before
> going forward with this patch series. I don't want to implement
> 2.2 borders on top of two different versions; trunk with fogged
> borders and S2_2 without.

It should be very safe to have this in 2.2.  It doesn't change the way how
borders are calculated, just how they are notified.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[Matthias Pfafferodt]

Follow-up Comment #9, patch #1258 (project freeciv):

> Set default behaviour as setting default.

Activating this as default is reasonable but a change of the known behavior
...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[pepeto]

Follow-up Comment #10, patch #1258 (project freeciv):

>> Set default behaviour as setting default.
>
>
> Activating this as default is reasonable but a change of the
> known behavior ...

I totally messed up, I inverted the setting according to the help text.  New
patch attached.

(file #6911)
___

Additional Item Attachment:

File name: trunk_S2_2_foggedborders2.diff Size:9 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1258] [1/4] Setting to disable border info in fog of war.

[pepeto]

Update of patch #1258 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev