Re: [Freedos-kernel] kernel sources - peer review

2004-07-06 Thread tom ehlert
Hello Bernd,

 be prepared to defend yourself against Tom's and Lucho's comments. I
 believe it's called peer review.

in theory - yes.

in praxis - here are the reasons why
   you won't see a peer review by me
   I started a new branch of the kernel,
   I'll not use any arkady kernel for production

it's simply that to much has changed; far beond the necesary amount.

example:
  config.b :
removed all comments,
  build.bat
   changed MSCL8 to MSC
   changed TC2 to TC
   changed comments :- to ::
   etc.
  etc...

not only that it was MSCL8 for some reason (because it's the MSC V8
compiler), this also makes MANY changes without any useful purpose.

but when reviewing changes, I'd have to review ALL changes and see
if there any new bugs introduced, and thats simply impossible due to
the sheer amount.

there are people, that can add significant to a project, but change
only relevant parts, and leave the rest intact (cheers to michael);
other's are simple unable to do so even if told 100 times.

I'll run my own kernel, as I simply trust it more; I've put
enough time to make it as stable as it is now. Should it
break, it's my fault, noone else to blame; betting on a russian
horse is too risky for me.

tom




---
This SF.Net email sponsored by Black Hat Briefings  Training.
Attend Black Hat Briefings  Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
___
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel


Re: [Freedos-kernel] kernel sources - peer review

2004-07-06 Thread tom ehlert
Hello Arkady,

just an example why I will NOT peer review anything:

just comparing old and new FLOPPY.ASM:

about every 2'nd line has changed - with no useful purpose.
sometimes - if nothing else was changed - 2 lines were simply
switched. empty lines inserted or removed. trivial comment
changes. ...

just to find out if you did something useful or harmful
would require significant work.

tom




---
This SF.Net email sponsored by Black Hat Briefings  Training.
Attend Black Hat Briefings  Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
___
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel