Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-10 Thread David O'Brien

Rob Crittenden wrote:

David O'Brien wrote:

Adam Young wrote:

On 10/06/2010 09:07 PM, David O'Brien wrote:

Rob Crittenden wrote:

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob

No more complaints from me.
(I'm purposely not using "nack" or "ack" because I don't write man
pages, and haven't tried to apply this patch. I'm just checking a bit
of English.)


David, it is certainly OK for you to ACK/NACK somthing like this.
We'll know if it "Breaks the build" pretty quickly, so we're not
worried about computer language syntax errors, just natural language
syntax errors.



ok, thanks for that. Will bear that in mind for similar patches in the
future.



So is that an ack? ;-)

rob

Pedant  :P

ACK


--

David O'Brien
Red Hat APAC Pty Ltd

"We couldn't care less about comfort. We make you feel good."
Federico Minoli CEO Ducati Motor S.p.A.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-08 Thread Rob Crittenden

David O'Brien wrote:

Adam Young wrote:

On 10/06/2010 09:07 PM, David O'Brien wrote:

Rob Crittenden wrote:

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob

No more complaints from me.
(I'm purposely not using "nack" or "ack" because I don't write man
pages, and haven't tried to apply this patch. I'm just checking a bit
of English.)


David, it is certainly OK for you to ACK/NACK somthing like this.
We'll know if it "Breaks the build" pretty quickly, so we're not
worried about computer language syntax errors, just natural language
syntax errors.



ok, thanks for that. Will bear that in mind for similar patches in the
future.



So is that an ack? ;-)

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-07 Thread David O'Brien

Adam Young wrote:

On 10/06/2010 09:07 PM, David O'Brien wrote:

Rob Crittenden wrote:

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob

No more complaints from me.
(I'm purposely not using "nack" or "ack" because I don't write man 
pages, and haven't tried to apply this patch. I'm just checking a bit 
of English.)


David,  it is certainly OK for you to ACK/NACK somthing like this.  
We'll know if it "Breaks the build" pretty quickly, so we're not worried 
about computer language syntax errors, just natural language syntax errors.




ok, thanks for that. Will bear that in mind for similar patches in the 
future.


--

David

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-07 Thread Adam Young

On 10/06/2010 09:07 PM, David O'Brien wrote:

Rob Crittenden wrote:

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob

No more complaints from me.
(I'm purposely not using "nack" or "ack" because I don't write man 
pages, and haven't tried to apply this patch. I'm just checking a bit 
of English.)


David,  it is certainly OK for you to ACK/NACK somthing like this.  
We'll know if it "Breaks the build" pretty quickly, so we're not worried 
about computer language syntax errors, just natural language syntax errors.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel



Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-06 Thread David O'Brien

Rob Crittenden wrote:

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob

No more complaints from me.
(I'm purposely not using "nack" or "ack" because I don't write man 
pages, and haven't tried to apply this patch. I'm just checking a bit of 
English.)


--

David O'Brien
Red Hat APAC Pty Ltd

"We couldn't care less about comfort. We make you feel good."
Federico Minoli CEO Ducati Motor S.p.A.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-06 Thread Rob Crittenden

David O'Brien wrote:

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob



Can you be consistent with "Kerberos" instead of adding "kerberos" to
the mix as well (unless necessary, of course)?

If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include
"...password to use when not..."

cheers


Updated patch attached.

rob


freeipa-559-2-man.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 559 update ipa-getkeytab man page

2010-10-05 Thread David O'Brien

Rob Crittenden wrote:

Add some missing options to the ipa-getkeytab man page.

rob


Can you be consistent with "Kerberos" instead of adding "kerberos" to 
the mix as well (unless necessary, of course)?


If my understanding is correct, I'd update the following:
"The LDAP password when not binding with Kerberos." to include 
"...password to use when not..."


cheers
--

David O'Brien
Red Hat APAC Pty Ltd

"We couldn't care less about comfort. We make you feel good."
Federico Minoli CEO Ducati Motor S.p.A.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel