[Ganglia-developers] Click-to-enlarge patch
This is a re-post of a patch I sent back in December (originally based on someone else's code). This patch changes the default template so that clicking on the 4 canned reports in the cluster_view will link to a larger version of that image. This behavior already exists in found in the 3.0.x releases, but is missing from the SVN trunk. -- Jesse Becker GPG Fingerprint -- BD00 7AA4 4483 AFCC 82D0 2720 0083 0931 9A2B 06A2 click-to-embiggen.patch Description: Binary data - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Click-to-enlarge patch
On Tue, Jan 15, 2008 at 09:08:03PM -0500, Jesse Becker wrote: > This is a re-post of a patch I sent back in December (originally based > on someone else's code). Committed revision 921, thanks Carlo - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Click-to-enlarge patch
The previous patch took care of the cluster view. This one takes care of the host view. It adds the same "click-to-enlarge" to the report and per-metric graphs. Same basic idea, and it also exists in 3.0.x, but not in trunk. On Jan 15, 2008 9:39 PM, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Tue, Jan 15, 2008 at 09:08:03PM -0500, Jesse Becker wrote: > > This is a re-post of a patch I sent back in December (originally based > > on someone else's code). > > Committed revision 921, thanks > > Carlo > -- Jesse Becker GPG Fingerprint -- BD00 7AA4 4483 AFCC 82D0 2720 0083 0931 9A2B 06A2 click-to-embiggen-hostvieww.patch Description: Binary data - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Click-to-enlarge patch
Sendingdefault/cluster_view.tpl Sendingdefault/host_view.tpl Transmitting file data .. Committed revision 924. On Wed, Jan 16, 2008 at 08:40:38PM -0500, Jesse Becker wrote: > The previous patch took care of the cluster view. This one takes care > of the host view. It adds the same "click-to-enlarge" to the report > and per-metric graphs. Same basic idea, and it also exists in 3.0.x, > but not in trunk. reverted previous patch and committed a merge better (which also avoids any mismatching case which would generate spurious differences with the 3.0.x branch) svn diff -c-921 | patch -p0 && svn merge -c810 Carlo - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Click-to-enlarge patch
On Jan 17, 2008 12:44 AM, Carlo Marcelo Arenas Belon
<[EMAIL PROTECTED]> wrote:
> Sendingdefault/cluster_view.tpl
> Sendingdefault/host_view.tpl
> Transmitting file data ..
> Committed revision 924.
>
> On Wed, Jan 16, 2008 at 08:40:38PM -0500, Jesse Becker wrote:
> > The previous patch took care of the cluster view. This one takes care
> > of the host view. It adds the same "click-to-enlarge" to the report
> > and per-metric graphs. Same basic idea, and it also exists in 3.0.x,
> > but not in trunk.
>
> reverted previous patch and committed a merge better (which also avoids any
> mismatching case which would generate spurious differences with the 3.0.x
> branch)
>
> svn diff -c-921 | patch -p0 && svn merge -c810
This actually reverted three lines too many, and broke the enlarging
of optional graphs. A fix is attached.
--
Jesse Becker
GPG Fingerprint -- BD00 7AA4 4483 AFCC 82D0 2720 0083 0931 9A2B 06A2
Index: cluster_view.tpl
===
--- cluster_view.tpl (revision 924)
+++ cluster_view.tpl (working copy)
@@ -37,8 +37,9 @@
SRC="./graph.php?g=network_report&z=medium&{graph_args}">
-
+
+
+
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/___
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
Re: [Ganglia-developers] Click-to-enlarge patch
On Thu, Jan 17, 2008 at 09:48:11AM -0500, Jesse Becker wrote: > On Jan 17, 2008 12:44 AM, Carlo Marcelo Arenas Belon > > > > svn diff -c-921 | patch -p0 && svn merge -c810 > > This actually reverted three lines too many, and broke the enlarging > of optional graphs. Which shouldn't be the case if the previous patch matched what was in the 3.0.x branch as advertised. When making independent changes it is better if doing also independent patches > A fix is attached. Committed revision 925. Carlo - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
