[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #14 from Andrew Benton andy at benton dot eu.com 2012-06-11 15:00:41 UTC --- Many thanks, Libre Office now compiles as expected. Should this bug be marked as fixed?
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #10 from Richard Henderson rth at gcc dot gnu.org 2012-06-09 06:14:34 UTC --- Author: rth Date: Sat Jun 9 06:14:27 2012 New Revision: 188356 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=188356 Log: PR c++/53602 * combine-stack-adj.c (force_move_args_size_note): Add ARGS_SIZE note to a clobber insn when no other insn is available. Added: branches/gcc-4_7-branch/gcc/testsuite/g++.dg/torture/pr53602.C Modified: branches/gcc-4_7-branch/gcc/ChangeLog branches/gcc-4_7-branch/gcc/combine-stack-adj.c
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #11 from Richard Henderson rth at gcc dot gnu.org 2012-06-09 06:17:27 UTC --- Author: rth Date: Sat Jun 9 06:17:12 2012 New Revision: 188357 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=188357 Log: PR c++/53602 * combine-stack-adj.c (force_move_args_size_note): Add ARGS_SIZE note to a clobber insn when no other insn is available. Modified: trunk/gcc/ChangeLog trunk/gcc/combine-stack-adj.c
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #12 from Richard Henderson rth at gcc dot gnu.org 2012-06-09 06:18:53 UTC --- Author: rth Date: Sat Jun 9 06:18:38 2012 New Revision: 188358 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=188358 Log: PR c++/53602 Added: trunk/gcc/testsuite/g++.dg/torture/pr53602.C
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #13 from Richard Henderson rth at gcc dot gnu.org 2012-06-09 16:27:59 UTC --- Author: rth Date: Sat Jun 9 16:27:52 2012 New Revision: 188360 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=188360 Log: PR c++/53602 * cfgcleanup.c (execute_jump): Rename from rest_of_handle_jump2. (pass_jump): Rename from pass_jump2. (execute_jump2, pass_jump2): New. * combine-stack-adj.c (rest_of_handle_stack_adjustments): Don't perform cfg cleanup here. Move the test of PUSH_ROUNDING and ACCUMULATE_OUTGOING_ARGS test... (gate_handle_stack_adjustments): ... here. * passes.c (init_optimization_passes): Update for pass_jump2 rename. Place new pass_jump2 after pass_stack_adjustments. * tree-pass.h (pass_jump): Declare. Modified: trunk/gcc/ChangeLog trunk/gcc/cfgcleanup.c trunk/gcc/combine-stack-adj.c trunk/gcc/passes.c trunk/gcc/tree-pass.h
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602
Jakub Jelinek jakub at gcc dot gnu.org changed:
What|Removed |Added
CC||rth at gcc dot gnu.org
--- Comment #7 from Jakub Jelinek jakub at gcc dot gnu.org 2012-06-08
07:51:25 UTC ---
We end up with:
(insn 38 73 40 5 (parallel [
(set (reg/f:SI 7 sp)
(plus:SI (reg/f:SI 7 sp)
(const_int 12 [0xc])))
(clobber (reg:CC 17 flags))
]) pr53602.ii:359 251 {*addsi_1}
(expr_list:REG_UNUSED (reg:CC 17 flags)
(expr_list:REG_ARGS_SIZE (const_int 0 [0])
(nil
(insn 40 38 41 5 (parallel [
(set (reg/f:SI 7 sp)
(plus:SI (reg/f:SI 7 sp)
(const_int -12 [0xfff4])))
(clobber (reg:CC 17 flags))
]) pr53602.ii:64 251 {*addsi_1}
(expr_list:REG_UNUSED (reg:CC 17 flags)
(expr_list:REG_ARGS_SIZE (const_int 12 [0xc])
(nil
(insn 41 40 42 5 (set (mem/f:SI (pre_dec:SI (reg/f:SI 7 sp)) [0 S4 A32])
(mem/f/c:SI (plus:SI (reg/f:SI 6 bp)
(const_int -12 [0xfff4])) [3 D.3489.pData+0 S4
A32])) pr53602.ii:64 43 {*pushsi2}
(expr_list:REG_ARGS_SIZE (const_int 16 [0x10])
(nil)))
before csa and csa obviously merges the two into sp += 0 that it wants to
delete.
force_move_args_size is called with prev == NULL (as it is at the start of a
bb). But apparently cleanup_cfg at the start of csa pass jump threaded the
call sequence starting at insn 41, so the two stack adjustments that cancel
each other end up the only insns in a bb. So we trigger:
/* ??? We *must* have a place, lest we ICE on the lost adjustment.
Options are: dummy clobber insn, nop, or prevent the removal of
the sp += 0 insn. Defer that decision until we can prove this
can actually happen. */
I guess if we proved that all the predecessors of the bb have the same current
REG_ARGS_SIZE, or all the successor have the same current REG_ARGS_SIZE, we
could avoid the note altogether. Or do one of the things the comment talks
about. Richard, can you please handle this?
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 --- Comment #8 from Jakub Jelinek jakub at gcc dot gnu.org 2012-06-08 07:57:23 UTC --- Or perhaps just handle this particular case for now, when there has been jump threading right after the sp adjustment sequence that cancelled each other. Thus, if we reach end of bb after the insn without seeing a CALL or or throwing insn and the bb has a single fallthru successor only, keep looking in the successor bb.
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 Richard Henderson rth at gcc dot gnu.org changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|unassigned at gcc dot |rth at gcc dot gnu.org |gnu.org | --- Comment #9 from Richard Henderson rth at gcc dot gnu.org 2012-06-08 14:10:29 UTC --- Mine.
[Bug c++/53602] [4.7/4.8 Regression] Libre Office causes an internal compiler error
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53602 Jakub Jelinek jakub at gcc dot gnu.org changed: What|Removed |Added Status|WAITING |NEW Version|unknown |4.7.0 Target Milestone|--- |4.7.1 Summary|Libre Office causes an |[4.7/4.8 Regression] Libre |internal compiler error |Office causes an internal ||compiler error --- Comment #6 from Jakub Jelinek jakub at gcc dot gnu.org 2012-06-07 21:53:25 UTC --- Started with http://gcc.gnu.org/viewcvs?root=gccview=revrev=186018
