Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-06 Thread Diego Novillo 

On 2012-11-02 16:03 , Dodji Seketeli wrote:


* asan.c (create_cond_insert_point_before_iter): Factorize out of ...
(build_check_stmt): ... here.


OK.


Diego.

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Dodji Seketeli 
Jakub Jelinek  writes:

> On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote:
>> +  int fallthrough_probability =
>> +then_more_likely_p
>> +? PROB_VERY_UNLIKELY
>> +: PROB_ALWAYS - PROB_VERY_UNLIKELY;
>
> Just a formatting nit, I think = needs to go on the next line, so
>
>   int fallthrough_probability
> = then_more_likely_p
>   ? PROB_VERY_UNLIKELY
>   : PROB_ALWAYS - PROB_VERY_UNLIKELY;

OK.  Patch updated in my local tree.

> No need to repost for that.

OK, thanks.

-- 
Dodji

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

2012-11-05 Thread Jakub Jelinek 
On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote:
> +  int fallthrough_probability =
> +then_more_likely_p
> +? PROB_VERY_UNLIKELY
> +: PROB_ALWAYS - PROB_VERY_UNLIKELY;

Just a formatting nit, I think = needs to go on the next line, so

  int fallthrough_probability
= then_more_likely_p
  ? PROB_VERY_UNLIKELY
  : PROB_ALWAYS - PROB_VERY_UNLIKELY;

No need to repost for that.

Jakub