[gem5-dev] Change in gem5/gem5[master]: base: Delete an inet.hh accessor which is unused and makes gcc 9 upset.

2020-02-01 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/24925 )


Change subject: base: Delete an inet.hh accessor which is unused and makes  
gcc 9 upset.

..

base: Delete an inet.hh accessor which is unused and makes gcc 9 upset.

This accessor will return a pointer to an unaligned uint32_t. Since
it's not used and it's not clear how to fix it trivially, this change
just deletes it.

Change-Id: I08bc62276d639cc728411f3a8a23be385000ebab
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/24925
Reviewed-by: Jason Lowe-Power 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/base/inet.hh
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/inet.hh b/src/base/inet.hh
index 7d1235c..d016fd6 100644
--- a/src/base/inet.hh
+++ b/src/base/inet.hh
@@ -352,7 +352,6 @@
 uint16_t mtup() const { return ntohs(opt_data.mtu); }
 uint16_t mtur() const { return ntohs(opt_data.mtu); }
 void tr(ip_opt_data_tr ) const;
-const uint32_t *addext() const { return _data.addext[0]; }
 uint16_t rtralt() const { return ntohs(opt_data.rtralt); }
 void sdb(std::vector ) const;
 };

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/24925
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I08bc62276d639cc728411f3a8a23be385000ebab
Gerrit-Change-Number: 24925
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: base: Delete an inet.hh accessor which is unused and makes gcc 9 upset.

2020-01-30 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/24925 )



Change subject: base: Delete an inet.hh accessor which is unused and makes  
gcc 9 upset.

..

base: Delete an inet.hh accessor which is unused and makes gcc 9 upset.

This accessor will return a pointer to an unaligned uint32_t. Since
it's not used and it's not clear how to fix it trivially, this change
just deletes it.

Change-Id: I08bc62276d639cc728411f3a8a23be385000ebab
---
M src/base/inet.hh
1 file changed, 0 insertions(+), 1 deletion(-)



diff --git a/src/base/inet.hh b/src/base/inet.hh
index 7d1235c..d016fd6 100644
--- a/src/base/inet.hh
+++ b/src/base/inet.hh
@@ -352,7 +352,6 @@
 uint16_t mtup() const { return ntohs(opt_data.mtu); }
 uint16_t mtur() const { return ntohs(opt_data.mtu); }
 void tr(ip_opt_data_tr ) const;
-const uint32_t *addext() const { return _data.addext[0]; }
 uint16_t rtralt() const { return ntohs(opt_data.rtralt); }
 void sdb(std::vector ) const;
 };

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/24925
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I08bc62276d639cc728411f3a8a23be385000ebab
Gerrit-Change-Number: 24925
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev