Re: [gentoo-portage-dev] PATCH: Disable logging during pkg_config (#99527)

2005-08-08 Thread Zac Medico

Drake Wyrm wrote:

Jason Stubbs [EMAIL PROTECTED] wrote:


When logging is enabled, ebuild output is passed via tee. Running
anything that checks for terminal type inside of pkg_config therefore
doesn't work correctly. This patch disables logging during pkg_config
altogether.



There was a thread about this recently, and I'm almost certain that my
input was lost in the noise. A cleaner way of accomplishing that is to
write the ebuild such that portions which need a terminal either attach
to a terminal (`make menuconfig /dev/tty /dev/tty`) or simply check
for a terminal (`tty -s || die I need a terminal.`). I almost never
use the `ebuild ... config` feature, but just on general principle I'd
rather the logging capability remain intact.



Is this type of /dev/tty device functionality portable among all gentoo 
supported (non-Linux) operating systems?  This is a concern that comes to my 
mind.

Zac
--
gentoo-portage-dev@gentoo.org mailing list



Re: [gentoo-portage-dev] PATCH: Disable logging during pkg_config (#99527)

2005-08-08 Thread Jason Stubbs
On Monday 08 August 2005 15:58, Zac Medico wrote:
 Drake Wyrm wrote:
  Jason Stubbs [EMAIL PROTECTED] wrote:
 When logging is enabled, ebuild output is passed via tee. Running
 anything that checks for terminal type inside of pkg_config therefore
 doesn't work correctly. This patch disables logging during pkg_config
 altogether.
 
  There was a thread about this recently, and I'm almost certain that my
  input was lost in the noise. A cleaner way of accomplishing that is to
  write the ebuild such that portions which need a terminal either attach
  to a terminal (`make menuconfig /dev/tty /dev/tty`) or simply check
  for a terminal (`tty -s || die I need a terminal.`). I almost never
  use the `ebuild ... config` feature, but just on general principle I'd
  rather the logging capability remain intact.

 Is this type of /dev/tty device functionality portable among all gentoo
 supported (non-Linux) operating systems?  This is a concern that comes to
 my mind.

Good point. I often forget about 'those others'. ;)

By the way, you might want to drop by #gentoo-portage on irc.freenode.net 
sometime as a lot of discussion tends to happen there...

-- 
Jason Stubbs


pgp4C6WlNC3wV.pgp
Description: PGP signature