Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10321 ) Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3 Gerrit-Change-Number: 10321 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 02 Aug 2018 19:22:37 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10321 ) Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. USSD/hlr_vty.c: print error if EUSE is not found Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3 --- M src/hlr_vty.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 9532a03..2d9b929 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -193,7 +193,13 @@ USSD_STR "Configure default-route for all USSD to unknown destinations\n" EXT_STR) { - struct hlr_euse *euse = euse_find(g_hlr, argv[0]); + struct hlr_euse *euse; + + euse = euse_find(g_hlr, argv[0]); + if (!euse) { + vty_out(vty, "%% Cannot find EUSE %s%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } if (g_hlr->euse_default != euse) { vty_out(vty, "Switching default route from %s to %s%s", -- To view, visit https://gerrit.osmocom.org/10321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3 Gerrit-Change-Number: 10321 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
Change in osmo-hlr[master]: USSD/hlr_vty.c: print error if EUSE is not found
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/10321 Change subject: USSD/hlr_vty.c: print error if EUSE is not found .. USSD/hlr_vty.c: print error if EUSE is not found Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3 --- M src/hlr_vty.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/21/10321/1 diff --git a/src/hlr_vty.c b/src/hlr_vty.c index 9532a03..2d9b929 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -193,7 +193,13 @@ USSD_STR "Configure default-route for all USSD to unknown destinations\n" EXT_STR) { - struct hlr_euse *euse = euse_find(g_hlr, argv[0]); + struct hlr_euse *euse; + + euse = euse_find(g_hlr, argv[0]); + if (!euse) { + vty_out(vty, "%% Cannot find EUSE %s%s", argv[0], VTY_NEWLINE); + return CMD_WARNING; + } if (g_hlr->euse_default != euse) { vty_out(vty, "Switching default route from %s to %s%s", -- To view, visit https://gerrit.osmocom.org/10321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I18045c5e544a99b2414a6f0268f1343df119b9f3 Gerrit-Change-Number: 10321 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy