osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Patch Set 2: > > It appears that osmo-hnbgw *does* need -lsctp. > > Which particular libsctp API is used directly by osmo-hnbgw? for the record: it turns out osmo-hnbgw still had an unused function that called sctp_send() from an earlier code state. With that function dropped, all worked out. -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Patch Set 2: > It appears that osmo-hnbgw *does* need -lsctp. Which particular libsctp API is used directly by osmo-hnbgw? Can you please point this out? I would have expected that all use of libsctp API is done through libosmo-netif and/or libosmo-sigtran, and those libraries than bring in the sctp dependency. -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Patch Set 2: It appears that osmo-hnbgw *does* need -lsctp. -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
[MERGED] osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Harald Welte has submitted this change and it was merged. Change subject: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp .. osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp This fixes the following dpkg-shlibeps warnings: Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-hnbgw/usr/bin/osmo-hnbgw was not linked against libosmogsm.so.8 (it uses none of the library's symbols) dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-hnbgw/usr/bin/osmo-hnbgw was not linked against libsctp.so.1 (it uses none of the library's symbols) --- M src/Makefile.am 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/Makefile.am b/src/Makefile.am index d815394..a45b70b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -45,7 +45,6 @@ AM_CFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include \ $(OSMOCORE_CFLAGS) $(OSMOVTY_CFLAGS) $(OSMOGSM_CFLAGS) \ $(OSMONETIF_CFLAGS) $(ASN1C_CFLAGS) $(OSMOSIGTRAN_CFLAGS) -COMMON_LDADD = -lsctp # build the shared RANAP library # @@ -68,7 +67,7 @@ hnbgw_vty.c \ context_map.c hnbgw_cn.c -osmo_hnbgw_LDADD = $(OSMOCORE_LIBS) $(OSMOVTY_LIBS) $(OSMOGSM_LIBS) \ +osmo_hnbgw_LDADD = $(OSMOCORE_LIBS) $(OSMOVTY_LIBS) \ $(ASN1C_LIBS) $(OSMOSIGTRAN_LIBS) $(COMMON_LDADD) \ $(OSMONETIF_LIBS) \ hnbap/libosmo-asn1-hnbap.a rua/libosmo-asn1-rua.a \ -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] osmo-iuh[master]: osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp
Review at https://gerrit.osmocom.org/4618 osmo-hnbgw: Avoid useless linking to libosmogsm and libsctp This fixes the following dpkg-shlibeps warnings: Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-hnbgw/usr/bin/osmo-hnbgw was not linked against libosmogsm.so.8 (it uses none of the library's symbols) dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-hnbgw/usr/bin/osmo-hnbgw was not linked against libsctp.so.1 (it uses none of the library's symbols) --- M src/Makefile.am 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/18/4618/1 diff --git a/src/Makefile.am b/src/Makefile.am index d815394..a45b70b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -45,7 +45,6 @@ AM_CFLAGS = -I$(top_srcdir)/include -I$(top_builddir)/include \ $(OSMOCORE_CFLAGS) $(OSMOVTY_CFLAGS) $(OSMOGSM_CFLAGS) \ $(OSMONETIF_CFLAGS) $(ASN1C_CFLAGS) $(OSMOSIGTRAN_CFLAGS) -COMMON_LDADD = -lsctp # build the shared RANAP library # @@ -68,7 +67,7 @@ hnbgw_vty.c \ context_map.c hnbgw_cn.c -osmo_hnbgw_LDADD = $(OSMOCORE_LIBS) $(OSMOVTY_LIBS) $(OSMOGSM_LIBS) \ +osmo_hnbgw_LDADD = $(OSMOCORE_LIBS) $(OSMOVTY_LIBS) \ $(ASN1C_LIBS) $(OSMOSIGTRAN_LIBS) $(COMMON_LDADD) \ $(OSMONETIF_LIBS) \ hnbap/libosmo-asn1-hnbap.a rua/libosmo-asn1-rua.a \ -- To view, visit https://gerrit.osmocom.org/4618 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6a645a93406670d58eb5edf5f2f2e1266168c92 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Harald Welte
