[MERGED] osmo-mgw[master]: protocol: on wildcarded CRCX return endpoint number as hex
Harald Welte has submitted this change and it was merged. Change subject: protocol: on wildcarded CRCX return endpoint number as hex .. protocol: on wildcarded CRCX return endpoint number as hex When a wildcarded CRCX is done, then the endpoint number is returned as unsigned integer (%u). This results into problems with endpoint numbers higher than 9. - Return endpoint identifier with the endpoint number in hexadecimal representation Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 709c04a..3f1594f 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -201,7 +201,7 @@ /* NOTE: Only in the virtual trunk we allow dynamic endpoint names */ if (endp->wildcarded_crcx && endp->tcfg->trunk_type == MGCP_TRUNK_VIRTUAL) { - rc = msgb_printf(msg, "Z: %s%u@%s\r\n", + rc = msgb_printf(msg, "Z: %s%x@%s\r\n", MGCP_ENDPOINT_PREFIX_VIRTUAL_TRUNK, ENDPOINT_NUMBER(endp), endp->cfg->domain); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/6242 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexterGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder
osmo-mgw[master]: protocol: on wildcarded CRCX return endpoint number as hex
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6242 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexterGerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
[PATCH] osmo-mgw[master]: protocol: on wildcarded CRCX return endpoint number as hex
Review at https://gerrit.osmocom.org/6242 protocol: on wildcarded CRCX return endpoint number as hex When a wildcarded CRCX is done, then the endpoint number is returned as unsigned integer (%u). This results into problems with endpoint numbers higher than 9. - Return endpoint identifier with the endpoint number in hexadecimal representation Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/42/6242/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 709c04a..3f1594f 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -201,7 +201,7 @@ /* NOTE: Only in the virtual trunk we allow dynamic endpoint names */ if (endp->wildcarded_crcx && endp->tcfg->trunk_type == MGCP_TRUNK_VIRTUAL) { - rc = msgb_printf(msg, "Z: %s%u@%s\r\n", + rc = msgb_printf(msg, "Z: %s%x@%s\r\n", MGCP_ENDPOINT_PREFIX_VIRTUAL_TRUNK, ENDPOINT_NUMBER(endp), endp->cfg->domain); if (rc < 0) -- To view, visit https://gerrit.osmocom.org/6242 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I504f4658c193009347753b15256dbb46b32ad5a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter