osmo-pcu[master]: Revert "Use Timing Advance Index in UL assignments"
Patch Set 1: Verified+1 verified on sysmoBTS that GPRS works better after the revert of these four patches -- To view, visit https://gerrit.osmocom.org/6976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-pcu[master]: Revert "Use Timing Advance Index in UL assignments"
Patch Set 1: I know that you opposed these reverts; but since nothing else is happening to fix usability of osmo-pcu, I still think that it's a good start to remove the changes that broke it. Let's re-apply them once we understand whatever it is that they are doing; particularly since these reverts apply cleanly onto current master, which means that the changes are sufficiently independent of the other changes that happened since. If we never get time to do it, then at least osmo-pcu isn't broken forever, like it is now. -- To view, visit https://gerrit.osmocom.org/6976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
osmo-pcu[master]: Revert "Use Timing Advance Index in UL assignments"
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr Gerrit-HasComments: No
[PATCH] osmo-pcu[master]: Revert "Use Timing Advance Index in UL assignments"
Review at https://gerrit.osmocom.org/6976 Revert "Use Timing Advance Index in UL assignments" This reverts commit 6298fbb7b2f3639fde994633e33ba54a64a6ef9b, I8b17be78a46c0bc17516b7c90f35aa4768010ae4. Commit I52ec9b07413daabba8cd5f1fba5c7b3af6a33389 / 896574e92bea09ed8d39688b6fdf504e84521746 was found (empirically) to be a regression, rendering GPRS service fatally unreliable. This reverted commit seems to follow after the regression and is reverted along with it. Related: OS#3013 Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 --- M src/encoding.cpp 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/76/6976/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 39cbe24..e96894f 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -255,9 +255,7 @@ rc = write_alpha_gamma(dest, alpha, gamma); check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest); /* No TIMING_ADVANCE_INDEX */ set_0(dest); /* No TBF_STARTING_TIME */ } else { set_0(dest); /* Single Block Allocation */ @@ -319,9 +317,7 @@ rc = write_alpha_gamma(dest, alpha, gamma); /* ALPHA and GAMMA */ check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest);/* No TIMING_ADVANCE_INDEX */ set_0(dest);/* No TBF_STARTING_TIME */ bitvec_set_bit(dest, L);/* No Additions for Rel-7 */ } else { -- To view, visit https://gerrit.osmocom.org/6976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr
[MERGED] osmo-pcu[master]: Revert "Use Timing Advance Index in UL assignments"
Harald Welte has submitted this change and it was merged. Change subject: Revert "Use Timing Advance Index in UL assignments" .. Revert "Use Timing Advance Index in UL assignments" This reverts commit 6298fbb7b2f3639fde994633e33ba54a64a6ef9b, I8b17be78a46c0bc17516b7c90f35aa4768010ae4. Commit I52ec9b07413daabba8cd5f1fba5c7b3af6a33389 / 896574e92bea09ed8d39688b6fdf504e84521746 was found (empirically) to be a regression, rendering GPRS service fatally unreliable. This reverted commit seems to follow after the regression and is reverted along with it. Related: OS#3013 Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 --- M src/encoding.cpp 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Neels Hofmeyr: Verified Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/encoding.cpp b/src/encoding.cpp index 39cbe24..e96894f 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -255,9 +255,7 @@ rc = write_alpha_gamma(dest, alpha, gamma); check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest); /* No TIMING_ADVANCE_INDEX */ set_0(dest); /* No TBF_STARTING_TIME */ } else { set_0(dest); /* Single Block Allocation */ @@ -319,9 +317,7 @@ rc = write_alpha_gamma(dest, alpha, gamma); /* ALPHA and GAMMA */ check(rc); - rc = write_ta_index(dest, ta_idx); - check(rc); - + set_0(dest);/* No TIMING_ADVANCE_INDEX */ set_0(dest);/* No TBF_STARTING_TIME */ bitvec_set_bit(dest, L);/* No Additions for Rel-7 */ } else { -- To view, visit https://gerrit.osmocom.org/6976 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e0fd8c9c3b89e519e7382e3d0bb24e0aeddeff6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr