Re: [PATCH 0/3] fix travis TAP/--verbose conflict
> On 21 Oct 2016, at 12:41, Jeff King wrote: > > On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote: > >> The obvious fix would be to send "--verbose" output to stderr, but I >> suspect that would end up annoying for people who do: >> >> ./t5547-push-quarantine.sh -v | less >> >> to read long output. Probably we need some option like "--log" which >> logs in the same way that "--tee" does, but _without_ sending the data >> to stdout. Naively, that just means replacing the "tee" invocation with >> "cat", but I suspect it will be a lot more complicated than that, >> because we still need to let the TAP output go to stdout. > > Yeah, it was definitely a lot more complicated. This patch series fixes > it. Thanks a lot for this detailed and quick fix :-) Cheers, Lars
Re: [PATCH 0/3] fix travis TAP/--verbose conflict
On Fri, Oct 21, 2016 at 3:41 AM, Jeff King wrote: > On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote: > >> The obvious fix would be to send "--verbose" output to stderr, but I >> suspect that would end up annoying for people who do: >> >> ./t5547-push-quarantine.sh -v | less >> >> to read long output. Probably we need some option like "--log" which >> logs in the same way that "--tee" does, but _without_ sending the data >> to stdout. Naively, that just means replacing the "tee" invocation with >> "cat", but I suspect it will be a lot more complicated than that, >> because we still need to let the TAP output go to stdout. > > Yeah, it was definitely a lot more complicated. This patch series fixes > it. > > [1/3]: test-lib: handle TEST_OUTPUT_DIRECTORY with spaces > [2/3]: test-lib: add --verbose-log option > [3/3]: travis: use --verbose-log test option All patches look good to me (1&3 are obvious, and 2 is very well described). Thanks, Stefan
[PATCH 0/3] fix travis TAP/--verbose conflict
On Fri, Oct 21, 2016 at 04:43:48AM -0400, Jeff King wrote: > The obvious fix would be to send "--verbose" output to stderr, but I > suspect that would end up annoying for people who do: > > ./t5547-push-quarantine.sh -v | less > > to read long output. Probably we need some option like "--log" which > logs in the same way that "--tee" does, but _without_ sending the data > to stdout. Naively, that just means replacing the "tee" invocation with > "cat", but I suspect it will be a lot more complicated than that, > because we still need to let the TAP output go to stdout. Yeah, it was definitely a lot more complicated. This patch series fixes it. [1/3]: test-lib: handle TEST_OUTPUT_DIRECTORY with spaces [2/3]: test-lib: add --verbose-log option [3/3]: travis: use --verbose-log test option .travis.yml | 2 +- t/README | 6 ++ t/test-lib.sh | 24 3 files changed, 27 insertions(+), 5 deletions(-) -Peff