Re: [PATCH 4/4] gitweb: make search help link less ugly
Jakub Narębski jna...@gmail.com wrote: - -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . + -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . Nb. what changed here (in line above)? Whoops, tab damage. I will re-roll. Thanks for the review. Tony. -- f.anthony.n.finch d...@dotat.at http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first.
Re: [PATCH 4/4] gitweb: make search help link less ugly
On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch d...@dotat.at wrote: The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned I think the idea was to simulate footnote explaining search terms (I think, I am not the author of this feature)... and is a cramped and awkward click target. Remove the superscript tags and add some spacing to fix these nits. Add a title attribute to provide an explanatory mouseover. ... but I agree that it makes for poor UI. Signed-off-by: Tony Finch d...@dotat.at --- gitweb/gitweb.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c029b98..874c948 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4029,9 +4029,9 @@ sub print_search_form { $cgi-input({-name=a, -value=search, -type=hidden}) . \n . $cgi-input({-name=h, -value=$search_hash, -type=hidden}) . \n . $cgi-popup_menu(-name = 'st', -default = 'commit', - -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . - $cgi-sup($cgi-a({-href = href(action=search_help)}, ?)) . - search:\n, + -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . Nb. what changed here (in line above)? + . $cgi-a({-href = href(action=search_help), +-title = search help }, ?) . search:\n, $cgi-textfield(-name = s, -value = $searchtext, -override = 1) . \n . span title=\Extended regular expression\ . $cgi-checkbox(-name = 'sr', -value = 1, -label = 're', -- 1.8.3.1.605.g85318f5 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4] gitweb: make search help link less ugly
The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned and is a cramped and awkward click target. Remove the superscript tags and add some spacing to fix these nits. Add a title attribute to provide an explanatory mouseover. Signed-off-by: Tony Finch d...@dotat.at --- gitweb/gitweb.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c029b98..874c948 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4029,9 +4029,9 @@ sub print_search_form { $cgi-input({-name=a, -value=search, -type=hidden}) . \n . $cgi-input({-name=h, -value=$search_hash, -type=hidden}) . \n . $cgi-popup_menu(-name = 'st', -default = 'commit', - -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . - $cgi-sup($cgi-a({-href = href(action=search_help)}, ?)) . - search:\n, + -values = ['commit', 'grep', 'author', 'committer', 'pickaxe']) . + . $cgi-a({-href = href(action=search_help), +-title = search help }, ?) . search:\n, $cgi-textfield(-name = s, -value = $searchtext, -override = 1) . \n . span title=\Extended regular expression\ . $cgi-checkbox(-name = 'sr', -value = 1, -label = 're', -- 1.8.3.1.605.g85318f5 -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html