Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

2015-03-20 Thread Paul Tan
Hi,

On Thu, Mar 19, 2015 at 12:23 AM, Matthieu Moy
 wrote:
> I would personnally prefer to see this squashed with PATCH 2/4: pushing
> the "bisectable history" principle a bit, the state between patches 2
> and 3 could be considered broken because the code does not do what the
> documentation says. And as a reviewer, I like having pieces of docs
> linked to the patch they document.

Yup, I can see what you mean. Will squash on the next version.

> Paul Tan  writes:
>
>> +Credential storage will per default
>
> Not a native, but "per default" sounds weird and "by default" seems far
> more common.

Ah right, that definitely sounds better. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

2015-03-18 Thread Matthieu Moy
I would personnally prefer to see this squashed with PATCH 2/4: pushing
the "bisectable history" principle a bit, the state between patches 2
and 3 could be considered broken because the code does not do what the
documentation says. And as a reviewer, I like having pieces of docs
linked to the patch they document.

Paul Tan  writes:

> +Credential storage will per default

Not a native, but "per default" sounds weird and "by default" seems far
more common.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence

2015-03-18 Thread Paul Tan
git-credential-store now supports an additional default credential file
at $XDG_CONFIG_HOME/git/credentials. However, ~/.git-credentials takes
precedence over it for backwards compatibility. To make the precedence
ordering explicit, add a new section FILES that lists out the credential
file paths in their order of precedence, and explains how the ordering
affects the lookup, storage and erase operations.

Also update documentation for --store to briefly explain the operations
on multiple files if the --store option is not provided.

Helped-by: Eric Sunshine 
Signed-off-by: Paul Tan 
---

The previous version can be found at [1].

[1] http://thread.gmane.org/gmane.comp.version-control.git/265305/focus=265308

The changes are as follows:

* Remove "support for this file was added fairly recently" statement, as
it will become out-dated with time. Thanks Eric for pointing this out.

 Documentation/git-credential-store.txt | 35 --
 1 file changed, 33 insertions(+), 2 deletions(-)

diff --git a/Documentation/git-credential-store.txt 
b/Documentation/git-credential-store.txt
index bc97071..e16afd8 100644
--- a/Documentation/git-credential-store.txt
+++ b/Documentation/git-credential-store.txt
@@ -31,10 +31,41 @@ OPTIONS
 
 --file=::
 
-   Use `` to store credentials. The file will have its
+   Use `` to lookup and store credentials. The file will have its
filesystem permissions set to prevent other users on the system
from reading it, but will not be encrypted or otherwise
-   protected. Defaults to `~/.git-credentials`.
+   protected. If not specified, credentials will be searched for from
+   `~/.git-credentials` and `$XDG_CONFIG_HOME/git/credentials`, and
+   credentials will be written to `~/.git-credentials` if it exists, or
+   `$XDG_CONFIG_HOME/git/credentials` if it exists and the former does
+   not. See also <>.
+
+[[FILES]]
+FILES
+-
+
+If not set explicitly with '--file', there are two files where
+git-credential-store will search for credentials in order of precedence:
+
+~/.git-credentials::
+   User-specific credentials file.
+
+$XDG_CONFIG_HOME/git/credentials::
+   Second user-specific credentials file. If '$XDG_CONFIG_HOME' is not set
+   or empty, `$HOME/.config/git/credentials` will be used. Any credentials
+   stored in this file will not be used if `~/.git-credentials` has a
+   matching credential as well. It is a good idea not to create this file
+   if you sometimes use older versions of Git that do not support it.
+
+For credential lookups, the files are read in the order given above, with the
+first matching credential found taking precedence over credentials found in
+files further down the list.
+
+Credential storage will per default write to the first existing file in the
+list. If none of these files exist, `~/.git-credentials` will be created and
+written to.
+
+When erasing credentials, matching credentials will be erased from all files.
 
 EXAMPLES
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html