Re: [PATCH v2 00/17] Clean up how fetch_pack() handles the heads list

2012-08-26 Thread Junio C Hamano
mhag...@alum.mit.edu writes:

 Re-roll, incorporating Jeff's suggestions.  Some commit messages have
 also been improved, but the only interdiff is that match_pos is
 renamed to head_pos in filter_refs().

 This patch series applies to the merge between master and
 jc/maint-push-refs-all, though the dependency on the latter is only
 textual.

I've read this twice and saw nothing questionable in the series
(other than that the titles of a few weren't clear enough when
placed in a short-log like below).  Very nicely done.

Thanks.  Will queue.

 Michael Haggerty (17):
   t5500: add tests of error output for missing refs
   Rename static function fetch_pack() to http_fetch_pack()
   Fix formatting.
   Name local variables more consistently
   Do not check the same head_pos twice
   Let fetch_pack() inform caller about number of unique heads
   Pass nr_heads to do_pack_ref() by reference
   Pass nr_heads to everything_local() by reference
   Pass nr_heads to filter_refs() by reference
   Remove ineffective optimization
   filter_refs(): do not leave gaps in return_refs
   filter_refs(): compress unmatched refs in heads array
   cmd_fetch_pack: return early if finish_connect() returns an error
   Report missing refs even if no existing refs were received
   cmd_fetch_pack(): simplify computation of return value
   fetch_pack(): free matching heads
   filter_refs(): simplify logic

  builtin/fetch-pack.c  | 128 
 --
  fetch-pack.h  |  19 +---
  http-walker.c |   4 +-
  t/t5500-fetch-pack.sh |  32 -
  transport.c   |   8 ++--
  5 files changed, 101 insertions(+), 90 deletions(-)
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 00/17] Clean up how fetch_pack() handles the heads list

2012-08-25 Thread mhagger
From: Michael Haggerty mhag...@alum.mit.edu

Re-roll, incorporating Jeff's suggestions.  Some commit messages have
also been improved, but the only interdiff is that match_pos is
renamed to head_pos in filter_refs().

This patch series applies to the merge between master and
jc/maint-push-refs-all, though the dependency on the latter is only
textual.

Michael Haggerty (17):
  t5500: add tests of error output for missing refs
  Rename static function fetch_pack() to http_fetch_pack()
  Fix formatting.
  Name local variables more consistently
  Do not check the same head_pos twice
  Let fetch_pack() inform caller about number of unique heads
  Pass nr_heads to do_pack_ref() by reference
  Pass nr_heads to everything_local() by reference
  Pass nr_heads to filter_refs() by reference
  Remove ineffective optimization
  filter_refs(): do not leave gaps in return_refs
  filter_refs(): compress unmatched refs in heads array
  cmd_fetch_pack: return early if finish_connect() returns an error
  Report missing refs even if no existing refs were received
  cmd_fetch_pack(): simplify computation of return value
  fetch_pack(): free matching heads
  filter_refs(): simplify logic

 builtin/fetch-pack.c  | 128 --
 fetch-pack.h  |  19 +---
 http-walker.c |   4 +-
 t/t5500-fetch-pack.sh |  32 -
 transport.c   |   8 ++--
 5 files changed, 101 insertions(+), 90 deletions(-)

-- 
1.7.11.3

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html