Re: [PATCH v6 12/14] commit-graph: read only from specific pack-indexes
On 3/15/2018 6:50 PM, SZEDER Gábor wrote: On Wed, Mar 14, 2018 at 8:27 PM, Derrick Stoleewrote: From: Derrick Stolee Teach git-commit-graph to inspect the objects only in a certain list of pack-indexes within the given pack directory. This allows updating the commit graph iteratively. This commit message, and indeed the code itself talk about pack indexes ... Signed-off-by: Derrick Stolee --- Documentation/git-commit-graph.txt | 11 ++- builtin/commit-graph.c | 33 ++--- commit-graph.c | 26 -- commit-graph.h | 4 +++- packfile.c | 4 ++-- packfile.h | 2 ++ t/t5318-commit-graph.sh| 10 ++ 7 files changed, 81 insertions(+), 9 deletions(-) diff --git a/Documentation/git-commit-graph.txt b/Documentation/git-commit-graph.txt index 51cb038f3d..b945510f0f 100644 --- a/Documentation/git-commit-graph.txt +++ b/Documentation/git-commit-graph.txt @@ -32,7 +32,9 @@ COMMANDS 'write':: Write a commit graph file based on the commits found in packfiles. -Includes all commits from the existing commit graph file. ++ +With the `--stdin-packs` option, generate the new commit graph by +walking objects only in the specified packfiles. ... but this piece of documentation ... + OPT_BOOL(0, "stdin-packs", _packs, + N_("scan packfiles listed by stdin for commits")), ... and this help text, and even the name of the option talk about packfiles. Thanks! I'll fix that. -Stolee
Re: [PATCH v6 12/14] commit-graph: read only from specific pack-indexes
On Wed, Mar 14, 2018 at 8:27 PM, Derrick Stoleewrote: > From: Derrick Stolee > > Teach git-commit-graph to inspect the objects only in a certain list > of pack-indexes within the given pack directory. This allows updating > the commit graph iteratively. This commit message, and indeed the code itself talk about pack indexes ... > Signed-off-by: Derrick Stolee > --- > Documentation/git-commit-graph.txt | 11 ++- > builtin/commit-graph.c | 33 ++--- > commit-graph.c | 26 -- > commit-graph.h | 4 +++- > packfile.c | 4 ++-- > packfile.h | 2 ++ > t/t5318-commit-graph.sh| 10 ++ > 7 files changed, 81 insertions(+), 9 deletions(-) > > diff --git a/Documentation/git-commit-graph.txt > b/Documentation/git-commit-graph.txt > index 51cb038f3d..b945510f0f 100644 > --- a/Documentation/git-commit-graph.txt > +++ b/Documentation/git-commit-graph.txt > @@ -32,7 +32,9 @@ COMMANDS > 'write':: > > Write a commit graph file based on the commits found in packfiles. > -Includes all commits from the existing commit graph file. > ++ > +With the `--stdin-packs` option, generate the new commit graph by > +walking objects only in the specified packfiles. ... but this piece of documentation ... > + OPT_BOOL(0, "stdin-packs", _packs, > + N_("scan packfiles listed by stdin for commits")), ... and this help text, and even the name of the option talk about packfiles.