Re: [Gluster-devel] quota tests and usage of sleep
On 06/17/2014 11:14 AM, Varun Shastry wrote: > - Original Message - >> hi, >> Could you guys remove 'sleep' for quota tests authored by you guys >> if it can be done. They are leading to spurious failures. I don't get how sleep can cause the failures. But for script bug-1087198.t in my name, it is part of the testing. I can reduce it to a smaller value but we need to have the test which waits for a small amount of time. Sleeps are added to make sure a certain condition is met in that time. Sometimes what happens is that the condition could take longer to meet causing spurious failure. So we are going through the tests and eliminating 'sleeps' that is not required. Or use better expect_within statement to make sure the condition is met using explicit tests. Pranith - Varun Shastry >> I will be sending out a patch removing 'sleep' in other tests. >> >> Pranith >> ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] quota tests and usage of sleep
> - Original Message - >> hi, >> Could you guys remove 'sleep' for quota tests authored by you guys >> if it can be done. They are leading to spurious failures. I don't get how sleep can cause the failures. But for script bug-1087198.t in my name, it is part of the testing. I can reduce it to a smaller value but we need to have the test which waits for a small amount of time. - Varun Shastry >> I will be sending out a patch removing 'sleep' in other tests. >> >> Pranith >> ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] quota tests and usage of sleep
On 06/17/2014 09:21 AM, Krutika Dhananjay wrote: *From: *"Pranith Kumar Karampuri" *To: *"Krishnan Parthasarathi" *Cc: *"Raghavendra Gowdappa" , vshas...@redhat.com, "Krutika Dhananjay" , "Gluster Devel" , "Anuradha Talur" , "Susant Palai" *Sent: *Monday, June 16, 2014 10:24:36 PM *Subject: *Re: quota tests and usage of sleep These are the test files which need attention. I added the authors to the mail. bug-1038598.t - Anuradha bug-1040423.t - Susant bug-1087198.t - Varun bug-1099890.t - Krutika sleep cannot be removed from bug-1099890.t until the way DHT currently refreshes cached values of its subvolumes' struct statvfs info is resolved. -Krutika Thanks for the update krutika. Is that a bug or is it by design?. If it is a bug please log one. Could the rest of you also respond please. Pranith Pranith On 06/16/2014 09:08 AM, Krishnan Parthasarathi wrote: > All, > > I have just one quota test authored by me in the regression test suite and that doesn't use sleep. Let me know if you need my help in reviewing your changes. > > thanks, > Krish > > - Original Message - >> hi, >> Could you guys remove 'sleep' for quota tests authored by you guys >> if it can be done. They are leading to spurious failures. >> I will be sending out a patch removing 'sleep' in other tests. >> >> Pranith >> ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] quota tests and usage of sleep
- Original Message - > From: "Pranith Kumar Karampuri" > To: "Krishnan Parthasarathi" > Cc: "Raghavendra Gowdappa" , vshas...@redhat.com, > "Krutika Dhananjay" , "Gluster Devel" > , "Anuradha Talur" , "Susant > Palai" > Sent: Monday, June 16, 2014 10:24:36 PM > Subject: Re: quota tests and usage of sleep > These are the test files which need attention. I added the authors to > the mail. > bug-1038598.t - Anuradha > bug-1040423.t - Susant > bug-1087198.t - Varun > bug-1099890.t - Krutika sleep cannot be removed from bug-1099890.t until the way DHT currently refreshes cached values of its subvolumes' struct statvfs info is resolved. -Krutika > Pranith > On 06/16/2014 09:08 AM, Krishnan Parthasarathi wrote: > > All, > > > > I have just one quota test authored by me in the regression test suite and > > that doesn't use sleep. Let me know if you need my help in reviewing your > > changes. > > > > thanks, > > Krish > > > > - Original Message - > >> hi, > >> Could you guys remove 'sleep' for quota tests authored by you guys > >> if it can be done. They are leading to spurious failures. > >> I will be sending out a patch removing 'sleep' in other tests. > >> > >> Pranith > >> ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] quota tests and usage of sleep
These are the test files which need attention. I added the authors to the mail. bug-1038598.t - Anuradha bug-1040423.t - Susant bug-1087198.t - Varun bug-1099890.t - Krutika Pranith On 06/16/2014 09:08 AM, Krishnan Parthasarathi wrote: All, I have just one quota test authored by me in the regression test suite and that doesn't use sleep. Let me know if you need my help in reviewing your changes. thanks, Krish - Original Message - hi, Could you guys remove 'sleep' for quota tests authored by you guys if it can be done. They are leading to spurious failures. I will be sending out a patch removing 'sleep' in other tests. Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] quota tests and usage of sleep
All, I have just one quota test authored by me in the regression test suite and that doesn't use sleep. Let me know if you need my help in reviewing your changes. thanks, Krish - Original Message - > hi, > Could you guys remove 'sleep' for quota tests authored by you guys > if it can be done. They are leading to spurious failures. > I will be sending out a patch removing 'sleep' in other tests. > > Pranith > ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] quota tests and usage of sleep
hi, Could you guys remove 'sleep' for quota tests authored by you guys if it can be done. They are leading to spurious failures. I will be sending out a patch removing 'sleep' in other tests. Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
