[gwt-contrib] Re: Re-enabling commits in Gerrit
Just to clarify: does that mean the SVN is now dead? (except for GWT_TOOLS) Anyway, thanks a lot for your work Matthew! On Wednesday, May 8, 2013 2:27:17 AM UTC+2, Matthew Dempsky wrote: FYI, this is now live. Members of the gwt-maintainers group have +2 code-review and submit permissions again. On Tue, May 7, 2013 at 3:49 PM, Matthew Dempsky mdem...@google.comjavascript: wrote: *tl;dr:* We’re enabling commits in Gerrit, so you’ll be able to land patches directly on gwt.googlesource.com instead of needing a Googler to merge them internally for you. We’ve finally gotten things in place internally so we can change the mirroring strategy from “google - subversion - git” to “git - google - subversion”. (We’re going to keep Subversion around in the interim in case something goes wrong and we need to switch back.) As such, we'll soon re-enable +2’s in Gerrit and start allowing commits directly to Git. Since this is a big change from the current workflow, we’re going to try to take things slowly to start just so we can make sure everything’s working how we envision. We’ll also work on formalizing some development practices. As we feel more confident in the process, I expect things will speed up and contributing should be much easier. Also, we still plan to re-spin the Git repository in the near future to clean up some accumulated history cruft (e.g., the old plugins binaries). We’ll send out more announcements about that once we’re prepared to make that change. Thanks for your patience! -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] Re: Re-enabling commits in Gerrit
On Wed, May 8, 2013 at 4:31 AM, Thomas Broyer t.bro...@gmail.com wrote: Just to clarify: does that mean the SVN is now dead? (except for GWT_TOOLS) Pretty much, unless something really serious comes up that forces us to temporarily switch back. We'll continue mirroring to subversion for the time being, but developers and contributors should switch to using Git if they haven't already. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: dummy testing commit
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/2660 Change subject: dummy testing commit .. dummy testing commit Change-Id: If0881f00eaafbb05190a0640f82559dda09545d6 --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/build.xml b/build.xml index c783631..7bc237e 100755 --- a/build.xml +++ b/build.xml @@ -1,3 +1,4 @@ +!-- testing -- project name=GWT default=dist basedir=. property name=gwt.root location=. / property name=project.tail value= / -- To view, visit https://gwt-review.googlesource.com/2660 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0881f00eaafbb05190a0640f82559dda09545d6 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: dummy testing commit
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/2670 Change subject: dummy testing commit .. dummy testing commit Change-Id: If0881f00eaafbb05190a0640f82559dda09545d7 --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/build.xml b/build.xml index c783631..7bc237e 100755 --- a/build.xml +++ b/build.xml @@ -1,3 +1,4 @@ +!-- testing -- project name=GWT default=dist basedir=. property name=gwt.root location=. / property name=project.tail value= / -- To view, visit https://gwt-review.googlesource.com/2670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0881f00eaafbb05190a0640f82559dda09545d7 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: dummy testing commit
Matthew Dempsky has abandoned this change. Change subject: dummy testing commit .. Abandoned Testing. -- To view, visit https://gwt-review.googlesource.com/2670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If0881f00eaafbb05190a0640f82559dda09545d7 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Testing again.
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/2671 Change subject: Testing again. .. Testing again. Change-Id: Ic927ad9a06e7ca780045b4255b1a2577e9b3f291 --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/build.xml b/build.xml index c783631..7bc237e 100755 --- a/build.xml +++ b/build.xml @@ -1,3 +1,4 @@ +!-- testing -- project name=GWT default=dist basedir=. property name=gwt.root location=. / property name=project.tail value= / -- To view, visit https://gwt-review.googlesource.com/2671 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic927ad9a06e7ca780045b4255b1a2577e9b3f291 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Testing again.
Matthew Dempsky has abandoned this change. Change subject: Testing again. .. Abandoned Abandon. -- To view, visit https://gwt-review.googlesource.com/2671 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic927ad9a06e7ca780045b4255b1a2577e9b3f291 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Roberto Lublinerman has uploaded a new patch set (#5). Change subject: Adds part of Java 7 new language features. .. Adds part of Java 7 new language features. Adds the Java 7 new language features: namely, the diamond operator, new numerical literal formats, and switch/case on string literals. Adds a new flag -source to select source level compatibility (java 6 or java 7); -source defaults to java 6. Fixes issue 6633. Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Review-Link: https://gwt-review.googlesource.com/#/c/2650/ --- M dev/codeserver/java/com/google/gwt/dev/codeserver/CodeServer.java M dev/codeserver/java/com/google/gwt/dev/codeserver/CompilerOptionsImpl.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/codeserver/java/com/google/gwt/dev/codeserver/Recompiler.java M dev/codeserver/java/com/google/gwt/dev/codeserver/UnmodifiableCompilerOptions.java M dev/core/src/com/google/gwt/dev/CompileModule.java M dev/core/src/com/google/gwt/dev/CompileTaskOptions.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/Compiler.java M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/Precompile.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/javac/testing/impl/JavaResourceBase.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptions.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java A dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java A dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java M dev/core/test/com/google/gwt/dev/javac/JdtBehaviorTest.java A dev/core/test/com/google/gwt/dev/javac/JdtJava7Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java A dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/junit/JUnitShell.java A user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/CompilerSuite.java A user/test/com/google/gwt/dev/jjs/Java7Test.gwt.xml A user/test/com/google/gwt/dev/jjs/test/Java7Test.java 34 files changed, 944 insertions(+), 45 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Roberto Lublinerman has abandoned this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Abandoned Redid as dependent patch. -- To view, visit https://gwt-review.googlesource.com/2680 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic46ae3c9ee49518cfddc6f6f329b721e6645802d Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upgrade JDT to 3.8.3.
Roberto Lublinerman has abandoned this change. Change subject: Upgrade JDT to 3.8.3. .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/2361 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 1: Verified-1 Oops, this change failed the build and/or style presubmit. :( More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/46 -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds part of Java 7 new language features.
Matthew Dempsky has posted comments on this change. Change subject: Adds part of Java 7 new language features. .. Patch Set 5: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://gwt-ci.dempsky.org:8080/job/gwt.presubmit/45 -- To view, visit https://gwt-review.googlesource.com/2650 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c1f39ff20a2e7ac131d647bf4c96e34ce47a70 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 1: (1 comment) File user/super/com/google/gwt/emul/java/lang/Throwable.java Line 19: import com.google.gwt.lang.Array; Unused import. -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Goktug Gokdogan has posted comments on this change.
Change subject: Adds the remaining (and more complex) Java 7 new language
features.
..
Patch Set 1:
(9 comments)
File user/src/com/google/gwt/core/shared/SerializableThrowable.java
Line 34: * NOTE: Does not serialize suppressed exceptions to remain
compatible with Java 6 and below.
Don't forget to create a thread on this issue =)
File user/super/com/google/gwt/emul/java/lang/AutoCloseable.java
Line 3: *
nit: spaces here
Line 19: * Indicates that a class implements codeclose()/code and can
be used in a try-with-resources
Can you just refer to jdk documentation like the other classes in this
package?
Line 26:* @throws Exception
remove empty @throws
File user/super/com/google/gwt/emul/java/lang/Exception.java
Line 38: }
I guess this class is not intended to be here :)
File user/super/com/google/gwt/emul/java/lang/Throwable.java
Line 40:* SerializabilityUtil.fieldQualifiesForSerialization(Field)
method.
can you put a todo item for missing stuff related to suppressed exceptions?
Also can you create an issue to follow up on this?
Line 44: private transient Throwable[] suppressed = new Throwable[0];
it is better to instantiate this lazily.
Line 74:
asserts are just like javadocs, nothing more. In this kind of scenarios we
want guaranteed checks. (see go/java-practices/assertions).
Line 78: }
you don't need the whole array copy. This will only run in script mode.
just set the array. The whole method can look something like:
public final void addSuppressed(Throwable exception) {
if (exception == null) {
throw new NPE();
}
if (exception == this) {
throw new IllegalArgumentException(Self-suppress not permitted);
}
if (suppressed == null ) {
suppressed = new Throwable[] { exception };
} else {
suppressed[suppressed.length] = exception;
}
}
--
To view, visit https://gwt-review.googlesource.com/2681
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John Stalcup stal...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: A
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/2661 Change subject: A .. A Change-Id: Ia518ca4bdac81eaf863ebf6f193de87abb115851 --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/build.xml b/build.xml index c783631..3f393de 100755 --- a/build.xml +++ b/build.xml @@ -1,3 +1,4 @@ +!-- A -- project name=GWT default=dist basedir=. property name=gwt.root location=. / property name=project.tail value= / -- To view, visit https://gwt-review.googlesource.com/2661 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia518ca4bdac81eaf863ebf6f193de87abb115851 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: B
Matthew Dempsky has uploaded a new change for review. https://gwt-review.googlesource.com/2662 Change subject: B .. B Change-Id: I507c952ef6a914e08682918e986406271b7cec8f --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/build.xml b/build.xml index 3f393de..b4ea0ce 100755 --- a/build.xml +++ b/build.xml @@ -1,4 +1,5 @@ !-- A -- +!-- b -- project name=GWT default=dist basedir=. property name=gwt.root location=. / property name=project.tail value= / -- To view, visit https://gwt-review.googlesource.com/2662 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I507c952ef6a914e08682918e986406271b7cec8f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: B
Matthew Dempsky has uploaded a new patch set (#2). Change subject: B .. B Change-Id: I507c952ef6a914e08682918e986406271b7cec8f --- M build.xml 1 file changed, 1 insertion(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2662 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I507c952ef6a914e08682918e986406271b7cec8f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Matthew Dempsky mdemp...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Hello Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2681 to look at the new patch set (#2). Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Adds the remaining (and more complex) Java 7 new language features. Adds the remaining Java 7 new language features: namely, multiexception catch and try-with-resources. Fixes issue 7999, issue 6960. Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c --- M dev/core/src/com/google/gwt/dev/jjs/ast/JTryStatement.java M dev/core/src/com/google/gwt/dev/jjs/impl/CatchBlockNormalizer.java M dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java M dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java M dev/core/src/com/google/gwt/dev/jjs/impl/TypeTightener.java M dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java M dev/core/src/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilder.java M dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Exceptions.java M dev/core/test/com/google/gwt/dev/jjs/impl/Java7AstTest.java M user/src/com/google/gwt/core/shared/SerializableThrowable.java A user/super/com/google/gwt/emul/java/lang/AutoCloseable.java M user/super/com/google/gwt/emul/java/lang/Exception.java M user/super/com/google/gwt/emul/java/lang/Throwable.java M user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/dev/jjs/test/Java7Test.java M user/test/com/google/gwt/emultest/java/lang/ThrowableTest.java 18 files changed, 922 insertions(+), 78 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds the remaining (and more complex) Java 7 new language fe...
Matthew Dempsky has posted comments on this change. Change subject: Adds the remaining (and more complex) Java 7 new language features. .. Patch Set 2: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/47 -- To view, visit https://gwt-review.googlesource.com/2681 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If973b8c847d1202aca794221f32ae4b33b616f9c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John Stalcup stal...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow line breaks and other whitespace in jsni method refere...
Matthew Dempsky has posted comments on this change. Change subject: Allow line breaks and other whitespace in jsni method references. .. Patch Set 2: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/48 -- To view, visit https://gwt-review.googlesource.com/2640 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64426b03f4cde2c84c2faf27a2e38aba4720f401 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Kelly Campbell kelly.a.campb...@gmail.com Gerrit-Reviewer: Kelly Campbell kelly.a.campb...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: reduces Java AST optimization time by bailing out when the r...
John Stalcup has abandoned this change. Change subject: reduces Java AST optimization time by bailing out when the rate of change slows to a crawl (only applies on optimization levels less than 9) .. Abandoned submitted -- To view, visit https://gwt-review.googlesource.com/2580 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iabf844d6a02f694e8d14103377f74f46e4e01915 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: preparation for turning off Dataflow Optimizer to speed up o...
John Stalcup has abandoned this change. Change subject: preparation for turning off Dataflow Optimizer to speed up optimized compiles (at optimization levels less than 9) .. Abandoned submitted -- To view, visit https://gwt-review.googlesource.com/2610 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2f33700566e97672b2e570fc5f75293bd6b2fb9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Stalcup stal...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2683
Change subject: Allow GWT to continue even in presence of internal JDT
compiler Errors.
..
Allow GWT to continue even in presence of internal JDT compiler Errors.
Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a
---
M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
1 file changed, 22 insertions(+), 5 deletions(-)
diff --git a/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
b/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
index 716e2c6..51749eb 100644
--- a/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
+++ b/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
@@ -375,6 +375,12 @@
}
}
+ /**
+ * Maximun number of JDT compiler errors or abort requests before it
actually returns
+ * a fatal error to the user.
+ */
+ private static final double ABORT_COUNT_MAX = 100;
+
private class CompilerImpl extends Compiler {
private TreeLogger logger;
private int abortCount = 0;
@@ -420,9 +426,14 @@
JDT aborted: + filename + : + e.problem.getMessage());
return; // continue without it; it might be a server-side class.
} catch (RuntimeException e) {
+abortCount++;
+String filename = new String(cud.getFileName());
logger.log(TreeLogger.Type.ERROR,
-JDT died after + abortCount + previous errors, e);
-throw new AbortCompilation(cud.compilationResult, e);
+JDT threw an exception: + filename + e);
+if (abortCount = ABORT_COUNT_MAX) {
+ throw new AbortCompilation(cud.compilationResult, e);
+}
+return; // continue without it; it might be a server-side class.
}
ClassFile[] classFiles = cud.compilationResult().getClassFiles();
MapClassFile, CompiledClass results = new LinkedHashMapClassFile,
CompiledClass();
@@ -458,6 +469,10 @@
new CompiledClass(classFile.getBytes(), enclosingClass,
isLocalType(classFile),
internalName);
results.put(classFile, result);
+}
+
+int getAbortCount() {
+ return abortCount;
}
}
@@ -922,15 +937,17 @@
try {
compilerImpl.compile(icus.toArray(new
ICompilationUnit[icus.size()]));
} catch (AbortCompilation e) {
+ final String compilerAborted = String.format(JDT compiler aborted
after %d errors,
+ compilerImpl.getAbortCount());
if (e.problem == null) {
-logger.log(TreeLogger.Type.ERROR, JDT compiler aborted);
+logger.log(TreeLogger.Type.ERROR, compilerAborted + .);
} else if (e.problem.getOriginatingFileName() == null) {
-logger.log(TreeLogger.Type.ERROR, JDT compiler aborted: +
e.problem.getMessage());
+logger.log(TreeLogger.Type.ERROR, compilerAborted + : +
e.problem.getMessage());
} else {
String filename = new String(e.problem.getOriginatingFileName());
TreeLogger branch = logger.branch(TreeLogger.Type.ERROR,
At + filename + : + e.problem.getSourceLineNumber());
-branch.log(TreeLogger.Type.ERROR, JDT compiler aborted: +
e.problem.getMessage());
+branch.log(TreeLogger.Type.ERROR, compilerAborted + : +
e.problem.getMessage());
}
throw new UnableToCompleteException();
} finally {
--
To view, visit https://gwt-review.googlesource.com/2683
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Matthew Dempsky has posted comments on this change. Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Patch Set 1: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/49 -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Hello Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2683 to look at the new patch set (#3). Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Allow GWT to continue even in presence of internal JDT compiler Errors. Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a --- M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java 1 file changed, 25 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Matthew Dempsky has posted comments on this change. Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Patch Set 2: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/50 -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Hello Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2683 to look at the new patch set (#4). Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Allow GWT to continue even in presence of internal JDT compiler Errors. Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a --- M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java 1 file changed, 25 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Hello Matthew Dempsky, Matthew Dempsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2683 to look at the new patch set (#5). Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Allow GWT to continue even in presence of internal JDT compiler Errors. Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a --- M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java 1 file changed, 25 insertions(+), 5 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Matthew Dempsky has posted comments on this change. Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Patch Set 3: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/51 -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Matthew Dempsky has posted comments on this change. Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Patch Set 4: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/52 -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Allow GWT to continue even in presence of internal JDT compi...
Matthew Dempsky has posted comments on this change. Change subject: Allow GWT to continue even in presence of internal JDT compiler Errors. .. Patch Set 5: Verified+1 Hoorays, this change passed the build and style presubmit. :D More details at http://build.gwtproject.org/job/gwt.presubmit/53 -- To view, visit https://gwt-review.googlesource.com/2683 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7df86271fc64ac75e0857d17e557e79d870854a Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
