LGTM. With nits.
http://gwt-code-reviews.appspot.com/1185801/diff/1/3
File
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java
(right):
http://gwt-code-reviews.appspot.com/1185801/diff/1/3#newcode53
samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/application/ValidationRequirementTest.java:53:
public void notestIgnoreStaticFieldsAndProperties() {
Is this a test we never want to use or just something disabled
temporarily?
http://gwt-code-reviews.appspot.com/1185801/diff/1/6
File
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
(right):
http://gwt-code-reviews.appspot.com/1185801/diff/1/6#newcode418
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:418:
*/
Delete or fill-in
http://gwt-code-reviews.appspot.com/1185801/diff/3001/4005#newcode538
user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java:538:
sw.println(new HashSetConstraintViolationT(););
Use sw.indent and sw.outdent
http://gwt-code-reviews.appspot.com/1185801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
